Skip to contentSkip to conversation

dt-bindings: efm32: remove bindings for deleted platform

PATCH In review Wolfram Sang 5 participants 5 messages Jun 15, 2022 – Jun 17, 2022

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: efm32: remove bindings for deleted platform

Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform, so no need to still carry the bindings.

---
 .../devicetree/bindings/clock/efm32-clock.txt | 11 -----
 .../devicetree/bindings/i2c/i2c-efm32.txt     | 33 --------------
 .../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
 .../devicetree/bindings/spi/efm32-spi.txt     | 39 -----------------
 include/dt-bindings/clock/efm32-cmu.h         | 43 -------------------
 5 files changed, 146 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
 delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
 delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
 delete mode 100644 include/dt-bindings/clock/efm32-cmu.h
Documentation/devicetree/bindings/clock/efm32-clock.txt deleted +0 -11
deleted file mode 100644
index 263d293f6a10..000000000000
@@ -1,11 +0,0 @@
-* Clock bindings for Energy Micro efm32 Giant Gecko's Clock Management Unit
-
-Required properties:
-- compatible: Should be "efm32gg,cmu"
-- reg: Base address and length of the register set
-- interrupts: Interrupt used by the CMU
-- #clock-cells: Should be <1>
-
-The clock consumer should specify the desired clock by having the clock ID in
-its "clocks" phandle cell. The header efm32-clk.h contains a list of available
-IDs.
Documentation/devicetree/bindings/i2c/i2c-efm32.txt deleted +0 -33
deleted file mode 100644
index 3b30e54ae3c7..000000000000
@@ -1,33 +0,0 @@
-* Energymicro efm32 i2c controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device
- - compatible : should be "energymicro,efm32-i2c"
- - interrupts : the interrupt number
- - clocks : reference to the module clock
-
-Recommended properties :
-
- - clock-frequency : maximal I2C bus clock frequency in Hz.
- - energymicro,location : Decides the location of the USART I/O pins.
-   Allowed range : [0 .. 6]
-
-Example:
-	i2c0: i2c@4000a000 {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		compatible = "energymicro,efm32-i2c";
-		reg = <0x4000a000 0x400>;
-		interrupts = <9>;
-		clocks = <&cmu clk_HFPERCLKI2C0>;
-		clock-frequency = <100000>;
-		energymicro,location = <3>;
-
-		eeprom@50 {
-			compatible = "microchip,24c02";
-			reg = <0x50>;
-			pagesize = <16>;
-		};
-	};
-
Documentation/devicetree/bindings/serial/efm32-uart.txt deleted +0 -20
deleted file mode 100644
index 4f8d8fde0c1c..000000000000
@@ -1,20 +0,0 @@
-* Energymicro efm32 UART
-
-Required properties:
-- compatible : Should be "energymicro,efm32-uart"
-- reg : Address and length of the register set
-- interrupts : Should contain uart interrupt
-
-Optional properties:
-- energymicro,location : Decides the location of the USART I/O pins.
-  Allowed range : [0 .. 5]
-  Default: 0
-
-Example:
-
-uart@4000c400 {
-	compatible = "energymicro,efm32-uart";
-	reg = <0x4000c400 0x400>;
-	interrupts = <15>;
-	energymicro,location = <0>;
-};
Documentation/devicetree/bindings/spi/efm32-spi.txt deleted +0 -39
deleted file mode 100644
index e0fa61a1be0c..000000000000
@@ -1,39 +0,0 @@
-* Energy Micro EFM32 SPI
-
-Required properties:
-- #address-cells: see spi-bus.txt
-- #size-cells: see spi-bus.txt
-- compatible: should be "energymicro,efm32-spi"
-- reg: Offset and length of the register set for the controller
-- interrupts: pair specifying rx and tx irq
-- clocks: phandle to the spi clock
-- cs-gpios: see spi-bus.txt
-
-Recommended properties :
-- energymicro,location: Value to write to the ROUTE register's LOCATION
-                        bitfield to configure the pinmux for the device, see
-                        datasheet for values.
-                        If this property is not provided, keeping what is
-                        already configured in the hardware, so its either the
-                        reset default 0 or whatever the bootloader did.
-
-Example:
-
-spi1: spi@4000c400 { /* USART1 */
-	#address-cells = <1>;
-	#size-cells = <0>;
-	compatible = "energymicro,efm32-spi";
-	reg = <0x4000c400 0x400>;
-	interrupts = <15 16>;
-	clocks = <&cmu 20>;
-	cs-gpios = <&gpio 51 1>; // D3
-	energymicro,location = <1>;
-
-	ks8851@0 {
-		compatible = "ks8851";
-		spi-max-frequency = <6000000>;
-		reg = <0>;
-		interrupt-parent = <&boardfpga>;
-		interrupts = <4>;
-	};
-};
include/dt-bindings/clock/efm32-cmu.h deleted +0 -43

43 lines not on this page · raw message

Signature · 1 line
2.35.1
maintainer
#3 lore raw
In reply to Wolfram Sang
Quoted 4 lines · Wolfram Sang

Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform, so no need to still carry the bindings.

Quoted 13 lines
---
 .../devicetree/bindings/clock/efm32-clock.txt | 11 -----
 .../devicetree/bindings/i2c/i2c-efm32.txt     | 33 --------------
 .../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
 .../devicetree/bindings/spi/efm32-spi.txt     | 39 -----------------
 include/dt-bindings/clock/efm32-cmu.h         | 43 -------------------
 5 files changed, 146 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
 delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
 delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
 delete mode 100644 include/dt-bindings/clock/efm32-cmu.h

Deletions are automatically applied, thanks! ;)

#4 lore raw
In reply to Wolfram Sang
Quoted 4 lines · Wolfram Sang

Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform, so no need to still carry the bindings.

Quoted 12 lines
---
 .../devicetree/bindings/clock/efm32-clock.txt | 11 -----
 .../devicetree/bindings/i2c/i2c-efm32.txt     | 33 --------------
 .../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
 .../devicetree/bindings/spi/efm32-spi.txt     | 39 -----------------
 include/dt-bindings/clock/efm32-cmu.h         | 43 -------------------
 5 files changed, 146 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
 delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
 delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
 delete mode 100644 include/dt-bindings/clock/efm32-cmu.h

I didn't do that back then wondering if the bindings are sensible to keep even for removed arch (or more general drivers). In this case the chip isn't old and unavailable, but just too small for sensible Linux usage.

OTOH I'm not aware of any dtb usage on efm32.

No hard feelings here, if you consider it not useful to keep the binding around, go on and remove them.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |