net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
Subsystems (4)
PATCH v2 1/1 net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
To: David S. Miller <[email protected]>, Greg Kroah-Hartman <[email protected]>
Cc: netdev <[email protected]>, stable <[email protected]>, Ronald Wahl <[email protected]>
[PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions that have no issues.
The FLAG_SEND_ZLP is not safe to use in this context. See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
--
drivers/net/usb/ax88179_178a.c +13 -13
@@ -1680,7 +1680,7 @@ static const struct driver_info ax88179_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1693,7 +1693,7 @@ static const struct driver_info ax88178a_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1706,7 +1706,7 @@ static const struct driver_info cypress_GX3_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1719,7 +1719,7 @@ static const struct driver_info dlink_dub1312_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1732,7 +1732,7 @@ static const struct driver_info sitecom_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1745,7 +1745,7 @@ static const struct driver_info samsung_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1758,7 +1758,7 @@ static const struct driver_info lenovo_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1771,7 +1771,7 @@ static const struct driver_info belkin_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1784,7 +1784,7 @@ static const struct driver_info toshiba_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1797,7 +1797,7 @@ static const struct driver_info mct_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1810,7 +1810,7 @@ static const struct driver_info at_umc2000_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1823,7 +1823,7 @@ static const struct driver_info at_umc200_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
@@ -1836,7 +1836,7 @@ static const struct driver_info at_umc2000sp_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, };
Jakub Kicinski
maintainerQuoted 6 lines · On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
To: David S. Miller <[email protected]>, Greg Kroah-Hartman <[email protected]>
Cc: netdev <[email protected]>, stable <[email protected]>, Ronald Wahl <[email protected]>[PATCH net] net: usb:
ax88179_178ahave issues withFLAG_SEND_ZLPThe usage ofFLAG_SEND_ZLPcauses problems to otherfirmware/hardwareversions that have no issues.
But you tested with 1790 previously so isn't the misbehaviour on that device going to come back if we remove the flag again?
Quoted 10 lines
The FLAG_SEND_ZLP is not safe to use in this context.
See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
Reported-by: Ronald Wahl <[email protected]>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
Link: https://bugs.archlinux.org/task/75491
Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
Signed-off-by: Jose Alonso <[email protected]>The commit message looks unnecessarily indented, could you try with git format-patch / git send-email?
Quoted 4 lines · Jakub Kicinski
Quoted 3 lines · On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
To: David S. Miller <[email protected]>, Greg Kroah-Hartman <[email protected]>
Cc: netdev <[email protected]>, stable <[email protected]>, Ronald Wahl <[email protected]>
Quoted 8 lines
Quoted 3 lines
[PATCH net] net: usb:
ax88179_178ahave issues withFLAG_SEND_ZLPThe usage ofFLAG_SEND_ZLPcauses problems to otherfirmware/hardwareversions that have no issues.But you tested with 1790 previously so isn't the misbehaviour on that device going to come back if we remove the flag again?
There are also 0b95:1790 devices with probably different firmware/hardware version that have issues with the patch.
The original problem needs another way to solve.
Quoted 11 lines · Jose Alonso
To: David S. Miller <[email protected]>, Greg Kroah-Hartman <[email protected]>
Cc: netdev <[email protected]>, stable <[email protected]>, Ronald Wahl <[email protected]>[PATCH net] net: usb:
ax88179_178ahave issues withFLAG_SEND_ZLPThe usage ofFLAG_SEND_ZLPcauses problems to otherfirmware/hardwareversions that have no issues.The
FLAG_SEND_ZLPis not safe to use in this context. See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
Quoted 8 lines
Reported-by Ronald Wahl <[email protected]>Fixes 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")Signed-off-by Jose Alonso <[email protected]>--
Please take a read of:
https://kernel.org/doc/html/latest/process/submitting-patches.html
It should explain all the things you are getting wrong.
It is also worth looking at a few patches on the mailing list which do get accepted. Look at there format and copy them.
Andrew