nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
Subsystems (3)
Christoph Hellwig
maintainerPATCH 1/1 nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
dh_keysize is a size_t, use the proper format specifier for printing it.
--- drivers/nvme/target/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +1 -1
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,return -ENOKEY ; }if (buf_size != ctrl->dh_keysize) { -pr_warn ("ctrl %d DH public key size mismatch, need %lu is %d\n" , +pr_warn ("ctrl %d DH public key size mismatch, need %zu is %d\n" , ctrl->cntlid, ctrl->dh_keysize, buf_size); ret = -EINVAL ; }else {
Signature · 1 line
2.30.2
Quoted 4 lines · Christoph Hellwig
dh_keysizeis asize_t, use the proper format specifier for printing it.Reported-by Guenter Roeck <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Quoted 17 lines
--- drivers/nvme/target/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/target/auth.c +1
-1@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,return -ENOKEY ; }if (buf_size != ctrl->dh_keysize) { -pr_warn ("ctrl %d DH public key size mismatch, need %lu is %d\n" , +pr_warn ("ctrl %d DH public key size mismatch, need %zu is %d\n" , ctrl->cntlid, ctrl->dh_keysize, buf_size); ret = -EINVAL ; }else {
Quoted 13 lines · Christoph Hellwig
dh_keysizeis asize_t, use the proper format specifier for printing it.Reported-by Guenter Roeck <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>--- drivers/nvme/target/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/target/auth.c +0
-0
drivers/nvme/target/auth.c int nvmet_auth_ctrl_exponential(struct nvmet_req *req, · line 494
Quoted 8 lines
drivers/nvme/target/auth.c +1
-1@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,return -ENOKEY ; }if (buf_size != ctrl->dh_keysize) { -pr_warn ("ctrl %d DH public key size mismatch, need %lu is %d\n" , +pr_warn ("ctrl %d DH public key size mismatch, need %zu is %d\n" , ctrl->cntlid, ctrl->dh_keysize, buf_size); ret = -EINVAL ; }else {
Cheers,
Hannes
Quoted 5 lines · Christoph Hellwig
dh_keysizeis asize_t, use the proper format specifier for printing it.Reported-by Guenter Roeck <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>---
Looks good.
-ck
Quoted 26 lines · Christoph Hellwig
dh_keysizeis asize_t, use the proper format specifier for printing it.Reported-by Guenter Roeck <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>--- drivers/nvme/target/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/target/auth.c +1
-1@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,return -ENOKEY ; }if (buf_size != ctrl->dh_keysize) { -pr_warn ("ctrl %d DH public key size mismatch, need %lu is %d\n" , +pr_warn ("ctrl %d DH public key size mismatch, need %zu is %d\n" , ctrl->cntlid, ctrl->dh_keysize, buf_size); ret = -EINVAL ; }else {Signature · 1 line
2.30.2
This patch runs parallel to our efforts to re-enable -Wformat.
See here: https://lore.kernel.org/all/[email protected]/
Hopefully this patch gets picked up by a maintainer so that Masahiro can stage a clean PR re-enabling the -Wformat warning.
Quoted 26 lines · Christoph Hellwig
dh_keysizeis asize_t, use the proper format specifier for printing it.Reported-by Guenter Roeck <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>--- drivers/nvme/target/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/target/auth.c +1
-1@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,return -ENOKEY ; }if (buf_size != ctrl->dh_keysize) { -pr_warn ("ctrl %d DH public key size mismatch, need %lu is %d\n" , +pr_warn ("ctrl %d DH public key size mismatch, need %zu is %d\n" , ctrl->cntlid, ctrl->dh_keysize, buf_size); ret = -EINVAL ; }else {Signature · 1 line
2.30.2
Disregard my previous reply as this has already been picked up:
https://lore.kernel.org/all/[email protected]/