Skip to contentSkip to conversation

nvmet: fix a format specifier in nvmet_auth_ctrl_exponential

PATCH In review Christoph Hellwig 6 participants 7 messages Jul 18, 2022 – Aug 1, 2022

Subsystems (3)
lore
Share & tools
lore

Christoph Hellwig

author maintainer
#0 lore raw

PATCH 1/1 nvmet: fix a format specifier in nvmet_auth_ctrl_exponential

dh_keysize is a size_t, use the proper format specifier for printing it.

---
 drivers/nvme/target/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +1 -1
index b41c7bbcc4366..cf690df347758 100644
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
 		return -ENOKEY;
 	}
 	if (buf_size != ctrl->dh_keysize) {
-		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
+		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
 			ctrl->cntlid, ctrl->dh_keysize, buf_size);
 		ret = -EINVAL;
 	} else {
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christoph Hellwig

dh_keysize is a size_t, use the proper format specifier for printing it.

Quoted 17 lines
---
  drivers/nvme/target/auth.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +1 -1
index b41c7bbcc4366..cf690df347758 100644
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
  		return -ENOKEY;
  	}
  	if (buf_size != ctrl->dh_keysize) {
-		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
+		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
  			ctrl->cntlid, ctrl->dh_keysize, buf_size);
  		ret = -EINVAL;
  	} else {
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Christoph Hellwig
Quoted 13 lines · Christoph Hellwig

dh_keysize is a size_t, use the proper format specifier for printing it.

---
  drivers/nvme/target/auth.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +0 -0
index b41c7bbcc4366..cf690df347758 100644

drivers/nvme/target/auth.c int nvmet_auth_ctrl_exponential(struct nvmet_req *req, · line 494

Quoted 8 lines
drivers/nvme/target/auth.c +1 -1
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
  		return -ENOKEY;
  	}
  	if (buf_size != ctrl->dh_keysize) {
-		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
+		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
  			ctrl->cntlid, ctrl->dh_keysize, buf_size);
  		ret = -EINVAL;
  	} else {

Cheers,

Hannes

Reviewed-by on v1 1/1
#5 lore raw
In reply to Christoph Hellwig
Quoted 26 lines · Christoph Hellwig

dh_keysize is a size_t, use the proper format specifier for printing it.

---
 drivers/nvme/target/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +1 -1
index b41c7bbcc4366..cf690df347758 100644
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
 		return -ENOKEY;
 	}
 	if (buf_size != ctrl->dh_keysize) {
-		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
+		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
 			ctrl->cntlid, ctrl->dh_keysize, buf_size);
 		ret = -EINVAL;
 	} else {
Signature · 1 line
2.30.2

This patch runs parallel to our efforts to re-enable -Wformat.
See here: https://lore.kernel.org/all/[email protected]/

Hopefully this patch gets picked up by a maintainer so that Masahiro can stage a clean PR re-enabling the -Wformat warning.

#6 lore raw
In reply to Christoph Hellwig
Quoted 26 lines · Christoph Hellwig

dh_keysize is a size_t, use the proper format specifier for printing it.

---
 drivers/nvme/target/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/auth.c +1 -1
index b41c7bbcc4366..cf690df347758 100644
@@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
 		return -ENOKEY;
 	}
 	if (buf_size != ctrl->dh_keysize) {
-		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
+		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
 			ctrl->cntlid, ctrl->dh_keysize, buf_size);
 		ret = -EINVAL;
 	} else {
Signature · 1 line
2.30.2

Disregard my previous reply as this has already been picked up:
https://lore.kernel.org/all/[email protected]/