Skip to contentSkip to conversation

of: device: fix repeated words in comments

PATCH In review Jilin Yuan 3 participants 6 messages Sep 18, 2022 – Sep 27, 2022 Device tree

lore
Share & tools
lore

Jilin Yuan

author
#0 lore raw

PATCH 1/1 of: device: fix repeated words in comments

Delete the redundant word 'of'.

---
 drivers/of/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/device.c +1 -1
index 75b6cbffa755..6158173b92ad 100644
@@ -19,7 +19,7 @@
 
 /**
  * of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
  * @dev: the of device structure to match against
  *
  * Used by a driver to check whether an platform_device present in the
Signature · 1 line
2.36.1
maintainer
#1 lore raw
Quoted 1 line · Jilin Yuan

Delete the redundant word 'of'.

Again? Sigh.

Please read:

https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/

Quoted 2 lines

Are you sure you are the author?

Quoted 21 lines
---
 drivers/of/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/device.c +1 -1
index 75b6cbffa755..6158173b92ad 100644
@@ -19,7 +19,7 @@
 
 /**
  * of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
  * @dev: the of device structure to match against
  *
  * Used by a driver to check whether an platform_device present in the
Signature · 1 line
2.36.1
#2 lore raw
Quoted 5 lines · Rob Herring
Quoted 1 line · Jilin Yuan

Delete the redundant word 'of'.

Again? Sigh.

Quoted 9 lines

Please read:

https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/

Quoted 2 lines

Are you sure you are the author?

Hi Rob,

Some reviewers sent comments for similar patches from @cdjrlc.com people (including myself at [1]), with some of them requesting changes. However, there are never any responses to these reviews from @cdjrlc.com people, just like ZTE developers sending through cgel.zte ignored review comments [2] (try searching f:"cdjrlc.com" AND s:"Re:", it returns nothing for now).

Thanks.

[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/lkml/[email protected]/

Signature · 1 line
An old man doll... just what I always wanted! - Clara
maintainer
#3 lore raw
Quoted 17 lines · Bagas Sanjaya
Quoted 5 lines · Rob Herring
Quoted 1 line · Jilin Yuan

Delete the redundant word 'of'.

Again? Sigh.

Quoted 9 lines

Please read:

https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/

Quoted 2 lines

Are you sure you are the author?

Quoted 8 lines

Hi Rob,

Some reviewers sent comments for similar patches from @cdjrlc.com people (including myself at [1]), with some of them requesting changes. However, there are never any responses to these reviews from @cdjrlc.com people, just like ZTE developers sending through cgel.zte ignored review comments [2] (try searching f:"cdjrlc.com" AND s:"Re:", it returns nothing for now).

I can't decide whether to fix it correctly myself or leave it to see how many times I can get the same patch. :)

Rob

#4 lore raw
Quoted 9 lines · Rob Herring
Quoted 8 lines

Hi Rob,

Some reviewers sent comments for similar patches from @cdjrlc.com people (including myself at [1]), with some of them requesting changes. However, there are never any responses to these reviews from @cdjrlc.com people, just like ZTE developers sending through cgel.zte ignored review comments [2] (try searching f:"cdjrlc.com" AND s:"Re:", it returns nothing for now).

Quoted 3 lines

I can't decide whether to fix it correctly myself or leave it to see how many times I can get the same patch. :)

Hi Rob,

I'm not talking about whether this patch should be picked up or not, but rather I'm pointing out the ignoring review behavior of @cdjrlc.com people.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
maintainer
#5 lore raw
Quoted 11 lines · Bagas Sanjaya
Quoted 9 lines · Rob Herring
Quoted 8 lines

Hi Rob,

Some reviewers sent comments for similar patches from @cdjrlc.com people (including myself at [1]), with some of them requesting changes. However, there are never any responses to these reviews from @cdjrlc.com people, just like ZTE developers sending through cgel.zte ignored review comments [2] (try searching f:"cdjrlc.com" AND s:"Re:", it returns nothing for now).

Quoted 8 lines
Quoted 3 lines

I can't decide whether to fix it correctly myself or leave it to see how many times I can get the same patch. :)

Hi Rob,

I'm not talking about whether this patch should be picked up or not, but rather I'm pointing out the ignoring review behavior of @cdjrlc.com people.

Yes, I get that. Not responding seems to be a growing behavior not just on these trivial type patches. (Though replying with 'ok' to every review comment is equally annoying.) I suppose there could be some filtering happening such that replies are never received.

Rob