Skip to contentSkip to conversation

RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port

PATCH Superseded Dmitry Torokhov 3 participants 3 messages Sep 29, 2022 – Sep 30, 2022 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port

According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.

---
 arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stihxxx-b2120.dtsi +1 -1
index 2aa94605d3d4..d52a7aaa1074 100644
@@ -178,7 +178,7 @@ tsin0: port {
 				tsin-num = <0>;
 				serial-not-parallel;
 				i2c-bus = <&ssc2>;
-				reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
+				reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
 				dvb-card = <STV0367_TDA18212_NIMA_1>;
 			};
 		};
Signature · 5 lines
2.38.0.rc1.362.ged0d419d3c-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw

Hi Dmitry

Quoted 15 lines · Dmitry Torokhov

According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.

---
 arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stihxxx-b2120.dtsi +0 -0
index 2aa94605d3d4..d52a7aaa1074 100644

arch/arm/boot/dts/stihxxx-b2120.dtsi tsin0: port { · line 184

Quoted 8 lines
arch/arm/boot/dts/stihxxx-b2120.dtsi +1 -1
@@ -178,7 +178,7 @@ tsin0: port {
 				tsin-num = <0>;
 				serial-not-parallel;
 				i2c-bus = <&ssc2>;
-				reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
+				reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
 				dvb-card = <STV0367_TDA18212_NIMA_1>;
 			};
 		};

Thanks
Patrice

#2 lore raw
In reply to Dmitry Torokhov
Quoted 6 lines · Dmitry Torokhov

According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.

Typo in subject - s/RM/ARM/

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel