Skip to contentSkip to conversation

board: qualcomm: dragonboard820c: udpate readme

PATCH In review Jorge Ramirez-Ortiz 5 participants 17 messages Apr 7, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 board: qualcomm: dragonboard820c: udpate readme

Update build instructions.

---
 board/qualcomm/dragonboard820c/readme.txt | 47 ++++++++++-------------
 1 file changed, 21 insertions(+), 26 deletions(-)
board/qualcomm/dragonboard820c/readme.txt +21 -26
index 966e9520e85..a01d24122cb 100644
@@ -16,10 +16,7 @@
                      Build & Run instructions
 ================================================================================
 
-1) Install mkbootimg and dtbTool from Codeaurora:
-
-   git://codeaurora.org/quic/kernel/skales
-   commit 8492547e404e969262d9070dee9bdd15668bb70f worked for me.
+1) Install mkbootimg
 
 2) Setup CROSS_COMPILE to aarch64 compiler or if you use ccache just do
    CROSS_COMPILE="ccache aarch64-linux-gnu-"
@@ -33,15 +30,15 @@
 
    $ touch rd
 
-5) Generate qualcomm device tree table with dtbTool
+5) Append the dtb to the u-boot binary discarding the internal dtb.
 
-   $ dtbTool -o dt.img arch/arm/dts
+   $ gzip u-boot-nodtb.bin
+   $ cat u-boot.dtb >> u-boot-nodtb.bin.gz
 
 6) Generate Android boot image with mkbootimg:
 
-   $ mkbootimg --kernel=u-boot-dtb.bin             \
+   $ mkbootimg --kernel=u-boot-nodtb.bin.gz          \
                --output=u-boot.img                 \
-               --dt=dt.img                         \
                --pagesize 4096                     \
                --base 0x80000000                   \
                --ramdisk=rd                        \
@@ -251,44 +248,42 @@ Wait for 5 seconds before proceeding
 [5300] booting linux @ 0x80080000, ramdisk @ 0x82200000 (0), tags/device tree @ 0x82000000
 [5310] Jumping to kernel via monitor
 
-U-Boot 2017.11-00145-ge895117 (Nov 29 2017 - 10:04:06 +0100)
+U-Boot 2025.04-rc5-00020-g40a61ca0e7eb-dirty (Apr 07 2025 - 09:37:03 +0200)
 Qualcomm-DragonBoard 820C
 
-DRAM:  3 GiB
-PSCI:  v1.0
-MMC:   sdhci@74a4900: 0
+DRAM:  3.5 GiB (effective 3 GiB)
+Core:  136 devices, 18 uclasses, devicetree: board
+MMC:   Bulk clocks not available (-19), trying core clock
+mmc@74a4900: 0
+Loading Environment from EXT4... OK
 In:    serial@75b0000
 Out:   serial@75b0000
 Err:   serial@75b0000
-Net:   Net Initialization Skipped
-No ethernet found.
+Net:   No ethernet found.
 Hit any key to stop autoboot:  0
 switch to partitions #0, OK
 mmc0 is current device
 Scanning mmc 0:1...
 Found /extlinux/extlinux.conf
 Retrieving file: /extlinux/extlinux.conf
-433 bytes read in 71 ms (5.9 KiB/s)
 1:      nfs root
-
+Enter choice: 1:        nfs root
 Retrieving file: /uImage
-19397184 bytes read in 2024 ms (9.1 MiB/s)
-append: root=/dev/nfs rw nfsroot=192.168.1.2:/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlycon=msm_serial_dm,0x75b0000 androidboot.bootdevice=624000.ufshc androidboot.verifiedbootstate=orange androidboot.ver0
-
+append: root=/dev/nfs rw nfsroot=192.168.1.6:/home/jramirez/Src/qualcomm-lt/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlyco0
 Retrieving file: /apq8096-db820c.dtb
-38134 bytes read in 37 ms (1005.9 KiB/s)
-
-## Booting kernel from Legacy Image at 95000000 ...
+## Booting kernel from Legacy Image at 155000000 ...
    Image Name:   Dragonboard820c
    Image Type:   AArch64 Linux Kernel Image (uncompressed)
    Data Size:    19397120 Bytes = 18.5 MiB
    Load Address: 80080000
    Entry Point:  80080000
    Verifying Checksum ... OK
-## Flattened Device Tree blob at 93000000
-   Booting using the fdt blob at 0x93000000
-   Loading Kernel Image ... OK
-   Using Device Tree in place at 0000000093000000, end 000000009300c4f5
+## Flattened Device Tree blob at 148600000
+   Booting using the fdt blob at 0x148600000
+Working FDT set to 148600000
+   Loading Kernel Image to 80080000
+   Using Device Tree in place at 0000000148600000, end 000000014860c4f5
+Working FDT set to 148600000
 
 Starting kernel ...
 
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/5 clk/qcom: apq8096: fix set rate for the uart clock

The function should return a valid rate.

---
 drivers/clk/qcom/clock-apq8096.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clk/qcom/clock-apq8096.c +2 -1
index c77d69128b0..bc00826a5e8 100644
@@ -87,7 +87,8 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
 		return clk_init_sdc(priv, rate);
 		break;
 	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
-		return clk_init_uart(priv);
+		clk_init_uart(priv);
+		return 7372800;
 	default:
 		return 0;
 	}
Signature · 1 line
2.34.1
Reviewed-by on v1 2/5
#2 lore raw

Re: [PATCH 2/5] clk/qcom: apq8096: fix set rate for the uart clock

Quoted 4 lines · Jorge Ramirez-Ortiz

The function should return a valid rate.

Quoted 17 lines
  drivers/clk/qcom/clock-apq8096.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clk/qcom/clock-apq8096.c +2 -1
index c77d69128b0..bc00826a5e8 100644
@@ -87,7 +87,8 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
  		return clk_init_sdc(priv, rate);
  		break;
  	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
-		return clk_init_uart(priv);
+		clk_init_uart(priv);
+		return 7372800;
  	default:
  		return 0;
  	}
Signature · 1 line
Caleb (they/them)
#3 lore raw

PATCH 3/5 clk/qcom: apq8096: fix the sdhci clock

In reply to Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
 drivers/clk/qcom/clock-apq8096.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clock-apq8096.c +1 -1
index bc00826a5e8..551f52d5197 100644
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
 	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
 
 	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */
 		return clk_init_sdc(priv, rate);
 		break;
 	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
Signature · 1 line
2.34.1
#4 lore raw

Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock

Quoted 13 lines · Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
  drivers/clk/qcom/clock-apq8096.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clock-apq8096.c +0 -0
index bc00826a5e8..551f52d5197 100644

drivers/clk/qcom/clock-apq8096.c static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate) · line 86

Quoted 5 lines
drivers/clk/qcom/clock-apq8096.c +1 -1
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
  	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
 
  	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

Quoted 3 lines
drivers/clk/qcom/clock-apq8096.c +0 -0
  		return clk_init_sdc(priv, rate);
  		break;
  	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
#5 lore raw

Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock

Quoted 9 lines · On 07/04/25 14:36:51, [email protected] wrote:
Quoted 8 lines · Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
  drivers/clk/qcom/clock-apq8096.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

drivers/clk/qcom/clock-apq8096.c static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate) · line 85

Quoted 9 lines
drivers/clk/qcom/clock-apq8096.c +1 -1
index bc00826a5e8..551f52d5197 100644
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
  	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
  	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

why? also if I do that, mcc fails to probe

Quoted 5 lines
Quoted 4 lines
drivers/clk/qcom/clock-apq8096.c +0 -0
  		return clk_init_sdc(priv, rate);
  		break;
  	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
Reviewed-by
#6 lore raw

Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock

Quoted 22 lines · Jorge Ramirez
Quoted 9 lines · On 07/04/25 14:36:51, [email protected] wrote:
Quoted 8 lines · Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
   drivers/clk/qcom/clock-apq8096.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

drivers/clk/qcom/clock-apq8096.c static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate) · line 85

Quoted 9 lines
drivers/clk/qcom/clock-apq8096.c +1 -1
index bc00826a5e8..551f52d5197 100644
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
   	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
   	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

Quoted 1 line

why? also if I do that, mcc fails to probe

GCC_SDCC2_APPS_CLK is correct, that's the "core" clock and the one the sdhci_msm driver calls clk_set_rate() on. So this patch is good. I suspect the misuse of GCC_SDCC1_APPS_CLK is from way back when this board had a custom DT that didn't follow upstream.

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
drivers/clk/qcom/clock-apq8096.c +0 -0
   		return clk_init_sdc(priv, rate);
   		break;
   	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
Signature · 1 line
Caleb (they/them)
#7 lore raw

Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock

In reply to Jorge Ramirez
Quoted 22 lines · Jorge Ramirez
Quoted 9 lines · On 07/04/25 14:36:51, [email protected] wrote:
Quoted 8 lines · Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
   drivers/clk/qcom/clock-apq8096.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

drivers/clk/qcom/clock-apq8096.c static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate) · line 85

Quoted 9 lines
drivers/clk/qcom/clock-apq8096.c +1 -1
index bc00826a5e8..551f52d5197 100644
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
   	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
   	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

Quoted 1 line

why? also if I do that, mcc fails to probe

The discussion at https://lore.kernel.org/all/Z/OqoqnPb1gfk5iG@trex/ made me thought using GCC_SDCC2_AHB_CLK fixed the sdhci set_rate, but I maybe did misread.

Neil

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
drivers/clk/qcom/clock-apq8096.c +0 -0
   		return clk_init_sdc(priv, rate);
   		break;
   	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
#8 lore raw

Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock

Quoted 23 lines · On 07/04/25 17:12:45, [email protected] wrote:
Quoted 22 lines · Jorge Ramirez
Quoted 20 lines · On 07/04/25 14:36:51, [email protected] wrote:
Quoted 13 lines · Jorge Ramirez-Ortiz

Select the right clock for sdhci.

---
   drivers/clk/qcom/clock-apq8096.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clock-apq8096.c +0 -0
index bc00826a5e8..551f52d5197 100644

drivers/clk/qcom/clock-apq8096.c static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate) · line 85

Quoted 4 lines
drivers/clk/qcom/clock-apq8096.c +1 -1
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
   	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
   	switch (clk->id) {
-	case GCC_SDCC1_APPS_CLK: /* SDC1 */
+	case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

Quoted 5 lines
Quoted 1 line

why? also if I do that, mcc fails to probe

The discussion at https://lore.kernel.org/all/Z/OqoqnPb1gfk5iG@trex/ made me thought using GCC_SDCC2_AHB_CLK fixed the sdhci set_rate, but I maybe did misread.

Neil

can I add your review/acked?

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
drivers/clk/qcom/clock-apq8096.c +0 -0
   		return clk_init_sdc(priv, rate);
   		break;
   	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
#9 lore raw

PATCH 4/5 clk: stub: add qcom,glink-smd-rpm

In reply to Jorge Ramirez-Ortiz

Add support for the resource power manager clocks over SMD/GLINK to be stubbed.

---
 drivers/clk/clk-stub.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk-stub.c +1 -0
index 5fbbb07b7f7..09be2946bbc 100644
@@ -15,6 +15,7 @@ static const struct udevice_id nop_parent_ids[] = {
 	{ .compatible = "qcom,rpm-proc" },
 	{ .compatible = "qcom,glink-rpm" },
 	{ .compatible = "qcom,rpm-sm6115" },
+	{ .compatible = "qcom,glink-smd-rpm" },
 	{ }
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v1 4/5
#10 lore raw

Re: [PATCH 4/5] clk: stub: add qcom,glink-smd-rpm

Quoted 13 lines · Jorge Ramirez-Ortiz

Add support for the resource power manager clocks over SMD/GLINK to be stubbed.

---
 drivers/clk/clk-stub.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk-stub.c +0 -0
index 5fbbb07b7f7..09be2946bbc 100644

drivers/clk/clk-stub.c static const struct udevice_id nop_parent_ids[] = { · line 17

Quoted 3 lines
drivers/clk/clk-stub.c +0 -0
@@ -15,6 +15,7 @@ static const struct udevice_id nop_parent_ids[] = {
 	{ .compatible = "qcom,rpm-proc" },
 	{ .compatible = "qcom,glink-rpm" },
 	{ .compatible = "qcom,rpm-sm6115" },

This platform specific compatible can be dropped now.

Apart from that, feel free to add:

-Sumit

Quoted 7 lines
drivers/clk/clk-stub.c +1 -0
+	{ .compatible = "qcom,glink-smd-rpm" },
 	{ }
 };
 
Signature · 1 line
2.34.1
#11 lore raw

Re: [PATCH 4/5] clk: stub: add qcom,glink-smd-rpm

In reply to Jorge Ramirez-Ortiz
Quoted 13 lines · Jorge Ramirez-Ortiz

Add support for the resource power manager clocks over SMD/GLINK to be stubbed.

---
  drivers/clk/clk-stub.c | 1 +
  1 file changed, 1 insertion(+)
drivers/clk/clk-stub.c +0 -0
index 5fbbb07b7f7..09be2946bbc 100644

drivers/clk/clk-stub.c static const struct udevice_id nop_parent_ids[] = { · line 18

Quoted 4 lines
drivers/clk/clk-stub.c +1 -0
@@ -15,6 +15,7 @@ static const struct udevice_id nop_parent_ids[] = {
  	{ .compatible = "qcom,rpm-proc" },
  	{ .compatible = "qcom,glink-rpm" },
  	{ .compatible = "qcom,rpm-sm6115" },
+	{ .compatible = "qcom,glink-smd-rpm" },

You can delete qcom,rpm-sm6115 if you add qcom,glink-smd-rpm

Quoted 3 lines
drivers/clk/clk-stub.c +0 -0
  	{ }
  };
 
#12 lore raw

Re: [PATCH 4/5] clk: stub: add qcom,glink-smd-rpm

Quoted 9 lines · On 07/04/25 14:37:27, [email protected] wrote:
Quoted 8 lines · Jorge Ramirez-Ortiz

Add support for the resource power manager clocks over SMD/GLINK to be stubbed.

---
  drivers/clk/clk-stub.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 11 lines

drivers/clk/clk-stub.c static const struct udevice_id nop_parent_ids[] = { · line 18

Quoted 9 lines
drivers/clk/clk-stub.c +1 -0
index 5fbbb07b7f7..09be2946bbc 100644
@@ -15,6 +15,7 @@ static const struct udevice_id nop_parent_ids[] = {
  	{ .compatible = "qcom,rpm-proc" },
  	{ .compatible = "qcom,glink-rpm" },
  	{ .compatible = "qcom,rpm-sm6115" },
+	{ .compatible = "qcom,glink-smd-rpm" },

You can delete qcom,rpm-sm6115 if you add qcom,glink-smd-rpm

ok - I wasnt sure if you wanted that as part of a separate commit.

Quoted 4 lines
Quoted 3 lines
drivers/clk/clk-stub.c +0 -0
  	{ }
  };
#13 lore raw

PATCH 5/5 configs: dragonboard820: updates

In reply to Jorge Ramirez-Ortiz

Configure GPIO and CLK_STUBS

---
 configs/dragonboard820c_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/dragonboard820c_defconfig +2 -0
index e29bea7deb2..2a5b7212f74 100644
@@ -45,4 +45,6 @@ CONFIG_PINCTRL_QCOM_APQ8096=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_QCOM=y
 CONFIG_MSM_SERIAL=y
+CONFIG_MSM_GPIO=y
 CONFIG_SPMI_MSM=y
+CONFIG_CLK_STUB=y
Signature · 1 line
2.34.1
Reviewed-by on v1 1/5
#14 lore raw
In reply to Jorge Ramirez-Ortiz

Hi Jorge,

Long time no speak.

Quoted 5 lines · Jorge Ramirez-Ortiz

Update build instructions.

Your patch subject has a typo in "udpate" -> "update.

With that fixed:

Quoted 104 lines
---
 board/qualcomm/dragonboard820c/readme.txt | 47 ++++++++++-------------
 1 file changed, 21 insertions(+), 26 deletions(-)
board/qualcomm/dragonboard820c/readme.txt +21 -27
index 966e9520e85..a01d24122cb 100644
@@ -16,10 +16,7 @@
                      Build & Run instructions
 ================================================================================
 
-1) Install mkbootimg and dtbTool from Codeaurora:
-
-   git://codeaurora.org/quic/kernel/skales
-   commit 8492547e404e969262d9070dee9bdd15668bb70f worked for me.
+1) Install mkbootimg
 
 2) Setup CROSS_COMPILE to aarch64 compiler or if you use ccache just do
    CROSS_COMPILE="ccache aarch64-linux-gnu-"
@@ -33,15 +30,15 @@
 
    $ touch rd
 
-5) Generate qualcomm device tree table with dtbTool
+5) Append the dtb to the u-boot binary discarding the internal dtb.
 
-   $ dtbTool -o dt.img arch/arm/dts
+   $ gzip u-boot-nodtb.bin
+   $ cat u-boot.dtb >> u-boot-nodtb.bin.gz
 
 6) Generate Android boot image with mkbootimg:
 
-   $ mkbootimg --kernel=u-boot-dtb.bin             \
+   $ mkbootimg --kernel=u-boot-nodtb.bin.gz          \
                --output=u-boot.img                 \
-               --dt=dt.img                         \
                --pagesize 4096                     \
                --base 0x80000000                   \
                --ramdisk=rd                        \
@@ -251,44 +248,42 @@ Wait for 5 seconds before proceeding
 [5300] booting linux @ 0x80080000, ramdisk @ 0x82200000 (0), tags/device tree @ 0x82000000
 [5310] Jumping to kernel via monitor
 
-U-Boot 2017.11-00145-ge895117 (Nov 29 2017 - 10:04:06 +0100)
+U-Boot 2025.04-rc5-00020-g40a61ca0e7eb-dirty (Apr 07 2025 - 09:37:03 +0200)
 Qualcomm-DragonBoard 820C
 
-DRAM:  3 GiB
-PSCI:  v1.0
-MMC:   sdhci@74a4900: 0
+DRAM:  3.5 GiB (effective 3 GiB)
+Core:  136 devices, 18 uclasses, devicetree: board
+MMC:   Bulk clocks not available (-19), trying core clock
+mmc@74a4900: 0
+Loading Environment from EXT4... OK
 In:    serial@75b0000
 Out:   serial@75b0000
 Err:   serial@75b0000
-Net:   Net Initialization Skipped
-No ethernet found.
+Net:   No ethernet found.
 Hit any key to stop autoboot:  0
 switch to partitions #0, OK
 mmc0 is current device
 Scanning mmc 0:1...
 Found /extlinux/extlinux.conf
 Retrieving file: /extlinux/extlinux.conf
-433 bytes read in 71 ms (5.9 KiB/s)
 1:      nfs root
-
+Enter choice: 1:        nfs root
 Retrieving file: /uImage
-19397184 bytes read in 2024 ms (9.1 MiB/s)
-append: root=/dev/nfs rw nfsroot=192.168.1.2:/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlycon=msm_serial_dm,0x75b0000 androidboot.bootdevice=624000.ufshc androidboot.verifiedbootstate=orange androidboot.ver0
-
+append: root=/dev/nfs rw nfsroot=192.168.1.6:/home/jramirez/Src/qualcomm-lt/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlyco0
 Retrieving file: /apq8096-db820c.dtb
-38134 bytes read in 37 ms (1005.9 KiB/s)
-
-## Booting kernel from Legacy Image at 95000000 ...
+## Booting kernel from Legacy Image at 155000000 ...
    Image Name:   Dragonboard820c
    Image Type:   AArch64 Linux Kernel Image (uncompressed)
    Data Size:    19397120 Bytes = 18.5 MiB
    Load Address: 80080000
    Entry Point:  80080000
    Verifying Checksum ... OK
-## Flattened Device Tree blob at 93000000
-   Booting using the fdt blob at 0x93000000
-   Loading Kernel Image ... OK
-   Using Device Tree in place at 0000000093000000, end 000000009300c4f5
+## Flattened Device Tree blob at 148600000
+   Booting using the fdt blob at 0x148600000
+Working FDT set to 148600000
+   Loading Kernel Image to 80080000
+   Using Device Tree in place at 0000000148600000, end 000000014860c4f5
+Working FDT set to 148600000
 
 Starting kernel ...
 
--

2.34.1

#15 lore raw
Quoted 3 lines · Christopher Obbard

Hi Jorge,

Long time no speak.

hey, yeah, Embedded Recipes 2023 I think.

Quoted 11 lines
Quoted 5 lines · Jorge Ramirez-Ortiz

Update build instructions.

Your patch subject has a typo in "udpate" -> "update.

thanks!

Quoted 107 lines

With that fixed:

Quoted 104 lines
---
 board/qualcomm/dragonboard820c/readme.txt | 47 ++++++++++-------------
 1 file changed, 21 insertions(+), 26 deletions(-)
board/qualcomm/dragonboard820c/readme.txt +21 -27
index 966e9520e85..a01d24122cb 100644
@@ -16,10 +16,7 @@
                      Build & Run instructions
 ================================================================================
 
-1) Install mkbootimg and dtbTool from Codeaurora:
-
-   git://codeaurora.org/quic/kernel/skales
-   commit 8492547e404e969262d9070dee9bdd15668bb70f worked for me.
+1) Install mkbootimg
 
 2) Setup CROSS_COMPILE to aarch64 compiler or if you use ccache just do
    CROSS_COMPILE="ccache aarch64-linux-gnu-"
@@ -33,15 +30,15 @@
 
    $ touch rd
 
-5) Generate qualcomm device tree table with dtbTool
+5) Append the dtb to the u-boot binary discarding the internal dtb.
 
-   $ dtbTool -o dt.img arch/arm/dts
+   $ gzip u-boot-nodtb.bin
+   $ cat u-boot.dtb >> u-boot-nodtb.bin.gz
 
 6) Generate Android boot image with mkbootimg:
 
-   $ mkbootimg --kernel=u-boot-dtb.bin             \
+   $ mkbootimg --kernel=u-boot-nodtb.bin.gz          \
                --output=u-boot.img                 \
-               --dt=dt.img                         \
                --pagesize 4096                     \
                --base 0x80000000                   \
                --ramdisk=rd                        \
@@ -251,44 +248,42 @@ Wait for 5 seconds before proceeding
 [5300] booting linux @ 0x80080000, ramdisk @ 0x82200000 (0), tags/device tree @ 0x82000000
 [5310] Jumping to kernel via monitor
 
-U-Boot 2017.11-00145-ge895117 (Nov 29 2017 - 10:04:06 +0100)
+U-Boot 2025.04-rc5-00020-g40a61ca0e7eb-dirty (Apr 07 2025 - 09:37:03 +0200)
 Qualcomm-DragonBoard 820C
 
-DRAM:  3 GiB
-PSCI:  v1.0
-MMC:   sdhci@74a4900: 0
+DRAM:  3.5 GiB (effective 3 GiB)
+Core:  136 devices, 18 uclasses, devicetree: board
+MMC:   Bulk clocks not available (-19), trying core clock
+mmc@74a4900: 0
+Loading Environment from EXT4... OK
 In:    serial@75b0000
 Out:   serial@75b0000
 Err:   serial@75b0000
-Net:   Net Initialization Skipped
-No ethernet found.
+Net:   No ethernet found.
 Hit any key to stop autoboot:  0
 switch to partitions #0, OK
 mmc0 is current device
 Scanning mmc 0:1...
 Found /extlinux/extlinux.conf
 Retrieving file: /extlinux/extlinux.conf
-433 bytes read in 71 ms (5.9 KiB/s)
 1:      nfs root
-
+Enter choice: 1:        nfs root
 Retrieving file: /uImage
-19397184 bytes read in 2024 ms (9.1 MiB/s)
-append: root=/dev/nfs rw nfsroot=192.168.1.2:/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlycon=msm_serial_dm,0x75b0000 androidboot.bootdevice=624000.ufshc androidboot.verifiedbootstate=orange androidboot.ver0
-
+append: root=/dev/nfs rw nfsroot=192.168.1.6:/home/jramirez/Src/qualcomm-lt/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlyco0
 Retrieving file: /apq8096-db820c.dtb
-38134 bytes read in 37 ms (1005.9 KiB/s)
-
-## Booting kernel from Legacy Image at 95000000 ...
+## Booting kernel from Legacy Image at 155000000 ...
    Image Name:   Dragonboard820c
    Image Type:   AArch64 Linux Kernel Image (uncompressed)
    Data Size:    19397120 Bytes = 18.5 MiB
    Load Address: 80080000
    Entry Point:  80080000
    Verifying Checksum ... OK
-## Flattened Device Tree blob at 93000000
-   Booting using the fdt blob at 0x93000000
-   Loading Kernel Image ... OK
-   Using Device Tree in place at 0000000093000000, end 000000009300c4f5
+## Flattened Device Tree blob at 148600000
+   Booting using the fdt blob at 0x148600000
+Working FDT set to 148600000
+   Loading Kernel Image to 80080000
+   Using Device Tree in place at 0000000148600000, end 000000014860c4f5
+Working FDT set to 148600000
 
 Starting kernel ...
 
--

2.34.1

Reviewed-by on v1 1/5
#16 lore raw
In reply to Jorge Ramirez-Ortiz
Quoted 4 lines · Jorge Ramirez-Ortiz

Update build instructions.

Quoted 100 lines
  board/qualcomm/dragonboard820c/readme.txt | 47 ++++++++++-------------
  1 file changed, 21 insertions(+), 26 deletions(-)
board/qualcomm/dragonboard820c/readme.txt +21 -26
index 966e9520e85..a01d24122cb 100644
@@ -16,10 +16,7 @@
                       Build & Run instructions
  ================================================================================
 
-1) Install mkbootimg and dtbTool from Codeaurora:
-
-   git://codeaurora.org/quic/kernel/skales
-   commit 8492547e404e969262d9070dee9bdd15668bb70f worked for me.
+1) Install mkbootimg
 
  2) Setup CROSS_COMPILE to aarch64 compiler or if you use ccache just do
     CROSS_COMPILE="ccache aarch64-linux-gnu-"
@@ -33,15 +30,15 @@
 
     $ touch rd
 
-5) Generate qualcomm device tree table with dtbTool
+5) Append the dtb to the u-boot binary discarding the internal dtb.
 
-   $ dtbTool -o dt.img arch/arm/dts
+   $ gzip u-boot-nodtb.bin
+   $ cat u-boot.dtb >> u-boot-nodtb.bin.gz
 
  6) Generate Android boot image with mkbootimg:
 
-   $ mkbootimg --kernel=u-boot-dtb.bin             \
+   $ mkbootimg --kernel=u-boot-nodtb.bin.gz          \
                 --output=u-boot.img                 \
-               --dt=dt.img                         \
                 --pagesize 4096                     \
                 --base 0x80000000                   \
                 --ramdisk=rd                        \
@@ -251,44 +248,42 @@ Wait for 5 seconds before proceeding
  [5300] booting linux @ 0x80080000, ramdisk @ 0x82200000 (0), tags/device tree @ 0x82000000
  [5310] Jumping to kernel via monitor
 
-U-Boot 2017.11-00145-ge895117 (Nov 29 2017 - 10:04:06 +0100)
+U-Boot 2025.04-rc5-00020-g40a61ca0e7eb-dirty (Apr 07 2025 - 09:37:03 +0200)
  Qualcomm-DragonBoard 820C
 
-DRAM:  3 GiB
-PSCI:  v1.0
-MMC:   sdhci@74a4900: 0
+DRAM:  3.5 GiB (effective 3 GiB)
+Core:  136 devices, 18 uclasses, devicetree: board
+MMC:   Bulk clocks not available (-19), trying core clock
+mmc@74a4900: 0
+Loading Environment from EXT4... OK
  In:    serial@75b0000
  Out:   serial@75b0000
  Err:   serial@75b0000
-Net:   Net Initialization Skipped
-No ethernet found.
+Net:   No ethernet found.
  Hit any key to stop autoboot:  0
  switch to partitions #0, OK
  mmc0 is current device
  Scanning mmc 0:1...
  Found /extlinux/extlinux.conf
  Retrieving file: /extlinux/extlinux.conf
-433 bytes read in 71 ms (5.9 KiB/s)
  1:      nfs root
-
+Enter choice: 1:        nfs root
  Retrieving file: /uImage
-19397184 bytes read in 2024 ms (9.1 MiB/s)
-append: root=/dev/nfs rw nfsroot=192.168.1.2:/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlycon=msm_serial_dm,0x75b0000 androidboot.bootdevice=624000.ufshc androidboot.verifiedbootstate=orange androidboot.ver0
-
+append: root=/dev/nfs rw nfsroot=192.168.1.6:/home/jramirez/Src/qualcomm-lt/db820c/rootfs,v3,tcp rootwait ip=dhcp consoleblank=0 console=tty0 console=ttyMSM0,115200n8 earlyprintk earlyco0
  Retrieving file: /apq8096-db820c.dtb
-38134 bytes read in 37 ms (1005.9 KiB/s)
-
-## Booting kernel from Legacy Image at 95000000 ...
+## Booting kernel from Legacy Image at 155000000 ...
     Image Name:   Dragonboard820c
     Image Type:   AArch64 Linux Kernel Image (uncompressed)
     Data Size:    19397120 Bytes = 18.5 MiB
     Load Address: 80080000
     Entry Point:  80080000
     Verifying Checksum ... OK
-## Flattened Device Tree blob at 93000000
-   Booting using the fdt blob at 0x93000000
-   Loading Kernel Image ... OK
-   Using Device Tree in place at 0000000093000000, end 000000009300c4f5
+## Flattened Device Tree blob at 148600000
+   Booting using the fdt blob at 0x148600000
+Working FDT set to 148600000
+   Loading Kernel Image to 80080000
+   Using Device Tree in place at 0000000148600000, end 000000014860c4f5
+Working FDT set to 148600000
 
  Starting kernel ...
 
Signature · 1 line
Caleb (they/them)