dt-bindings: arm: rockchip: Add MNT Reform 2 (RCORE)

PATCH Superseded Patrick Wildt 3 participants 6 messages Jan 30, 2025 – Feb 10, 2025

Subsystems (2)

Device tree bindings Arm Rockchip

lore

Share & tools

lore

Patrick Wildt

author

2025-01-30 11:53 UTC #0 lore raw

PATCH 1/2 dt-bindings: arm: rockchip: Add MNT Reform 2 (RCORE)

Document board compatible bindings.

Signed-off-by Patrick Wildt <[email protected]>

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0

index 522a6f0450ea..bc995db8cbfe 100644
@@ -710,6 +710,11 @@ properties:
           - const: mqmaker,miqi
           - const: rockchip,rk3288
 
+      - description: MNT Reform2 (RCORE)
+        items:
+          - const: mntre,reform2-rcore
+          - const: rockchip,rk3588
+
       - description: Neardi LBA3368
         items:
           - const: neardi,lba3368

Signature · 1 line

2.48.1

Patrick Wildt

author

2025-01-30 11:54 UTC #1 lore raw

PATCH 2/2 arm64: dts: rockchip: add MNT Reform 2

MNT Reform 2 is an open source laptop with replaceable CPU modules, including a version with the RK3588-based MNT RCORE[1]:

- Rockchip RK3588
- Quad A76 and Quad A55 CPU
- 6 TOPS NPU
- up to 32GB LPDDR4x RAM
- SD Card slot
- Gigabit ethernet port
- HDMI port
- 2x mPCIe ports for WiFi or NVMe
- 3x USB 3.0 Type-A HOST port

[1] https://shop.mntre.com/products/mnt-reform

Signed-off-by Lukas F. Hartmann <[email protected]>

Signed-off-by Patrick Wildt <[email protected]>

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588-mnt-reform2.dts  | 921 ++++++++++++++++++
 2 files changed, 922 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts

arch/arm64/boot/dts/rockchip/Makefile +1 -0

index def1222c1907..88381d9a20e3 100644
@@ -145,6 +145,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-firefly-itx-3588j.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-friendlyelec-cm3588-nas.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-h96-max-v58.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-jaguar.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-mnt-reform2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6-lts.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +921 -0

921 lines not on this page · raw message

Signature · 1 line

2.48.1

Krzysztof Kozlowski

2025-01-30 12:05 UTC #2 lore raw

Re: [PATCH 2/2] arm64: dts: rockchip: add MNT Reform 2

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 247

Quoted 11 lines · Patrick Wildt

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +11 -0

+
+&hdptxphy_hdmi0 {
+	status = "okay";
+};
+
+&i2c0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0m2_xfer>;
+	status = "okay";
+
+	vdd_cpu_big0_s0: vdd_cpu_big0_mem_s0: rk8602@42 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 11 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +11 -0

+		compatible = "rockchip,rk8602";
+		reg = <0x42>;
+
+		vin-supply = <&vcc5v0_sys>;
+		fcs,suspend-voltage-selector = <1>;
+		rockchip,suspend-voltage-selector = <1>;
+
+		regulator-compatible = "rk860x-reg";
+		regulator-name = "vdd_cpu_big0_s0";
+		regulator-min-microvolt = <0x86470>;
+		regulator-max-microvolt = <0x100590>;

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 268

Quoted 10 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +10 -0

+		regulator-ramp-delay = <0x8fc>;
+		regulator-boot-on;
+		regulator-always-on;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+
+	vdd_cpu_big1_s0: vdd_cpu_big1_mem_s0: rk8603@43 {

Quoted 3 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +3 -0
+		compatible = "rockchip,rk8602", "rockchip,rk8603";
+		reg = <0x43>;
+

...

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 431

Quoted 12 lines

+&spi2 {

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +11 -0

+	status = "okay";
+	assigned-clocks = <&cru CLK_SPI2>;
+	assigned-clock-rates = <200000000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi2m2_cs0 &spi2m2_pins>;
+	num-cs = <1>;
+
+	rk806single: pmic@0 {
+		compatible = "rockchip,rk806";
+		spi-max-frequency = <1000000>;
+		reg = <0x0>;

reg is always theh second property.

Quoted 26 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +26 -0

+
+		interrupt-parent = <&gpio0>;
+		interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-names = "default", "pmic-power-off";
+		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
+			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
+		pinctrl-1 = <&rk806_dvs1_pwrdn>;
+
+		pmic-reset-func = <1>;
+
+		vcc1-supply = <&vcc5v0_sys>;
+		vcc2-supply = <&vcc5v0_sys>;
+		vcc3-supply = <&vcc5v0_sys>;
+		vcc4-supply = <&vcc5v0_sys>;
+		vcc5-supply = <&vcc5v0_sys>;
+		vcc6-supply = <&vcc5v0_sys>;
+		vcc7-supply = <&vcc5v0_sys>;
+		vcc8-supply = <&vcc5v0_sys>;
+		vcc9-supply = <&vcc5v0_sys>;
+		vcc10-supply = <&vcc5v0_sys>;
+		vcc11-supply = <&vcc_2v0_pldo_s3>;
+		vcc12-supply = <&vcc5v0_sys>;
+		vcc13-supply = <&vcc_1v1_nldo_s3>;
+		vcc14-supply = <&vcc_1v1_nldo_s3>;
+		vcca-supply = <&vcc5v0_sys>;

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 467

Quoted 10 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +10 -0

+
+		#gpio-cells = <2>;
+		gpio-controller;
+
+		rk806_dvs1_null: dvs1-null-pins {
+			pins = "gpio_pwrctrl2";
+			function = "pin_fun0";
+		};
+
+		rk806_dvs1_slp: rk806_dvs1_slp {

No underscores in node names. Missing suffix also suggests this fails tests, so standard disclaimer:

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 470

Quoted 3 lines

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +3 -0
+			pins = "gpio_pwrctrl1";
+			function = "pin_fun1";
+		};

Best regards,
Krzysztof

Patrick Wildt

author

2025-02-10 22:14 UTC #3 lore raw

Re: [PATCH 2/2] arm64: dts: rockchip: add MNT Reform 2

Quoted 6 lines · Krzysztof Kozlowski

arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts line 467
Quoted 1 line · Patrick Wildt
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts new file +1 -0
+		rk806_dvs1_slp: rk806_dvs1_slp {
No underscores in node names. Missing suffix also suggests this fails tests, so standard disclaimer:

Quoted 8 lines

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.

Hi Krzysztof,

You were right, I did not know about that; thanks for bringing that to my attention! I've prepared a v2 that I'll send out now which does seem to be happy with the schema, and hope fix those issues plus a few more.

Please let me know if there's anything else that I might have missed.

Thanks,
Patrick

Rob Herring (Arm)

maintainer

2025-01-30 23:38 UTC #4 lore raw

In reply to Patrick Wildt

Quoted 7 lines · Patrick Wildt

Document board compatible bindings.
Signed-off-by Patrick Wildt <[email protected]>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi:355.39-358.4: Warning (clocks_property): /display-subsystem: Missing property '#clock-cells' in node /phy@fed60000 or bad phandle (referred from clocks[0])
also defined at arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts:200.20-203.3
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: display-subsystem: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: rk8602@42: Unevaluated properties are not allowed ('regulator-compatible', 'rockchip,suspend-voltage-selector' were unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: rk8603@43: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk8602', 'rockchip,rk8603'] is too long
'rockchip,rk8601' was expected
'rockchip,rk8603' was expected
'rockchip,rk8600' was expected
'rockchip,rk8602' was expected
from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: rk8603@43: Unevaluated properties are not allowed ('compatible', 'regulator-compatible', 'rockchip,suspend-voltage-selector' were unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: hdmi@fde80000: Unevaluated properties are not allowed ('enable-gpios' was unexpected)
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk806.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: pmic@0: Unevaluated properties are not allowed ('pmic-reset-func', 'regulators', 'rk806_dvs1_pwrdn', 'rk806_dvs1_rst', 'rk806_dvs1_slp', 'rk806_dvs2_dvs', 'rk806_dvs2_gpio', 'rk806_dvs2_null', 'rk806_dvs2_pwrdn', 'rk806_dvs2_rst', 'rk806_dvs2_slp', 'rk806_dvs3_dvs', 'rk806_dvs3_gpio', 'rk806_dvs3_null', 'rk806_dvs3_pwrdn', 'rk806_dvs3_rst', 'rk806_dvs3_slp' were unexpected)
from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk806.yaml#
arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dtb: codec@1a: Unevaluated properties are not allowed ('port' was unexpected)
from schema $id: http://devicetree.org/schemas/sound/wlf,wm8960.yaml#

Krzysztof Kozlowski

Acked-by on v1 1/2

2025-01-31 07:42 UTC #5 lore raw

In reply to Patrick Wildt

Quoted 6 lines · Patrick Wildt

Document board compatible bindings.
Signed-off-by Patrick Wildt <[email protected]>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof