RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call
Subsystems (2)
PATCH 1/1 RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call
Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.
--- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/irdma/hw.c +2 -2
@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_break ; rf->init_state =CEQ0_CREATED ;/* Handles processing of CQP completions */ - rf->cqp_cmpl_wq =alloc_ordered_workqueue ("cqp_cmpl_wq" , -WQ_HIGHPRI |WQ_UNBOUND ); + rf->cqp_cmpl_wq = +alloc_ordered_workqueue ("cqp_cmpl_wq" ,WQ_HIGHPRI );if (!rf->cqp_cmpl_wq) { status = -ENOMEM ;break ;
Quoted 27 lines
Subject: [PATCH] RDMA/irdma: Drop spurious
WQ_UNBOUNDfromalloc_ordered_workqueue()callWorkqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit
WQ_UNBOUNDisn't needed foralloc_ordered_workqueue()and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.Signed-off-by Tejun Heo <[email protected]>--- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/infiniband/hw/irdma/hw.c +2
-2@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_break ; rf->init_state =CEQ0_CREATED ;/* Handles processing of CQP completions */ - rf->cqp_cmpl_wq =alloc_ordered_workqueue ("cqp_cmpl_wq" , -WQ_HIGHPRI | WQ_UNBOUND); + rf->cqp_cmpl_wq = +alloc_ordered_workqueue ("cqp_cmpl_wq" ,WQ_HIGHPRI );if (!rf->cqp_cmpl_wq) {
drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908
Quoted 2 lines
drivers/infiniband/hw/irdma/hw.c +0
-0status = -ENOMEM ;break ;
Quoted 23 lines · Shiraz
Quoted 23 lines
Subject: [PATCH] RDMA/irdma: Drop spurious
WQ_UNBOUNDfromalloc_ordered_workqueue()callWorkqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit
WQ_UNBOUNDisn't needed foralloc_ordered_workqueue()and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.Signed-off-by Tejun Heo <[email protected]>--- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/infiniband/hw/irdma/hw.c +0
-2@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_break ; rf->init_state =CEQ0_CREATED ;/* Handles processing of CQP completions */ - rf->cqp_cmpl_wq =alloc_ordered_workqueue ("cqp_cmpl_wq" , -WQ_HIGHPRI | WQ_UNBOUND);
Quoted 8 lines
drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908
Quoted 6 lines
drivers/infiniband/hw/irdma/hw.c +2
-0+ rf->cqp_cmpl_wq = +alloc_ordered_workqueue ("cqp_cmpl_wq" ,WQ_HIGHPRI );if (!rf->cqp_cmpl_wq) {drivers/infiniband/hw/irdma/hw.c +0
-0status = -ENOMEM ;break ;Acked-by Shiraz Saleem <[email protected]>
Tejun, do you want this in your tree too?
Thanks
Jason
Hello,
Quoted 33 lines · Jason Gunthorpe
Quoted 23 lines · Shiraz
Quoted 23 lines
Subject: [PATCH] RDMA/irdma: Drop spurious
WQ_UNBOUNDfromalloc_ordered_workqueue()callWorkqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit
WQ_UNBOUNDisn't needed foralloc_ordered_workqueue()and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.Signed-off-by Tejun Heo <[email protected]>--- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/infiniband/hw/irdma/hw.c +0
-2@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_break ; rf->init_state =CEQ0_CREATED ;/* Handles processing of CQP completions */ - rf->cqp_cmpl_wq =alloc_ordered_workqueue ("cqp_cmpl_wq" , -WQ_HIGHPRI | WQ_UNBOUND);Quoted 8 lines
drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908
Quoted 6 lines
drivers/infiniband/hw/irdma/hw.c +2
-0+ rf->cqp_cmpl_wq = +alloc_ordered_workqueue ("cqp_cmpl_wq" ,WQ_HIGHPRI );if (!rf->cqp_cmpl_wq) {drivers/infiniband/hw/irdma/hw.c +0
-0status = -ENOMEM ;break ;Acked-by Shiraz Saleem <[email protected]>
Quoted 1 line
Tejun, do you want this in your tree too?
This one doesn't create any dependency and can go through any tree. So, I guess routing through RDMA is better?
Thanks.
Signature · 1 line
tejun
Quoted 10 lines · Tejun Heo
Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit
WQ_UNBOUNDisn't needed foralloc_ordered_workqueue()and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.Signed-off-by Tejun Heo <[email protected]>Acked-by Shiraz Saleem <[email protected]>--- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-next, thanks
Jason