Skip to contentSkip to conversation

RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call

PATCH Applied Tejun Heo 4 participants 5 messages Apr 20, 2023 – Apr 21, 2023

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call

Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.

---
 drivers/infiniband/hw/irdma/hw.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/irdma/hw.c +2 -2
@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
 			break;
 		rf->init_state = CEQ0_CREATED;
 		/* Handles processing of CQP completions */
-		rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
-						WQ_HIGHPRI | WQ_UNBOUND);
+		rf->cqp_cmpl_wq =
+			alloc_ordered_workqueue("cqp_cmpl_wq", WQ_HIGHPRI);
 		if (!rf->cqp_cmpl_wq) {
 			status = -ENOMEM;
 			break;
Acked-by on v1 1/1
#1 lore raw
Quoted 27 lines

Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call

Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.

---
 drivers/infiniband/hw/irdma/hw.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/irdma/hw.c +2 -2
@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
 			break;
 		rf->init_state = CEQ0_CREATED;
 		/* Handles processing of CQP completions */
-		rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
-						WQ_HIGHPRI |
 WQ_UNBOUND);
+		rf->cqp_cmpl_wq =
+			alloc_ordered_workqueue("cqp_cmpl_wq",
 WQ_HIGHPRI);
 		if (!rf->cqp_cmpl_wq) {

drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908

Quoted 2 lines
drivers/infiniband/hw/irdma/hw.c +0 -0
 			status = -ENOMEM;
 			break;
#2 lore raw
Quoted 23 lines · Shiraz
Quoted 23 lines

Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call

Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.

---
 drivers/infiniband/hw/irdma/hw.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/irdma/hw.c +0 -2
@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
 			break;
 		rf->init_state = CEQ0_CREATED;
 		/* Handles processing of CQP completions */
-		rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
-						WQ_HIGHPRI |
 WQ_UNBOUND);
Quoted 8 lines

drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908

Quoted 6 lines
drivers/infiniband/hw/irdma/hw.c +2 -0
+		rf->cqp_cmpl_wq =
+			alloc_ordered_workqueue("cqp_cmpl_wq",
 WQ_HIGHPRI);
 		if (!rf->cqp_cmpl_wq) {
drivers/infiniband/hw/irdma/hw.c +0 -0
 			status = -ENOMEM;
 			break;

Tejun, do you want this in your tree too?

Thanks
Jason

author
#3 lore raw

Hello,

Quoted 33 lines · Jason Gunthorpe
Quoted 23 lines · Shiraz
Quoted 23 lines

Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call

Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.

---
 drivers/infiniband/hw/irdma/hw.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/irdma/hw.c +0 -2
@@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
 			break;
 		rf->init_state = CEQ0_CREATED;
 		/* Handles processing of CQP completions */
-		rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
-						WQ_HIGHPRI |
 WQ_UNBOUND);
Quoted 8 lines

drivers/infiniband/hw/irdma/hw.c int irdma_ctrl_init_hw(struct irdma_pci_ · line 1908

Quoted 6 lines
drivers/infiniband/hw/irdma/hw.c +2 -0
+		rf->cqp_cmpl_wq =
+			alloc_ordered_workqueue("cqp_cmpl_wq",
 WQ_HIGHPRI);
 		if (!rf->cqp_cmpl_wq) {
drivers/infiniband/hw/irdma/hw.c +0 -0
 			status = -ENOMEM;
 			break;
Quoted 1 line

Tejun, do you want this in your tree too?

This one doesn't create any dependency and can go through any tree. So, I guess routing through RDMA is better?

Thanks.

Signature · 1 line
tejun
maintainer Applied
#4 lore raw
In reply to Tejun Heo
Quoted 10 lines · Tejun Heo

Workqueue is in the process of cleaning up the distinction between unbound workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a warning in the future. Let's remove it. This doesn't cause any functional changes.

---
 drivers/infiniband/hw/irdma/hw.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason