Skip to contentSkip to conversation

drm/xe: clear the serviced bits on INTR_IDENTITY_REG

PATCH Superseded Jonathan Cavitt 2 participants 2 messages Nov 3, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/xe: clear the serviced bits on INTR_IDENTITY_REG

On XE, we have to write the serviced bits to the
INTR_IDENTITY_REG. Do so.

CC Daniele Spurio Ceraolo <[email protected]>
CC Lucas De Marchi <[email protected]>
---
 drivers/gpu/drm/xe/xe_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 21d5273d7e611..c5315e02fc5bb 100644
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
 		return 0;
 	}
 
-	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
 
 	return ident;
 }
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 2 lines · Jonathan Cavitt

On XE, we have to write the serviced bits to the
INTR_IDENTITY_REG. Do so.

Please have a more descriptive commit message, explaining why do we need or what are you trying to solve.

like, why does Xe needs but i915 can stay with the other code? what bug, condition or corner case are you attempting to address?

Quoted 24 lines
CC Daniele Spurio Ceraolo <[email protected]>
CC Lucas De Marchi <[email protected]>
---
 drivers/gpu/drm/xe/xe_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 21d5273d7e611..c5315e02fc5bb 100644
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
 		return 0;
 	}
 
-	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
 
 	return ident;
 }
Signature · 1 line
2.25.1