Define _GNU_SOURCE for sources using

Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a central location.

809216233555 ("selftests/harness: remove use of LINE_MAX") introduced asprintf into kselftest_harness.h, which is a GNU extension and needs _GNU_SOURCE to either be defined prior to including headers or with the -D_GNU_SOURCE flag passed to the compiler.

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Reported-by kernel test robot <[email protected]>

Closes https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang at intel.com

Signed-off-by Edward Liaw <[email protected]>

---
 tools/testing/selftests/Makefile            | 4 ++--
 tools/testing/selftests/kselftest_harness.h | 2 +-
 tools/testing/selftests/lib.mk              | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

tools/testing/selftests/Makefile +2 -2

index e1504833654d..ed012a7f0786 100644
@@ -161,11 +161,11 @@ ifneq ($(KBUILD_OUTPUT),)
   # $(realpath ...) resolves symlinks
   abs_objtree := $(realpath $(abs_objtree))
   BUILD := $(abs_objtree)/kselftest
-  KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include
+  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include
 else
   BUILD := $(CURDIR)
   abs_srctree := $(shell cd $(top_srcdir) && pwd)
-  KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include
+  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include
   DEFAULT_INSTALL_HDR_PATH := 1
 endif
 

tools/testing/selftests/kselftest_harness.h +1 -1

index d98702b6955d..b2a1b6343896 100644
@@ -51,7 +51,7 @@
 #define __KSELFTEST_HARNESS_H
 
 #ifndef _GNU_SOURCE
-#define _GNU_SOURCE
+static_assert(0, "kselftest harness requires _GNU_SOURCE to be defined");
 #endif
 #include <asm/types.h>
 #include <ctype.h>

tools/testing/selftests/lib.mk +1 -1

index da2cade3bab0..2503dc732b4d 100644
@@ -45,7 +45,7 @@ selfdir = $(realpath $(dir $(filter %/lib.mk,$(MAKEFILE_LIST))))
 top_srcdir = $(selfdir)/../../..
 
 ifeq ($(KHDR_INCLUDES),)
-KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include
+KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include
 endif
 
 # The following are built by lib.mk common compile rules.

Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a central location.

809216233555 ("selftests/harness: remove use of LINE_MAX") introduced asprintf into kselftest_harness.h, which is a GNU extension and needs _GNU_SOURCE to either be defined prior to including headers or with the -D_GNU_SOURCE flag passed to the compiler.

Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a central location.

809216233555 ("selftests/harness: remove use of LINE_MAX") introduced asprintf into kselftest_harness.h, which is a GNU extension and needs _GNU_SOURCE to either be defined prior to including headers or with the -D_GNU_SOURCE flag passed to the compiler.

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Reported-by kernel test robot <[email protected]>

Closes https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang at intel.com

Signed-off-by Edward Liaw <[email protected]>

---
  tools/testing/selftests/Makefile            | 4 ++--
  tools/testing/selftests/kselftest_harness.h | 2 +-
  tools/testing/selftests/lib.mk              | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)

tools/testing/selftests/Makefile +0 -0

index e1504833654d..ed012a7f0786 100644
@@ -161,11 +161,11 @@ ifneq ($(KBUILD_OUTPUT),)
    # $(realpath ...) resolves symlinks
    abs_objtree := $(realpath $(abs_objtree))

tools/testing/selftests/kselftest_harness.h +1 -1

index d98702b6955d..b2a1b6343896 100644
@@ -51,7 +51,7 @@
  #define __KSELFTEST_HARNESS_H
 
  #ifndef _GNU_SOURCE
-#define _GNU_SOURCE
+static_assert(0, "kselftest harness requires _GNU_SOURCE to be defined");
  #endif
  #include <asm/types.h>
  #include <ctype.h>

tools/testing/selftests/lib.mk +0 -0

index da2cade3bab0..2503dc732b4d 100644

Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Also, remove redefinitions of _GNU_SOURCE in the source code.

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Reported-by kernel test robot <[email protected]>

Closes https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang at intel.com

Signed-off-by Edward Liaw <[email protected]>

---
 tools/testing/selftests/sgx/Makefile    | 2 +-
 tools/testing/selftests/sgx/sigstruct.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

tools/testing/selftests/sgx/Makefile +1 -1

index 867f88ce2570..26ea30fae23c 100644
@@ -12,7 +12,7 @@ OBJCOPY := $(CROSS_COMPILE)objcopy
 endif
 
 INCLUDES := -I$(top_srcdir)/tools/include
-HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
+HOST_CFLAGS := -Wall -Werror $(KHDR_INCLUDES) -g $(INCLUDES) -fPIC
 HOST_LDFLAGS := -z noexecstack -lcrypto
 ENCL_CFLAGS += -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE \
 	       -fno-stack-protector -mrdrnd $(INCLUDES)

tools/testing/selftests/sgx/sigstruct.c +0 -1

index d73b29becf5b..200034a0fee5 100644
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*  Copyright(c) 2016-20 Intel Corporation. */
 
-#define _GNU_SOURCE
 #include <assert.h>
 #include <getopt.h>
 #include <stdbool.h>

Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Also, remove redefinitions of _GNU_SOURCE in the source code.

Quoted 4 lines · Edward Liaw

Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Also, remove redefinitions of _GNU_SOURCE in the source code.

From an x86 and SGX perspective, looks fine. I assume Shuah is planning on taking this pile.

Acked-by Dave Hansen <[email protected]>

Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Also, remove redefinitions of _GNU_SOURCE in the source code.

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Reported-by kernel test robot <[email protected]>

Closes https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang at intel.com

Signed-off-by Edward Liaw <[email protected]>

---
  tools/testing/selftests/sgx/Makefile    | 2 +-
  tools/testing/selftests/sgx/sigstruct.c | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

tools/testing/selftests/sgx/Makefile +1 -1

index 867f88ce2570..26ea30fae23c 100644
@@ -12,7 +12,7 @@ OBJCOPY := $(CROSS_COMPILE)objcopy
  endif
 
  INCLUDES := -I$(top_srcdir)/tools/include
-HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
+HOST_CFLAGS := -Wall -Werror $(KHDR_INCLUDES) -g $(INCLUDES) -fPIC
  HOST_LDFLAGS := -z noexecstack -lcrypto
  ENCL_CFLAGS += -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE \
  	       -fno-stack-protector -mrdrnd $(INCLUDES)

tools/testing/selftests/sgx/sigstruct.c +0 -1

index d73b29becf5b..200034a0fee5 100644
@@ -1,7 +1,6 @@
  // SPDX-License-Identifier: GPL-2.0
  /*  Copyright(c) 2016-20 Intel Corporation. */
 
-#define _GNU_SOURCE
  #include <assert.h>
  #include <getopt.h>
  #include <stdbool.h>

Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Signed-off-by Edward Liaw <[email protected]>

Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Signed-off-by Edward Liaw <[email protected]>

---
 tools/testing/selftests/alsa/Makefile                  | 2 +-
 tools/testing/selftests/arm64/signal/Makefile          | 2 +-
 tools/testing/selftests/exec/Makefile                  | 2 +-
 tools/testing/selftests/filesystems/overlayfs/Makefile | 2 +-
 tools/testing/selftests/hid/Makefile                   | 2 +-
 tools/testing/selftests/nci/Makefile                   | 2 +-
 tools/testing/selftests/prctl/Makefile                 | 2 ++
 tools/testing/selftests/proc/Makefile                  | 2 +-
 tools/testing/selftests/riscv/mm/Makefile              | 2 +-
 tools/testing/selftests/rtc/Makefile                   | 2 +-
 tools/testing/selftests/tmpfs/Makefile                 | 2 +-
 11 files changed, 12 insertions(+), 10 deletions(-)

tools/testing/selftests/alsa/Makefile +1 -1

index 5af9ba8a4645..9a0ef194522c 100644
@@ -6,7 +6,7 @@ LDLIBS += $(shell pkg-config --libs alsa)
 ifeq ($(LDLIBS),)
 LDLIBS += -lasound
 endif
-CFLAGS += -L$(OUTPUT) -Wl,-rpath=./
+CFLAGS += $(KHDR_INCLUDES) -L$(OUTPUT) -Wl,-rpath=./
 
 LDLIBS+=-lpthread
 

tools/testing/selftests/arm64/signal/Makefile +1 -1

index 8f5febaf1a9a..ae682ade615d 100644
@@ -2,7 +2,7 @@
 # Copyright (C) 2019 ARM Limited
 
 # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
 SRCS := $(filter-out testcases/testcases.c,$(wildcard testcases/*.c))
 PROGS := $(patsubst %.c,%,$(SRCS))

tools/testing/selftests/exec/Makefile +1 -1

index fb4472ddffd8..15e78ec7c55e 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 CFLAGS = -Wall
 CFLAGS += -Wno-nonnull
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
 TEST_PROGS := binfmt_script.py
 TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular

tools/testing/selftests/filesystems/overlayfs/Makefile +1 -1

index 56b2b48a765b..6c29c963c7a8 100644
@@ -2,6 +2,6 @@
 
 TEST_GEN_PROGS := dev_in_maps
 
-CFLAGS := -Wall -Werror
+CFLAGS := -Wall -Werror $(KHDR_INCLUDES)
 
 include ../../lib.mk

tools/testing/selftests/hid/Makefile +1 -1

index 2b5ea18bde38..0661b34488ef 100644
@@ -21,7 +21,7 @@ CXX ?= $(CROSS_COMPILE)g++
 
 HOSTPKG_CONFIG := pkg-config
 
-CFLAGS += -g -O0 -rdynamic -Wall -Werror -I$(OUTPUT)
+CFLAGS += -g -O0 -rdynamic -Wall -Werror $(KHDR_INCLUDES) -I$(OUTPUT)
 CFLAGS += -I$(OUTPUT)/tools/include
 
 LDLIBS += -lelf -lz -lrt -lpthread

tools/testing/selftests/nci/Makefile +1 -1

index 47669a1d6a59..bbc5b8ec3b17 100644
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wl,-no-as-needed -Wall
+CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
 LDFLAGS += -lpthread
 
 TEST_GEN_PROGS := nci_dev

tools/testing/selftests/prctl/Makefile +2 -0

index 01dc90fbb509..1a0aefec9d6f 100644
@@ -6,6 +6,8 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
 ifeq ($(ARCH),x86)
 TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \
 		disable-tsc-test set-anon-vma-name-test set-process-name
+
+CFLAGS += $(KHDR_INCLUDES)
 all: $(TEST_PROGS)
 
 include ../lib.mk

tools/testing/selftests/proc/Makefile +1 -1

index cd95369254c0..9596014c10a0 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 CFLAGS += -Wall -O2 -Wno-unused-function
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 LDFLAGS += -pthread
 
 TEST_GEN_PROGS :=

tools/testing/selftests/riscv/mm/Makefile +1 -1

index c333263f2b27..715a21241113 100644
@@ -3,7 +3,7 @@
 # Originally tools/testing/arm64/abi/Makefile
 
 # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
 TEST_GEN_FILES := mmap_default mmap_bottomup
 

tools/testing/selftests/rtc/Makefile +1 -1

index 55198ecc04db..654f9d58da3c 100644
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -O3 -Wl,-no-as-needed -Wall
+CFLAGS += -O3 -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
 LDLIBS += -lrt -lpthread -lm
 
 TEST_GEN_PROGS = rtctest

tools/testing/selftests/tmpfs/Makefile +1 -1

index aa11ccc92e5b..bcdc1bb6d2e6 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 CFLAGS += -Wall -O2
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
 TEST_GEN_PROGS :=
 TEST_GEN_PROGS += bug-link-o-tmpfile

Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Signed-off-by Edward Liaw <[email protected]>

---
  tools/testing/selftests/alsa/Makefile                  | 2 +-
  tools/testing/selftests/arm64/signal/Makefile          | 2 +-
  tools/testing/selftests/exec/Makefile                  | 2 +-
  tools/testing/selftests/filesystems/overlayfs/Makefile | 2 +-
  tools/testing/selftests/hid/Makefile                   | 2 +-
  tools/testing/selftests/nci/Makefile                   | 2 +-
  tools/testing/selftests/prctl/Makefile                 | 2 ++
  tools/testing/selftests/proc/Makefile                  | 2 +-
  tools/testing/selftests/riscv/mm/Makefile              | 2 +-
  tools/testing/selftests/rtc/Makefile                   | 2 +-
  tools/testing/selftests/tmpfs/Makefile                 | 2 +-
  11 files changed, 12 insertions(+), 10 deletions(-)

tools/testing/selftests/alsa/Makefile +1 -1

index 5af9ba8a4645..9a0ef194522c 100644
@@ -6,7 +6,7 @@ LDLIBS += $(shell pkg-config --libs alsa)
  ifeq ($(LDLIBS),)
  LDLIBS += -lasound
  endif
-CFLAGS += -L$(OUTPUT) -Wl,-rpath=./
+CFLAGS += $(KHDR_INCLUDES) -L$(OUTPUT) -Wl,-rpath=./
 
  LDLIBS+=-lpthread
 

tools/testing/selftests/arm64/signal/Makefile +1 -1

index 8f5febaf1a9a..ae682ade615d 100644
@@ -2,7 +2,7 @@
  # Copyright (C) 2019 ARM Limited
 
  # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
  SRCS := $(filter-out testcases/testcases.c,$(wildcard testcases/*.c))
  PROGS := $(patsubst %.c,%,$(SRCS))

tools/testing/selftests/exec/Makefile +1 -1

index fb4472ddffd8..15e78ec7c55e 100644
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
  CFLAGS = -Wall
  CFLAGS += -Wno-nonnull
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
  TEST_PROGS := binfmt_script.py
  TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular

tools/testing/selftests/filesystems/overlayfs/Makefile +1 -1

index 56b2b48a765b..6c29c963c7a8 100644
@@ -2,6 +2,6 @@
 
  TEST_GEN_PROGS := dev_in_maps
 
-CFLAGS := -Wall -Werror
+CFLAGS := -Wall -Werror $(KHDR_INCLUDES)
 
  include ../../lib.mk

tools/testing/selftests/hid/Makefile +1 -1

index 2b5ea18bde38..0661b34488ef 100644
@@ -21,7 +21,7 @@ CXX ?= $(CROSS_COMPILE)g++
 
  HOSTPKG_CONFIG := pkg-config
 
-CFLAGS += -g -O0 -rdynamic -Wall -Werror -I$(OUTPUT)
+CFLAGS += -g -O0 -rdynamic -Wall -Werror $(KHDR_INCLUDES) -I$(OUTPUT)
  CFLAGS += -I$(OUTPUT)/tools/include
 
  LDLIBS += -lelf -lz -lrt -lpthread

tools/testing/selftests/nci/Makefile +1 -1

index 47669a1d6a59..bbc5b8ec3b17 100644
@@ -1,5 +1,5 @@
  # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wl,-no-as-needed -Wall
+CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
  LDFLAGS += -lpthread
 
  TEST_GEN_PROGS := nci_dev

tools/testing/selftests/prctl/Makefile +2 -0

index 01dc90fbb509..1a0aefec9d6f 100644
@@ -6,6 +6,8 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
  ifeq ($(ARCH),x86)
  TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \
  		disable-tsc-test set-anon-vma-name-test set-process-name
+
+CFLAGS += $(KHDR_INCLUDES)
  all: $(TEST_PROGS)
 
  include ../lib.mk

tools/testing/selftests/proc/Makefile +1 -1

index cd95369254c0..9596014c10a0 100644
@@ -1,6 +1,6 @@
  # SPDX-License-Identifier: GPL-2.0-only
  CFLAGS += -Wall -O2 -Wno-unused-function
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
  LDFLAGS += -pthread
 
  TEST_GEN_PROGS :=

tools/testing/selftests/riscv/mm/Makefile +1 -1

index c333263f2b27..715a21241113 100644
@@ -3,7 +3,7 @@
  # Originally tools/testing/arm64/abi/Makefile
 
  # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
  TEST_GEN_FILES := mmap_default mmap_bottomup
 

tools/testing/selftests/rtc/Makefile +1 -1

index 55198ecc04db..654f9d58da3c 100644
@@ -1,5 +1,5 @@
  # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -O3 -Wl,-no-as-needed -Wall
+CFLAGS += -O3 -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
  LDLIBS += -lrt -lpthread -lm
 
  TEST_GEN_PROGS = rtctest

tools/testing/selftests/tmpfs/Makefile +1 -1

index aa11ccc92e5b..bcdc1bb6d2e6 100644
@@ -1,6 +1,6 @@
  # SPDX-License-Identifier: GPL-2.0-only
  CFLAGS += -Wall -O2
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
  TEST_GEN_PROGS :=
  TEST_GEN_PROGS += bug-link-o-tmpfile

Quoted 5 lines · Edward Liaw

Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE).

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Signed-off-by Edward Liaw <[email protected]>

Quoted 13 lines

---
  tools/testing/selftests/alsa/Makefile                  | 2 +-
  tools/testing/selftests/arm64/signal/Makefile          | 2 +-
  tools/testing/selftests/exec/Makefile                  | 2 +-
  tools/testing/selftests/filesystems/overlayfs/Makefile | 2 +-
  tools/testing/selftests/hid/Makefile                   | 2 +-
  tools/testing/selftests/nci/Makefile                   | 2 +-
  tools/testing/selftests/prctl/Makefile                 | 2 ++
  tools/testing/selftests/proc/Makefile                  | 2 +-
  tools/testing/selftests/riscv/mm/Makefile              | 2 +-
  tools/testing/selftests/rtc/Makefile                   | 2 +-
  tools/testing/selftests/tmpfs/Makefile                 | 2 +-
  11 files changed, 12 insertions(+), 10 deletions(-)

Hi Edward,

Seeing as how these all include lib.mk, and all use CFLAGS, is there any reason not to simply fix this in lib.mk instead? Like this:

tools/testing/selftests/lib.mk +0 -0

index 7fa4a96e26ed..df72610e0d2b 100644

thanks,
--
John Hubbard
NVIDIA

Quoted 137 lines

tools/testing/selftests/alsa/Makefile +1 -1

index 5af9ba8a4645..9a0ef194522c 100644
@@ -6,7 +6,7 @@ LDLIBS += $(shell pkg-config --libs alsa)
  ifeq ($(LDLIBS),)
  LDLIBS += -lasound
  endif
-CFLAGS += -L$(OUTPUT) -Wl,-rpath=./
+CFLAGS += $(KHDR_INCLUDES) -L$(OUTPUT) -Wl,-rpath=./
 
  LDLIBS+=-lpthread
 

tools/testing/selftests/arm64/signal/Makefile +1 -1

index 8f5febaf1a9a..ae682ade615d 100644
@@ -2,7 +2,7 @@
  # Copyright (C) 2019 ARM Limited
 
  # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
  SRCS := $(filter-out testcases/testcases.c,$(wildcard testcases/*.c))
  PROGS := $(patsubst %.c,%,$(SRCS))

tools/testing/selftests/exec/Makefile +1 -1

index fb4472ddffd8..15e78ec7c55e 100644
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
  CFLAGS = -Wall
  CFLAGS += -Wno-nonnull
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
  TEST_PROGS := binfmt_script.py
  TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular

tools/testing/selftests/filesystems/overlayfs/Makefile +1 -1

index 56b2b48a765b..6c29c963c7a8 100644
@@ -2,6 +2,6 @@
 
  TEST_GEN_PROGS := dev_in_maps
 
-CFLAGS := -Wall -Werror
+CFLAGS := -Wall -Werror $(KHDR_INCLUDES)
 
  include ../../lib.mk

tools/testing/selftests/hid/Makefile +1 -1

index 2b5ea18bde38..0661b34488ef 100644
@@ -21,7 +21,7 @@ CXX ?= $(CROSS_COMPILE)g++
 
  HOSTPKG_CONFIG := pkg-config
 
-CFLAGS += -g -O0 -rdynamic -Wall -Werror -I$(OUTPUT)
+CFLAGS += -g -O0 -rdynamic -Wall -Werror $(KHDR_INCLUDES) -I$(OUTPUT)
  CFLAGS += -I$(OUTPUT)/tools/include
 
  LDLIBS += -lelf -lz -lrt -lpthread

tools/testing/selftests/nci/Makefile +1 -1

index 47669a1d6a59..bbc5b8ec3b17 100644
@@ -1,5 +1,5 @@
  # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wl,-no-as-needed -Wall
+CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
  LDFLAGS += -lpthread
 
  TEST_GEN_PROGS := nci_dev

tools/testing/selftests/prctl/Makefile +2 -0

index 01dc90fbb509..1a0aefec9d6f 100644
@@ -6,6 +6,8 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
  ifeq ($(ARCH),x86)
  TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \
              disable-tsc-test set-anon-vma-name-test set-process-name
+
+CFLAGS += $(KHDR_INCLUDES)
  all: $(TEST_PROGS)
 
  include ../lib.mk

tools/testing/selftests/proc/Makefile +1 -1

index cd95369254c0..9596014c10a0 100644
@@ -1,6 +1,6 @@
  # SPDX-License-Identifier: GPL-2.0-only
  CFLAGS += -Wall -O2 -Wno-unused-function
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
  LDFLAGS += -pthread
 
  TEST_GEN_PROGS :=

tools/testing/selftests/riscv/mm/Makefile +1 -1

index c333263f2b27..715a21241113 100644
@@ -3,7 +3,7 @@
  # Originally tools/testing/arm64/abi/Makefile
 
  # Additional include paths needed by kselftest.h and local headers
-CFLAGS += -D_GNU_SOURCE -std=gnu99 -I.
+CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I.
 
  TEST_GEN_FILES := mmap_default mmap_bottomup
 

tools/testing/selftests/rtc/Makefile +1 -1

index 55198ecc04db..654f9d58da3c 100644
@@ -1,5 +1,5 @@
  # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -O3 -Wl,-no-as-needed -Wall
+CFLAGS += -O3 -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
  LDLIBS += -lrt -lpthread -lm
 
  TEST_GEN_PROGS = rtctest

tools/testing/selftests/tmpfs/Makefile +1 -1

index aa11ccc92e5b..bcdc1bb6d2e6 100644
@@ -1,6 +1,6 @@
  # SPDX-License-Identifier: GPL-2.0-only
  CFLAGS += -Wall -O2
-CFLAGS += -D_GNU_SOURCE
+CFLAGS += $(KHDR_INCLUDES)
 
  TEST_GEN_PROGS :=
  TEST_GEN_PROGS += bug-link-o-tmpfile

Quoted 1 line · On Wed, May 8, 2024 at 2:41?PM John Hubbard <[email protected]> wrote:

On 5/7/24 2:38 PM, Edward Liaw wrote:

Quoted 11 lines

Seeing as how these all include lib.mk, and all use CFLAGS, is there any reason not to simply fix this in lib.mk instead? Like this:

tools/testing/selftests/lib.mk +0 -0

index 7fa4a96e26ed..df72610e0d2b 100644
@@ -170,6 +170,8 @@ clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir)
   CFLAGS += $(USERCFLAGS)
   LDFLAGS += $(USERLDFLAGS)
 

tools/testing/selftests/lib.mk clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir) · line 177

Quoted 6 lines

tools/testing/selftests/lib.mk +2 -0

+CFLAGS += $(KHDR_INCLUDES)
+
   # When make O= with kselftest target from main level
   # the following aren't defined.
   #

Or how about just adding -D_GNU_SOURCE to CFLAGS then?

 tools/testing/selftests/arm64/signal/Makefile          | 2 +-

_GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to prevent _GNU_SOURCE redefined warnings.

Fixes 809216233555 ("selftests/harness: remove use of LINE_MAX")

Signed-off-by Edward Liaw <[email protected]>

---
 tools/testing/selftests/cachestat/test_cachestat.c            | 2 --
 tools/testing/selftests/capabilities/test_execve.c            | 2 --
 tools/testing/selftests/clone3/clone3.c                       | 2 --
 .../testing/selftests/clone3/clone3_cap_checkpoint_restore.c  | 2 --
 tools/testing/selftests/clone3/clone3_clear_sighand.c         | 2 --
 tools/testing/selftests/clone3/clone3_selftests.h             | 1 -
 tools/testing/selftests/clone3/clone3_set_tid.c               | 2 --
 tools/testing/selftests/core/close_range_test.c               | 2 --
 tools/testing/selftests/drivers/dma-buf/udmabuf.c             | 1 -
 tools/testing/selftests/fchmodat2/fchmodat2_test.c            | 2 --
 tools/testing/selftests/filesystems/binderfs/binderfs_test.c  | 2 --
 tools/testing/selftests/filesystems/devpts_pts.c              | 1 -
 tools/testing/selftests/filesystems/dnotify_test.c            | 1 -
 tools/testing/selftests/filesystems/epoll/epoll_wakeup_test.c | 2 --
 tools/testing/selftests/filesystems/eventfd/eventfd_test.c    | 2 --
 tools/testing/selftests/filesystems/fat/rename_exchange.c     | 2 --
 tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c   | 2 --
 .../testing/selftests/filesystems/statmount/statmount_test.c  | 3 ---
 tools/testing/selftests/futex/functional/futex_requeue_pi.c   | 3 ---
 tools/testing/selftests/ipc/msgque.c                          | 1 -
 tools/testing/selftests/kcmp/kcmp_test.c                      | 2 --
 tools/testing/selftests/kvm/aarch64/arch_timer.c              | 2 --
 tools/testing/selftests/kvm/aarch64/page_fault_test.c         | 1 -
 tools/testing/selftests/kvm/aarch64/psci_test.c               | 3 ---
 tools/testing/selftests/kvm/aarch64/vgic_init.c               | 1 -
 tools/testing/selftests/kvm/arch_timer.c                      | 3 ---
 tools/testing/selftests/kvm/demand_paging_test.c              | 3 ---
 tools/testing/selftests/kvm/dirty_log_test.c                  | 3 ---
 tools/testing/selftests/kvm/guest_memfd_test.c                | 2 --
 tools/testing/selftests/kvm/hardware_disable_test.c           | 3 ---
 tools/testing/selftests/kvm/include/userfaultfd_util.h        | 3 ---
 tools/testing/selftests/kvm/kvm_binary_stats_test.c           | 2 --
 tools/testing/selftests/kvm/kvm_create_max_vcpus.c            | 2 --
 tools/testing/selftests/kvm/kvm_page_table_test.c             | 3 ---
 tools/testing/selftests/kvm/lib/assert.c                      | 3 ---
 tools/testing/selftests/kvm/lib/kvm_util.c                    | 2 --
 tools/testing/selftests/kvm/lib/memstress.c                   | 2 --
 tools/testing/selftests/kvm/lib/test_util.c                   | 2 --
 tools/testing/selftests/kvm/lib/userfaultfd_util.c            | 3 ---
 tools/testing/selftests/kvm/lib/x86_64/sev.c                  | 1 -
 tools/testing/selftests/kvm/max_guest_memory_test.c           | 2 --
 .../testing/selftests/kvm/memslot_modification_stress_test.c  | 3 ---
 tools/testing/selftests/kvm/riscv/arch_timer.c                | 3 ---
 tools/testing/selftests/kvm/rseq_test.c                       | 1 -
 tools/testing/selftests/kvm/s390x/cmma_test.c                 | 2 --
 tools/testing/selftests/kvm/s390x/sync_regs_test.c            | 2 --
 tools/testing/selftests/kvm/set_memory_region_test.c          | 1 -
 tools/testing/selftests/kvm/steal_time.c                      | 1 -
 tools/testing/selftests/kvm/x86_64/amx_test.c                 | 2 --
 .../selftests/kvm/x86_64/exit_on_emulation_failure_test.c     | 3 ---
 tools/testing/selftests/kvm/x86_64/hwcr_msr_test.c            | 2 --
 tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c             | 2 --
 tools/testing/selftests/kvm/x86_64/hyperv_evmcs.c             | 1 -
 tools/testing/selftests/kvm/x86_64/hyperv_ipi.c               | 2 --
 tools/testing/selftests/kvm/x86_64/hyperv_svm_test.c          | 1 -
 tools/testing/selftests/kvm/x86_64/hyperv_tlb_flush.c         | 2 --
 tools/testing/selftests/kvm/x86_64/nested_exceptions_test.c   | 2 --
 tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c       | 3 ---
 tools/testing/selftests/kvm/x86_64/platform_info_test.c       | 2 --
 tools/testing/selftests/kvm/x86_64/pmu_counters_test.c        | 2 --
 tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c    | 3 ---
 .../selftests/kvm/x86_64/private_mem_conversions_test.c       | 1 -
 tools/testing/selftests/kvm/x86_64/set_boot_cpu_id.c          | 1 -
 tools/testing/selftests/kvm/x86_64/set_sregs_test.c           | 1 -
 .../selftests/kvm/x86_64/smaller_maxphyaddr_emulation_test.c  | 3 ---
 tools/testing/selftests/kvm/x86_64/smm_test.c                 | 1 -
 tools/testing/selftests/kvm/x86_64/state_test.c               | 1 -
 tools/testing/selftests/kvm/x86_64/sync_regs_test.c           | 2 --
 tools/testing/selftests/kvm/x86_64/ucna_injection_test.c      | 2 --
 tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c  | 2 --
 tools/testing/selftests/kvm/x86_64/vmx_dirty_log_test.c       | 3 ---
 tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c        | 1 -
 .../testing/selftests/kvm/x86_64/vmx_preemption_timer_test.c  | 1 -
 tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c           | 2 --
 tools/testing/selftests/kvm/x86_64/xapic_state_test.c         | 1 -
 tools/testing/selftests/kvm/x86_64/xss_msr_test.c             | 2 --
 tools/testing/selftests/landlock/base_test.c                  | 2 --
 tools/testing/selftests/landlock/fs_test.c                    | 2 --
 tools/testing/selftests/landlock/net_test.c                   | 2 --
 tools/testing/selftests/landlock/ptrace_test.c                | 2 --
 tools/testing/selftests/lsm/common.c                          | 2 --
 tools/testing/selftests/lsm/lsm_get_self_attr_test.c          | 2 --
 tools/testing/selftests/lsm/lsm_list_modules_test.c           | 2 --
 tools/testing/selftests/lsm/lsm_set_self_attr_test.c          | 2 --
 tools/testing/selftests/membarrier/membarrier_test_impl.h     | 1 -
 .../selftests/membarrier/membarrier_test_multi_thread.c       | 1 -
 .../selftests/membarrier/membarrier_test_single_thread.c      | 1 -
 tools/testing/selftests/memfd/common.c                        | 1 -
 tools/testing/selftests/memfd/fuse_test.c                     | 2 --
 tools/testing/selftests/memfd/memfd_test.c                    | 1 -
 tools/testing/selftests/mm/cow.c                              | 1 -
 tools/testing/selftests/mm/gup_longterm.c                     | 1 -
 tools/testing/selftests/mm/hugepage-mmap.c                    | 1 -
 tools/testing/selftests/mm/hugepage-mremap.c                  | 2 --
 tools/testing/selftests/mm/hugetlb-madvise.c                  | 2 --
 tools/testing/selftests/mm/hugetlb-read-hwpoison.c            | 2 --
 tools/testing/selftests/mm/khugepaged.c                       | 1 -
 tools/testing/selftests/mm/ksm_functional_tests.c             | 1 -
 tools/testing/selftests/mm/madv_populate.c                    | 1 -
 tools/testing/selftests/mm/map_populate.c                     | 2 --
 tools/testing/selftests/mm/mdwe_test.c                        | 1 -
 tools/testing/selftests/mm/memfd_secret.c                     | 2 --
 tools/testing/selftests/mm/mlock2-tests.c                     | 1 -
 tools/testing/selftests/mm/mrelease_test.c                    | 1 -
 tools/testing/selftests/mm/mremap_dontunmap.c                 | 1 -
 tools/testing/selftests/mm/mremap_test.c                      | 2 --
 tools/testing/selftests/mm/pagemap_ioctl.c                    | 1 -
 tools/testing/selftests/mm/pkey-helpers.h                     | 1 -
 tools/testing/selftests/mm/protection_keys.c                  | 1 -
 tools/testing/selftests/mm/split_huge_page_test.c             | 2 --
 tools/testing/selftests/mm/thuge-gen.c                        | 2 --
 tools/testing/selftests/mm/uffd-common.h                      | 1 -
 tools/testing/selftests/mount_setattr/mount_setattr_test.c    | 1 -
 .../move_mount_set_group/move_mount_set_group_test.c          | 1 -
 tools/testing/selftests/net/af_unix/diag_uid.c                | 2 --
 tools/testing/selftests/net/af_unix/scm_pidfd.c               | 1 -
 tools/testing/selftests/net/af_unix/unix_connect.c            | 2 --
 tools/testing/selftests/net/csum.c                            | 3 ---
 tools/testing/selftests/net/gro.c                             | 3 ---
 tools/testing/selftests/net/ip_defrag.c                       | 3 ---
 tools/testing/selftests/net/ipsec.c                           | 3 ---
 tools/testing/selftests/net/ipv6_flowlabel.c                  | 3 ---
 tools/testing/selftests/net/ipv6_flowlabel_mgr.c              | 3 ---
 tools/testing/selftests/net/mptcp/mptcp_connect.c             | 3 ---
 tools/testing/selftests/net/mptcp/mptcp_inq.c                 | 3 ---
 tools/testing/selftests/net/mptcp/mptcp_sockopt.c             | 3 ---
 tools/testing/selftests/net/msg_zerocopy.c                    | 3 ---
 tools/testing/selftests/net/nettest.c                         | 2 --
 tools/testing/selftests/net/psock_fanout.c                    | 3 ---
 tools/testing/selftests/net/psock_snd.c                       | 3 ---
 tools/testing/selftests/net/reuseport_addr_any.c              | 3 ---
 tools/testing/selftests/net/reuseport_bpf_cpu.c               | 3 ---
 tools/testing/selftests/net/reuseport_bpf_numa.c              | 3 ---
 tools/testing/selftests/net/reuseport_dualstack.c             | 3 ---
 tools/testing/selftests/net/so_incoming_cpu.c                 | 1 -
 tools/testing/selftests/net/so_netns_cookie.c                 | 1 -
 tools/testing/selftests/net/so_txtime.c                       | 3 ---
 tools/testing/selftests/net/tap.c                             | 3 ---
 tools/testing/selftests/net/tcp_fastopen_backup_key.c         | 1 -
 tools/testing/selftests/net/tcp_inq.c                         | 2 --
 tools/testing/selftests/net/tcp_mmap.c                        | 1 -
 tools/testing/selftests/net/tls.c                             | 3 ---
 tools/testing/selftests/net/toeplitz.c                        | 3 ---
 tools/testing/selftests/net/tun.c                             | 3 ---
 tools/testing/selftests/net/txring_overwrite.c                | 3 ---
 tools/testing/selftests/net/txtimestamp.c                     | 3 ---
 tools/testing/selftests/net/udpgso.c                          | 3 ---
 tools/testing/selftests/net/udpgso_bench_rx.c                 | 3 ---
 tools/testing/selftests/net/udpgso_bench_tx.c                 | 3 ---
 tools/testing/selftests/perf_events/remove_on_exec.c          | 2 --
 tools/testing/selftests/perf_events/sigtrap_threads.c         | 2 --
 tools/testing/selftests/pid_namespace/regression_enomem.c     | 1 -
 tools/testing/selftests/pidfd/pidfd.h                         | 1 -
 tools/testing/selftests/pidfd/pidfd_fdinfo_test.c             | 2 --
 tools/testing/selftests/pidfd/pidfd_getfd_test.c              | 2 --
 tools/testing/selftests/pidfd/pidfd_open_test.c               | 2 --
 tools/testing/selftests/pidfd/pidfd_poll_test.c               | 2 --
 tools/testing/selftests/pidfd/pidfd_setns_test.c              | 2 --
 tools/testing/selftests/pidfd/pidfd_test.c                    | 2 --
 tools/testing/selftests/pidfd/pidfd_wait.c                    | 2 --
 tools/testing/selftests/ptrace/get_set_sud.c                  | 1 -
 tools/testing/selftests/ptrace/peeksiginfo.c                  | 1 -
 tools/testing/selftests/rseq/basic_percpu_ops_test.c          | 1 -
 tools/testing/selftests/rseq/basic_test.c                     | 2 --
 tools/testing/selftests/rseq/param_test.c                     | 1 -
 tools/testing/selftests/rseq/rseq.c                           | 2 --
 tools/testing/selftests/seccomp/seccomp_benchmark.c           | 1 -
 tools/testing/selftests/seccomp/seccomp_bpf.c                 | 2 --
 tools/testing/selftests/user_events/abi_test.c                | 2 --
 tools/testing/selftests/x86/amx.c                             | 2 --
 tools/testing/selftests/x86/check_initial_reg_state.c         | 3 ---
 tools/testing/selftests/x86/corrupt_xstate_header.c           | 3 ---
 tools/testing/selftests/x86/entry_from_vm86.c                 | 3 ---
 tools/testing/selftests/x86/fsgsbase.c                        | 2 --
 tools/testing/selftests/x86/fsgsbase_restore.c                | 2 --
 tools/testing/selftests/x86/ioperm.c                          | 2 --
 tools/testing/selftests/x86/iopl.c                            | 2 --
 tools/testing/selftests/x86/lam.c                             | 1 -
 tools/testing/selftests/x86/ldt_gdt.c                         | 2 --
 tools/testing/selftests/x86/mov_ss_trap.c                     | 2 --
 tools/testing/selftests/x86/nx_stack.c                        | 2 --
 tools/testing/selftests/x86/ptrace_syscall.c                  | 2 --
 tools/testing/selftests/x86/sigaltstack.c                     | 2 --
 tools/testing/selftests/x86/sigreturn.c                       | 3 ---
 tools/testing/selftests/x86/single_step_syscall.c             | 3 ---
 tools/testing/selftests/x86/syscall_arg_fault.c               | 3 ---
 tools/testing/selftests/x86/syscall_numbering.c               | 3 ---
 tools/testing/selftests/x86/sysret_rip.c                      | 3 ---
 tools/testing/selftests/x86/sysret_ss_attrs.c                 | 3 ---
 tools/testing/selftests/x86/test_FCMOV.c                      | 4 ----
 tools/testing/selftests/x86/test_FCOMI.c                      | 4 ----
 tools/testing/selftests/x86/test_FISTTP.c                     | 4 ----
 tools/testing/selftests/x86/test_mremap_vdso.c                | 1 -
 tools/testing/selftests/x86/test_shadow_stack.c               | 3 ---
 tools/testing/selftests/x86/test_syscall_vdso.c               | 4 ----
 tools/testing/selftests/x86/test_vsyscall.c                   | 3 ---
 tools/testing/selftests/x86/unwind_vdso.c                     | 3 ---
 tools/testing/selftests/x86/vdso_restorer.c                   | 3 ---
 198 files changed, 405 deletions(-)

tools/testing/selftests/cachestat/test_cachestat.c +0 -2

index b171fd53b004..c1a6ce7b0912 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <stdbool.h>
 #include <linux/kernel.h>

tools/testing/selftests/capabilities/test_execve.c +0 -2

index 7cde07a5df78..e3954b88c3ee 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <cap-ng.h>
 #include <linux/capability.h>
 #include <stdbool.h>

tools/testing/selftests/clone3/clone3.c +0 -2

index 3c9bf0cd82a8..3c5e45dae617 100644
@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 
 /* Based on Christian Brauner's clone3() example */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <inttypes.h>
 #include <linux/types.h>

tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c +0 -2

index 31b56d625655..bb99ea20f7d5 100644
@@ -7,8 +7,6 @@
  */
 
 /* capabilities related code based on selftests/bpf/test_verifier.c */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <linux/types.h>
 #include <linux/sched.h>

tools/testing/selftests/clone3/clone3_clear_sighand.c +0 -2

index 54a8b2445be9..50336d56db6b 100644
@@ -1,6 +1,4 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <sched.h>
 #include <signal.h>

tools/testing/selftests/clone3/clone3_selftests.h +0 -1

index 3d2663fe50ba..172e19d5515f 100644
@@ -3,7 +3,6 @@
 #ifndef _CLONE3_SELFTESTS_H
 #define _CLONE3_SELFTESTS_H
 
-#define _GNU_SOURCE
 #include <sched.h>
 #include <linux/sched.h>
 #include <linux/types.h>

tools/testing/selftests/clone3/clone3_set_tid.c +0 -2

index ed785afb6077..8b5ed4484ee6 100644
@@ -5,8 +5,6 @@
  * These tests are assuming to be running in the host's
  * PID namespace.
  */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <linux/types.h>
 #include <linux/sched.h>

tools/testing/selftests/core/close_range_test.c +0 -2

index c59e4adb905d..1c2902bcc913 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/kernel.h>

tools/testing/selftests/drivers/dma-buf/udmabuf.c +0 -1

index c812080e304e..7c8dbab8ac44 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #define __EXPORTED_HEADERS__
 
 #include <stdio.h>

tools/testing/selftests/fchmodat2/fchmodat2_test.c +0 -2

index e0319417124d..6b411859c2cd 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-
-#define _GNU_SOURCE
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <sys/types.h>

tools/testing/selftests/filesystems/binderfs/binderfs_test.c +0 -2

index 5f362c0fd890..fca693db1b09 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <pthread.h>

tools/testing/selftests/filesystems/devpts_pts.c +0 -1

index b1fc9b916ace..73766447eeb0 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <sched.h>

tools/testing/selftests/filesystems/dnotify_test.c +0 -1

index c0a9b2d3302d..05367a70b963 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE	/* needed to get the defines */
 #include <fcntl.h>	/* in glibc 2.2 this has the needed
 				   values defined */
 #include <signal.h>

tools/testing/selftests/filesystems/epoll/epoll_wakeup_test.c +0 -2

index 65ede506305c..9bc2ddad7e92 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <asm/unistd.h>
 #include <linux/time_types.h>
 #include <poll.h>

tools/testing/selftests/filesystems/eventfd/eventfd_test.c +0 -2

index f142a137526c..17935f42fbc9 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <asm/unistd.h>

tools/testing/selftests/filesystems/fat/rename_exchange.c +0 -2

index e488ad354fce..56cf3ad8640d 100644
@@ -6,8 +6,6 @@
  * Copyright 2022 Red Hat Inc.
  * Author: Javier Martinez Canillas <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c +0 -2

index 759f86e7d263..b58a80bde95a 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <inttypes.h>
 #include <unistd.h>
 #include <stdio.h>

tools/testing/selftests/filesystems/statmount/statmount_test.c +0 -3

index 3eafd7da58e2..d1cefd1b7d16 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-
-#define _GNU_SOURCE
-
 #include <assert.h>
 #include <stdint.h>
 #include <sched.h>

tools/testing/selftests/futex/functional/futex_requeue_pi.c +0 -3

index 7f3ca5c78df1..8e41f9fe784c 100644
@@ -16,9 +16,6 @@
  *      2009-Nov-6: futex test adaptation by Darren Hart <[email protected]>
  *
  *****************************************************************************/
-
-#define _GNU_SOURCE
-
 #include <errno.h>
 #include <limits.h>
 #include <pthread.h>

tools/testing/selftests/ipc/msgque.c +0 -1

index 656c43c24044..291c81d59a9d 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>

tools/testing/selftests/kcmp/kcmp_test.c +0 -2

index 25110c7c0b3e..885c9e943cee 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <signal.h>

tools/testing/selftests/kvm/aarch64/arch_timer.c +0 -2

index 4eaba83cdcf3..5369959e9fc2 100644
@@ -5,8 +5,6 @@
  *
  * Copyright (c) 2021, Google LLC.
  */
-#define _GNU_SOURCE
-
 #include "arch_timer.h"
 #include "delay.h"
 #include "gic.h"

tools/testing/selftests/kvm/aarch64/page_fault_test.c +0 -1

index 5972905275cf..79e99f47a9fe 100644
@@ -7,7 +7,6 @@
  * hugetlbfs with a hole). It checks that the expected handling method is
  * called (e.g., uffd faults with the right address and write/read flag).
  */
-#define _GNU_SOURCE
 #include <linux/bitmap.h>
 #include <fcntl.h>
 #include <test_util.h>

tools/testing/selftests/kvm/aarch64/psci_test.c +0 -3

index 9b004905d1d3..1c8c6f0c1ca3 100644
@@ -10,9 +10,6 @@
  *  - A test for KVM's handling of PSCI SYSTEM_SUSPEND and the associated
  *    KVM_SYSTEM_EVENT_SUSPEND UAPI.
  */
-
-#define _GNU_SOURCE
-
 #include <linux/psci.h>
 
 #include "kvm_util.h"

tools/testing/selftests/kvm/aarch64/vgic_init.c +0 -1

index ca917c71ff60..b3b5fb0ff0a9 100644
@@ -4,7 +4,6 @@
  *
  * Copyright (C) 2020, Red Hat, Inc.
  */
-#define _GNU_SOURCE
 #include <linux/kernel.h>
 #include <sys/syscall.h>
 #include <asm/kvm.h>

tools/testing/selftests/kvm/arch_timer.c +0 -3

index ae1f1a6d8312..fcebd8d81ce4 100644
@@ -19,9 +19,6 @@
  *
  * Copyright (c) 2021, Google LLC.
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <pthread.h>
 #include <linux/sizes.h>

tools/testing/selftests/kvm/demand_paging_test.c +0 -3

index bf3609f71854..0c4d3b6afbf8 100644
@@ -6,9 +6,6 @@
  * Copyright (C) 2018, Red Hat, Inc.
  * Copyright (C) 2019, Google, Inc.
  */
-
-#define _GNU_SOURCE /* for pipe2 */
-
 #include <inttypes.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/dirty_log_test.c +0 -3

index eaad5b20854c..bf1ebc29f22a 100644
@@ -4,9 +4,6 @@
  *
  * Copyright (C) 2018, Red Hat, Inc.
  */
-
-#define _GNU_SOURCE /* for program_invocation_name */
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <pthread.h>

tools/testing/selftests/kvm/guest_memfd_test.c +0 -2

index 92eae206baa6..309fe84b84ad 100644
@@ -4,8 +4,6 @@
  *
  * Author: Chao Peng <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>

tools/testing/selftests/kvm/hardware_disable_test.c +0 -3

index decc521fc760..bce73bcb973c 100644
@@ -4,9 +4,6 @@
  * kvm_arch_hardware_disable is called and it attempts to unregister the user
  * return notifiers.
  */
-
-#define _GNU_SOURCE
-
 #include <fcntl.h>
 #include <pthread.h>
 #include <semaphore.h>

tools/testing/selftests/kvm/include/userfaultfd_util.h +0 -3

index 877449c34592..a9d97c213584 100644
@@ -5,9 +5,6 @@
  * Copyright (C) 2018, Red Hat, Inc.
  * Copyright (C) 2019-2022 Google LLC
  */
-
-#define _GNU_SOURCE /* for pipe2 */
-
 #include <inttypes.h>
 #include <time.h>
 #include <pthread.h>

tools/testing/selftests/kvm/kvm_binary_stats_test.c +0 -2

index 698c1cfa3111..f02355c3c4c2 100644
@@ -6,8 +6,6 @@
  *
  * Test the fd-based interface for KVM statistics.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/kvm_create_max_vcpus.c +0 -2

index b9e23265e4b3..c78f34699f73 100644
@@ -6,8 +6,6 @@
  *
  * Test for KVM_CAP_MAX_VCPUS and KVM_CAP_MAX_VCPU_ID.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/kvm_page_table_test.c +0 -3

index e0ba97ac1c56..7759c685086b 100644
@@ -8,9 +8,6 @@
  * page size have been pre-allocated on your system, if you are planning to
  * use hugepages to back the guest memory for testing.
  */
-
-#define _GNU_SOURCE /* for program_invocation_name */
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <time.h>

tools/testing/selftests/kvm/lib/assert.c +0 -3

index 2bd25b191d15..b49690658c60 100644
@@ -4,9 +4,6 @@
  *
  * Copyright (C) 2018, Google LLC.
  */
-
-#define _GNU_SOURCE /* for getline(3) and strchrnul(3)*/
-
 #include "test_util.h"
 
 #include <execinfo.h>

tools/testing/selftests/kvm/lib/kvm_util.c +0 -2

index b2262b5fad9e..1eaf001d0ad4 100644
@@ -4,8 +4,6 @@
  *
  * Copyright (C) 2018, Google LLC.
  */
-
-#define _GNU_SOURCE /* for program_invocation_name */
 #include "test_util.h"
 #include "kvm_util.h"
 #include "processor.h"

tools/testing/selftests/kvm/lib/memstress.c +0 -2

index cf2c73971308..555e3932e529 100644
@@ -2,8 +2,6 @@
 /*
  * Copyright (C) 2020, Google LLC.
  */
-#define _GNU_SOURCE
-
 #include <inttypes.h>
 #include <linux/bitmap.h>
 

tools/testing/selftests/kvm/lib/test_util.c +0 -2

index 5a8f8becb129..8ed0b74ae837 100644
@@ -4,8 +4,6 @@
  *
  * Copyright (C) 2020, Google LLC.
  */
-
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdarg.h>
 #include <assert.h>

tools/testing/selftests/kvm/lib/userfaultfd_util.c +0 -3

index f4eef6eb2dc2..bd07568a5240 100644
@@ -6,9 +6,6 @@
  * Copyright (C) 2018, Red Hat, Inc.
  * Copyright (C) 2019-2022 Google LLC
  */
-
-#define _GNU_SOURCE /* for pipe2 */
-
 #include <inttypes.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/lib/x86_64/sev.c +0 -1

index e248d3364b9c..e83809febae1 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <stdint.h>
 #include <stdbool.h>
 

tools/testing/selftests/kvm/max_guest_memory_test.c +0 -2

index 1a6da7389bf1..0b9678858b6d 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <pthread.h>

tools/testing/selftests/kvm/memslot_modification_stress_test.c +0 -3

index 156361966612..05fcf902e067 100644
@@ -6,9 +6,6 @@
  * Copyright (C) 2018, Red Hat, Inc.
  * Copyright (C) 2020, Google, Inc.
  */
-
-#define _GNU_SOURCE /* for program_invocation_name */
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/syscall.h>

tools/testing/selftests/kvm/riscv/arch_timer.c +0 -3

index 0f9cabd99fd4..4b5004ef9c6b 100644
@@ -7,9 +7,6 @@
  *
  * Copyright (c) 2024, Intel Corporation.
  */
-
-#define _GNU_SOURCE
-
 #include "arch_timer.h"
 #include "kvm_util.h"
 #include "processor.h"

tools/testing/selftests/kvm/rseq_test.c +0 -1

index 28f97fb52044..b3536400f9ac 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <errno.h>
 #include <fcntl.h>
 #include <pthread.h>

tools/testing/selftests/kvm/s390x/cmma_test.c +0 -2

index 626a2b8a2037..84ba79c42ab1 100644
@@ -7,8 +7,6 @@
  * Authors:
  *  Nico Boehr <[email protected]>
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/s390x/sync_regs_test.c +0 -2

index 43fb25ddc3ec..53def355ccba 100644
@@ -10,8 +10,6 @@
  *
  * Test expected behavior of the KVM_CAP_SYNC_REGS functionality.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/set_memory_region_test.c +0 -1

index bd57d991e27d..214ff84f6fdb 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <pthread.h>
 #include <sched.h>

tools/testing/selftests/kvm/steal_time.c +0 -1

index bae0c5026f82..e9231387c589 100644
@@ -4,7 +4,6 @@
  *
  * Copyright (C) 2020, Red Hat, Inc.
  */
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <time.h>
 #include <sched.h>

tools/testing/selftests/kvm/x86_64/amx_test.c +0 -2

index eae521f050e0..8e5713e36d4b 100644
@@ -6,8 +6,6 @@
  *
  * Tests for amx #NM exception and save/restore.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/exit_on_emulation_failure_test.c +0 -3

index 6c2e5e0ceb1f..9c21b6bccc38 100644
@@ -4,9 +4,6 @@
  *
  * Test for KVM_CAP_EXIT_ON_EMULATION_FAILURE.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
-
 #include "flds_emulation.h"
 
 #include "test_util.h"

tools/testing/selftests/kvm/x86_64/hwcr_msr_test.c +0 -2

index df351ae17029..10b1b0ba374e 100644
@@ -2,8 +2,6 @@
 /*
  * Copyright (C) 2023, Google LLC.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <sys/ioctl.h>
 
 #include "test_util.h"

tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c +0 -2

index 5c27efbf405e..4f5881d4ef66 100644
@@ -7,8 +7,6 @@
  * This work is licensed under the terms of the GNU GPL, version 2.
  *
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/hyperv_evmcs.c +0 -1

index 4c7257ecd2a6..4f3f3a9b038b 100644
@@ -4,7 +4,6 @@
  *
  * Tests for Enlightened VMCS, including nested guest state.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/hyperv_ipi.c +0 -2

index f1617762c22f..8206f5ef42dd 100644
@@ -5,8 +5,6 @@
  * Copyright (C) 2022, Red Hat, Inc.
  *
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <pthread.h>
 #include <inttypes.h>
 

tools/testing/selftests/kvm/x86_64/hyperv_svm_test.c +0 -1

index c9b18707edc0..b987a3d79715 100644
@@ -4,7 +4,6 @@
  *
  * Tests for Hyper-V extensions to SVM.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/hyperv_tlb_flush.c +0 -2

index 05b56095cf76..077cd0ec3040 100644
@@ -5,8 +5,6 @@
  * Copyright (C) 2022, Red Hat, Inc.
  *
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <asm/barrier.h>
 #include <pthread.h>
 #include <inttypes.h>

tools/testing/selftests/kvm/x86_64/nested_exceptions_test.c +0 -2

index 3670331adf21..3eb0313ffa39 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-#define _GNU_SOURCE /* for program_invocation_short_name */
-
 #include "test_util.h"
 #include "kvm_util.h"
 #include "processor.h"

tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c +0 -3

index 17bbb96fc4df..e7efb2b35f8b 100644
@@ -5,9 +5,6 @@
  *
  * Copyright (C) 2022, Google LLC.
  */
-
-#define _GNU_SOURCE
-
 #include <fcntl.h>
 #include <stdint.h>
 #include <time.h>

tools/testing/selftests/kvm/x86_64/platform_info_test.c +0 -2

index 87011965dc41..2165b1ad8b38 100644
@@ -9,8 +9,6 @@
  * Verifies expected behavior of controlling guest access to
  * MSR_PLATFORM_INFO.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/pmu_counters_test.c +0 -2

index 26c85815f7e9..77f14138594e 100644
@@ -2,8 +2,6 @@
 /*
  * Copyright (C) 2023, Tencent, Inc.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <x86intrin.h>
 
 #include "pmu.h"

tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c +0 -3

index 3c85d1ae9893..5ce53b8c46e0 100644
@@ -9,9 +9,6 @@
  * Verifies the expected behavior of allow lists and deny lists for
  * virtual PMU events.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
-
 #include "kvm_util.h"
 #include "pmu.h"
 #include "processor.h"

tools/testing/selftests/kvm/x86_64/private_mem_conversions_test.c +0 -1

index e0f642d2a3c4..82a8d88b5338 100644
@@ -2,7 +2,6 @@
 /*
  * Copyright (C) 2022, Google LLC.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <limits.h>
 #include <pthread.h>

tools/testing/selftests/kvm/x86_64/set_boot_cpu_id.c +0 -1

index 366cf18600bc..d691d86e5bc3 100644
@@ -4,7 +4,6 @@
  *
  * Copyright (C) 2020, Red Hat, Inc.
  */
-#define _GNU_SOURCE /* for program_invocation_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/set_sregs_test.c +0 -1

index 3610981d9162..c021c0795a96 100644
@@ -10,7 +10,6 @@
  * That bug allowed a user-mode program that called the KVM_SET_SREGS
  * ioctl to put a VCPU's local APIC into an invalid state.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/smaller_maxphyaddr_emulation_test.c +0 -3

index 416207c38a17..362be40fc00d 100644
@@ -5,9 +5,6 @@
  * Test that KVM emulates instructions in response to EPT violations when
  * allow_smaller_maxphyaddr is enabled and guest.MAXPHYADDR < host.MAXPHYADDR.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
-
 #include "flds_emulation.h"
 
 #include "test_util.h"

tools/testing/selftests/kvm/x86_64/smm_test.c +0 -1

index e18b86666e1f..55c88d664a94 100644
@@ -4,7 +4,6 @@
  *
  * Tests for SMM.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/state_test.c +0 -1

index 88b58aab7207..1c756db329e5 100644
@@ -6,7 +6,6 @@
  *
  * Tests for vCPU state save/restore, including nested guest state.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/sync_regs_test.c +0 -2

index adb5593daf48..8fa3948b0170 100644
@@ -8,8 +8,6 @@
  * including requesting an invalid register set, updates to/from values
  * in kvm_run.s.regs when kvm_valid_regs and kvm_dirty_regs are toggled.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/ucna_injection_test.c +0 -2

index dcbb3c29fb8e..abe71946941f 100644
@@ -17,8 +17,6 @@
  * delivered into the guest or not.
  *
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <pthread.h>
 #include <inttypes.h>
 #include <string.h>

tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c +0 -2

index f4f61a2d2464..53afbea4df88 100644
@@ -4,8 +4,6 @@
  *
  * Tests for exiting into userspace on registered MSRs
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <sys/ioctl.h>
 
 #include "kvm_test_harness.h"

tools/testing/selftests/kvm/x86_64/vmx_dirty_log_test.c +0 -3

index 977948fd52e6..fa512d033205 100644
@@ -4,9 +4,6 @@
  *
  * Copyright (C) 2018, Red Hat, Inc.
  */
-
-#define _GNU_SOURCE /* for program_invocation_name */
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <linux/bitmap.h>

tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c +0 -1

index ea0cb3cae0f7..3b93f262b797 100644
@@ -10,7 +10,6 @@
  * and check it can be retrieved with KVM_GET_MSR, also test
  * the invalid LBR formats are rejected.
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <sys/ioctl.h>
 
 #include <linux/bitmap.h>

tools/testing/selftests/kvm/x86_64/vmx_preemption_timer_test.c +0 -1

index affc32800158..00dd2ac07a61 100644
@@ -9,7 +9,6 @@
  * value instead of partially decayed timer value
  *
  */
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c +0 -2

index 725c206ba0b9..c78e5f755116 100644
@@ -19,8 +19,6 @@
  * Migration is a command line option. When used on non-numa machines will 
  * exit with error. Test is still usefull on non-numa for testing IPIs.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <getopt.h>
 #include <pthread.h>
 #include <inttypes.h>

tools/testing/selftests/kvm/x86_64/xapic_state_test.c +0 -1

index ab75b873a4ad..69849acd95b0 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>

tools/testing/selftests/kvm/x86_64/xss_msr_test.c +0 -2

index 167c97abff1b..f331a4e9bae3 100644
@@ -4,8 +4,6 @@
  *
  * Tests for the IA32_XSS MSR.
  */
-
-#define _GNU_SOURCE /* for program_invocation_short_name */
 #include <sys/ioctl.h>
 
 #include "test_util.h"

tools/testing/selftests/landlock/base_test.c +0 -2

index a6f89aaea77d..bdb3955a9452 100644
@@ -5,8 +5,6 @@
  * Copyright ? 2017-2020 Micka?l Sala?n <[email protected]>
  * Copyright ? 2019-2020 ANSSI
  */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/landlock.h>

tools/testing/selftests/landlock/fs_test.c +0 -2

index 9a6036fbf289..acec1c82c8b4 100644
@@ -6,8 +6,6 @@
  * Copyright ? 2020 ANSSI
  * Copyright ? 2020-2022 Microsoft Corporation
  */
-
-#define _GNU_SOURCE
 #include <fcntl.h>
 #include <linux/landlock.h>
 #include <linux/magic.h>

tools/testing/selftests/landlock/net_test.c +0 -2

index f21cfbbc3638..eed040adcbac 100644
@@ -5,8 +5,6 @@
  * Copyright ? 2022-2023 Huawei Tech. Co., Ltd.
  * Copyright ? 2023 Microsoft Corporation
  */
-
-#define _GNU_SOURCE
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/landlock/ptrace_test.c +0 -2

index a19db4d0b3bd..c831e6d03b02 100644
@@ -5,8 +5,6 @@
  * Copyright ? 2017-2020 Micka?l Sala?n <[email protected]>
  * Copyright ? 2019-2020 ANSSI
  */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/landlock.h>

tools/testing/selftests/lsm/common.c +0 -2

index 9ad258912646..1b18aac570f1 100644
@@ -4,8 +4,6 @@
  *
  * Copyright ? 2023 Casey Schaufler <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <fcntl.h>
 #include <string.h>

tools/testing/selftests/lsm/lsm_get_self_attr_test.c +0 -2

index df215e4aa63f..7465bde3f922 100644
@@ -5,8 +5,6 @@
  *
  * Copyright ? 2022 Casey Schaufler <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <fcntl.h>
 #include <string.h>

tools/testing/selftests/lsm/lsm_list_modules_test.c +0 -2

index 06d24d4679a6..a6b44e25c21f 100644
@@ -5,8 +5,6 @@
  *
  * Copyright ? 2022 Casey Schaufler <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <string.h>
 #include <stdio.h>

tools/testing/selftests/lsm/lsm_set_self_attr_test.c +0 -2

index 66dec47e3ca3..110c6a07e74c 100644
@@ -5,8 +5,6 @@
  *
  * Copyright ? 2022 Casey Schaufler <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <string.h>
 #include <stdio.h>

tools/testing/selftests/membarrier/membarrier_test_impl.h +0 -1

index af89855adb7b..a8a60b6271a5 100644
@@ -1,5 +1,4 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-#define _GNU_SOURCE
 #include <linux/membarrier.h>
 #include <syscall.h>
 #include <stdio.h>

tools/testing/selftests/membarrier/membarrier_test_multi_thread.c +0 -1

index a9cc17facfb3..b4651e2ade00 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <linux/membarrier.h>
 #include <syscall.h>
 #include <stdio.h>

tools/testing/selftests/membarrier/membarrier_test_single_thread.c +0 -1

index 4cdc8b1d124c..17ae5199b916 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <linux/membarrier.h>
 #include <syscall.h>
 #include <stdio.h>

tools/testing/selftests/memfd/common.c +0 -1

index 8eb3d75f6e60..879d4f4c66fa 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #define __EXPORTED_HEADERS__
 
 #include <stdio.h>

tools/testing/selftests/memfd/fuse_test.c +0 -2

index 93798c8c5d54..15bc189bf831 100644
@@ -12,8 +12,6 @@
  * the read() syscall with our memory-mapped memfd object as receive buffer to
  * force the kernel to write into our memfd object.
  */
-
-#define _GNU_SOURCE
 #define __EXPORTED_HEADERS__
 
 #include <errno.h>

tools/testing/selftests/memfd/memfd_test.c +0 -1

index 18f585684e20..5172c27a8748 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #define __EXPORTED_HEADERS__
 
 #include <errno.h>

tools/testing/selftests/mm/cow.c +0 -1

index 363bf5f801be..6f1a36d51f19 100644
@@ -6,7 +6,6 @@
  *
  * Author(s): David Hildenbrand <[email protected]>
  */
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>

tools/testing/selftests/mm/gup_longterm.c +0 -1

index ad168d35b23b..3bfd5a630081 100644
@@ -6,7 +6,6 @@
  *
  * Author(s): David Hildenbrand <[email protected]>
  */
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>

tools/testing/selftests/mm/hugepage-mmap.c +0 -1

index 267eea2e0e0b..edb46888222f 100644
@@ -16,7 +16,6 @@
  * range.
  * Other architectures, such as ppc64, i386 or x86_64 are not so constrained.
  */
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <unistd.h>

tools/testing/selftests/mm/hugepage-mremap.c +0 -2

index c463d1c09c9b..8e22822bb754 100644
@@ -11,8 +11,6 @@
  * To make sure the test triggers pmd sharing and goes through the 'unshare'
  * path in the mremap code use 1GB (1024) or more.
  */
-
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <unistd.h>

tools/testing/selftests/mm/hugetlb-madvise.c +0 -2

index e74107185324..70c40c67bc5d 100644
@@ -11,8 +11,6 @@
  * filesystem.  Therefore, a hugetlbfs filesystem must be mounted on some
  * directory.
  */
-
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <unistd.h>

tools/testing/selftests/mm/hugetlb-read-hwpoison.c +0 -2

index ba6cc6f9cabc..6b8b41b4f754 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>

tools/testing/selftests/mm/khugepaged.c +0 -1

index 829320a519e7..d18bf400dae6 100644
@@ -1,4 +1,3 @@
-#define _GNU_SOURCE
 #include <ctype.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/mm/ksm_functional_tests.c +0 -1

index d615767e396b..1deae905c42e 100644
@@ -6,7 +6,6 @@
  *
  * Author(s): David Hildenbrand <[email protected]>
  */
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>

tools/testing/selftests/mm/madv_populate.c +0 -1

index 17bcb07f19f3..d19ad13ffd7e 100644
@@ -6,7 +6,6 @@
  *
  * Author(s): David Hildenbrand <[email protected]>
  */
-#define _GNU_SOURCE
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>

tools/testing/selftests/mm/map_populate.c +0 -2

index 5c8a53869b1b..ff4d4079bd0e 100644
@@ -4,8 +4,6 @@
  *
  * MAP_POPULATE | MAP_PRIVATE should COW VMA pages.
  */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/mman.h>

tools/testing/selftests/mm/mdwe_test.c +0 -1

index 1e01d3ddc11c..200bedcdc32e 100644
@@ -7,7 +7,6 @@
 #include <linux/mman.h>
 #include <linux/prctl.h>
 
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/auxv.h>

tools/testing/selftests/mm/memfd_secret.c +0 -2

index 9b298f6a04b3..750adede2816 100644
@@ -4,8 +4,6 @@
  *
  * Author: Mike Rapoport <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <sys/uio.h>
 #include <sys/mman.h>
 #include <sys/wait.h>

tools/testing/selftests/mm/mlock2-tests.c +0 -1

index 26f744188ad0..42574290d728 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <sys/mman.h>
 #include <stdint.h>
 #include <unistd.h>

tools/testing/selftests/mm/mrelease_test.c +0 -1

index 100370a7111d..d78bf686e99f 100644
@@ -2,7 +2,6 @@
 /*
  * Copyright 2022 Google LLC
  */
-#define _GNU_SOURCE
 #include <errno.h>
 #include <stdbool.h>
 #include <stdio.h>

tools/testing/selftests/mm/mremap_dontunmap.c +0 -1

index 1d75084b9ca5..934fa6b441b2 100644
@@ -5,7 +5,6 @@
  *
  * Copyright 2020, Brian Geffon <[email protected]>
  */
-#define _GNU_SOURCE
 #include <sys/mman.h>
 #include <linux/mman.h>
 #include <errno.h>

tools/testing/selftests/mm/mremap_test.c +0 -2

index 2f8b991f78cb..e057154630e0 100644
@@ -2,8 +2,6 @@
 /*
  * Copyright 2020 Google LLC
  */
-#define _GNU_SOURCE
-
 #include <errno.h>
 #include <stdlib.h>
 #include <stdio.h>

tools/testing/selftests/mm/pagemap_ioctl.c +0 -1

index d59517ed3d48..2a18b5d276f0 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <fcntl.h>
 #include <string.h>

tools/testing/selftests/mm/pkey-helpers.h +0 -1

index 1af3156a9db8..37d6b01ce90a 100644
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _PKEYS_HELPER_H
 #define _PKEYS_HELPER_H
-#define _GNU_SOURCE
 #include <string.h>
 #include <stdarg.h>
 #include <stdio.h>

tools/testing/selftests/mm/protection_keys.c +0 -1

index 48dc151f8fca..9f7de92caeda 100644
@@ -21,7 +21,6 @@
  *	gcc -mxsave      -o protection_keys    -O2 -g -std=gnu99 -pthread -Wall protection_keys.c -lrt -ldl -lm
  *	gcc -mxsave -m32 -o protection_keys_32 -O2 -g -std=gnu99 -pthread -Wall protection_keys.c -lrt -ldl -lm
  */
-#define _GNU_SOURCE
 #define __SANE_USERSPACE_TYPES__
 #include <errno.h>
 #include <linux/elf.h>

tools/testing/selftests/mm/split_huge_page_test.c +0 -2

index d3c7f5fb3e7b..ae6ac950d7a1 100644
@@ -3,8 +3,6 @@
  * A test of splitting PMD THPs and PTE-mapped THPs from a specified virtual
  * address range in a process via <debugfs>/split_huge_pages interface.
  */
-
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>

tools/testing/selftests/mm/thuge-gen.c +0 -2

index ea7fd8fe2876..28a5c31bd791 100644
@@ -12,8 +12,6 @@
    ipcrm -m by hand, like this
    sudo ipcs | awk '$1 == "0x00000000" {print $2}' | xargs -n1 sudo ipcrm -m
    (warning this will remove all if someone else uses them) */
-
-#define _GNU_SOURCE 1
 #include <sys/mman.h>
 #include <stdlib.h>
 #include <stdio.h>

tools/testing/selftests/mm/uffd-common.h +0 -1

index cc5629c3d2aa..abb44319264a 100644
@@ -7,7 +7,6 @@
 #ifndef __UFFD_COMMON_H__
 #define __UFFD_COMMON_H__
 
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>

tools/testing/selftests/mount_setattr/mount_setattr_test.c +0 -1

index c6a8c732b802..d894417134b6 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <sched.h>
 #include <stdio.h>
 #include <errno.h>

tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c +0 -1

index bcf51d785a37..bd975670f61d 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <sched.h>
 #include <stdio.h>
 #include <errno.h>

tools/testing/selftests/net/af_unix/diag_uid.c +0 -2

index 79a3dd75590e..279d0c5f70d3 100644
@@ -1,7 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright Amazon.com Inc. or its affiliates. */
-
-#define _GNU_SOURCE
 #include <sched.h>
 
 #include <unistd.h>

tools/testing/selftests/net/af_unix/scm_pidfd.c +0 -1

index 7e534594167e..2986b8cd0418 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0 OR MIT
-#define _GNU_SOURCE
 #include <error.h>
 #include <limits.h>
 #include <stddef.h>

tools/testing/selftests/net/af_unix/unix_connect.c +0 -2

index d799fd8f5c7c..34e816862cc7 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <sched.h>
 
 #include <stddef.h>

tools/testing/selftests/net/csum.c +0 -3

index 90eb06fefa59..8262aa862331 100644
@@ -58,9 +58,6 @@
  * different seed for each run (and logs this for reproducibility). It
  * is advised to enable this for extra coverage in continuous testing.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <asm/byteorder.h>
 #include <errno.h>

tools/testing/selftests/net/gro.c +0 -3

index 353e1e867fbb..f5d7032e6466 100644
@@ -34,9 +34,6 @@
  * flakiness is to be expected.
  *
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/ip_defrag.c +0 -3

index f9ed749fd8c7..80c9e567a3d8 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/ipsec.c +0 -3

index be4a30a0d02a..04aa06d26b09 100644
@@ -3,9 +3,6 @@
  * ipsec.c - Check xfrm on veth inside a net-ns.
  * Copyright (c) 2018 Dmitry Safonov
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <asm/types.h>
 #include <errno.h>

tools/testing/selftests/net/ipv6_flowlabel.c +0 -3

index 708a9822259d..b7e0c3c02e20 100644
@@ -1,8 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Test IPV6_FLOWINFO cmsg on send and recv */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <asm/byteorder.h>
 #include <error.h>

tools/testing/selftests/net/ipv6_flowlabel_mgr.c +0 -3

index af95b48acea9..ebd219ba386e 100644
@@ -1,8 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Test IPV6_FLOWINFO_MGR */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <error.h>
 #include <errno.h>

tools/testing/selftests/net/mptcp/mptcp_connect.c +0 -3

index d2043ec3bf6d..ea93030ed3ec 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <errno.h>
 #include <limits.h>
 #include <fcntl.h>

tools/testing/selftests/net/mptcp/mptcp_inq.c +0 -3

index 218aac467321..c5bf873d76c2 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/net/mptcp/mptcp_sockopt.c +0 -3

index 926b0be87c99..7203ca9900e9 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/net/msg_zerocopy.c +0 -3

index bdc03a2097e8..9278bf585c80 100644
@@ -24,9 +24,6 @@
  * the kernel queues completions on the error queue for all zerocopy
  * transfers.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <error.h>
 #include <errno.h>

tools/testing/selftests/net/nettest.c +0 -2

index cd8a58097448..88e1d3b2ddf1 100644
@@ -3,8 +3,6 @@
  *
  * Copyright (c) 2013-2019 David Ahern <[email protected]>. All rights reserved.
  */
-
-#define _GNU_SOURCE
 #include <features.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>

tools/testing/selftests/net/psock_fanout.c +0 -3

index 1a736f700be4..5b2d34440ae9 100644
@@ -26,9 +26,6 @@
  * Todo:
  * - functionality: PACKET_FANOUT_FLAG_DEFRAG
  */
-
-#define _GNU_SOURCE		/* for sched_setaffinity */
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/net/psock_snd.c +0 -3

index edf1e6f80d41..2f29b513e18f 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/reuseport_addr_any.c +0 -3

index b8475cb29be7..9ee6ece52865 100644
@@ -3,9 +3,6 @@
 /* Test that sockets listening on a specific address are preferred
  * over sockets listening on addr_any.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/reuseport_bpf_cpu.c +0 -3

index 2d646174729f..e93e38cfb2a8 100644
@@ -11,9 +11,6 @@
  * This entire process is done for several different core id permutations
  * and for each IPv4/IPv6 and TCP/UDP combination.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/reuseport_bpf_numa.c +0 -3

index c9ba36aa688e..502fdb9ce770 100644
@@ -3,9 +3,6 @@
  * Test functionality of BPF filters with SO_REUSEPORT. Same test as
  * in reuseport_bpf_cpu, only as one socket per NUMA node.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/reuseport_dualstack.c +0 -3

index fb7a59ed759e..d3c3d3f39f8f 100644
@@ -10,9 +10,6 @@
  * This test creates these mixed AF_INET/AF_INET6 sockets and asserts the
  * AF_INET preference for v4 packets.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/so_incoming_cpu.c +0 -1

index e9fa14e10732..95bd0cdc3253 100644
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright Amazon.com Inc. or its affiliates. */
-#define _GNU_SOURCE
 #include <sched.h>
 
 #include <fcntl.h>

tools/testing/selftests/net/so_netns_cookie.c +0 -1

index b39e87e967cd..18532d564f79 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <sched.h>
 #include <unistd.h>
 #include <stdio.h>

tools/testing/selftests/net/so_txtime.c +0 -3

index 8457b7ccbc09..011a24af9786 100644
@@ -9,9 +9,6 @@
  * the expected stream. Sender will read transmit timestamps from the error
  * queue. The streams can differ due to out-of-order delivery and drops.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <error.h>
 #include <errno.h>

tools/testing/selftests/net/tap.c +0 -3

index 247c3b3ac1c9..fa78b92d9740 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>

tools/testing/selftests/net/tcp_fastopen_backup_key.c +0 -1

index c1cb0c75156a..d30f89bb944c 100644
@@ -12,7 +12,6 @@
  * there are no cases in which a cookie is not accepted by verifying
  * that TcpExtTCPFastOpenPassiveFail remains 0.
  */
-#define _GNU_SOURCE
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/tcp_inq.c +0 -2

index bd6a9c7a3e8a..71ee145f151e 100644
@@ -5,8 +5,6 @@
  *
  * Simple example on how to use TCP_INQ and TCP_CM_INQ.
  */
-#define _GNU_SOURCE
-
 #include <error.h>
 #include <netinet/in.h>
 #include <netinet/tcp.h>

tools/testing/selftests/net/tcp_mmap.c +0 -1

index 4fcce5150850..72d5f1207ee0 100644
@@ -46,7 +46,6 @@
  * received 32768 MB (99.9939 % mmap'ed) in 7.43764 s, 36.9577 Gbit
  *   cpu usage user:0.035 sys:3.467, 106.873 usec per MB, 65530 c-switches
  */
-#define _GNU_SOURCE
 #include <pthread.h>
 #include <sys/types.h>
 #include <fcntl.h>

tools/testing/selftests/net/tls.c +0 -3

index f27a12d2a2c9..6dbad97d1d0a 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/toeplitz.c +0 -3

index 9ba03164d73a..e2d739892ce4 100644
@@ -20,9 +20,6 @@
  * 5. Compute the cpu that RPS should select based on rx_hash and $rps_bitmap
  * 6. Compare the cpus from 4 and 5
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/net/tun.c +0 -3

index fa83918b62d1..a64dcfb242c1 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>

tools/testing/selftests/net/txring_overwrite.c +0 -3

index 7d9ea039450a..96972e0110a0 100644
@@ -4,9 +4,6 @@
  * Verify that consecutive sends over packet tx_ring are mirrored
  * with their original content intact.
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <assert.h>
 #include <error.h>

tools/testing/selftests/net/txtimestamp.c +0 -3

index ec60a16c9307..33dba9e90dea 100644
@@ -16,9 +16,6 @@
  * This test requires a dummy TCP server.
  * A simple `nc6 [-u] -l -p $DESTPORT` will do
  */
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <asm/types.h>
 #include <error.h>

tools/testing/selftests/net/udpgso.c +0 -3

index 85b3baa3f7f3..9dc1026a033a 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <stddef.h>
 #include <arpa/inet.h>
 #include <error.h>

tools/testing/selftests/net/udpgso_bench_rx.c +0 -3

index 1cbadd267c96..999df1236320 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <error.h>
 #include <errno.h>

tools/testing/selftests/net/udpgso_bench_tx.c +0 -3

index 477392715a9a..d7632993b354 100644
@@ -1,7 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
-
 #include <arpa/inet.h>
 #include <errno.h>
 #include <error.h>

tools/testing/selftests/perf_events/remove_on_exec.c +0 -2

index 5814611a1dc7..ef4d923f4759 100644
@@ -5,8 +5,6 @@
  * Copyright (C) 2021, Google LLC.
  */
 
-#define _GNU_SOURCE
-
 /* We need the latest siginfo from the kernel repo. */
 #include <sys/types.h>
 #include <asm/siginfo.h>

tools/testing/selftests/perf_events/sigtrap_threads.c +0 -2

index d1d8483ac628..14d1a3c8cb5c 100644
@@ -5,8 +5,6 @@
  * Copyright (C) 2021, Google LLC.
  */
 
-#define _GNU_SOURCE
-
 /* We need the latest siginfo from the kernel repo. */
 #include <sys/types.h>
 #include <asm/siginfo.h>

tools/testing/selftests/pid_namespace/regression_enomem.c +0 -1

index 7d84097ad45c..54dc8f16d92a 100644
@@ -1,4 +1,3 @@
-#define _GNU_SOURCE
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/pidfd/pidfd.h +0 -1

index 88d6830ee004..e33177b1aa41 100644
@@ -3,7 +3,6 @@
 #ifndef __PIDFD_H
 #define __PIDFD_H
 
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <sched.h>

tools/testing/selftests/pidfd/pidfd_fdinfo_test.c +0 -2

index 01cc37bf611c..67c9dc436c71 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>

tools/testing/selftests/pidfd/pidfd_getfd_test.c +0 -2

index cd51d547b751..b6a0e9b3d2f5 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>

tools/testing/selftests/pidfd/pidfd_open_test.c +0 -2

index 8a59438ccc78..781a3931fb5a 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <inttypes.h>

tools/testing/selftests/pidfd/pidfd_poll_test.c +0 -2

index 610811275357..a40fb27a78bb 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <linux/types.h>
 #include <poll.h>

tools/testing/selftests/pidfd/pidfd_setns_test.c +0 -2

index 6e2f2cd400ca..49d7a78cc4fe 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>

tools/testing/selftests/pidfd/pidfd_test.c +0 -2

index c081ae91313a..c3d52406b8fd 100644
@@ -1,6 +1,4 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/types.h>

tools/testing/selftests/pidfd/pidfd_wait.c +0 -2

index 0dcb8365ddc3..54beba0983f1 100644
@@ -1,6 +1,4 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <linux/sched.h>
 #include <linux/types.h>

tools/testing/selftests/ptrace/get_set_sud.c +0 -1

index 5297b10d25c3..054a78ebe8b5 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include "../kselftest_harness.h"
 #include <stdio.h>
 #include <string.h>

tools/testing/selftests/ptrace/peeksiginfo.c +0 -1

index a6884f66dc01..1b7b77190f72 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <signal.h>
 #include <unistd.h>

tools/testing/selftests/rseq/basic_percpu_ops_test.c +0 -1

index 2348d2c20d0a..5961c24ee1ae 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: LGPL-2.1
-#define _GNU_SOURCE
 #include <assert.h>
 #include <pthread.h>
 #include <sched.h>

tools/testing/selftests/rseq/basic_test.c +0 -2

index 295eea16466f..1fed749b4bd7 100644
@@ -2,8 +2,6 @@
 /*
  * Basic test coverage for critical regions and rseq_current_cpu().
  */
-
-#define _GNU_SOURCE
 #include <assert.h>
 #include <sched.h>
 #include <signal.h>

tools/testing/selftests/rseq/param_test.c +0 -1

index 2f37961240ca..48a55d94eb72 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: LGPL-2.1
-#define _GNU_SOURCE
 #include <assert.h>
 #include <linux/membarrier.h>
 #include <pthread.h>

tools/testing/selftests/rseq/rseq.c +0 -2

index 96e812bdf8a4..88602889414c 100644
@@ -14,8 +14,6 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  * Lesser General Public License for more details.
  */
-
-#define _GNU_SOURCE
 #include <errno.h>
 #include <sched.h>
 #include <stdio.h>

tools/testing/selftests/seccomp/seccomp_benchmark.c +0 -1

index b83099160fbc..3632a4890da9 100644
@@ -2,7 +2,6 @@
  * Strictly speaking, this is not a test. But it can report during test
  * runs so relative performace can be measured.
  */
-#define _GNU_SOURCE
 #include <assert.h>
 #include <err.h>
 #include <limits.h>

tools/testing/selftests/seccomp/seccomp_bpf.c +0 -2

index 783ebce8c4de..972ccc12553e 100644
@@ -4,8 +4,6 @@
  *
  * Test code for seccomp bpf.
  */
-
-#define _GNU_SOURCE
 #include <sys/types.h>
 
 /*

tools/testing/selftests/user_events/abi_test.c +0 -2

index 7288a05136ba..a1f156dbbd56 100644
@@ -4,8 +4,6 @@
  *
  * Copyright (c) 2022 Beau Belgrave <[email protected]>
  */
-
-#define _GNU_SOURCE
 #include <sched.h>
 
 #include <errno.h>

tools/testing/selftests/x86/amx.c +0 -2

index d884fd69dd51..9441635fc452 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-
-#define _GNU_SOURCE
 #include <err.h>
 #include <errno.h>
 #include <pthread.h>

tools/testing/selftests/x86/check_initial_reg_state.c +0 -3

index 3bc95f3ed585..0129cdae8abe 100644
@@ -3,9 +3,6 @@
  * check_initial_reg_state.c - check that execve sets the correct state
  * Copyright (c) 2014-2016 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
-
 #include <stdio.h>
 
 unsigned long ax, bx, cx, dx, si, di, bp, sp, flags;

tools/testing/selftests/x86/corrupt_xstate_header.c +0 -3

index cf9ce8fbb656..d2c746149678 100644
@@ -4,9 +4,6 @@
  *
  * Based on analysis and a test case from Thomas Gleixner.
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>

tools/testing/selftests/x86/entry_from_vm86.c +0 -3

index d1e919b0c1dc..9fa9d4a847ac 100644
@@ -5,9 +5,6 @@
  *
  * This exercises a few paths that need to special-case vm86 mode.
  */
-
-#define _GNU_SOURCE
-
 #include <assert.h>
 #include <stdlib.h>
 #include <sys/syscall.h>

tools/testing/selftests/x86/fsgsbase.c +0 -2

index 8c780cce941d..348134d2cefc 100644
@@ -3,8 +3,6 @@
  * fsgsbase.c, an fsgsbase test
  * Copyright (c) 2014-2016 Andy Lutomirski
  */
-
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdbool.h>

tools/testing/selftests/x86/fsgsbase_restore.c +0 -2

index 6fffadc51579..88dce47ab8e6 100644
@@ -12,8 +12,6 @@
  *
  * This is not part of fsgsbase.c, because that test is 64-bit only.
  */
-
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdbool.h>

tools/testing/selftests/x86/ioperm.c +0 -2

index 57ec5e99edb9..07b7c10f8d39 100644
@@ -3,8 +3,6 @@
  * ioperm.c - Test case for ioperm(2)
  * Copyright (c) 2015 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
 #include <err.h>
 #include <stdio.h>
 #include <stdint.h>

tools/testing/selftests/x86/iopl.c +0 -2

index 7e3e09c1abac..baa691154905 100644
@@ -3,8 +3,6 @@
  * iopl.c - Test case for a Linux on Xen 64-bit bug
  * Copyright (c) 2015 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
 #include <err.h>
 #include <stdio.h>
 #include <stdint.h>

tools/testing/selftests/x86/lam.c +0 -1

index 215b8150b7cc..39edfd7f6037 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

tools/testing/selftests/x86/ldt_gdt.c +0 -2

index 3a29346e1452..3b4237a85a12 100644
@@ -3,8 +3,6 @@
  * ldt_gdt.c - Test cases for LDT and GDT access
  * Copyright (c) 2015 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
 #include <err.h>
 #include <stdio.h>
 #include <stdint.h>

tools/testing/selftests/x86/mov_ss_trap.c +0 -2

index cc3de6ff9fba..47ecc63220b7 100644
@@ -19,8 +19,6 @@
  *
  * This should mostly cover CVE-2018-1087 and CVE-2018-8897.
  */
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <sys/ptrace.h>
 #include <sys/types.h>

tools/testing/selftests/x86/nx_stack.c +0 -2

index ea4a4e246879..97c5b34096cc 100644
@@ -23,8 +23,6 @@
  * Regular stack is completely overwritten before testing.
  * Test doesn't exit SIGSEGV handler after first fault at INT3.
  */
-#undef _GNU_SOURCE
-#define _GNU_SOURCE
 #undef NDEBUG
 #include <assert.h>
 #include <signal.h>

tools/testing/selftests/x86/ptrace_syscall.c +0 -2

index 12aaa063196e..bdc81c8bd1a7 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
-
 #include <sys/ptrace.h>
 #include <sys/types.h>
 #include <sys/wait.h>

tools/testing/selftests/x86/sigaltstack.c +0 -2

index f689af75e979..7f41c3a4268b 100644
@@ -1,6 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-
-#define _GNU_SOURCE
 #include <signal.h>
 #include <stdio.h>
 #include <stdbool.h>

tools/testing/selftests/x86/sigreturn.c +0 -3

index 5d7961a5f7f6..2054f729b2c2 100644
@@ -24,9 +24,6 @@
  *
  * Do not run on outdated, unpatched kernels at risk of nasty crashes.
  */
-
-#define _GNU_SOURCE
-
 #include <sys/time.h>
 #include <time.h>
 #include <stdlib.h>

tools/testing/selftests/x86/single_step_syscall.c +0 -3

index 9a30f443e928..375f3b50a0b5 100644
@@ -9,9 +9,6 @@
  * immediately issues #DB from CPL 0.  This requires special handling in
  * the kernel.
  */
-
-#define _GNU_SOURCE
-
 #include <sys/time.h>
 #include <time.h>
 #include <stdlib.h>

tools/testing/selftests/x86/syscall_arg_fault.c +0 -3

index 461fa41a4d02..10eee1bcd015 100644
@@ -3,9 +3,6 @@
  * syscall_arg_fault.c - tests faults 32-bit fast syscall stack args
  * Copyright (c) 2015 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>

tools/testing/selftests/x86/syscall_numbering.c +0 -3

index 991591718bb0..c72fc8aaa4d3 100644
@@ -5,9 +5,6 @@
  *
  * Copyright (c) 2018 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <stdio.h>
 #include <stdbool.h>

tools/testing/selftests/x86/sysret_rip.c +0 -3

index 84d74be1d902..24bc219358a5 100644
@@ -3,9 +3,6 @@
  * sigreturn.c - tests that x86 avoids Intel SYSRET pitfalls
  * Copyright (c) 2014-2016 Andrew Lutomirski
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>

tools/testing/selftests/x86/sysret_ss_attrs.c +0 -3

index 5f3d4fca440f..f8b9e0b2a0c5 100644
@@ -7,9 +7,6 @@
  * the hidden attributes set to an unusable state.  Make sure the kernel
  * doesn't let this happen.
  */
-
-#define _GNU_SOURCE
-
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>

tools/testing/selftests/x86/test_FCMOV.c +0 -4

index 6b5036fbb735..0c9431ba7d31 100644
@@ -1,8 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#undef _GNU_SOURCE
-#define _GNU_SOURCE 1
-#undef __USE_GNU
-#define __USE_GNU 1
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>

tools/testing/selftests/x86/test_FCOMI.c +0 -4

index aec6692c6dcf..ba186665918d 100644
@@ -1,8 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#undef _GNU_SOURCE
-#define _GNU_SOURCE 1
-#undef __USE_GNU
-#define __USE_GNU 1
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>

tools/testing/selftests/x86/test_FISTTP.c +0 -4

index 09789c0ce3e9..95580cdaaa32 100644
@@ -1,8 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0
-#undef _GNU_SOURCE
-#define _GNU_SOURCE 1
-#undef __USE_GNU
-#define __USE_GNU 1
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>

tools/testing/selftests/x86/test_mremap_vdso.c +0 -1

index f0d876d48277..a8bdba356682 100644
@@ -9,7 +9,6 @@
  * Can be built statically:
  * gcc -Os -Wall -static -m32 test_mremap_vdso.c
  */
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>

tools/testing/selftests/x86/test_shadow_stack.c +0 -3

index 757e6527f67e..0ceca9064cec 100644
@@ -7,9 +7,6 @@
  * special glibc shadow stack support (longjmp(), swapcontext(), etc). Just
  * stick to the basics and hope the compiler doesn't do anything strange.
  */
-
-#define _GNU_SOURCE
-
 #include <sys/syscall.h>
 #include <asm/mman.h>
 #include <sys/mman.h>

tools/testing/selftests/x86/test_syscall_vdso.c +0 -4

index 8965c311bd65..5cd13279bba5 100644
@@ -8,10 +8,6 @@
  * Can be built statically:
  * gcc -Os -Wall -static -m32 test_syscall_vdso.c thunks_32.S
  */
-#undef _GNU_SOURCE
-#define _GNU_SOURCE 1
-#undef __USE_GNU
-#define __USE_GNU 1
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>

tools/testing/selftests/x86/test_vsyscall.c +0 -3

index 47cab972807c..cbf4e5012005 100644
@@ -1,7 +1,4 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <sys/time.h>
 #include <time.h>

tools/testing/selftests/x86/unwind_vdso.c +0 -3

index 4c311e1af4c7..754f5d4d425a 100644
@@ -5,9 +5,6 @@
  *
  * This tests __kernel_vsyscall's unwind info.
  */
-
-#define _GNU_SOURCE
-
 #include <features.h>
 #include <stdio.h>
 

tools/testing/selftests/x86/vdso_restorer.c +0 -3

index fe99f2434155..8193de22a390 100644
@@ -10,9 +10,6 @@
  * 64-bit userspace has never supported sa_restorer == NULL, so this is
  * 32-bit only.
  */
-
-#define _GNU_SOURCE
-
 #include <err.h>
 #include <stdio.h>
 #include <dlfcn.h>