Add support for Imagis IST3038 and clarify the usage of protocol_b
Subsystems (4)
v2 cover Add support for Imagis IST3038 and clarify the usage of protocol_b
Imagis IST3038 is another variant of Imagis IST3038 IC, which has a different register interface from IST3038C (possibly firmware defined).
Unlike IST3038C/IST3032C, IST3038 has different registers for commands, which means IST3038 doesn't use protocol B.
Similar to IST3032C and maybe the other variants, IST3038 has touch keys support, which provides KEY_APPSELECT and KEY_BACK.
Add support for IST3038 with touch keys.
protocol_b is a property, which tells Imagis panel to use a different format for coordinates.
IST30XXC series is known for using protocol B, while the other series aren't. Note this could be confusing, unlike the model name implies.
Adjust the usage of protocol_b to avoid confusion.
---
v2: Sort the compatible enties in alphabetical order.
Document the binding before using in the driver.
PATCH v2 1/3 input/touchscreen: imagis: Clarify the usage of protocol_b
protocol_b is a property, which tells Imagis panel to use a different format for coordinates.
IST30XXC series is known for using protocol B, while the other series aren't. Note this could be confusing, unlike the model name implies.
Adjust the usage of protocol_b to avoid confusion.
--- drivers/input/touchscreen/imagis.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/input/touchscreen/imagis.c +5 -4
@@ -120,12 +120,12 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id)for (i =0 ; i < finger_count; i++) {if (ts->tdata->protocol_b) - error =imagis_i2c_read_reg (ts, - ts->tdata->touch_coord_cmd, &finger_status); -else error =imagis_i2c_read_reg (ts, ts->tdata->touch_coord_cmd + (i *4 ), &finger_status); +else + error =imagis_i2c_read_reg (ts, + ts->tdata->touch_coord_cmd, &finger_status);if (error) { dev_err(&ts->client->dev, "failed to read coordinates for finger %d: %d\n",
@@ -394,6 +394,7 @@ static const struct imagis_properties imagis_3032c_data = { .whoami_cmd = IST3038C_REG_CHIPID, .whoami_val = IST3032C_WHOAMI, .touch_keys_supported = true, + .protocol_b = true, };static const struct imagis_properties imagis_3038b_data = {
@@ -401,7 +402,6 @@ static const struct imagis_properties imagis_3038b_data = { .touch_coord_cmd = IST3038B_REG_STATUS, .whoami_cmd = IST3038B_REG_CHIPID, .whoami_val = IST3038B_WHOAMI, - .protocol_b = true, };static const struct imagis_properties imagis_3038c_data = {
@@ -409,6 +409,7 @@ static const struct imagis_properties imagis_3038c_data = { .touch_coord_cmd = IST3038C_REG_TOUCH_COORD, .whoami_cmd = IST3038C_REG_CHIPID, .whoami_val = IST3038C_WHOAMI, + .protocol_b = true, };#ifdef CONFIG_OF
Signature · 1 line
2.39.2
PATCH v2 2/3 dt-bindings: input/touchscreen: imagis: Document ist3038
In reply to Raymond HackleyImagis IST3038 is a variant of Imagis touchscreen IC. Document it in imagis,ist3038c bindings.
--- .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml +1 -0
@@ -16,6 +16,7 @@ properties: compatible: enum: - imagis,ist3032c + - imagis,ist3038 - imagis,ist3038b - imagis,ist3038c
Signature · 1 line
2.39.2
Re: [PATCH v2 2/3] dt-bindings: input/touchscreen: imagis: Document ist3038
Quoted 8 lines · Raymond Hackley
Imagis IST3038 is a variant of Imagis touchscreen IC. Document it in imagis,ist3038c bindings.
Signed-off-by Raymond Hackley <[email protected]>--- .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
PATCH v2 3/3 input/touchscreen: imagis: Add supports for Imagis IST3038
In reply to Raymond HackleyImagis IST3038 is another variant of Imagis IST3038 IC, which has a different register interface from IST3038C (possibly firmware defined).
Unlike IST3038C/IST3032C, IST3038 has different registers for commands, which means IST3038 doesn't use protocol B.
Similar to IST3032C and maybe the other variants, IST3038 has touch keys support, which provides KEY_APPSELECT and KEY_BACK.
Add support for IST3038 with touch keys.
--- drivers/input/touchscreen/imagis.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)
drivers/input/touchscreen/imagis.c +20 -4
@@ -12,9 +12,17 @@#include <linux/property.h> #include <linux/regulator/consumer.h> +#define IST30XX_REG_STATUS 0x20 +#define IST30XX_REG_CHIPID (0x40000000 | IST3038C_DIRECT_ACCESS) + +#define IST30XX_WHOAMI 0x30003000 +#define IST30XXA_WHOAMI 0x300a300a +#define IST30XXB_WHOAMI 0x300b300b +#define IST3038_WHOAMI 0x30383038 +#define IST3032C_WHOAMI 0x32c +#define IST3038C_WHOAMI 0x38c -#define IST3038B_REG_STATUS 0x20#define IST3038B_REG_CHIPID 0x30#define IST3038B_WHOAMI 0x30380b
@@ -25,7 +33,6 @@#define IST3038C_REG_TOUCH_STATUS (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS)#define IST3038C_REG_TOUCH_COORD (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x8)#define IST3038C_REG_INTR_MESSAGE (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x4) -#define IST3038C_WHOAMI 0x38c#define IST3038C_CHIP_ON_DELAY_MS 60#define IST3038C_I2C_RETRY_COUNT 3#define IST3038C_MAX_FINGER_NUM 10
@@ -397,9 +404,17 @@ static const struct imagis_properties imagis_3032c_data = { .protocol_b = true, }; +static const struct imagis_properties imagis_3038_data = { + .interrupt_msg_cmd =IST30XX_REG_STATUS , + .touch_coord_cmd =IST30XX_REG_STATUS , + .whoami_cmd =IST30XX_REG_CHIPID , + .whoami_val =IST3038_WHOAMI , + .touch_keys_supported = true, +}; +static const struct imagis_properties imagis_3038b_data = { - .interrupt_msg_cmd =IST3038B_REG_STATUS , - .touch_coord_cmd =IST3038B_REG_STATUS , + .interrupt_msg_cmd =IST30XX_REG_STATUS , + .touch_coord_cmd =IST30XX_REG_STATUS , .whoami_cmd =IST3038B_REG_CHIPID , .whoami_val =IST3038B_WHOAMI , };
@@ -415,6 +430,7 @@ static const struct imagis_properties imagis_3038c_data = {#ifdef CONFIG_OF static const struct of_device_id imagis_of_match[] = { { .compatible ="imagis,ist3032c" , .data = &imagis_3032c_data }, + { .compatible ="imagis,ist3038" , .data = &imagis_3038_data }, { .compatible ="imagis,ist3038b" , .data = &imagis_3038b_data }, { .compatible ="imagis,ist3038c" , .data = &imagis_3038c_data }, { },
Signature · 1 line
2.39.2
Dmitry Torokhov
maintainerQuoted 13 lines · Raymond Hackley
Imagis IST3038 is another variant of Imagis IST3038 IC, which has a different register interface from IST3038C (possibly firmware defined).
Unlike IST3038C/IST3032C, IST3038 has different registers for commands, which means IST3038 doesn't use protocol B.
Similar to IST3032C and maybe the other variants, IST3038 has touch keys support, which providesKEY_APPSELECTandKEY_BACK.Add support for IST3038 with touch keys.
protocol_bis a property, which tells Imagis panel to use a different format for coordinates.
Quoted 9 lines
IST30XXC series is known for using protocol B, while the other series aren't. Note this could be confusing, unlike the model name implies.
Adjust the usage of
protocol_bto avoid confusion.---
v2: Sort the compatible enties in alphabetical order.
Document the binding before using in the driver.
Applied the lot, thank you.
Signature · 1 line
Dmitry