LPSS PWM cleanups
Subsystems (2)
v2 cover LPSS PWM cleanups
This series implements minor cleanups for LPSS PWM driver.
Changes since v1:
- Update commit message
Raag Jadav (2):
pwm: lpss: use devm_pm_runtime_enable() helper
pwm: lpss: drop redundant runtime PM handles
drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- drivers/pwm/pwm-lpss-platform.c | 10 +--------- 2 files changed, 1 insertion(+), 31 deletions(-)
Signature · 1 line
2.35.3
PATCH v2 1/2 pwm: lpss: use devm_pm_runtime_enable() helper
Use devm_pm_runtime_enable() helper to enable runtime PM and drop redundant platform ->remove() callback.
--- drivers/pwm/pwm-lpss-platform.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/pwm/pwm-lpss-platform.c +1 -9
@@ -55,14 +55,7 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev) DPM_FLAG_SMART_SUSPEND);pm_runtime_set_active (&pdev->dev); -pm_runtime_enable (&pdev->dev); - -return 0 ; -} - -static void pwm_lpss_remove_platform (struct platform_device *pdev) -{ -pm_runtime_disable (&pdev->dev); +return devm_pm_runtime_enable (&pdev->dev); }static const struct acpi_device_id pwm_lpss_acpi_match[] = {
@@ -80,7 +73,6 @@ static struct platform_driver pwm_lpss_driver_platform = { .acpi_match_table = pwm_lpss_acpi_match, }, .probe = pwm_lpss_probe_platform, - .remove_new = pwm_lpss_remove_platform, };module_platform_driver (pwm_lpss_driver_platform);
Signature · 1 line
2.35.3
PATCH v2 2/2 pwm: lpss: drop redundant runtime PM handles
In reply to Raag JadavWe no longer need empty runtime PM handles for PCI devices after commits [1] and [2]. Drop them and let PCI core take care of power state transitions.
[1] c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions")
[2] fa885b06ec7e ("PCI/PM: Allow runtime PM with no PM callbacks at all")
--- drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- 1 file changed, 22 deletions(-)
drivers/pwm/pwm-lpss-pci.c +0 -22
@@ -46,25 +46,6 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)pm_runtime_get_sync (&pdev->dev); } -static int pwm_lpss_runtime_suspend_pci (struct device *dev) -{ -/* -* The PCI core will handle transition to D3 automatically. We only -* need to provide runtime PM hooks for that to happen. -*/ -return 0 ; -} - -static int pwm_lpss_runtime_resume_pci (struct device *dev) -{ -return 0 ; -} - -static DEFINE_RUNTIME_DEV_PM_OPS(pwm_lpss_pci_pm, - pwm_lpss_runtime_suspend_pci, - pwm_lpss_runtime_resume_pci, - NULL); -static const struct pci_device_id pwm_lpss_pci_ids[] = { {PCI_VDEVICE (INTEL ,0x0ac8 ), (unsigned long )&pwm_lpss_bxt_info}, {PCI_VDEVICE (INTEL ,0x0f08 ), (unsigned long )&pwm_lpss_byt_info},
@@ -84,9 +65,6 @@ static struct pci_driver pwm_lpss_driver_pci = { .id_table = pwm_lpss_pci_ids, .probe = pwm_lpss_probe_pci, .remove = pwm_lpss_remove_pci, - .driver = { - .pm = pm_ptr(&pwm_lpss_pci_pm), - }, };module_pci_driver (pwm_lpss_driver_pci);
Signature · 1 line
2.35.3
Quoted 4 lines · Raag Jadav
This series implements minor cleanups for LPSS PWM driver.
Changes since v1:
- Update commit message
Bump.
Anything I can do to move this forward?
Raag
Hello Raag,
Quoted 9 lines · Raag Jadav
Quoted 4 lines · Raag Jadav
This series implements minor cleanups for LPSS PWM driver.
Changes since v1:
- Update commit messageBump.
Anything I can do to move this forward?
Sorry for being a strain on your patience, I'm way behind my patch review duties. I applied your patch now, just swapping your S-o-b and Andy's R-b in the commit log to have your tag last.
Best regards
Uwe
Andy Shevchenko
reviewerQuoted 2 lines · Uwe Kleine-König
Quoted 1 line · Raag Jadav
On Wed, Jun 05, 2024 at 06:45:31PM +0530, Raag Jadav wrote:
...
Quoted 2 lines
just swapping your S-o-b and Andy's R-b in the commit log to have your tag last.
It's not required by the documentation as Rb != SoB.
Signature · 2 lines
With Best Regards, Andy Shevchenko