mm: delete the unused put_pages_list()
Subsystems (2)
PATCH 1/1 mm: delete the unused put_pages_list()
The last user of put_pages_list() converted away from it in 6.10 commit 06c375053cef ("iommu/vt-d: add wrapper functions for page allocations"):
delete put_pages_list().
--- include/linux/mm.h | 2 -- mm/swap.c | 31 ------------------------------- 2 files changed, 33 deletions(-)
include/linux/mm.h +0 -2
@@ -1286,8 +1286,6 @@ static inline struct folio *virt_to_folio(const void *x)void __folio_put (struct folio *folio); -void put_pages_list (struct list_head *pages); -void split_page (struct page *page,unsigned int order);void folio_copy (struct folio *dst,struct folio *src);int folio_mc_copy (struct folio *dst,struct folio *src);
mm/swap.c +0 -31
@@ -127,37 +127,6 @@ void __folio_put(struct folio *folio) }EXPORT_SYMBOL (__folio_put); -/** -* put_pages_list() - release a list of pages -* @pages: list of pages threaded on page->lru -* -* Release a list of pages which are strung together on page.lru. -*/ -void put_pages_list (struct list_head *pages) -{ -struct folio_batch fbatch; -struct folio *folio, *next; - -folio_batch_init (&fbatch); -list_for_each_entry_safe (folio, next, pages, lru) { -if (!folio_put_testzero (folio)) -continue ; -if (folio_test_hugetlb (folio)) { -free_huge_folio (folio); -continue ; - } -/* LRU flag must be clear because it's passed using the lru */ -if (folio_batch_add (&fbatch, folio) >0 ) -continue ; -free_unref_folios (&fbatch); - } - -if (fbatch.nr) -free_unref_folios (&fbatch); -INIT_LIST_HEAD (pages); -} -EXPORT_SYMBOL (put_pages_list); -typedef void (*move_fn_t )(struct lruvec *lruvec,struct folio *folio);static void lru_add (struct lruvec *lruvec,struct folio *folio)
Signature · 1 line
2.35.3
Quoted 5 lines · Hugh Dickins
The last user of
put_pages_list()converted away from it in 6.10 commit06c375053cef("iommu/vt-d: add wrapper functions for page allocations"):
deleteput_pages_list().Signed-off-by Hugh Dickins <[email protected]>
Signature · 1 line
Peter Xu
Quoted 3 lines · Hugh Dickins
The last user of
put_pages_list()converted away from it in 6.10 commit06c375053cef("iommu/vt-d: add wrapper functions for page allocations"):
deleteput_pages_list().
In that commit we now manually iterate over the list and call put_page() on each entry ... I would suspect that to perform worse ;)
In any case, the function surely is unused now.
Signature · 3 lines
Cheers, David / dhildenb
Quoted 6 lines · Hugh Dickins
The last user of
put_pages_list()converted away from it in 6.10 commit06c375053cef("iommu/vt-d: add wrapper functions for page allocations"):
deleteput_pages_list().Signed-off-by Hugh Dickins <[email protected]>
Quoted 62 lines
--- include/linux/mm.h | 2 -- mm/swap.c | 31 ------------------------------- 2 files changed, 33 deletions(-)include/linux/mm.h +0
-2@@ -1286,8 +1286,6 @@ static inline struct folio *virt_to_folio(const void *x)void __folio_put (struct folio *folio); -void put_pages_list (struct list_head *pages); -void split_page (struct page *page,unsigned int order);void folio_copy (struct folio *dst,struct folio *src);int folio_mc_copy (struct folio *dst,struct folio *src);mm/swap.c +0
-32@@ -127,37 +127,6 @@ void __folio_put(struct folio *folio) }EXPORT_SYMBOL (__folio_put); -/** -* put_pages_list() - release a list of pages -* @pages: list of pages threaded on page->lru -* -* Release a list of pages which are strung together on page.lru. -*/ -void put_pages_list (struct list_head *pages) -{ -struct folio_batch fbatch; -struct folio *folio, *next; - -folio_batch_init (&fbatch); -list_for_each_entry_safe (folio, next, pages, lru) { -if (!folio_put_testzero (folio)) -continue ; -if (folio_test_hugetlb (folio)) { -free_huge_folio (folio); -continue ; - } -/* LRU flag must be clear because it's passed using the lru */ -if (folio_batch_add (&fbatch, folio) >0 ) -continue ; -free_unref_folios (&fbatch); - } - -if (fbatch.nr) -free_unref_folios (&fbatch); -INIT_LIST_HEAD (pages); -} -EXPORT_SYMBOL (put_pages_list); -typedef void (*move_fn_t )(struct lruvec *lruvec,struct folio *folio);static void lru_add (struct lruvec *lruvec,struct folio *folio) --2.35.3