Skip to contentSkip to conversation

mm: delete the unused put_pages_list()

PATCH Applied Hugh Dickins 4 participants 4 messages Oct 27, 2024 – Oct 28, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: delete the unused put_pages_list()

The last user of put_pages_list() converted away from it in 6.10 commit 06c375053cef ("iommu/vt-d: add wrapper functions for page allocations"):
delete put_pages_list().

---
 include/linux/mm.h |  2 --
 mm/swap.c          | 31 -------------------------------
 2 files changed, 33 deletions(-)
include/linux/mm.h +0 -2
index ecf63d2b0582..8524bf86dd74 100644
@@ -1286,8 +1286,6 @@ static inline struct folio *virt_to_folio(const void *x)
 
 void __folio_put(struct folio *folio);
 
-void put_pages_list(struct list_head *pages);
-
 void split_page(struct page *page, unsigned int order);
 void folio_copy(struct folio *dst, struct folio *src);
 int folio_mc_copy(struct folio *dst, struct folio *src);
mm/swap.c +0 -31
index b8e3259ea2c4..638a3f001676 100644
@@ -127,37 +127,6 @@ void __folio_put(struct folio *folio)
 }
 EXPORT_SYMBOL(__folio_put);
 
-/**
- * put_pages_list() - release a list of pages
- * @pages: list of pages threaded on page->lru
- *
- * Release a list of pages which are strung together on page.lru.
- */
-void put_pages_list(struct list_head *pages)
-{
-	struct folio_batch fbatch;
-	struct folio *folio, *next;
-
-	folio_batch_init(&fbatch);
-	list_for_each_entry_safe(folio, next, pages, lru) {
-		if (!folio_put_testzero(folio))
-			continue;
-		if (folio_test_hugetlb(folio)) {
-			free_huge_folio(folio);
-			continue;
-		}
-		/* LRU flag must be clear because it's passed using the lru */
-		if (folio_batch_add(&fbatch, folio) > 0)
-			continue;
-		free_unref_folios(&fbatch);
-	}
-
-	if (fbatch.nr)
-		free_unref_folios(&fbatch);
-	INIT_LIST_HEAD(pages);
-}
-EXPORT_SYMBOL(put_pages_list);
-
 typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio);
 
 static void lru_add(struct lruvec *lruvec, struct folio *folio)
Signature · 1 line
2.35.3
Acked-by on v1 1/1
#2 lore raw
In reply to Hugh Dickins
Quoted 3 lines · Hugh Dickins

The last user of put_pages_list() converted away from it in 6.10 commit 06c375053cef ("iommu/vt-d: add wrapper functions for page allocations"):
delete put_pages_list().

In that commit we now manually iterate over the list and call put_page() on each entry ... I would suspect that to perform worse ;)

In any case, the function surely is unused now.

Signature · 3 lines
Cheers,

David / dhildenb
Reviewed-by on v1 1/1
#3 lore raw
In reply to Hugh Dickins
Quoted 6 lines · Hugh Dickins

The last user of put_pages_list() converted away from it in 6.10 commit 06c375053cef ("iommu/vt-d: add wrapper functions for page allocations"):
delete put_pages_list().

Quoted 62 lines
---
 include/linux/mm.h |  2 --
 mm/swap.c          | 31 -------------------------------
 2 files changed, 33 deletions(-)
include/linux/mm.h +0 -2
index ecf63d2b0582..8524bf86dd74 100644
@@ -1286,8 +1286,6 @@ static inline struct folio *virt_to_folio(const void *x)
 
 void __folio_put(struct folio *folio);
 
-void put_pages_list(struct list_head *pages);
-
 void split_page(struct page *page, unsigned int order);
 void folio_copy(struct folio *dst, struct folio *src);
 int folio_mc_copy(struct folio *dst, struct folio *src);
mm/swap.c +0 -32
index b8e3259ea2c4..638a3f001676 100644
@@ -127,37 +127,6 @@ void __folio_put(struct folio *folio)
 }
 EXPORT_SYMBOL(__folio_put);
 
-/**
- * put_pages_list() - release a list of pages
- * @pages: list of pages threaded on page->lru
- *
- * Release a list of pages which are strung together on page.lru.
- */
-void put_pages_list(struct list_head *pages)
-{
-       struct folio_batch fbatch;
-       struct folio *folio, *next;
-
-       folio_batch_init(&fbatch);
-       list_for_each_entry_safe(folio, next, pages, lru) {
-               if (!folio_put_testzero(folio))
-                       continue;
-               if (folio_test_hugetlb(folio)) {
-                       free_huge_folio(folio);
-                       continue;
-               }
-               /* LRU flag must be clear because it's passed using the lru */
-               if (folio_batch_add(&fbatch, folio) > 0)
-                       continue;
-               free_unref_folios(&fbatch);
-       }
-
-       if (fbatch.nr)
-               free_unref_folios(&fbatch);
-       INIT_LIST_HEAD(pages);
-}
-EXPORT_SYMBOL(put_pages_list);
-
 typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio);
 
 static void lru_add(struct lruvec *lruvec, struct folio *folio)
--

2.35.3