Skip to contentSkip to conversation

Redfish HealthRollup/LED question

DISCUSSION Deepak Kodihalli 2 participants 4 messages Jul 14, 2020 – Jul 15, 2020

lore
Share & tools
lore
#0 lore raw

Hi James/Gunnar,

On IBM platforms, a fault indicator LED associated with a FRU can indicate the "Health Rollup" status of the FRU. For eg a CPU can be healthy, but something contained within (eg a core) may be broken, so the LED will be turned on. I think the Redfish HealthRollup property is conceptually similar.

Question is - do you see a problem if we add code in bmcweb that sets the HealthRollup property for a FRU if an associated LED is turned on? I believe this is aligned with https://github.com/openbmc/docs/blob/master/designs/redfish-health-rolllup.md (no new D-Bus objects/interfaces being added, etc). On IBM platforms, a D-Bus association might exist between the FRU and the LED, and setting the HealthRollup property will be based on this. If the said association is missing on other platforms, the code will not do anything.

Thanks,
Deepak

#1 lore raw
Quoted 5 lines · Deepak Kodihalli

Hi James/Gunnar,

On IBM platforms, a fault indicator LED associated with a FRU can indicate the "Health Rollup" status of the FRU. For eg a CPU can be healthy, but something contained within (eg a core) may be broken, so the LED will be turned on. I think the Redfish HealthRollup property is conceptually similar.

Question is - do you see a problem if we add code in bmcweb that sets the HealthRollup property for a FRU if an associated LED is turned on? I believe this is aligned with https://github.com/openbmc/docs/blob/master/designs/redfish-health-rolllup.md (no new D-Bus objects/interfaces being added, etc). On IBM platforms, a D-Bus association might exist between the FRU and the LED, and setting the HealthRollup property will be based on this. If the said association is missing on other platforms, the code will not do anything.

What changes does this require? I believe this is how the health roll up functions today.

Quoted 3 lines

Thanks,
Deepak

#2 lore raw
Quoted 8 lines · James Feist
Quoted 5 lines · Deepak Kodihalli

Hi James/Gunnar,

On IBM platforms, a fault indicator LED associated with a FRU can indicate the "Health Rollup" status of the FRU. For eg a CPU can be healthy, but something contained within (eg a core) may be broken, so the LED will be turned on. I think the Redfish HealthRollup property is conceptually similar.

Question is - do you see a problem if we add code in bmcweb that sets the HealthRollup property for a FRU if an associated LED is turned on? I believe this is aligned with https://github.com/openbmc/docs/blob/master/designs/redfish-health-rolllup.md (no new D-Bus objects/interfaces being added, etc). On IBM platforms, a D-Bus association might exist between the FRU and the LED, and setting the HealthRollup property will be based on this. If the said association is missing on other platforms, the code will not do anything.

What changes does this require? I believe this is how the health roll up functions today.

Yes, the bmcweb code around HealthRollup does look up association endpoints today already. What I mentioned above might need code changes to look at additional association types.

#3 lore raw
Quoted 4 lines · Deepak Kodihalli
Quoted 3 lines · James Feist
Quoted 2 lines · Deepak Kodihalli

Hi James/Gunnar,

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

On IBM platforms, a fault indicator LED associated with a FRU can indicate the "Health Rollup" status of the FRU. For eg a CPU can be healthy, but something contained within (eg a core) may be broken, so the LED will be turned on. I think the Redfish HealthRollup property is conceptually similar.

Question is - do you see a problem if we add code in bmcweb that sets the HealthRollup property for a FRU if an associated LED is turned on? I believe this is aligned with https://github.com/openbmc/docs/blob/master/designs/redfish-health-rolllup.md (no new D-Bus objects/interfaces being added, etc). On IBM platforms, a D-Bus association might exist between the FRU and the LED, and setting the HealthRollup property will be based on this. If the said association is missing on other platforms, the code will not do anything.

What changes does this require? I believe this is how the health roll up functions today.

Yes, the bmcweb code around HealthRollup does look up association endpoints today already. What I mentioned above might need code changes to look at additional association types.

I'd prefer we try to be consistent, but if that is not possible additional associations are probably fine, as long as the documentation is updated.