Skip to contentSkip to conversation

s390x/cpumodel: Introduce dynamic feature group

PATCH In review David Hildenbrand 4 participants 14 messages Nov 25, 2019 – Dec 12, 2019

lore
Share & tools
lore
#0 lore raw

v2 cover s390x/cpumodel: Introduce dynamic feature group

This thread was previously called:

    s390x/cpumodel: Introduce "best" model variants

There was recently a discussion regarding CPU model versions. That concept does not fit s390x where we have a lot of feature variability. I proposed an alternative approach in [1], which might work for x86 as well (but I am not sure if x86 still can or wants to switch to that), and requires only little changes in upper layers.

[1] and patch #2 contains more information on the motivation for this. It allows, for example, to specify/expand "best feature set possible on this accelerator, hw and, firmware"

"
Get the best possible feature set (e.g., excluding deprecated features) for a CPU definition in the configuration
-cpu z14,all-features=off,recommended-features=on

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Get all valid features for a CPU definition:
-cpu z14,all-features=on
"

v1 -> v2:
- Use dynamic feature groups instead of new models

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg07222.html

Cc Daniel P. Berrangé <[email protected]>
Cc Markus Armbruster <[email protected]>
Cc Jiri Denemark <[email protected]>
Cc Eduardo Habkost <[email protected]>
Cc Michael Mueller <[email protected]>
Cc Peter Maydell <[email protected]>

David Hildenbrand (2):
s390x/cpumodel: Factor out CPU feature dependencies s390x/cpumodel: Introduce dynamic feature groups

 target/s390x/cpu_features.c |  29 +++++
 target/s390x/cpu_features.h |  14 +++
 target/s390x/cpu_models.c   | 242 +++++++++++++++++++++++++++---------
 3 files changed, 228 insertions(+), 57 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH v2 1/2 s390x/cpumodel: Factor out CPU feature dependencies

Currently we check "if bit X is set, bit Y is required". We want to perform "if bit Y is not set, bit X must also not be set" when creating CPU models that will pass all consistency checks.

---
 target/s390x/cpu_models.c | 115 +++++++++++++++++++-------------------
 1 file changed, 58 insertions(+), 57 deletions(-)
target/s390x/cpu_models.c +58 -57
index 7e92fb2e15..e6072fab43 100644
@@ -88,6 +88,59 @@ static S390CPUDef s390_cpu_defs[] = {
     CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM 8562 GA1"),
 };
 
+static const int cpu_feature_dependencies[][2] = {
+    { S390_FEAT_IPTE_RANGE, S390_FEAT_DAT_ENH },
+    { S390_FEAT_IDTE_SEGMENT, S390_FEAT_DAT_ENH },
+    { S390_FEAT_IDTE_REGION, S390_FEAT_DAT_ENH },
+    { S390_FEAT_IDTE_REGION, S390_FEAT_IDTE_SEGMENT },
+    { S390_FEAT_LOCAL_TLB_CLEARING, S390_FEAT_DAT_ENH},
+    { S390_FEAT_LONG_DISPLACEMENT_FAST, S390_FEAT_LONG_DISPLACEMENT },
+    { S390_FEAT_DFP_FAST, S390_FEAT_DFP },
+    { S390_FEAT_TRANSACTIONAL_EXE, S390_FEAT_STFLE_49 },
+    { S390_FEAT_EDAT_2, S390_FEAT_EDAT},
+    { S390_FEAT_MSA_EXT_5, S390_FEAT_KIMD_SHA_512 },
+    { S390_FEAT_MSA_EXT_5, S390_FEAT_KLMD_SHA_512 },
+    { S390_FEAT_MSA_EXT_4, S390_FEAT_MSA_EXT_3 },
+    { S390_FEAT_SIE_CMMA, S390_FEAT_CMM },
+    { S390_FEAT_SIE_CMMA, S390_FEAT_SIE_GSLS },
+    { S390_FEAT_SIE_PFMFI, S390_FEAT_EDAT },
+    { S390_FEAT_MSA_EXT_8, S390_FEAT_MSA_EXT_3 },
+    { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_3 },
+    { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_4 },
+    { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING },
+    { S390_FEAT_VECTOR_PACKED_DECIMAL, S390_FEAT_VECTOR },
+    { S390_FEAT_VECTOR_ENH, S390_FEAT_VECTOR },
+    { S390_FEAT_INSTRUCTION_EXEC_PROT, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 },
+    { S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2, S390_FEAT_ESOP },
+    { S390_FEAT_CMM_NT, S390_FEAT_CMM },
+    { S390_FEAT_GUARDED_STORAGE, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 },
+    { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_STORE_CLOCK_FAST },
+    { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING },
+    { S390_FEAT_SEMAPHORE_ASSIST, S390_FEAT_STFLE_49 },
+    { S390_FEAT_KIMD_SHA3_224, S390_FEAT_MSA },
+    { S390_FEAT_KIMD_SHA3_256, S390_FEAT_MSA },
+    { S390_FEAT_KIMD_SHA3_384, S390_FEAT_MSA },
+    { S390_FEAT_KIMD_SHA3_512, S390_FEAT_MSA },
+    { S390_FEAT_KIMD_SHAKE_128, S390_FEAT_MSA },
+    { S390_FEAT_KIMD_SHAKE_256, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHA3_224, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHA3_256, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHA3_384, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHA3_512, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHAKE_128, S390_FEAT_MSA },
+    { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA },
+    { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 },
+    { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 },
+    { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 },
+    { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP },
+    { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP },
+    { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH },
+    { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH },
+    { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH },
+    { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH },
+    { S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, S390_FEAT_AP },
+};
+
 #define QEMU_MAX_CPU_TYPE 0x2964
 #define QEMU_MAX_CPU_GEN 13
 #define QEMU_MAX_CPU_EC_GA 2
@@ -769,66 +822,14 @@ CpuModelBaselineInfo *qmp_query_cpu_model_baseline(CpuModelInfo *infoa,
 
 static void check_consistency(const S390CPUModel *model)
 {
-    static int dep[][2] = {
-        { S390_FEAT_IPTE_RANGE, S390_FEAT_DAT_ENH },
-        { S390_FEAT_IDTE_SEGMENT, S390_FEAT_DAT_ENH },
-        { S390_FEAT_IDTE_REGION, S390_FEAT_DAT_ENH },
-        { S390_FEAT_IDTE_REGION, S390_FEAT_IDTE_SEGMENT },
-        { S390_FEAT_LOCAL_TLB_CLEARING, S390_FEAT_DAT_ENH},
-        { S390_FEAT_LONG_DISPLACEMENT_FAST, S390_FEAT_LONG_DISPLACEMENT },
-        { S390_FEAT_DFP_FAST, S390_FEAT_DFP },
-        { S390_FEAT_TRANSACTIONAL_EXE, S390_FEAT_STFLE_49 },
-        { S390_FEAT_EDAT_2, S390_FEAT_EDAT},
-        { S390_FEAT_MSA_EXT_5, S390_FEAT_KIMD_SHA_512 },
-        { S390_FEAT_MSA_EXT_5, S390_FEAT_KLMD_SHA_512 },
-        { S390_FEAT_MSA_EXT_4, S390_FEAT_MSA_EXT_3 },
-        { S390_FEAT_SIE_CMMA, S390_FEAT_CMM },
-        { S390_FEAT_SIE_CMMA, S390_FEAT_SIE_GSLS },
-        { S390_FEAT_SIE_PFMFI, S390_FEAT_EDAT },
-        { S390_FEAT_MSA_EXT_8, S390_FEAT_MSA_EXT_3 },
-        { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_3 },
-        { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_4 },
-        { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING },
-        { S390_FEAT_VECTOR_PACKED_DECIMAL, S390_FEAT_VECTOR },
-        { S390_FEAT_VECTOR_ENH, S390_FEAT_VECTOR },
-        { S390_FEAT_INSTRUCTION_EXEC_PROT, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 },
-        { S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2, S390_FEAT_ESOP },
-        { S390_FEAT_CMM_NT, S390_FEAT_CMM },
-        { S390_FEAT_GUARDED_STORAGE, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 },
-        { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_STORE_CLOCK_FAST },
-        { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING },
-        { S390_FEAT_SEMAPHORE_ASSIST, S390_FEAT_STFLE_49 },
-        { S390_FEAT_KIMD_SHA3_224, S390_FEAT_MSA },
-        { S390_FEAT_KIMD_SHA3_256, S390_FEAT_MSA },
-        { S390_FEAT_KIMD_SHA3_384, S390_FEAT_MSA },
-        { S390_FEAT_KIMD_SHA3_512, S390_FEAT_MSA },
-        { S390_FEAT_KIMD_SHAKE_128, S390_FEAT_MSA },
-        { S390_FEAT_KIMD_SHAKE_256, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHA3_224, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHA3_256, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHA3_384, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHA3_512, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHAKE_128, S390_FEAT_MSA },
-        { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA },
-        { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 },
-        { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 },
-        { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 },
-        { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP },
-        { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP },
-        { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH },
-        { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH },
-        { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH },
-        { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH },
-        { S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, S390_FEAT_AP },
-    };
     int i;
 
-    for (i = 0; i < ARRAY_SIZE(dep); i++) {
-        if (test_bit(dep[i][0], model->features) &&
-            !test_bit(dep[i][1], model->features)) {
+    for (i = 0; i < ARRAY_SIZE(cpu_feature_dependencies); i++) {
+        if (test_bit(cpu_feature_dependencies[i][0], model->features) &&
+            !test_bit(cpu_feature_dependencies[i][1], model->features)) {
             warn_report("\'%s\' requires \'%s\'.",
-                        s390_feat_def(dep[i][0])->name,
-                        s390_feat_def(dep[i][1])->name);
+                        s390_feat_def(cpu_feature_dependencies[i][0])->name,
+                        s390_feat_def(cpu_feature_dependencies[i][1])->name);
         }
     }
 }
Signature · 1 line
2.21.0
#2 lore raw

PATCH v2 2/2 s390x/cpumodel: Introduce dynamic feature groups

In reply to David Hildenbrand

For a specific CPU model, we have a lot of feature variability depending on
- The microcode version of the HW
- The hypervisor we're running on (LPAR vs. KVM vs. z/VM)
- The hypervisor version we're running on
- The KVM version
- KVM module parameters (especially, "nested=1")
- The accelerator

Our default models are migration safe, however can only be changed between QEMU releases (glued to QEMU machine). This somewhat collides with the feature variability we have. E.g., the z13 model will not run under TCG. There is the demand from higher levels in the stack to "have the best CPU model possible on a given accelerator, firmware and HW", which should especially include all features that fix security issues. Especially, if we have a new feature due to a security flaw, we want to have a way to backport this feature to older QEMU versions and a way to automatically enable it when asked.

This is where dynamic CPU feature groups come into play. They allow to first disable all features that would be enabled as default for a QEMU machine, to then enable a dynamic set of features (depending on the CPU definition, the accelerator, and the host).

Get the best possible feature set (e.g., excluding deprecated features) for a CPU definition in the configuration
-cpu z14,all-features=off,recommended-features=on

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Get all valid features for a CPU definition:
-cpu z14,all-features=on

The idea of using feature flags for this use case instead of introducing new models was brought up by Eduardo Habkost.

The best possible features will then, for example, include nested virtualization ("SIE" feature) when KVM+HW support is enabled, or fixes via microcode updates (e.g., spectre) - something we cannot have in the default models of older QEMU machines.

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

---
 target/s390x/cpu_features.c |  29 ++++++++
 target/s390x/cpu_features.h |  14 ++++
 target/s390x/cpu_models.c   | 127 ++++++++++++++++++++++++++++++++++++
 3 files changed, 170 insertions(+)
target/s390x/cpu_features.c +29 -0
index 9f817e3cfa..77deabf375 100644
@@ -166,6 +166,35 @@ void s390_feat_bitmap_to_ascii(const S390FeatBitmap features, void *opaque,
     };
 }
 
+#define DYN_FEAT_GROUP_INIT(_name, _group, _desc)    \
+    [S390_DYN_FEAT_GROUP_ ## _group] = {             \
+        .name = _name,                               \
+        .desc = _desc,                               \
+    }
+
+/*
+ * Dynamic feature groups can change between QEMU versions (or even for the
+ * same version on backports) and depend on the selected CPU definition. Most of
+ * them also depend on the selected accelerator and the host ("max" model). When
+ * used, they turn every model into a migration-unsafe model. Thus, they will
+ * never appear in expaneded CPU models.
+ *
+ * Indexed by dynamic feature group number.
+ */
+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+    /* "all" corresponds to our "full" definitions */
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU definition"),
+    /* "recommended" does not include deprecated features. */
+    DYN_FEAT_GROUP_INIT("recommended-features", RECOMMENDED, "Available, recommended features supported by the accelerator in the current host for a CPU definition"),
+    /* "available" includes deprecated features. */
+    DYN_FEAT_GROUP_INIT("available-features", AVAILABLE, "Available features supported by the accelerator in the current host for a CPU definition"),
+};
+
+const S390DynFeatGroupDef *s390_dyn_feat_group_def(S390DynFeatGroup group)
+{
+    return &s390_dyn_feature_groups[group];
+}
+
 #define FEAT_GROUP_INIT(_name, _group, _desc)        \
     {                                                \
         .name = _name,                               \
target/s390x/cpu_features.h +14 -0
index da695a8346..4a2f418cd3 100644
@@ -76,7 +76,21 @@ typedef struct {
     S390FeatInit init;      /* used to init feat from generated data */
 } S390FeatGroupDef;
 
+/* Definition of a dynamic CPU feature group */
+typedef struct {
+    const char *name;       /* name exposed to the user */
+    const char *desc;       /* description exposed to the user */
+} S390DynFeatGroupDef;
+
+typedef enum {
+    S390_DYN_FEAT_GROUP_ALL,
+    S390_DYN_FEAT_GROUP_RECOMMENDED,
+    S390_DYN_FEAT_GROUP_AVAILABLE,
+    S390_DYN_FEAT_GROUP_MAX,
+} S390DynFeatGroup;
+
 const S390FeatGroupDef *s390_feat_group_def(S390FeatGroup group);
+const S390DynFeatGroupDef *s390_dyn_feat_group_def(S390DynFeatGroup group);
 
 #define BE_BIT_NR(BIT) (BIT ^ (BITS_PER_LONG - 1))
 
target/s390x/cpu_models.c +127 -0

153 lines not on this page · raw message

Signature · 1 line
2.21.0
#3 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 4 lines · David Hildenbrand

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

I really dislike that. I am trying to get rid of the unsafe variants (e.g. now defaulting to host-model instead of host-passthrough). I do not want to give users new ways of hurting themselves.

Unless I misunderstood Eduardo, I think his versioning approach is actually better in regard to migration, no?
I z terms, you can still say -cpu z13 which is just an alias to z13v1 z13v2 etc. Assuming that the version is checked this will be safe.

#4 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 8 lines

Am 26.11.2019 um 08:54 schrieb Christian Borntraeger <[email protected]>:



Quoted 2 lines · David Hildenbrand
Quoted 8 lines
Quoted 3 lines

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

I really dislike that. I am trying to get rid of the unsafe variants (e.g. now defaulting to host-model instead of host-passthrough). I do not want to give users new ways of hurting themselves.

Please note that this is just on the bare command line. Libvirt and friends will expand the model and have proper migration in place. What exactly is your concern in that regard?

Quoted 5 lines

Unless I misunderstood Eduardo, I think his versioning approach is actually better in regard to migration, no?
I z terms, you can still say -cpu z13 which is just an alias to z13v1 z13v2 etc. Assuming that the version is checked this will be safe.

It‘s even worse AFAIKS. A „-cpu z13“ would dynamically map to whatever is best on the host.

#5 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

re-adding ccs from the cover-letter

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines · David Hildenbrand

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

Quoted 6 lines
Quoted 4 lines

I really dislike that. I am trying to get rid of the unsafe variants (e.g. now defaulting to host-model instead of host-passthrough). I do not want to give users new ways of hurting themselves.

Please note that this is just on the bare command line. Libvirt and friends will expand the model and have proper migration in place. What exactly is your concern in that regard?

What is then the value? libvirt can also use host-model or baselining if necessary. And for the command line this will just add more opportunity to shot yourself in the foot, no?

Let me put it this way, I might have misunderstood what you are trying to do here, but if I do not get, then others (e.g. users) will also not get it.

Maybe its just the interface or the name. But I find this very non-intuitive

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

Quoted 9 lines
Quoted 6 lines

Unless I misunderstood Eduardo, I think his versioning approach is actually better in regard to migration, no?
I z terms, you can still say -cpu z13 which is just an alias to z13v1 z13v2 etc. Assuming that the version is checked this will be safe.

It‘s even worse AFAIKS. A „-cpu z13“ would dynamically map to whatever is best on the host.

#6 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 13 lines · Christian Borntraeger

re-adding ccs from the cover-letter

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines · David Hildenbrand

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

I really dislike that. I am trying to get rid of the unsafe variants (e.g. now defaulting to host-model instead of host-passthrough). I do not want to give users new ways of hurting themselves.

Quoted 5 lines
Quoted 1 line

Please note that this is just on the bare command line. Libvirt and friends will expand the model and have proper migration in place. What exactly is your concern in that regard?

What is then the value? libvirt can also use host-model or baselining if necessary. And for the command line this will just add more opportunity to shot yourself in the foot, no?

I don't think so. It's in no way more dangerous than "-cpu host" or "-cpu max". And it is in no way more dangerous than the discussed CPU versions, where even a "-cpu z13" would no longer be migration-safe.

You could - in theory - baseline(z13, host), but it could suddenly fallback to a, say, zEC12 - and that's not what you asked for. And you should not simply mask of deprecated features when baselining. Sure, we could eventually add config knobs for that , but ...

... I really do like the part where you can specify on the command line to have specific CPU definition, but including all available/recommended features (e.g., nested virtualization).

Quoted 3 lines

Let me put it this way, I might have misunderstood what you are trying to do here, but if I do not get, then others (e.g. users) will also not get it.

I remember you participated in the relevant discussions. That's where we also agreed that versioned CPU models on s390x don't make any sense. But I can refine what's included in this patch description

"There is the demand from higher levels in the stack to "have the best CPU model possible on a given accelerator, firmware and HW"" - the best CPU model for a specific *CPU definition*.

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

Quoted 2 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

I am open for better names. e.g. all-features -> valid-features.

Signature · 3 lines
Thanks,

David / dhildenb
#7 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 45 lines · David Hildenbrand
Quoted 13 lines · Christian Borntraeger

re-adding ccs from the cover-letter

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines · David Hildenbrand

As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe and static variants, allowing them to be migrated.

I really dislike that. I am trying to get rid of the unsafe variants (e.g. now defaulting to host-model instead of host-passthrough). I do not want to give users new ways of hurting themselves.

Quoted 5 lines
Quoted 1 line

Please note that this is just on the bare command line. Libvirt and friends will expand the model and have proper migration in place. What exactly is your concern in that regard?

What is then the value? libvirt can also use host-model or baselining if necessary. And for the command line this will just add more opportunity to shot yourself in the foot, no?

I don't think so. It's in no way more dangerous than "-cpu host" or "-cpu max". And it is in no way more dangerous than the discussed CPU versions, where even a "-cpu z13" would no longer be migration-safe.

You could - in theory - baseline(z13, host), but it could suddenly fallback to a, say, zEC12 - and that's not what you asked for. And you should not simply mask of deprecated features when baselining. Sure, we could eventually add config knobs for that , but ...

... I really do like the part where you can specify on the command line to have specific CPU definition, but including all available/recommended features (e.g., nested virtualization).

Quoted 3 lines

Let me put it this way, I might have misunderstood what you are trying to do here, but if I do not get, then others (e.g. users) will also not get it.

I remember you participated in the relevant discussions. That's where we also agreed that versioned CPU models on s390x don't make any sense. But I can refine what's included in this patch description

"There is the demand from higher levels in the stack to "have the best CPU model possible on a given accelerator, firmware and HW"" - the best CPU model for a specific *CPU definition*.

Quoted 6 lines

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

This is a good description of the main use case we're worried about in x86 too, and the main reason we have added versioned CPU models.

I remember I was planning to use query-cpu-model-expansion for "please give me the best configuration for this specific CPU model" (which would be very similar to the approach used in this series). Now, I need to refresh my memory and try to remember why I concluded this approach wouldn't work for x86.

Quoted 19 lines
Quoted 2 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

Quoted 8 lines

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

I am open for better names. e.g. all-features -> valid-features.

"all" is not a meaningful name to me. It surely doesn't mean "all features in the universe", so it means a more specific set of features. How is that set defined?

"valid" seems clearer, but we still need a description of what "valid" means exactly.

Signature · 1 line
Eduardo
#8 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 12 lines
Quoted 7 lines

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

This is a good description of the main use case we're worried about in x86 too, and the main reason we have added versioned CPU models.

Quoted 5 lines

I remember I was planning to use query-cpu-model-expansion for "please give me the best configuration for this specific CPU model" (which would be very similar to the approach used in this series). Now, I need to refresh my memory and try to remember why I concluded this approach wouldn't work for x86.

I would be interested in that - I don't really think exposing CPU versions to the user is necessary here.

E.g., you can maintain the versions internally and enable the stored features of the fitting one with "recommended-features=on...".

Quoted 28 lines
Quoted 28 lines
Quoted 4 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

Quoted 9 lines
Quoted 1 line

I am open for better names. e.g. all-features -> valid-features.

"all" is not a meaningful name to me. It surely doesn't mean "all features in the universe", so it means a more specific set of features. How is that set defined?

"valid" seems clearer, but we still need a description of what "valid" means exactly.

So, we have

+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+ /* "all" corresponds to our "full" definitions */
+ DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU
definition"),
[...]
+};

it includes features that are not available - all features that could theoretically be enabled for that CPU definition.

(e.g., "vx" was introduced with z13 and cannot be enabled for the z12. It's part of the full model of a z13, but not of a z12)

Signature · 3 lines
Thanks,

David / dhildenb
#9 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 18 lines · David Hildenbrand
Quoted 12 lines
Quoted 7 lines

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

This is a good description of the main use case we're worried about in x86 too, and the main reason we have added versioned CPU models.

Quoted 5 lines

I remember I was planning to use query-cpu-model-expansion for "please give me the best configuration for this specific CPU model" (which would be very similar to the approach used in this series). Now, I need to refresh my memory and try to remember why I concluded this approach wouldn't work for x86.

Quoted 5 lines

I would be interested in that - I don't really think exposing CPU versions to the user is necessary here.

E.g., you can maintain the versions internally and enable the stored features of the fitting one with "recommended-features=on...".

I was re-reading some code and threads, and now I remember: the main obstacle for using query-cpu-model-expansion for CPU model version resolution in x86 is the fact that the x86 CPU models aren't static yet. (type=full expansion isn't useful for CPU the use case above; type=static expansion requires static CPU models to be useful)

I was planning to make x86 CPU models static, then I noticed we do have lots of feature flags that depend on the current accelerator (set by kvm_default_props) or current machine (set by compat_props). This breaks the rules for static CPU models.

We can still try to provide useful static CPU models in x86 in the future (I want to). But I don't want to make this an obstacle for providing a CPU model update mechanism that works for x86 (which is more urgent).

Quoted 48 lines
Quoted 29 lines
Quoted 29 lines
Quoted 5 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

Quoted 9 lines
Quoted 1 line

I am open for better names. e.g. all-features -> valid-features.

"all" is not a meaningful name to me. It surely doesn't mean "all features in the universe", so it means a more specific set of features. How is that set defined?

"valid" seems clearer, but we still need a description of what "valid" means exactly.

So, we have

(quoted diff) +3 -0
+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+    /* "all" corresponds to our "full" definitions */
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU

definition"),
[...]
+};

Quoted 5 lines

it includes features that are not available - all features that could theoretically be enabled for that CPU definition.

(e.g., "vx" was introduced with z13 and cannot be enabled for the z12. It's part of the full model of a z13, but not of a z12)

Isn't this something already returned by device-list-properties?

Signature · 1 line
Eduardo
#10 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 25 lines · Eduardo Habkost
Quoted 18 lines · David Hildenbrand
Quoted 12 lines
Quoted 7 lines

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

This is a good description of the main use case we're worried about in x86 too, and the main reason we have added versioned CPU models.

Quoted 5 lines

I remember I was planning to use query-cpu-model-expansion for "please give me the best configuration for this specific CPU model" (which would be very similar to the approach used in this series). Now, I need to refresh my memory and try to remember why I concluded this approach wouldn't work for x86.

Quoted 5 lines

I would be interested in that - I don't really think exposing CPU versions to the user is necessary here.

E.g., you can maintain the versions internally and enable the stored features of the fitting one with "recommended-features=on...".

Quoted 6 lines

I was re-reading some code and threads, and now I remember: the main obstacle for using query-cpu-model-expansion for CPU model version resolution in x86 is the fact that the x86 CPU models aren't static yet. (type=full expansion isn't useful for CPU the use case above; type=static expansion requires static CPU models to be useful)

I think, you could if you would expand "best X" to something like

-cpu X,all-features=off,featX=on,featY=on ...

The "all-features" part would need a better name as discussed. Such a model would always have a defined feature set (all listed features) == static. The list could get a little longer, which is why s390x has these static "base" features. But that's not a road blocker.

Quoted 5 lines

I was planning to make x86 CPU models static, then I noticed we do have lots of feature flags that depend on the current accelerator (set by kvm_default_props) or current machine (set by compat_props). This breaks the rules for static CPU models.

The static models we have (e.g., z13-base) contain a minimum set of features we expect to be around in every environment (but doesn't have to). It's just a way to make the featX=on,featY=on ... list shorter.

X would be expanded to e.g.,

-cpu X-base,featX=on,featY=on ...

But nothing speaks against having

-cpu X-base,featX=off,featY=on ...

A very simplistic base model would be a model without any features. (like -cpu X,all-features=off), but then it would be set in stone.

Quoted 54 lines

We can still try to provide useful static CPU models in x86 in the future (I want to). But I don't want to make this an obstacle for providing a CPU model update mechanism that works for x86 (which is more urgent).

Quoted 48 lines
Quoted 29 lines
Quoted 29 lines
Quoted 5 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

Quoted 9 lines
Quoted 1 line

I am open for better names. e.g. all-features -> valid-features.

"all" is not a meaningful name to me. It surely doesn't mean "all features in the universe", so it means a more specific set of features. How is that set defined?

"valid" seems clearer, but we still need a description of what "valid" means exactly.

So, we have

(quoted diff) +3 -0
+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+    /* "all" corresponds to our "full" definitions */
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU

definition"),
[...]
+};

Quoted 8 lines
Quoted 5 lines

it includes features that are not available - all features that could theoretically be enabled for that CPU definition.

(e.g., "vx" was introduced with z13 and cannot be enabled for the z12. It's part of the full model of a z13, but not of a z12)

Isn't this something already returned by device-list-properties?

We do register all feature properties for all models. So, yes, it would have been possible if we (I) would have implemented that differently. We could (and maybe should) still change that - only register the features that are part of the "full" model.

Signature · 3 lines
Thanks,

David / dhildenb
#11 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 55 lines · David Hildenbrand
Quoted 25 lines · Eduardo Habkost
Quoted 18 lines · David Hildenbrand
Quoted 12 lines
Quoted 7 lines

Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host model can do that, CPU definitions can't. You can't change default models within a QEMU release, or for older releases (e.g., a z13).

This is a good description of the main use case we're worried about in x86 too, and the main reason we have added versioned CPU models.

Quoted 5 lines

I remember I was planning to use query-cpu-model-expansion for "please give me the best configuration for this specific CPU model" (which would be very similar to the approach used in this series). Now, I need to refresh my memory and try to remember why I concluded this approach wouldn't work for x86.

Quoted 5 lines

I would be interested in that - I don't really think exposing CPU versions to the user is necessary here.

E.g., you can maintain the versions internally and enable the stored features of the fitting one with "recommended-features=on...".

Quoted 6 lines

I was re-reading some code and threads, and now I remember: the main obstacle for using query-cpu-model-expansion for CPU model version resolution in x86 is the fact that the x86 CPU models aren't static yet. (type=full expansion isn't useful for CPU the use case above; type=static expansion requires static CPU models to be useful)

I think, you could if you would expand "best X" to something like

-cpu X,all-features=off,featX=on,featY=on ...

The "all-features" part would need a better name as discussed. Such a model would always have a defined feature set (all listed features) == static. The list could get a little longer, which is why s390x has these static "base" features. But that's not a road blocker.

Quoted 5 lines

I was planning to make x86 CPU models static, then I noticed we do have lots of feature flags that depend on the current accelerator (set by kvm_default_props) or current machine (set by compat_props). This breaks the rules for static CPU models.

The static models we have (e.g., z13-base) contain a minimum set of features we expect to be around in every environment (but doesn't have to). It's just a way to make the featX=on,featY=on ... list shorter.

X would be expanded to e.g.,

Quoted 8 lines

-cpu X-base,featX=on,featY=on ...

But nothing speaks against having

-cpu X-base,featX=off,featY=on ...

A very simplistic base model would be a model without any features. (like -cpu X,all-features=off), but then it would be set in stone.

x86 has only one static CPU model, called "base", just to make type=static expansion work. Having multiple "<model>-base" CPU models would help make the extra feature list shorter, yes.

But we would still need to decide how to handle the accel-specific code in x86_cpu_load_model(), including:
* kvm_default_props/tcg_default_props;
* x2apic special case for !kvm_irqchip_in_kernel();
* host vendor ID special case for KVM.

If we include that in static expansion, it would be a large number of user-visible side effects for something that was supposed to just add/remove a tiny set of CPU features to an existing configuration. If we don't, we are breaking the rules of static expansion (aren't we?).

We can still try to address this and make "query-cpu-model-expansion type=static ...,recommended-features=on" work on x86, and see it is usable by libvirt in x86. I'm just worried that the interface may become complex, easy to get wrong, and hard to validate until full libvirt support is implemented. query-cpu-model-expansion is very extensible and flexible, but hard to explain and reason about.

Quoted 64 lines
Quoted 55 lines

We can still try to provide useful static CPU models in x86 in the future (I want to). But I don't want to make this an obstacle for providing a CPU model update mechanism that works for x86 (which is more urgent).

Quoted 48 lines
Quoted 29 lines
Quoted 29 lines
Quoted 5 lines

Maybe its just the interface or the name. But I find this very non-intuitive

I'm open for suggestions.

Quoted 8 lines

e.g. you wrote

Get the maximum possible feature set (e.g., including deprecated features) for a CPU definition in the configuration ("everything that could be enabled"):
-cpu z14,all-features=off,available-features=on

Quoted 5 lines

Get all valid features for a CPU definition:
-cpu z14,all-features=on

What is the point of this? It is either the same as the one before, or it wont be able to start.

valid != available, all != available. Yes, the model won't run unless you are on pretty good HW :)

Maybe I should just have dropped the last example, as it seems to confuse people - it's mostly only relevant for introspection via CPU model expansion.

Quoted 9 lines
Quoted 1 line

I am open for better names. e.g. all-features -> valid-features.

"all" is not a meaningful name to me. It surely doesn't mean "all features in the universe", so it means a more specific set of features. How is that set defined?

"valid" seems clearer, but we still need a description of what "valid" means exactly.

So, we have

(quoted diff) +3 -0
+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+    /* "all" corresponds to our "full" definitions */
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU

definition"),
[...]
+};

Quoted 8 lines
Quoted 5 lines

it includes features that are not available - all features that could theoretically be enabled for that CPU definition.

(e.g., "vx" was introduced with z13 and cannot be enabled for the z12. It's part of the full model of a z13, but not of a z12)

Isn't this something already returned by device-list-properties?

Quoted 4 lines

We do register all feature properties for all models. So, yes, it would have been possible if we (I) would have implemented that differently. We could (and maybe should) still change that - only register the features that are part of the "full" model.

Understood. When exactly would all-features=on be useful for management software?

Signature · 1 line
Eduardo
#12 lore raw

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

Quoted 25 lines
Quoted 25 lines

I think, you could if you would expand "best X" to something like

-cpu X,all-features=off,featX=on,featY=on ...

The "all-features" part would need a better name as discussed. Such a model would always have a defined feature set (all listed features) == static. The list could get a little longer, which is why s390x has these static "base" features. But that's not a road blocker.

Quoted 5 lines

I was planning to make x86 CPU models static, then I noticed we do have lots of feature flags that depend on the current accelerator (set by kvm_default_props) or current machine (set by compat_props). This breaks the rules for static CPU models.

The static models we have (e.g., z13-base) contain a minimum set of features we expect to be around in every environment (but doesn't have to). It's just a way to make the featX=on,featY=on ... list shorter.

X would be expanded to e.g.,

-cpu X-base,featX=on,featY=on ...

But nothing speaks against having

Quoted 8 lines
Quoted 4 lines

-cpu X-base,featX=off,featY=on ...

A very simplistic base model would be a model without any features. (like -cpu X,all-features=off), but then it would be set in stone.

x86 has only one static CPU model, called "base", just to make type=static expansion work. Having multiple "<model>-base" CPU models would help make the extra feature list shorter, yes.

On s390x, we also glue some magic numbers to the models (e.g., CPU ID, IBC value, HW generation). IOW, you can't
make a z12 to a z13 just by adding features. The guest is able to observe these magic numbers. That's also one reason we need distinct base models.

Quoted 6 lines

But we would still need to decide how to handle the accel-specific code in x86_cpu_load_model(), including:
* kvm_default_props/tcg_default_props;
* x2apic special case for !kvm_irqchip_in_kernel();
* host vendor ID special case for KVM.

What would happen right now if you would do a static expansion of e.g., "SandyBridge" or of "host"? wouldn't all these knobs also have to be expanded as well?

Quoted 6 lines

If we include that in static expansion, it would be a large number of user-visible side effects for something that was supposed to just add/remove a tiny set of CPU features to an existing configuration. If we don't, we are breaking the rules of static expansion (aren't we?).

I guess we would have to include - but a long list of features wouldn't really be problematic, right? (at least when tooling just expands and passes on whatever it gets). Same as when expanding "host".

Quoted 9 lines

We can still try to address this and make "query-cpu-model-expansion type=static ...,recommended-features=on" work on x86, and see it is usable by libvirt in x86. I'm just worried that the interface may become complex, easy to get wrong, and hard to validate until full libvirt support is implemented. query-cpu-model-expansion is very extensible and flexible, but hard to explain and reason about.

I don't see a real alternative to get "the best model of a specific generation for the current accel+hw+firmware". Ack that we should clarify all implications (and requirements) first, before taking that path.

At least the concept of feature groups should be easy to explain.

[...]

Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -0
+static S390DynFeatGroupDef s390_dyn_feature_groups[] = {
+    /* "all" corresponds to our "full" definitions */
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU

definition"),
[...]
+};

Quoted 5 lines

it includes features that are not available - all features that could theoretically be enabled for that CPU definition.

(e.g., "vx" was introduced with z13 and cannot be enabled for the z12. It's part of the full model of a z13, but not of a z12)

Isn't this something already returned by device-list-properties?

Quoted 8 lines
Quoted 4 lines

We do register all feature properties for all models. So, yes, it would have been possible if we (I) would have implemented that differently. We could (and maybe should) still change that - only register the features that are part of the "full" model.

Understood. When exactly would all-features=on be useful for management software?

I guess "all-features=on" would only be useful for some sort of introspection (or testing), but not actually for something else I guess.

One interesting use case of "all-features=off/recommended-features=on" could be

-cpu host,all-features=off,recommended-features=on

Would allow us to disable all deprecated features when starting a new VM that we have to keep in the "host" model to keep baseline/runnability tests working and migration of old VMs unchanged.

Signature · 3 lines
Thanks,

David / dhildenb
#13 lore raw
In reply to David Hildenbrand
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group
Type: series
Message-id: [email protected]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
abb1bba s390x/cpumodel: Introduce dynamic feature groups f8b362f s390x/cpumodel: Factor out CPU feature dependencies

=== OUTPUT BEGIN ===
1/2 Checking commit f8b362f40451 (s390x/cpumodel: Factor out CPU feature dependencies) 2/2 Checking commit abb1bba82287 (s390x/cpumodel: Introduce dynamic feature groups)
WARNING: line over 80 characters
#82: FILE: target/s390x/cpu_features.c:186:
+ DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU definition"),

ERROR: line over 90 characters
#84: FILE: target/s390x/cpu_features.c:188:
+ DYN_FEAT_GROUP_INIT("recommended-features", RECOMMENDED, "Available, recommended features supported by the accelerator in the current host for a CPU definition"),

ERROR: line over 90 characters
#86: FILE: target/s390x/cpu_features.c:190:
+ DYN_FEAT_GROUP_INIT("available-features", AVAILABLE, "Available features supported by the accelerator in the current host for a CPU definition"),

total: 2 errors, 1 warnings, 209 lines checked

Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]