net: dsa: lantiq_gswip: move MDIO bus registration to .setup()
Subsystems (3)
RFC PATCH 17/23 net: dsa: lantiq_gswip: move MDIO bus registration to .setup()
Instead of registering the switch MDIO bus in the probe() function, move the call to gswip_mdio() into the .setup() DSA switch op, so it can be reused independently of the probe() function.
Signed-off-by Daniel Golle <[email protected]>
--- drivers/net/dsa/lantiq_gswip.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/dsa/lantiq_gswip.c +7 -7
@@ -677,6 +677,13 @@ static int gswip_setup(struct dsa_switch *ds)/* Configure the MDIO Clock 2.5 MHz */ gswip_mdio_mask (priv,0xff ,0x09 ,GSWIP_MDIO_MDC_CFG1 ); +/* bring up the mdio bus */ + err =gswip_mdio (priv); +if (err) { +dev_err (priv->dev,"mdio bus setup failed\n" ); +return err; + } +/* Disable the xMII interface and clear it's isolation bit */ for (i =0 ; i < priv->hw_info->max_ports; i++) gswip_mii_mask_cfg(priv,
@@ -2093,13 +2100,6 @@ static int gswip_probe(struct platform_device *pdev) "gphy fw probe failed\n"); } -/* bring up the mdio bus */ - err =gswip_mdio (priv); -if (err) { -dev_err_probe (dev, err,"mdio probe failed\n" ); - goto gphy_fw_remove; - } - err =gswip_allocate_vlans (priv);if (err) goto gphy_fw_remove;
Signature · 1 line
2.50.1