Skip to content

RFC net: dsa: lantiq_gswip: Add support for MaxLinear GSW1xx switch family

Daniel Golle lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest23 patches 25 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23net: dsa: lantiq_gswip: honor dsa_db passed to port_fdb_{add,del}drivers/net/dsa/lantiq_gswip.c+33 -220 replies
2/23net: dsa: lantiq_gswip: deduplicate dsa_switch_opsdrivers/net/dsa/lantiq_gswip.c+15 -291 reply
3/23net: dsa: lantiq_gswip: prepare for more CPU port optionsdrivers/net/dsa/lantiq_gswip.c+50 -291 reply
4/23net: dsa: lantiq_gswip: move definitions to headerdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+256 -2481 reply
5/23net: dsa: lantiq_gswip: introduce bitmaps for port typesdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+15 -31 reply
6/23net: dsa: lantiq_gswip: load model-specific microcodedrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h drivers/net/dsa/lantiq_pce.h+20 -125 replies
7/23net: dsa: lantiq_gswip: make DSA tag protocol model-specificdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+6 -11 reply
8/23net: dsa: lantiq_gswip: store switch API version in privdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+7 -71 reply
9/23net: dsa: lantiq_gswip: add support for SWAPI version 2.3drivers/net/dsa/lantiq_gswip.h+3 -02 replies
10/23net: dsa: lantiq_gswip: support enable/disable learningdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+27 -00 replies
11/23net: dsa: lantiq_gswip: support Energy Efficient Ethernetdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+60 -40 replies
12/23net: dsa: lantiq_gswip: support 4k VLANs on API 2.2 or laterdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+52 -253 replies
13/23net: dsa: lantiq_gswip: support model-specific mac_select_pcs()drivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+16 -00 replies
14/23net: dsa: lantiq_gswip: support GSW1xx offset of MII registerdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+13 -30 replies
15/23net: dsa: lantiq_gswip: allow adjusting MII delaysdrivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+34 -00 replies
16/23net: dsa: lantiq_gswip: support standard MDIO node namedrivers/net/dsa/lantiq_gswip.c+3 -00 replies
17/23net: dsa: lantiq_gswip: move MDIO bus registration to .setup()drivers/net/dsa/lantiq_gswip.c+7 -70 replies
18/23net: dsa: lantiq_gswip: convert to use regmapdrivers/net/dsa/Kconfig drivers/net/dsa/lantiq_gswip.c drivers/net/dsa/lantiq_gswip.h+114 -501 reply
19/23net: dsa: lantiq_gswip: split into common and MMIO partsdrivers/net/dsa/Kconfig drivers/net/dsa/Makefile drivers/net/dsa/lantiq_gswip.c +2 more+1815 -17610 replies
20/23net: dsa: lantiq_gswip: add registers specific for MaxLinear GSW1xxdrivers/net/dsa/lantiq_gswip.h+109 -02 replies
21/23net: dsa: add tagging driver for MaxLinear GSW1xx switch familyinclude/net/dsa.h net/dsa/Kconfig net/dsa/Makefile +1 more+152 -01 reply
22/23net: dsa: add driver for MaxLinear GSW1xx switch familydrivers/net/dsa/Kconfig drivers/net/dsa/Makefile drivers/net/dsa/mxl-gsw1xx.c +1 more+883 -04 replies
23/23net: dsa: lantiq_gswip: ignore SerDes modes in phylink_mac_config()drivers/net/dsa/lantiq_gswip_common.c+4 -00 replies

Reviews trailers per patch

5 of 23 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/23
2/23R-b
3/23R-b
4/23R-b
5/23
6/23
7/23R-b
8/23R-b
9/23
10/23
11/23
12/23
13/23
14/23
15/23
16/23
17/23
18/23
19/23
20/23
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC net-next 00/23] net: dsa: lantiq_gswip: Add support for MaxLinear GSW1xx switch family

This patch series extends the existing lantiq_gswip DSA driver to support the MaxLinear GSW1xx family of dedicated Ethernet switch ICs. These switches are based on the same IP as the Lantiq/Intel GSWIP found in VR9 and xRX MIPS router SoCs, but are connected via MDIO instead of memory-mapped I/O.

The series includes several improvements and refactoring to prepare for the new hardware support.

The GSW1xx family includes several variants:
- GSW120: 4 ports, 2 PHYs, RGMII & SGMII/2500Base-X
- GSW125: 4 ports, 2 PHYs, RGMII & SGMII/2500Base-X, industrial temperature
- GSW140: 6 ports, 4 PHYs, RGMII & SGMII/2500Base-X
- GSW141: 6 ports, 4 PHYs, RGMII & SGMII
- GSW145: 6 ports, 4 PHYs, RGMII & SGMII/2500Base-X, industrial temperature

Key features implemented:
- MDIO-based register access using regmap
- Support for SGMII/1000Base-X/2500Base-X SerDes interfaces
- Configurable MII delays via device tree properties
- Energy Efficient Ethernet (EEE) support
- 4096 VLAN support on newer API versions
- Assisted learning on CPU port

This is submitted as RFC to gather feedback on the approach, particularly regarding the prefered order of things, ie. should I first introduce all features (some are already supported on GRX3xx), then split into MDIO and common parts, then add new hardware like I did now, or rather first split into MDIO and common parts, then add new hardware support and then new features would follow (maybe even in follow series)?

Basic testing has be carried out on the GSW145 reference board, confirming everything works as fine as it does on older Lantiq GSWIP hardware. Brief testing also showed that nothing breaks on Lantiq VR9 (VRX208), testing on slightly newer Intel GRX330 hardware is going to follow.

As Vladimir Oltean is working on a series of patches improving lantiq_gswip the first patch of this series is likely to be replaced by his work and can be ignored for now. I've included it anyway for completeness as that is also what I have been testing.

Daniel Golle (23):
net: dsa: lantiq_gswip: honor dsa_db passed to port_fdb_{add,del}
net: dsa: lantiq_gswip: deduplicate dsa_switch_ops
net: dsa: lantiq_gswip: prepare for more CPU port options
net: dsa: lantiq_gswip: move definitions to header
net: dsa: lantiq_gswip: introduce bitmaps for port types
net: dsa: lantiq_gswip: load model-specific microcode
net: dsa: lantiq_gswip: make DSA tag protocol model-specific
net: dsa: lantiq_gswip: store switch API version in priv
net: dsa: lantiq_gswip: add support for SWAPI version 2.3
net: dsa: lantiq_gswip: support enable/disable learning
net: dsa: lantiq_gswip: support Energy Efficient Ethernet
net: dsa: lantiq_gswip: support 4k VLANs on API 2.2 or later
net: dsa: lantiq_gswip: support model-specific mac_select_pcs()
net: dsa: lantiq_gswip: support GSW1xx offset of MII register
net: dsa: lantiq_gswip: allow adjusting MII delays
net: dsa: lantiq_gswip: support standard MDIO node name
net: dsa: lantiq_gswip: move MDIO bus registration to .setup()
net: dsa: lantiq_gswip: convert to use regmap
net: dsa: lantiq_gswip: split into common and MMIO parts
net: dsa: lantiq_gswip: add registers specific for MaxLinear GSW1xx
net: dsa: add tagging driver for MaxLinear GSW1xx switch family
net: dsa: add driver for MaxLinear GSW1xx switch family
net: dsa: lantiq_gswip: ignore SerDes modes in phylink_mac_config()

 drivers/net/dsa/Kconfig               |   17 +
 drivers/net/dsa/Makefile              |    2 +
 drivers/net/dsa/lantiq_gswip.c        | 1933 ++-----------------------
 drivers/net/dsa/lantiq_gswip.h        |  408 ++++++
 drivers/net/dsa/lantiq_gswip_common.c | 1778 +++++++++++++++++++++++
 drivers/net/dsa/lantiq_pce.h          |    9 +-
 drivers/net/dsa/mxl-gsw1xx.c          |  710 +++++++++
 drivers/net/dsa/mxl-gsw1xx_pce.h      |  160 ++
 include/net/dsa.h                     |    2 +
 net/dsa/Kconfig                       |    8 +
 net/dsa/Makefile                      |    1 +
 net/dsa/tag_mxl-gsw1xx.c              |  141 ++
 12 files changed, 3331 insertions(+), 1838 deletions(-)
 create mode 100644 drivers/net/dsa/lantiq_gswip.h
 create mode 100644 drivers/net/dsa/lantiq_gswip_common.c
 create mode 100644 drivers/net/dsa/mxl-gsw1xx.c
 create mode 100644 drivers/net/dsa/mxl-gsw1xx_pce.h
 create mode 100644 net/dsa/tag_mxl-gsw1xx.c
Signature · 1 line
2.50.1