drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
Subsystems (5)
PATCH 1/1 drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
This dw_dp_video_need_vsc_sdp() function is type bool so returning -EINVAL means returning true. Return false instead.
--- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/dw-dp.c +1 -1
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) state =dw_dp_get_bridge_state (dp);if (!state) -return -EINVAL ; +return false;if (!link->vsc_sdp_supported)return false;
Signature · 1 line
2.47.2
Hello Dan,
Quoted 5 lines · Dan Carpenter
This
dw_dp_video_need_vsc_sdp()function is type bool so returning-EINVALmeans returning true. Return false instead.Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")Signed-off-by Dan Carpenter <[email protected]>
Quoted 19 lines
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/synopsys/dw-dp.c +1
-1@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) state =dw_dp_get_bridge_state (dp);if (!state) -return -EINVAL ; +return false;if (!link->vsc_sdp_supported)return false;Signature · 1 line
2.47.2
Quoted 4 lines · Andy Yan
Hello Dan,
At 2025-09-02 14:33:44, "Dan Carpenter" <[email protected]> wrote:
Quoted 9 lines
Quoted 5 lines
This
dw_dp_video_need_vsc_sdp()function is type bool so returning-EINVALmeans returning true. Return false instead.Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")Signed-off-by Dan Carpenter <[email protected]>Reviewed-by Andy Yan <[email protected]>
Ping?
regards,
dan carpenter
Quoted 20 lines
Quoted 20 lines
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/synopsys/dw-dp.c +1
-1@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) state =dw_dp_get_bridge_state (dp);if (!state) -return -EINVAL ; +return false;if (!link->vsc_sdp_supported)return false;Signature · 1 line
2.47.2
Ping again?
regards,
dan carpenter
Quoted 40 lines · Dan Carpenter
Quoted 4 lines · Andy Yan
Hello Dan,
At 2025-09-02 14:33:44, "Dan Carpenter" <[email protected]> wrote:
Quoted 9 lines
Quoted 5 lines
This
dw_dp_video_need_vsc_sdp()function is type bool so returning-EINVALmeans returning true. Return false instead.Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")Signed-off-by Dan Carpenter <[email protected]>Reviewed-by Andy Yan <[email protected]>Ping?
regards,
dan carpenterQuoted 20 lines
Quoted 20 lines
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/synopsys/dw-dp.c +1
-1@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) state =dw_dp_get_bridge_state (dp);if (!state) -return -EINVAL ; +return false;if (!link->vsc_sdp_supported)return false;Signature · 1 line
2.47.2