Skip to contentSkip to conversation

drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()

PATCH In review Dan Carpenter 2 participants 4 messages Sep 2, 2025 – Jan 22

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()

This dw_dp_video_need_vsc_sdp() function is type bool so returning -EINVAL means returning true. Return false instead.

Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/dw-dp.c +1 -1
index 9bbfe8da3de0..33be4eae2b20 100644
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
Signature · 1 line
2.47.2
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hello Dan,

Quoted 5 lines · Dan Carpenter

This dw_dp_video_need_vsc_sdp() function is type bool so returning -EINVAL means returning true. Return false instead.

Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Quoted 19 lines

---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/dw-dp.c +1 -1
index 9bbfe8da3de0..33be4eae2b20 100644
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
Signature · 1 line
2.47.2
#2 lore raw
Quoted 4 lines · Andy Yan

Hello Dan,

At 2025-09-02 14:33:44, "Dan Carpenter" <[email protected]> wrote:

Quoted 9 lines
Quoted 5 lines

This dw_dp_video_need_vsc_sdp() function is type bool so returning -EINVAL means returning true. Return false instead.

Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")

Ping?

regards,
dan carpenter

Quoted 20 lines
Quoted 20 lines

---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/dw-dp.c +1 -1
index 9bbfe8da3de0..33be4eae2b20 100644
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
Signature · 1 line
2.47.2
#3 lore raw

Ping again?

regards,
dan carpenter

Quoted 40 lines · Dan Carpenter
Quoted 4 lines · Andy Yan

Hello Dan,

At 2025-09-02 14:33:44, "Dan Carpenter" <[email protected]> wrote:

Quoted 9 lines
Quoted 5 lines

This dw_dp_video_need_vsc_sdp() function is type bool so returning -EINVAL means returning true. Return false instead.

Fixes 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")

Ping?

regards,
dan carpenter

Quoted 20 lines
Quoted 20 lines

---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/dw-dp.c +1 -1
index 9bbfe8da3de0..33be4eae2b20 100644
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
Signature · 1 line
2.47.2