Skip to contentSkip to conversation

perf test: Checking BPF metadata collection fails on version string

PATCH In review Thomas Richter 4 participants 4 messages Aug 22, 2025 – Sep 3, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: Checking BPF metadata collection fails on version string

commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:

 # perf version
 perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git
 #

and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.

Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.

Output before:

 # perf test -F 102
 Checking BPF metadata collection
 egrep: warning: egrep is obsolescent; using grep -E
 Basic BPF metadata test [Failed invalid output]
 102: BPF metadata collection test             : FAILED!
 #

Output after:

 # perf test -F 102
 Checking BPF metadata collection
 Basic BPF metadata test [Success]
 102: BPF metadata collection test             : Ok
 #
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")
Cc Blake Jones <[email protected]>
---
 tools/perf/tests/shell/test_bpf_metadata.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_bpf_metadata.sh +1 -1
index 69e3c2055134..be67d56e0f09 100755
@@ -61,7 +61,7 @@ test_bpf_metadata() {
 		/perf_version/ {
 			if (entry) print $NF;
 		}
-	' | egrep "$VERS" > /dev/null
+	' | grep -qF "$VERS"
 	then
 		echo "Basic BPF metadata test [Failed invalid output]"
 		err=1
Signature · 1 line
2.50.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines · Thomas Richter

commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:

 # perf version
 perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git
 #

and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.

Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.

Output before:

 # perf test -F 102
 Checking BPF metadata collection
 egrep: warning: egrep is obsolescent; using grep -E
 Basic BPF metadata test [Failed invalid output]
 102: BPF metadata collection test             : FAILED!
 #

Output after:

 # perf test -F 102
 Checking BPF metadata collection
 Basic BPF metadata test [Success]
 102: BPF metadata collection test             : Ok
 #
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")
Cc Blake Jones <[email protected]>

Thanks,
Ian

Quoted 21 lines
---
 tools/perf/tests/shell/test_bpf_metadata.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_bpf_metadata.sh +1 -2
index 69e3c2055134..be67d56e0f09 100755
@@ -61,7 +61,7 @@ test_bpf_metadata() {
                /perf_version/ {
                        if (entry) print $NF;
                }
-       ' | egrep "$VERS" > /dev/null
+       ' | grep -qF "$VERS"
        then
                echo "Basic BPF metadata test [Failed invalid output]"
                err=1
--

2.50.1

maintainer Reviewed-by
#2 lore raw
Quoted 16 lines · Ian Rogers
Quoted 15 lines · Thomas Richter

commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:

 # perf version
 perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git

and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.

Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.

<SNIP>

Quoted 6 lines
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")
Cc Blake Jones <[email protected]>

Namhyung, I think this should go into v6.17-rc.

Thanks,

- Arnaldo

maintainer
#3 lore raw
Quoted 25 lines · Arnaldo Carvalho de Melo
Quoted 16 lines · Ian Rogers
Quoted 15 lines · Thomas Richter

commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:

 # perf version
 perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git

and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.

Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.

<SNIP>

Quoted 4 lines
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")
Cc Blake Jones <[email protected]>
Quoted 5 lines
Quoted 1 line

Namhyung, I think this should go into v6.17-rc.

Sorry for the delay, will add.

Thanks,
Namhyung