perf test: Checking BPF metadata collection fails on version string
Subsystems (2)
PATCH 1/1 perf test: Checking BPF metadata collection fails on version string
commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")
fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:
# perf version perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git #
and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.
Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.
Output before:
# perf test -F 102 Checking BPF metadata collection egrep: warning: egrep is obsolescent; using grep -E Basic BPF metadata test [Failed invalid output] 102: BPF metadata collection test : FAILED! #
Output after:
# perf test -F 102 Checking BPF metadata collection Basic BPF metadata test [Success] 102: BPF metadata collection test : Ok #
--- tools/perf/tests/shell/test_bpf_metadata.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_bpf_metadata.sh +1 -1
@@ -61,7 +61,7 @@ test_bpf_metadata() { /perf_version/ { if (entry) print $NF; } - ' | egrep "$VERS" > /dev/null + ' | grep -qF "$VERS" then echo "Basic BPF metadata test [Failed invalid output]" err=1
Signature · 1 line
2.50.1
Quoted 33 lines · Thomas Richter
commit
edf2cadf01e8f("perf test: add test for BPF metadata collection")fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:
# perf version perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git #and the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.
Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.
Output before:
# perf test -F 102 Checking BPF metadata collection egrep: warning: egrep is obsolescent; using grep -E Basic BPF metadata test [Failed invalid output] 102: BPF metadata collection test : FAILED! #Output after:
# perf test -F 102 Checking BPF metadata collection Basic BPF metadata test [Success] 102: BPF metadata collection test : Ok #
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Blake Jones <[email protected]>
Thanks,
Ian
Quoted 21 lines
--- tools/perf/tests/shell/test_bpf_metadata.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/tests/shell/test_bpf_metadata.sh +1
-2@@ -61,7 +61,7 @@ test_bpf_metadata() { /perf_version/ { if (entry) print $NF; } - ' | egrep "$VERS" > /dev/null + ' | grep -qF "$VERS" then echo "Basic BPF metadata test [Failed invalid output]" err=1 --2.50.1
Quoted 16 lines · Ian Rogers
Quoted 15 lines · Thomas Richter
commit
edf2cadf01e8f("perf test: add test for BPF metadata collection")fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:
# perf version perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+gitand the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.
Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.
<SNIP>
Quoted 6 lines
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Blake Jones <[email protected]>Reviewed-by Ian Rogers <[email protected]>
Namhyung, I think this should go into v6.17-rc.
Thanks,
- Arnaldo
Namhyung Kim
maintainerQuoted 25 lines · Arnaldo Carvalho de Melo
Quoted 16 lines · Ian Rogers
Quoted 15 lines · Thomas Richter
commit
edf2cadf01e8f("perf test: add test for BPF metadata collection")fails consistently on the version string check. The perf version string on some of the constant integration test machines contains characters with special meaning in grep's extended regular expression matching algorithm. The output of perf version is:
# perf version perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+gitand the '+' character has special meaning in egrep command. Also the use of egrep is deprecated.
Change the perf version string check to fixed character matching and get rid of egrep's warning being deprecated. Use grep -F instead.
<SNIP>
Quoted 4 lines
Quoted 4 lines
Fixes edf2cadf01e8f ("perf test: add test for BPF metadata collection")Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Blake Jones <[email protected]>
Quoted 5 lines
Quoted 1 line
Reviewed-by Ian Rogers <[email protected]>Reviewed-by Arnaldo Carvalho de Melo <[email protected]>Namhyung, I think this should go into v6.17-rc.
Sorry for the delay, will add.
Thanks,
Namhyung