huge_memory: return -EINVAL in folio split functions when THP is disabled
Subsystems (2)
PATCH v3 1/1 huge_memory: return -EINVAL in folio split functions when THP is disabled
From: Pankaj Raghav <[email protected]>
split_huge_page_to_list_[to_order](), split_huge_page() and try_folio_split() return 0 on success and error codes on failure.
When THP is disabled, these functions return 0 indicating success even though an error code should be returned as it is not possible to split a folio when THP is disabled.
Make all these functions return -EINVAL to indicate failure instead of
0. As large folios depend on CONFIG_THP, issue warning as this function should not be called without a large folio.
---
Changes since v2:
- use page_folio(page) directly in VM_WARN_ON_ONCE_FOLIO
include/linux/huge_mm.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
include/linux/huge_mm.h +8 -4
@@ -553,22 +553,26 @@ static inline int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, unsigned int new_order) { - return 0; + VM_WARN_ON_ONCE_FOLIO(1, page_folio(page)); +return -EINVAL ; }static inline int split_huge_page (struct page *page) { -return 0 ; +VM_WARN_ON_ONCE_FOLIO (1 ,page_folio (page)); +return -EINVAL ; }static inline int split_folio_to_list (struct folio *folio,struct list_head *list) { -return 0 ; +VM_WARN_ON_ONCE_FOLIO (1 , folio); +return -EINVAL ; }static inline int try_folio_split (struct folio *folio,struct page *page,struct list_head *list) { -return 0 ; +VM_WARN_ON_ONCE_FOLIO (1 , folio); +return -EINVAL ; }static inline void deferred_split_folio (struct folio *folio,bool partially_mapped) {}
base-commit: e6b9dce0aeeb91dfc0974ab87f02454e24566182
Signature · 1 line
2.50.1
Quoted 2 lines · Pankaj Raghav (Samsung)
Changes since v2:
- usepage_folio(page)directly inVM_WARN_ON_ONCE_FOLIO
... why not use VM_WARN_ON_ONCE_PAGE?
Quoted 5 lines · Matthew Wilcox
Quoted 2 lines · Pankaj Raghav (Samsung)
Changes since v2:
- usepage_folio(page)directly inVM_WARN_ON_ONCE_FOLIO... why not use
VM_WARN_ON_ONCE_PAGE?
No idea how I missed that!
--
Pankaj
Barry Song
Reviewed-byQuoted 8 lines · Pankaj Raghav (Samsung)
Quoted 5 lines · Matthew Wilcox
Quoted 2 lines · Pankaj Raghav (Samsung)
Changes since v2:
- usepage_folio(page)directly inVM_WARN_ON_ONCE_FOLIO... why not use
VM_WARN_ON_ONCE_PAGE?No idea how I missed that!
With this,
Thanks
Barry