Skip to contentSkip to conversation

drm/amdgpu: make wb 256bit function names consistent

PATCH In review Alex Deucher 2 participants 2 messages Jul 27, 2017 – Jul 28, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: make wb 256bit function names consistent

Use a lower case b to be consistent with the other wb functions.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -1
index f364900..5f8d2e8 100644
@@ -1192,7 +1192,7 @@ struct amdgpu_wb {
 int amdgpu_wb_get(struct amdgpu_device *adev, u32 *wb);
 void amdgpu_wb_free(struct amdgpu_device *adev, u32 wb);
 int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb);
-int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb);
+int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb);
 void amdgpu_wb_free_64bit(struct amdgpu_device *adev, u32 wb);
 void amdgpu_wb_free_256bit(struct amdgpu_device *adev, u32 wb);
 
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 06c214f..41f6af3 100644
@@ -602,7 +602,7 @@ int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb)
 	}
 }
 
-int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb)
+int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb)
 {
 	int i = 0;
 	unsigned long offset = bitmap_find_next_zero_area_off(adev->wb.used,
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +1 -1
index 15b7149..3874be8 100644
@@ -213,7 +213,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
 	}
 
 	if (amdgpu_sriov_vf(adev) && ring->funcs->type == AMDGPU_RING_TYPE_GFX) {
-		r = amdgpu_wb_get_256Bit(adev, &ring->fence_offs);
+		r = amdgpu_wb_get_256bit(adev, &ring->fence_offs);
 		if (r) {
 			dev_err(adev->dev, "(%d) ring fence_offs wb alloc failed\n", r);
 			return r;
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1501188222-10241-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 27.07.2017 um 22:43 schrieb Alex Deucher:

Quoted 3 lines

Use a lower case b to be consistent with the other wb functions.

I still suggest to get rid of all those variants and always allocate 256bits, but anyway the patch is Reviewed-by: Christian König <[email protected]>.

Quoted 37 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 2 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c   | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -1
index f364900..5f8d2e8 100644
@@ -1192,7 +1192,7 @@ struct amdgpu_wb {
  int amdgpu_wb_get(struct amdgpu_device *adev, u32 *wb);
  void amdgpu_wb_free(struct amdgpu_device *adev, u32 wb);
  int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb);
-int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb);
+int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb);
  void amdgpu_wb_free_64bit(struct amdgpu_device *adev, u32 wb);
  void amdgpu_wb_free_256bit(struct amdgpu_device *adev, u32 wb);
 
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 06c214f..41f6af3 100644
@@ -602,7 +602,7 @@ int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb)
  	}
  }
 
-int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb)
+int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb)
  {
  	int i = 0;
  	unsigned long offset = bitmap_find_next_zero_area_off(adev->wb.used,
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +0 -0
index 15b7149..3874be8 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring, · line 219

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +1 -1
@@ -213,7 +213,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
  	}
 
  	if (amdgpu_sriov_vf(adev) && ring->funcs->type == AMDGPU_RING_TYPE_GFX) {
-		r = amdgpu_wb_get_256Bit(adev, &ring->fence_offs);
+		r = amdgpu_wb_get_256bit(adev, &ring->fence_offs);
  		if (r) {
  			dev_err(adev->dev, "(%d) ring fence_offs wb alloc failed\n", r);
  			return r;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx