drm/amdgpu: make wb 256bit function names consistent
Subsystems (2)
PATCH 1/1 drm/amdgpu: make wb 256bit function names consistent
Use a lower case b to be consistent with the other wb functions.
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -1
@@ -1192,7 +1192,7 @@ struct amdgpu_wb {int amdgpu_wb_get (struct amdgpu_device *adev,u32 *wb);void amdgpu_wb_free (struct amdgpu_device *adev,u32 wb);int amdgpu_wb_get_64bit (struct amdgpu_device *adev,u32 *wb); -int amdgpu_wb_get_256Bit (struct amdgpu_device *adev,u32 *wb); +int amdgpu_wb_get_256bit (struct amdgpu_device *adev,u32 *wb);void amdgpu_wb_free_64bit (struct amdgpu_device *adev,u32 wb);void amdgpu_wb_free_256bit (struct amdgpu_device *adev,u32 wb);
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -602,7 +602,7 @@ int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb) } } -int amdgpu_wb_get_256Bit (struct amdgpu_device *adev,u32 *wb) +int amdgpu_wb_get_256bit (struct amdgpu_device *adev,u32 *wb) {int i =0 ; unsigned long offset = bitmap_find_next_zero_area_off(adev->wb.used,
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +1 -1
@@ -213,7 +213,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring, }if (amdgpu_sriov_vf (adev) && ring->funcs->type ==AMDGPU_RING_TYPE_GFX ) { - r =amdgpu_wb_get_256Bit (adev, &ring->fence_offs); + r =amdgpu_wb_get_256bit (adev, &ring->fence_offs);if (r) {dev_err (adev->dev,"(%d) ring fence_offs wb alloc failed\n" , r);return r;
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1501188222-10241-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Am 27.07.2017 um 22:43 schrieb Alex Deucher:
Quoted 3 lines
Use a lower case b to be consistent with the other wb functions.
Signed-off-by Alex Deucher <[email protected]>
I still suggest to get rid of all those variants and always allocate 256bits, but anyway the patch is Reviewed-by: Christian König <[email protected]>.
Quoted 37 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu.h +1
-1@@ -1192,7 +1192,7 @@ struct amdgpu_wb {int amdgpu_wb_get (struct amdgpu_device *adev,u32 *wb);void amdgpu_wb_free (struct amdgpu_device *adev,u32 wb);int amdgpu_wb_get_64bit (struct amdgpu_device *adev,u32 *wb); -int amdgpu_wb_get_256Bit (struct amdgpu_device *adev,u32 *wb); +int amdgpu_wb_get_256bit (struct amdgpu_device *adev,u32 *wb);void amdgpu_wb_free_64bit (struct amdgpu_device *adev,u32 wb);void amdgpu_wb_free_256bit (struct amdgpu_device *adev,u32 wb);drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -602,7 +602,7 @@ int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb) } } -int amdgpu_wb_get_256Bit (struct amdgpu_device *adev,u32 *wb) +int amdgpu_wb_get_256bit (struct amdgpu_device *adev,u32 *wb) {int i =0 ; unsigned long offset = bitmap_find_next_zero_area_off(adev->wb.used,drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring, · line 219
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +1
-1@@ -213,7 +213,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring, }if (amdgpu_sriov_vf (adev) && ring->funcs->type ==AMDGPU_RING_TYPE_GFX ) { - r =amdgpu_wb_get_256Bit (adev, &ring->fence_offs); + r =amdgpu_wb_get_256bit (adev, &ring->fence_offs);if (r) {dev_err (adev->dev,"(%d) ring fence_offs wb alloc failed\n" , r);return r;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx