drm: Remove unused header in drm_dumb_buffers.c
Subsystems (2)
PATCH 1/1 drm: Remove unused header in drm_dumb_buffers.c
Remove the header #include "drm_internal.h" from drm_dumb_buffers.c, which is included but not used.
Header was introduced in 47f10854ca89 when moving functions, but was not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was removed.
Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.
--- drivers/gpu/drm/drm_dumb_buffers.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/drm_dumb_buffers.c +0 -1
@@ -32,7 +32,6 @@#include <drm/drm_print.h> #include "drm_crtc_internal.h" -#include "drm_internal.h" /** * DOC: overview
Signature · 1 line
2.53.0
Quoted 21 lines · Yicong Hui
Remove the header #include "
drm_internal.h" fromdrm_dumb_buffers.c, which is included but not used.Header was introduced in
47f10854ca89when moving functions, but was not removed in96a7b60f6ddbwhen thedrm_gem_dumb_destroyfunction was removed.Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.
Fixes 96a7b60f6ddb ("drm: remove dumb_destroy callback")Signed-off-by Yicong Hui <[email protected]>--- drivers/gpu/drm/drm_dumb_buffers.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/drm_dumb_buffers.c +0
-0
drivers/gpu/drm/drm_dumb_buffers.c line 37
Quoted 7 lines
drivers/gpu/drm/drm_dumb_buffers.c +0
-1@@ -32,7 +32,6 @@#include <drm/drm_print.h> #include "drm_crtc_internal.h" -#include "drm_internal.h" /** * DOC: overview
Hello!
Is there any further feedback or progress on this patch?
Thank you!
Yicong
Hi,
sorry for the delay.
Am 09.04.26 um 17:48 schrieb Yicong Hui:
Quoted 7 lines
Remove the header #include "
drm_internal.h" fromdrm_dumb_buffers.c, which is included but not used.Header was introduced in
47f10854ca89when moving functions, but was not removed in96a7b60f6ddbwhen thedrm_gem_dumb_destroyfunction was removed.
Quoted 5 lines
Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.
Fixes 96a7b60f6ddb ("drm: remove dumb_destroy callback")Signed-off-by Yicong Hui <[email protected]>
Quoted 16 lines
--- drivers/gpu/drm/drm_dumb_buffers.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/drm_dumb_buffers.c +0
-1@@ -32,7 +32,6 @@#include <drm/drm_print.h> #include "drm_crtc_internal.h" -#include "drm_internal.h" /** * DOC: overview
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)