Skip to contentSkip to conversation

drm: Remove unused header in drm_dumb_buffers.c

PATCH In review Yicong Hui 2 participants 3 messages Apr 9 – May 26

Subsystems (2)
lore
Share & tools
lore

Yicong Hui

author
#0 lore raw

PATCH 1/1 drm: Remove unused header in drm_dumb_buffers.c

Remove the header #include "drm_internal.h" from drm_dumb_buffers.c, which is included but not used.

Header was introduced in 47f10854ca89 when moving functions, but was not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was removed.

Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.

Fixes 96a7b60f6ddb ("drm: remove dumb_destroy callback")
---
 drivers/gpu/drm/drm_dumb_buffers.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/drm_dumb_buffers.c +0 -1
index e2b62e5fb891..61bf3c9b7182 100644
@@ -32,7 +32,6 @@
 #include <drm/drm_print.h>
 
 #include "drm_crtc_internal.h"
-#include "drm_internal.h"
 
 /**
  * DOC: overview
Signature · 1 line
2.53.0
#1 lore raw
Quoted 21 lines · Yicong Hui

Remove the header #include "drm_internal.h" from drm_dumb_buffers.c, which is included but not used.

Header was introduced in 47f10854ca89 when moving functions, but was not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was removed.

Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.

Fixes 96a7b60f6ddb ("drm: remove dumb_destroy callback")
---
  drivers/gpu/drm/drm_dumb_buffers.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/drm_dumb_buffers.c +0 -0
index e2b62e5fb891..61bf3c9b7182 100644

drivers/gpu/drm/drm_dumb_buffers.c line 37

Quoted 7 lines
drivers/gpu/drm/drm_dumb_buffers.c +0 -1
@@ -32,7 +32,6 @@
  #include <drm/drm_print.h>
 
  #include "drm_crtc_internal.h"
-#include "drm_internal.h"
 
  /**
   * DOC: overview

Hello!

Is there any further feedback or progress on this patch?

Thank you!
Yicong

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Yicong Hui

Hi,

sorry for the delay.

Am 09.04.26 um 17:48 schrieb Yicong Hui:

Quoted 7 lines

Remove the header #include "drm_internal.h" from drm_dumb_buffers.c, which is included but not used.

Header was introduced in 47f10854ca89 when moving functions, but was not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was removed.

Quoted 5 lines

Compiles successfully with DRM enabled, pass kunit tests and IGT-tests in a vng virtual machine.

Fixes 96a7b60f6ddb ("drm: remove dumb_destroy callback")
Quoted 16 lines
---
  drivers/gpu/drm/drm_dumb_buffers.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/drm_dumb_buffers.c +0 -1
index e2b62e5fb891..61bf3c9b7182 100644
@@ -32,7 +32,6 @@
  #include <drm/drm_print.h>
 
  #include "drm_crtc_internal.h"
-#include "drm_internal.h"
 
  /**
   * DOC: overview
Signature · 6 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)