media: atomisp: fix block comment formatting style
Subsystems (4)
PATCH v3 1/1 media: atomisp: fix block comment formatting style
Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.
--- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +6 -3
@@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,if (sizeof (*cur) !=sizeof (dvs2_coefs.grid) ||memcmp (&dvs2_coefs.grid, cur,sizeof (dvs2_coefs.grid))) {dev_err (asd->isp->dev,"dvs grid mismatch!\n" ); -/* If the grid info in the argument differs from the current -grid info, we tell the caller to reset the grid size and -try again. */ +/* +* If the grid info in the argument differs +* from the current grid info, we tell the +* caller to reset the grid size and try +* again. +*/ return -EAGAIN ; }
Signature · 1 line
2.55.0
Quoted 4 lines · Bohdan D. Marcus
Fix a block comment formatting warning reported by checkpatch.pl in
atomisp_cmd.cto conform to the Linux kernel coding style.
Almost the same comments as per v2. Please, slow down, read other comments and act accordingly.
Signature · 2 lines
With Best Regards, Andy Shevchenko
A message that is not in the archive (sent off-list or not yet received): CANqab03_SQFDb38wkXBMUiJ1Xk-g9_ZpqvOUo+nQyR+SsVnsFQ@mail.gmail.com
Hi Andy,
Thank you for the review.
You are completely right about the indentation and line wraps. Dan Carpenter also pointed this out to me yesterday, and I have already prepared a v4 that fixes all of these issues perfectly. I am strictly following the rule to wait a full 24 hours between sending versions, so I will send v4 later today.
Regarding your question about whether this is the only issue in the driver:
I understand that sending a patch for a single block comment in a 100k LoC driver is a very small contribution. Since this is my very first patch to the Linux kernel, my main goal was to learn the correct workflow (git send-email, formatting versions, acting on feedback) before sending larger patch series.
Once this v4 is accepted and I am confident that my setup is correct, my next step is to grep through the rest of atomisp to fix similar block comments and submit them as a proper patch series.
Thank you for your patience and for guiding a newcomer!
Regards,
Bohdan
Quoted 32 lines · Bohdan Derkach
Hi Andy,
Thank you for the review.
You are completely right about the indentation and line wraps. Dan Carpenter also pointed this out to me yesterday, and I have already prepared a v4 that fixes all of these issues perfectly. I am strictly following the rule to wait a full 24 hours between sending versions, so I will send v4 later today.
Regarding your question about whether this is the only issue in the driver:
I understand that sending a patch for a single block comment in a 100k LoC driver is a very small contribution. Since this is my very first patch to the Linux kernel, my main goal was to learn the correct workflow (git send-email, formatting versions, acting on feedback) before sending larger patch series.Once this v4 is accepted and I am confident that my setup is correct, my next step is to grep through the rest of atomisp to fix similar block comments and submit them as a proper patch series.
Thank you for your patience and for guiding a newcomer!
Regards,
BohdanQuoted 14 lines · Andy Shevchenko
Quoted 4 lines · Bohdan D. Marcus
Fix a block comment formatting warning reported by checkpatch.pl in
atomisp_cmd.cto conform to the Linux kernel coding style.Almost the same comments as per v2. Please, slow down, read other comments and act accordingly.
--
With Best Regards,
Andy Shevchenko
On Wed, Jul 01, 2026 at 11:51:43AM +0300, Bohdan Derkach wrote:
First of all, do not top-post!
Second, do not send HTML, the only plain text is what is considered.
Quoted 15 lines · Bohdan Derkach
Quoted 14 lines
You are completely right about the indentation and line wraps. Dan Carpenter also pointed this out to me yesterday, and I have already prepared a v4 that fixes all of these issues perfectly. I am strictly following the rule to wait a full 24 hours between sending versions, so I will send v4 later today.
Regarding your question about whether this is the only issue in the driver:
I understand that sending a patch for a single block comment in a 100k LoC driver is a very small contribution. Since this is my very first patch to the Linux kernel, my main goal was to learn the correct workflow (git send-email, formatting versions, acting on feedback) before sending larger patch series.
Quoted 3 lines
Quoted 3 lines
Once this v4 is accepted and I am confident that my setup is correct, my next step is to grep through the rest of atomisp to fix similar block comments and submit them as a proper patch series.
It really doesn't matter if this is a single place fix or not, the part of the process is to try to fix the whole class of the problems at once.
Also check that your code is based on latest and greatest maintainer's tip. (It's located somewhere on git.linuxtv.org with atomisp in the tree name.)
Quoted 1 line
Quoted 1 line
Thank you for your patience and for guiding a newcomer!
You're welcome.
Quoted 11 lines
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines
Quoted 4 lines · Bohdan D. Marcus
Fix a block comment formatting warning reported by checkpatch.pl in
atomisp_cmd.cto conform to the Linux kernel coding style.Almost the same comments as per v2. Please, slow down, read other comments and act accordingly.
Signature · 2 lines
With Best Regards, Andy Shevchenko