staging: xgifb: function definition argument should also have an identifier name
PATCH v3 1/1 staging: xgifb: function definition argument should also have an identifier name
function definition argument like 'struct vb_device_info *','unsigned long' etc. should also have an identifier name.
---
Changes in v2:
- By mistake one irrelevant line was added which is removed in this patch.
- write the changes done in previous version in correct format.
--- drivers/staging/xgifb/vb_setmode.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/staging/xgifb/vb_setmode.h +9 -9
@@ -1,14 +1,14 @@#ifndef _VBSETMODE_#define _VBSETMODE_ -void InitTo330Pointer (unsigned char ,struct vb_device_info *); -void XGI_UnLockCRT2 (struct vb_device_info *); -void XGI_LockCRT2 (struct vb_device_info *); -void XGI_DisplayOff (struct xgifb_video_info *, -struct xgi_hw_device_info *, -struct vb_device_info *); -void XGI_GetVBType (struct vb_device_info *); -void XGI_SenseCRT1 (struct vb_device_info *); +void InitTo330Pointer (unsigned char ChipType,struct vb_device_info *pVBInfo); +void XGI_UnLockCRT2 (struct vb_device_info *pVBInfo); +void XGI_LockCRT2 (struct vb_device_info *pVBInfo); +void XGI_DisplayOff (struct xgifb_video_info *xgifb_info, +struct xgi_hw_device_info *pXGIHWDE, +struct vb_device_info *pVBInfo); +void XGI_GetVBType (struct vb_device_info *pVBInfo); +void XGI_SenseCRT1 (struct vb_device_info *pVBInfo);unsigned char XGISetModeNew (struct xgifb_video_info *xgifb_info,struct xgi_hw_device_info *HwDeviceExtension,unsigned short ModeNo);
@@ -18,6 +18,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,unsigned short XGI_GetRatePtrCRT2 (struct xgi_hw_device_info *pXGIHWDE,unsigned short ModeNo,unsigned short ModeIdIndex, -struct vb_device_info *); +struct vb_device_info *pVBInfo);#endif
Signature · 1 line
2.11.0
Quoted 2 lines · Arushi Singhal
function definition argument like 'struct
vb_device_info*','unsigned long' etc. should also have an identifier name.
Actually, this is not really clear. The definition of a function is the thing that has the actual code, like
int foo(int x) {
return x;
}
What you are referring to is the prototype, ie
int foo(int);
What you want to say is that function prototypes should also have parameter names.
Quoted 8 lines
Signed-off-by Arushi Singhal <[email protected]>---
Changes in v2:
- By mistake one irrelevant line was added which is removed in this patch.
- write the changes done in previous version in correct format.
---
The second --- is not needed.
julia
Quoted 48 lines
drivers/staging/xgifb/vb_setmode.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)drivers/staging/xgifb/vb_setmode.h +9
-10@@ -1,14 +1,14 @@#ifndef _VBSETMODE_#define _VBSETMODE_ -void InitTo330Pointer (unsigned char ,struct vb_device_info *); -void XGI_UnLockCRT2 (struct vb_device_info *); -void XGI_LockCRT2 (struct vb_device_info *); -void XGI_DisplayOff (struct xgifb_video_info *, -struct xgi_hw_device_info *, -struct vb_device_info *); -void XGI_GetVBType (struct vb_device_info *); -void XGI_SenseCRT1 (struct vb_device_info *); +void InitTo330Pointer (unsigned char ChipType,struct vb_device_info *pVBInfo); +void XGI_UnLockCRT2 (struct vb_device_info *pVBInfo); +void XGI_LockCRT2 (struct vb_device_info *pVBInfo); +void XGI_DisplayOff (struct xgifb_video_info *xgifb_info, +struct xgi_hw_device_info *pXGIHWDE, +struct vb_device_info *pVBInfo); +void XGI_GetVBType (struct vb_device_info *pVBInfo); +void XGI_SenseCRT1 (struct vb_device_info *pVBInfo);unsigned char XGISetModeNew (struct xgifb_video_info *xgifb_info,struct xgi_hw_device_info *HwDeviceExtension,unsigned short ModeNo);@@ -18,6 +18,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,unsigned short XGI_GetRatePtrCRT2 (struct xgi_hw_device_info *pXGIHWDE,unsigned short ModeNo,unsigned short ModeIdIndex, -struct vb_device_info *); +struct vb_device_info *pVBInfo);#endif --2.11.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170222024823.GA25104%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.