staging: rts5208: Replace a bit shift by a use of BIT.
PATCH v2 1/1 staging: rts5208: Replace a bit shift by a use of BIT.
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
---
changes in v2
- remove the unnecessary parenthesis.
drivers/staging/rts5208/rtsx_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/rtsx_chip.c +2 -2
@@ -1490,7 +1490,7 @@ int rtsx_write_register(struct rtsx_chip *chip, u16 addr, u8 mask, u8 data)for (i =0 ; i <MAX_RW_REG_CNT ; i++) { val =rtsx_readl (chip,RTSX_HAIMR ); -if ((val & (1 <<31 )) ==0 ) { +if ((val &BIT (31 )) ==0 ) {if (data != (u8 )val) {rtsx_trace (chip);return STATUS_FAIL ;
@@ -1518,7 +1518,7 @@ int rtsx_read_register(struct rtsx_chip *chip, u16 addr, u8 *data)for (i =0 ; i <MAX_RW_REG_CNT ; i++) { val =rtsx_readl (chip,RTSX_HAIMR ); -if ((val & (1 <<31 )) ==0 ) +if ((val &BIT (31 )) ==0 )break ; }
Signature · 1 line
2.11.0
Quoted 10 lines · Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@-1 << c
+BIT(c)Signed-off-by Arushi Singhal <[email protected]>
Quoted 39 lines
---
changes in v2
- remove the unnecessary parenthesis.drivers/staging/rts5208/rtsx_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rts5208/rtsx_chip.c +2
-3@@ -1490,7 +1490,7 @@ int rtsx_write_register(struct rtsx_chip *chip, u16 addr, u8 mask, u8 data)for (i =0 ; i <MAX_RW_REG_CNT ; i++) { val =rtsx_readl (chip,RTSX_HAIMR ); -if ((val & (1 <<31 )) ==0 ) { +if ((val &BIT (31 )) ==0 ) {if (data != (u8 )val) {rtsx_trace (chip);return STATUS_FAIL ;@@ -1518,7 +1518,7 @@ int rtsx_read_register(struct rtsx_chip *chip, u16 addr, u8 *data)for (i =0 ; i <MAX_RW_REG_CNT ; i++) { val =rtsx_readl (chip,RTSX_HAIMR ); -if ((val & (1 <<31 )) ==0 ) +if ((val &BIT (31 )) ==0 )break ; } --2.11.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170322131757.GA5335%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.