Staging: vt6655: Remove an unused function
PATCH 1/1 Staging: vt6655: Remove an unused function
Remove an unused function to improve codebase.
--- drivers/staging/vt6655/mac.h | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/vt6655/mac.h +0 -2
@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvGetLongRetryLimit (struct vnt_private *priv, -unsigned char *pbyRetryLimit);void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode);
Signature · 1 line
2.17.1
Quoted 12 lines · Madhumitha Prabakaran
Remove an unused function to improve codebase.
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/mac.h | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vt6655/mac.h +0
-0
drivers/staging/vt6655/mac.h void MACvSetShortRetryLimit(struct vnt_private *priv, · line 891
Quoted 5 lines
drivers/staging/vt6655/mac.h +0
-2@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvGetLongRetryLimit (struct vnt_private *priv, -unsigned char *pbyRetryLimit);
This is the prototype of a function. Is there a definition somewhere? If so, it would be good to remove the definition at the same time.
julia
Quoted 13 lines
drivers/staging/vt6655/mac.h +0
-1void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Madhumitha Prabakaran
Remove an unused function to improve codebase.
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/mac.h | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vt6655/mac.h +0
-0@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
Quoted 22 lines
drivers/staging/vt6655/mac.h void MACvSetShortRetryLimit(struct vnt_private *priv, · line 891
Quoted 3 lines
drivers/staging/vt6655/mac.h +0
-2void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvGetLongRetryLimit (struct vnt_private *priv, -unsigned char *pbyRetryLimit);This is the prototype of a function. Is there a definition somewhere? If so, it would be good to remove the definition at the same time.
julia
Quoted 13 lines
drivers/staging/vt6655/mac.h +0
-1void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
There is no function definition in the code base. Do you I need to edit the commit log and resend it.
?
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Madhumitha Prabakaran
Remove an unused function to improve codebase.
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/mac.h | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vt6655/mac.h +0
-0@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
Quoted 22 lines
drivers/staging/vt6655/mac.h void MACvSetShortRetryLimit(struct vnt_private *priv, · line 891
Quoted 3 lines
drivers/staging/vt6655/mac.h +0
-2void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvGetLongRetryLimit (struct vnt_private *priv, -unsigned char *pbyRetryLimit);This is the prototype of a function. Is there a definition somewhere? If so, it would be good to remove the definition at the same time.
julia
Quoted 13 lines
drivers/staging/vt6655/mac.h +0
-1void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?
thanks,
madhumitha
Quoted 42 lines · Madhumthia Prabakaran
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Madhumitha Prabakaran
Remove an unused function to improve codebase.
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/mac.h | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vt6655/mac.h +0
-0@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);Quoted 22 lines
drivers/staging/vt6655/mac.h void MACvSetShortRetryLimit(struct vnt_private *priv, · line 891
Quoted 3 lines
drivers/staging/vt6655/mac.h +0
-2void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvGetLongRetryLimit (struct vnt_private *priv, -unsigned char *pbyRetryLimit);This is the prototype of a function. Is there a definition somewhere? If so, it would be good to remove the definition at the same time.
julia
Quoted 13 lines
drivers/staging/vt6655/mac.h +0
-1void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 1 line
Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?
Same file -> series
Different files -> separate patches are fine.
julia
Greg KH
maintainerQuoted 1 line · Madhumitha Prabakaran
Remove an unused function to improve codebase.
This should probably say something like:
Remove an unused function prototype as there is no such function in the kernel tree.
That's a better description of what this patch is doing, don't you agree?
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 1 line · Madhumitha Prabakaran
Remove an unused function to improve codebase.
This should probably say something like:
Remove an unused function prototype as there is no such function in the kernel tree.
Quoted 6 lines
That's a better description of what this patch is doing, don't you agree?
thanks,
greg k-h
Yes. Will update and resend it.
Thanks.