Staging: media: davinci_vpfe: Fix preferred form of passing a size
Subsystems (2)
PATCH v2 1/1 Staging: media: davinci_vpfe: Fix preferred form of passing a size
Fix perferred form of passing a size of a struct to improve readability and eradicate an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not.
--- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2 -4
@@ -1264,8 +1264,7 @@ static int ipipe_s_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; from = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); to = (void *)params + module_if->param_offset; size = module_if->param_size;
@@ -1306,8 +1305,7 @@ static int ipipe_g_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; to = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); from = (void *)params + module_if->param_offset; size = module_if->param_size;
Signature · 1 line
2.17.1
Quoted 4 lines · Madhumitha Prabakaran
Fix perferred form of passing a size of a struct to improve readability and eradicate an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not.
You need to say what is new in v2. You can make a v3 that explains that, and also fix up the spelling of preferred.
julia
Quoted 40 lines
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2
-5@@ -1264,8 +1264,7 @@ static int ipipe_s_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; from = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); to = (void *)params + module_if->param_offset; size = module_if->param_size;@@ -1306,8 +1305,7 @@ static int ipipe_g_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; to = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); from = (void *)params + module_if->param_offset; size = module_if->param_size; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190325145934.8467-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.