Staging: pi433: Fix line over 80 characters issue
PATCH v4 1/1 Staging: pi433: Fix line over 80 characters issue
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 characters
--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/pi433/rf69.c +2 -1
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag) {switch (flag) {case mode_switch_completed: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_MODE_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_MODE_READY );case ready_to_receive:return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RX_READY );case ready_to_send:
Signature · 1 line
2.7.4
Quoted 5 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>
Quoted 28 lines
--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/pi433/rf69.c +2
-2@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag) {switch (flag) {case mode_switch_completed: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_MODE_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_MODE_READY );case ready_to_receive:return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RX_READY );case ready_to_send: --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551607296-33723-1-git-send-email-idebleenasen%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 8 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
Quoted 10 lines · On Tue, 5 Mar 2019, 13:10 Greg KH, <[email protected]> wrote:
Quoted 8 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 9 lines
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
Will do.
Thnaks,
Debleena
Quoted 10 lines · Greg KH
Quoted 8 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 9 lines
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
I'm not able to find the commit.
I tried using "git reset --mixed e19b9ce" but it shows an error:
error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a commit
fatal: could not parse object 'e19b9ce'
How can I recover it so that I can add the changes?
Thank you,
Debleena
Greg KH
maintainerQuoted 24 lines · Debleena Sen
Quoted 10 lines · Greg KH
Quoted 8 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 9 lines
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
I'm not able to find the commit.
Quoted 7 lines
I tried using "git reset --mixed e19b9ce" but it shows an error:
error: object
e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9is a blob, not a commit
fatal: could not parse object 'e19b9ce'How can I recover it so that I can add the changes?
I have no idea what you are trying to do here, sorry. Why are you running 'git reset'?
confused,
greg k-h
Quoted 27 lines · Greg KH
Quoted 26 lines · Debleena Sen
Quoted 10 lines · Greg KH
Quoted 8 lines · Debleena Sen
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 9 lines
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
I'm not able to find the commit.
I tried using "git reset --mixed e19b9ce" but it shows an error:
Quoted 8 lines
Quoted 5 lines
error: object
e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9is a blob, not a commit
fatal: could not parse object 'e19b9ce'How can I recover it so that I can add the changes?
I have no idea what you are trying to do here, sorry. Why are you running 'git reset'?
If you get confused with git, just undo the whole thing and start over.
julia
Quoted 12 lines
confused,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306091544.GE7927%40kroah.com.
For more options, visit https://groups.google.com/d/optout.
A message that is not in the archive (sent off-list or not yet received): CACw+u4EWiZyqyYmuyK_5vMq+x5B-iB7-Z1JyeiT8_amOMyd3pQ@mail.gmail.com
PATCH v4 1/1 Staging: pi433: Fix line over 80 characters issue
---------- Forwarded message ---------
From: Debleena Sen <[email protected]>
Date: Wed, Mar 6, 2019 at 3:10 PM
Subject: Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <[email protected]>
Quoted 32 lines · Greg KH
Quoted 1 line · Debleena Sen
On Tue, Mar 5, 2019 at 1:10 PM Greg KH <[email protected]>
Quoted 29 lines · wrote:
Quoted 11 lines · Debleena Sen
Quoted 8 lines
Break the line and match the indentation to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 9 lines
What changed from the previous versions? That information always goes below the --- line please.
Please fix up and resend.
thanks,
greg k-h
I'm not able to find the commit.
I tried using "git reset --mixed e19b9ce" but it shows an error:
error: object
e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9is a blob, not a commit
fatal: could not parse object 'e19b9ce'
Quoted 9 lines
Quoted 1 line
How can I recover it so that I can add the changes?
I have no idea what you are trying to do here, sorry. Why are you running 'git reset'?
confused,
greg k-h
In the tutorial it was written to edit a commit we need to use git reset --mixed <file ID>
So I thought to use that.
It was my first patch probably. I already told you in another mail that there were like 16 warnings of the same type and same styling issue in pi433/rf69.c
So in this patch I had fixed only one warning. Yesterday I sent another patch in which I've fixed the other 15 warnings.
In the tutorial, it was written to edit a commit we need to use git reset --mixed <file ID>
So I thought to use that to add the version change log.
But when I tried it, this error popped.
I'm sorry. I think I've messed up.