Skip to contentSkip to conversation

fix odd_ptr_err.cocci warnings

PATCH In review Julia Lawall 4 participants 6 messages Aug 9, 2019 – Aug 20, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix odd_ptr_err.cocci warnings

From: kbuild test robot <[email protected]>

PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes 62c9c1442c8f ("j721e new machine driver wip")

---

tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip

:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

 j721e-evm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +2 -2
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
 		parent = devm_clk_get(&pdev->dev, clk_name);
 		kfree(clk_name);
 		if (IS_ERR(parent)) {
-			ret = PTR_ERR(clocks->parent);
+			ret = PTR_ERR(parent);
 			if (ret != -EPROBE_DEFER)
 				dev_err(&pdev->dev, "failed to acquire %s': %d\n",
 					prefix, ret);
@@ -299,7 +299,7 @@ static int j721e_get_clocks(struct platf
 		parent = devm_clk_get(&pdev->dev, clk_name);
 		kfree(clk_name);
 		if (IS_ERR(parent)) {
-			ret = PTR_ERR(clocks->parent);
+			ret = PTR_ERR(parent);
 			if (ret != -EPROBE_DEFER)
 				dev_err(&pdev->dev, "failed to acquire %s': %d\n",
 					prefix, ret);
maintainer
#1 lore raw

sound/soc/ti/j721e-evm.c static int j721e_get_clocks(struct platf

Quoted 12 lines · Julia Lawall
tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip

:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

 j721e-evm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +0 -0
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.

#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 6 lines · Julia Lawall
tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip

:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

Quoted 8 lines

sound/soc/ti/j721e-evm.c static int j721e_get_clocks(struct platf

Quoted 6 lines
 j721e-evm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +0 -0
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.

Yes, it is not upstream, but the fix is valid.

Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?

It mostly carries TI BSP stuff and my various for upstream branches nowdays.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

#3 lore raw
Quoted 20 lines · Peter Ujfalusi
Quoted 8 lines · Mark Brown
Quoted 6 lines · Julia Lawall
tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip

:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

Quoted 8 lines

sound/soc/ti/j721e-evm.c static int j721e_get_clocks(struct platf

Quoted 6 lines
 j721e-evm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +0 -0
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.

Quoted 6 lines

Yes, it is not upstream, but the fix is valid.

Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?

It mostly carries TI BSP stuff and my various for upstream branches nowdays.

Please discuss it with the kbuild people. They should be able to set it up as you want.

You can try [email protected]

julia

#4 lore raw

Hi Peter,

We have updated to only send the reports to you, please see https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio

Best Regards,
Rong Chen

Quoted 36 lines · Julia Lawall
Quoted 17 lines · Peter Ujfalusi
Quoted 8 lines · Mark Brown
Quoted 6 lines · Julia Lawall
tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip

:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

Quoted 7 lines

sound/soc/ti/j721e-evm.c static int j721e_get_clocks(struct platf

Quoted 6 lines
  j721e-evm.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +0 -0
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.

Quoted 6 lines

Yes, it is not upstream, but the fix is valid.

Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?

It mostly carries TI BSP stuff and my various for upstream branches nowdays.

Please discuss it with the kbuild people. They should be able to set it up as you want.

You can try [email protected]

julia
_______________________________________________
kbuild-all mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild-all

#5 lore raw

Hi Chen,

Quoted 4 lines · Rong Chen

Hi Peter,

We have updated to only send the reports to you, please see
https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio

Thank you very much!

Quoted 45 lines

Best Regards,
Rong Chen

Quoted 39 lines · Julia Lawall
Quoted 19 lines · Peter Ujfalusi
Quoted 10 lines · Mark Brown
Quoted 8 lines · Julia Lawall

tree:   https://github.com/omap-audio/linux-audio
peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

Quoted 7 lines

sound/soc/ti/j721e-evm.c static int j721e_get_clocks(struct platf

Quoted 6 lines

  j721e-evm.c |    4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/ti/j721e-evm.c +0 -0
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.

Quoted 7 lines

Yes, it is not upstream, but the fix is valid.

Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?

It mostly carries TI BSP stuff and my various for upstream branches nowdays.

Please discuss it with the kbuild people.  They should be able to set it up as you want.

You can try [email protected]

julia
_______________________________________________
kbuild-all mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild-all

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki