Skip to contentSkip to conversation

Staging: comedi: Remove wrapper function declarartion

PATCH In review Evan Chime 2 participants 6 messages Oct 23, 2019 – Oct 24, 2019 Staging

lore
Share & tools
lore

Evan Chime

author
#0 lore raw

PATCH 4/7 Staging: comedi: Remove wrapper function declarartion

Remove wrapper function "comedi_buf_map_put" declaration as part of remove all wrappers in drivers/staging/comedi/TODO

---
 drivers/staging/comedi/comedi_internal.h | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/comedi/comedi_internal.h +0 -2
index df3b1af109f7..73131e625fe5 100644
@@ -23,12 +23,10 @@ struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);
 void comedi_release_hardware_device(struct device *hardware_device);
 int comedi_alloc_subdevice_minor(struct comedi_subdevice *s);
 void comedi_free_subdevice_minor(struct comedi_subdevice *s);
-
 int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
 		     unsigned long new_size);
 void comedi_buf_reset(struct comedi_subdevice *s);
 bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
-int comedi_buf_map_put(struct comedi_buf_map *bm);
 int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
 			  void *buf, int len, int write);
 struct comedi_buf_map *comedi_buf_map_from_subdev_get(
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Evan Chime

Remove wrapper function "comedi_buf_map_put" declaration as part of remove all wrappers in drivers/staging/comedi/TODO

---
 drivers/staging/comedi/comedi_internal.h | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/comedi/comedi_internal.h +0 -0
index df3b1af109f7..73131e625fe5 100644

drivers/staging/comedi/comedi_internal.h struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device); · line 26

Quoted 4 lines
drivers/staging/comedi/comedi_internal.h +0 -1
@@ -23,12 +23,10 @@ struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);
 void comedi_release_hardware_device(struct device *hardware_device);
 int comedi_alloc_subdevice_minor(struct comedi_subdevice *s);
 void comedi_free_subdevice_minor(struct comedi_subdevice *s);
-

Removing this blank line is not relevant to your change.

drivers/staging/comedi/comedi_internal.h struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device); · line 31

Quoted 5 lines
drivers/staging/comedi/comedi_internal.h +0 -1
 int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
 		     unsigned long new_size);
 void comedi_buf_reset(struct comedi_subdevice *s);
 bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
-int comedi_buf_map_put(struct comedi_buf_map *bm);

It looks suspicious that you are removing a prototype here and calls afterwards. Does the kernel compile after you apply this patch and before you apply the remaining ones? The kernel should compile before and after every single patch, not before and after every series.

julia

Quoted 11 lines
drivers/staging/comedi/comedi_internal.h +0 -1
 int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
 			  void *buf, int len, int write);
 struct comedi_buf_map *comedi_buf_map_from_subdev_get(
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191023234427.GA4613%40ik-ubuntu.

author
#2 lore raw

Hello Julia

Thanks for the reply. I see what you mean, the kernel compiles when I make changes to three files, for each of two of the functions. The other function is static, so it compiles on a change of only one file

Please Julia, I’ve two questions:

A) So I should change three files for a function, then make a single commit, for that, and that will be a patch of the patch set, right?

B) I will now have three patches for this patch set, and as obviously the previous patch set won’t be accepted, so my next patch set submission, won’t be a patch set review( PATCH v2, 1,2,3,4,5,6,7/7) since I will be having only three patches now, right?. So I need to make a fresh patch set of three submission

You’re superstar

Kind regards

Evan

Quoted 57 lines · Julia Lawall

Review

Quoted 9 lines · Evan Chime

Remove wrapper function "comedi_buf_map_put" declaration as part of remove all wrappers in drivers/staging/comedi/TODO

---
 drivers/staging/comedi/comedi_internal.h | 2 --
 1 file changed, 2 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/comedi/comedi_internal.h

drivers/staging/comedi/comedi_internal.h struct comedi_device

Quoted 4 lines

index df3b1af109f7..73131e625fe5 100644

drivers/staging/comedi/comedi_internal.h +0 -0
@@ -23,12 +23,10 @@ struct comedi_device

*comedi_alloc_board_minor(struct device *hardware_device);

drivers/staging/comedi/comedi_internal.h struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device); · line 26

Quoted 4 lines
drivers/staging/comedi/comedi_internal.h +0 -1
 void comedi_release_hardware_device(struct device *hardware_device);
 int comedi_alloc_subdevice_minor(struct comedi_subdevice *s);
 void comedi_free_subdevice_minor(struct comedi_subdevice *s);
-

Removing this blank line is not relevant to your change.

drivers/staging/comedi/comedi_internal.h struct comedi_device · line 26

Quoted 1 line
drivers/staging/comedi/comedi_internal.h +0 -0
 int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice

*s,

drivers/staging/comedi/comedi_internal.h struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device); · line 31

Quoted 4 lines
drivers/staging/comedi/comedi_internal.h +0 -1
                   unsigned long new_size);
 void comedi_buf_reset(struct comedi_subdevice *s);
 bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
-int comedi_buf_map_put(struct comedi_buf_map *bm);

It looks suspicious that you are removing a prototype here and calls afterwards. Does the kernel compile after you apply this patch and before you apply the remaining ones? The kernel should compile before and after every single patch, not before and after every series.

julia

drivers/staging/comedi/comedi_internal.h struct comedi_device · line 30

Quoted 1 line
drivers/staging/comedi/comedi_internal.h +0 -0
 int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long

offset,

Quoted 7 lines
drivers/staging/comedi/comedi_internal.h +0 -1
                        void *buf, int len, int write);
 struct comedi_buf_map *comedi_buf_map_from_subdev_get(
--

2.17.1

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected].

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20191023234427.GA4613%40ik-ubuntu
.

Quoted 1 line
#3 lore raw
Quoted 9 lines · evan chime

Hello Julia

Thanks for the reply. I see what you mean, the kernel compiles when I make changes to three files, for each of two of the functions. The other function is static, so it compiles on a change of only one file

Quoted 4 lines

Please Julia, I’ve two questions:

A) So I should change three files for a function, then make a single commit, for that, and that will be a patch of the patch set, right?

You can do as you like. For example, you could have one commit for all of the uses in a given file, and then one commit for the definition and the header. Or you could do as you propose - just adjust everything in a single commit. In this case, where there are a small number of uses and all of the patches go to the same people, the second solution may be simpler. In a more general vase, where the uses are all across the kernel, the first approach could be better.

Quoted 7 lines

B) I will now have three patches for this patch set, and as obviously the previous patch set won’t be accepted, so my next patch set submission, won’t be a patch set review( PATCH v2, 1,2,3,4,5,6,7/7) since I will be having only three patches now, right?. So I need to make a fresh patch set of three submission

No, it's a v2. Greg needs to ignore the first set of patches and take this one instead.

julia

Quoted 80 lines

You’re superstar

Kind regards

Evan

On Thu, 24 Oct 2019 at 05:47, Julia Lawall <[email protected]> wrote:

      On Thu, 24 Oct 2019, Evan Chime wrote:

      > Remove wrapper function "comedi_buf_map_put" declaration
      > as part of remove all wrappers in drivers/staging/comedi/TODO
      >
      > Signed-off-by: Evan Chime <[email protected]>
      > ---
      >  drivers/staging/comedi/comedi_internal.h | 2 --
      >  1 file changed, 2 deletions(-)
      >
      > diff --git a/drivers/staging/comedi/comedi_internal.h
      b/drivers/staging/comedi/comedi_internal.h
      > index df3b1af109f7..73131e625fe5 100644
      > --- a/drivers/staging/comedi/comedi_internal.h
      > +++ b/drivers/staging/comedi/comedi_internal.h
      > @@ -23,12 +23,10 @@ struct comedi_device
      *comedi_alloc_board_minor(struct device *hardware_device);
      >  void comedi_release_hardware_device(struct device
      *hardware_device);
      >  int comedi_alloc_subdevice_minor(struct comedi_subdevice *s);
      >  void comedi_free_subdevice_minor(struct comedi_subdevice *s);
      > -

      Removing this blank line is not relevant to your change.

      >  int comedi_buf_alloc(struct comedi_device *dev, struct
      comedi_subdevice *s,
      >                    unsigned long new_size);
      >  void comedi_buf_reset(struct comedi_subdevice *s);
      >  bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
      > -int comedi_buf_map_put(struct comedi_buf_map *bm);

      It looks suspicious that you are removing a prototype here and
      calls
      afterwards.  Does the kernel compile after you apply this patch
      and before
      you apply the remaining ones?  The kernel should compile before
      and after
      every single patch, not before and after every series.

      julia

      >  int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned
      long offset,
      >                         void *buf, int len, int write);
      >  struct comedi_buf_map *comedi_buf_map_from_subdev_get(
      > --
      > 2.17.1
      >
      > --
      > You received this message because you are subscribed to the
      Google Groups "outreachy-kernel" group.
      > To unsubscribe from this group and stop receiving emails from
      it, send an email to
      [email protected].
      > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20191023234427.GA4613%40
      ik-ubuntu.
      >

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jZA3yy124EDWogZkVo qtRKmx-0%2BnpxP6%3D_%3DyTcmTmHKLw%40mail.gmail.com.

author
#4 lore raw

Cheers mate

Quoted 136 lines · Julia Lawall
Quoted 5 lines · evan chime

Hello Julia

Thanks for the reply. I see what you mean, the kernel compiles when I

make

Quoted 1 line

changes to three files, for each of two of the functions. The other

function

Quoted 6 lines

is static, so it compiles on a change of only one file

Please Julia, I’ve two questions:

A) So I should change three files for a function, then make a single

commit,

Quoted 1 line

for that, and that will be a patch of the patch set, right?

You can do as you like. For example, you could have one commit for all of the uses in a given file, and then one commit for the definition and the header. Or you could do as you propose - just adjust everything in a single commit. In this case, where there are a small number of uses and all of the patches go to the same people, the second solution may be simpler. In a more general vase, where the uses are all across the kernel, the first approach could be better.

Quoted 4 lines

B) I will now have three patches for this patch set, and as obviously the previous patch set won’t be accepted, so my next patch set submission,

won’t

Quoted 2 lines

be a patch set review( PATCH v2, 1,2,3,4,5,6,7/7) since I will be having only three patches now, right?. So I need to make a fresh patch set of

three

Quoted 1 line

submission

No, it's a v2. Greg needs to ignore the first set of patches and take this one instead.

julia

Quoted 54 lines

You’re superstar

Kind regards

Evan

On Thu, 24 Oct 2019 at 05:47, Julia Lawall <[email protected]> wrote:

On Thu, 24 Oct 2019, Evan Chime wrote:

> Remove wrapper function "comedi_buf_map_put" declaration > as part of remove all wrappers in drivers/staging/comedi/TODO >
> Signed-off-by: Evan Chime <[email protected]> > ---
> drivers/staging/comedi/comedi_internal.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
> index df3b1af109f7..73131e625fe5 100644
> --- a/drivers/staging/comedi/comedi_internal.h
> +++ b/drivers/staging/comedi/comedi_internal.h
> @@ -23,12 +23,10 @@ struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device); > void comedi_release_hardware_device(struct device *hardware_device);
> int comedi_alloc_subdevice_minor(struct comedi_subdevice *s); > void comedi_free_subdevice_minor(struct comedi_subdevice *s); > -

Removing this blank line is not relevant to your change.

> int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
> unsigned long new_size);
> void comedi_buf_reset(struct comedi_subdevice *s); > bool comedi_buf_is_mmapped(struct comedi_subdevice *s); > -int comedi_buf_map_put(struct comedi_buf_map *bm);

It looks suspicious that you are removing a prototype here and calls
afterwards. Does the kernel compile after you apply this patch and before
you apply the remaining ones? The kernel should compile before and after
every single patch, not before and after every series.

julia

Quoted 14 lines

> int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
> void *buf, int len, int write);
> struct comedi_buf_map *comedi_buf_map_from_subdev_get( > --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/20191023234427.GA4613%40

Quoted 9 lines
      ik-ubuntu.
      >

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/CANR89jZA3yy124EDWogZkVo

Quoted 3 lines

qtRKmx-0%2BnpxP6%3D_%3DyTcmTmHKLw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910240951390.4479%40hadrien
.

#5 lore raw
Quoted 1 line · evan chime

Cheers mate

Please don't top post.

julia

Quoted 168 lines · Julia Lawall

On Thu, 24 Oct 2019, evan chime wrote:

>
> Hello Julia
>
>
> Thanks for the reply. I see what you mean, the kernel compiles when I make
> changes to three files, for each of two of the functions. The other function
> is static, so it compiles on a change of only one file >
>
> Please Julia, I’ve two questions:
>
> A) So I should change three files for a function, then make a single commit,
> for that, and that will be a patch of the patch set, right?

You can do as you like.  For example, you could have one commit for all of
the uses in a given file, and then one commit for the definition and the
header.  Or you could do as you propose - just adjust everything in a
single commit.  In this case, where there are a small number of uses and
all of the patches go to the same people, the second solution may be
simpler.  In a more general vase, where the uses are all across the
kernel, the first approach could be better.

>
>
> B) I will now have three patches for this patch set, and as obviously the
> previous patch set won’t be accepted, so my next patch set submission, won’t
> be a patch set review( PATCH v2, 1,2,3,4,5,6,7/7) since I will be having
> only three patches now, right?. So I need to make a fresh patch set of three
> submission

No, it's a v2.  Greg needs to ignore the first set of patches and take
this one instead.

julia

>
> You’re superstar
>
>
> Kind regards
>
> Evan
>
>
> On Thu, 24 Oct 2019 at 05:47, Julia Lawall
<[email protected]> wrote:
>
>
>       On Thu, 24 Oct 2019, Evan Chime wrote:
>
>       > Remove wrapper function "comedi_buf_map_put"
declaration
>       > as part of remove all wrappers in
drivers/staging/comedi/TODO
>       >
>       > Signed-off-by: Evan Chime
<[email protected]>
>       > ---
>       >  drivers/staging/comedi/comedi_internal.h | 2 --
>       >  1 file changed, 2 deletions(-)
>       >
>       > diff --git a/drivers/staging/comedi/comedi_internal.h
>       b/drivers/staging/comedi/comedi_internal.h
>       > index df3b1af109f7..73131e625fe5 100644
>       > --- a/drivers/staging/comedi/comedi_internal.h
>       > +++ b/drivers/staging/comedi/comedi_internal.h
>       > @@ -23,12 +23,10 @@ struct comedi_device
>       *comedi_alloc_board_minor(struct device
*hardware_device);
>       >  void comedi_release_hardware_device(struct device
>       *hardware_device);
>       >  int comedi_alloc_subdevice_minor(struct
comedi_subdevice *s);
>       >  void comedi_free_subdevice_minor(struct
comedi_subdevice *s);
>       > -
>
>       Removing this blank line is not relevant to your change.
>
>       >  int comedi_buf_alloc(struct comedi_device *dev,
struct
>       comedi_subdevice *s,
>       >                    unsigned long new_size);
>       >  void comedi_buf_reset(struct comedi_subdevice *s);
>       >  bool comedi_buf_is_mmapped(struct comedi_subdevice
*s);
>       > -int comedi_buf_map_put(struct comedi_buf_map *bm);
>
>       It looks suspicious that you are removing a prototype
here and
>       calls
>       afterwards.  Does the kernel compile after you apply
this patch
>       and before
>       you apply the remaining ones?  The kernel should compile
before
>       and after
>       every single patch, not before and after every series.
>
>       julia
>
>       >  int comedi_buf_map_access(struct comedi_buf_map *bm,
unsigned
>       long offset,
>       >                         void *buf, int len, int
write);
>       >  struct comedi_buf_map
*comedi_buf_map_from_subdev_get(
>       > --
>       > 2.17.1
>       >
>       > --
>       > You received this message because you are subscribed
to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving
emails from
>       it, send an email to
>       [email protected].
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20191023234427.GA46 13%40
>       ik-ubuntu.
>       >
>
> --
> You received this message because you are subscribed to the
Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
it, send an
> email to [email protected].
> To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jZA3yy124EDWo gZkVo
> qtRKmx-0%2BnpxP6%3D_%3DyTcmTmHKLw%40mail.gmail.com.
>
>

--
You received this message because you are subscribed to the
Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to
[email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19102409 51390.4479%40hadrien.