staging: comedi: dt2801: remove old unused code
PATCH v3 1/1 staging: comedi: dt2801: remove old unused code
There are two #if 0 blocks that have no recent history of any change. Remove those code blocks for improved readability of the code.
---
Changes in V3:
- moved patch revision comments for v2 into this area
Changes in V2:
- Removed extra spaces after colon in patch description
--- drivers/staging/comedi/drivers/dt2801.c | 22 ---------------------- 1 file changed, 22 deletions(-)
drivers/staging/comedi/drivers/dt2801.c +0 -22
@@ -87,17 +87,6 @@#define DT2801_STATUS 1#define DT2801_CMD 1 -#if 0 -/* ignore 'defined but not used' warning */ -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = { -4 , { -BIP_RANGE (10 ), -BIP_RANGE (5 ), -BIP_RANGE (2.5 ), -BIP_RANGE (1.25 ) - } -}; -#endif static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {4 , {BIP_RANGE (10 ),
@@ -107,17 +96,6 @@ static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = { } }; -#if 0 -/* ignore 'defined but not used' warning */ -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar = { -4 , { -UNI_RANGE (10 ), -UNI_RANGE (5 ), -UNI_RANGE (2.5 ), -UNI_RANGE (1.25 ) - } -}; -#endif static const struct comedi_lrange range_dt2801_ai_pgl_unipolar = {4 , {UNI_RANGE (10 ),
Signature · 1 line
2.17.1
Quoted 10 lines · Deepak R Varma
There are two #if 0 blocks that have no recent history of any change. Remove those code blocks for improved readability of the code.
Signed-off-by Deepak R Varma <[email protected]>---
Changes in V3:
- moved patch revision comments for v2 into this area
Changes in V2:
- Removed extra spaces after colon in patch description
---
It doesn't hurt anything, but you don't need this ---
julia
Greg KH
maintainerQuoted 22 lines · Deepak R Varma
There are two #if 0 blocks that have no recent history of any change. Remove those code blocks for improved readability of the code.
Signed-off-by Deepak R Varma <[email protected]>---
Changes in V3:
- moved patch revision comments for v2 into this area
Changes in V2:
- Removed extra spaces after colon in patch description--- drivers/staging/comedi/drivers/dt2801.c | 22 ---------------------- 1 file changed, 22 deletions(-)drivers/staging/comedi/drivers/dt2801.c +0
-1@@ -87,17 +87,6 @@#define DT2801_STATUS 1#define DT2801_CMD 1 -#if 0
drivers/staging/comedi/drivers/dt2801.c line 100
Quoted 10 lines
drivers/staging/comedi/drivers/dt2801.c +0
-10-/* ignore 'defined but not used' warning */ -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = { -4 , { -BIP_RANGE (10 ), -BIP_RANGE (5 ), -BIP_RANGE (2.5 ), -BIP_RANGE (1.25 ) - } -}; -#endif
These should be left alone, as they document hardware that doesn't happen to be supported at the moment.
thanks,
greg k-h