staging/rtl8192e: replace kmalloc with kzalloc
PATCH 1/1 staging/rtl8192e: replace kmalloc with kzalloc
kmalloc() and memset() calls can be replaced with kzalloc(). Found with Coccinelle.
--- drivers/staging/rtl8192e/rtllib_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8192e/rtllib_tx.c +1 -3
@@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,struct rtllib_txb *txb;int i; - txb =kmalloc (sizeof (struct rtllib_txb ) + (sizeof (u8 *) * nr_frags), - gfp_mask); + txb =kzalloc (sizeof (*txb) + (sizeof (u8 *) * nr_frags), gfp_mask);if (!txb)return NULL ; -memset (txb,0 ,sizeof (struct rtllib_txb )); txb->nr_frags = nr_frags; txb->frag_size =cpu_to_le16 (txb_size);
Signature · 1 line
2.25.1
Quoted 1 line · Elena Afanasova
kmalloc()andmemset()calls can be replaced withkzalloc().
It would be nice to say why the change is correct.
julia
Quoted 33 lines
Found with Coccinelle.
Signed-off-by Elena Afanasova <[email protected]>--- drivers/staging/rtl8192e/rtllib_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/rtl8192e/rtllib_tx.c +1
-4@@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,struct rtllib_txb *txb;int i; - txb =kmalloc (sizeof (struct rtllib_txb ) + (sizeof (u8 *) * nr_frags), - gfp_mask); + txb =kzalloc (sizeof (*txb) + (sizeof (u8 *) * nr_frags), gfp_mask);if (!txb)return NULL ; -memset (txb,0 ,sizeof (struct rtllib_txb )); txb->nr_frags = nr_frags; txb->frag_size =cpu_to_le16 (txb_size); --2.25.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201023100317.4473-1-eafanasova%40gmail.com.
drivers/staging/rtl8192e/rtllib_tx.c static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size, · line 208
Quoted 3 lines · Elena Afanasova
drivers/staging/rtl8192e/rtllib_tx.c +1
-2- txb =kmalloc (sizeof (struct rtllib_txb ) + (sizeof (u8 *) * nr_frags), - gfp_mask); + txb =kzalloc (sizeof (*txb) + (sizeof (u8 *) * nr_frags), gfp_mask);
This would be a good opportunity to use struct_size().