Skip to contentSkip to conversation

use weak assignments for PNBLACKLIST in recipe files

PATCH In review Robert P. J. Day 2 participants 5 messages May 25, 2020 – May 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use weak assignments for PNBLACKLIST in recipe files

Make sure PNBLACKLIST assignments in recipe files use weak assignment, so they can be overridden in, for example, local.conf files.

---

meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb +1 -1
index c39faef8d..eee96d865 100644
@@ -69,4 +69,4 @@ RDEPENDS_${PN}-server += "tcp-wrappers xinetd rpcbind"
 
 # http://errors.yoctoproject.org/Errors/Details/186962/
 COMPATIBLE_HOST_libc-musl = 'null'
-PNBLACKLIST[netkit-rusers] = "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
+PNBLACKLIST[netkit-rusers] ?= "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb +1 -1
index 23fe2021b..c296c3bc1 100644
@@ -22,4 +22,4 @@ do_install () {
     oe_runmake install DESTDIR="${D}"
 }
 
-PNBLACKLIST[drbd] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[drbd] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +1 -1
index 5917cfb3e..4a1bbe620 100644
@@ -36,4 +36,4 @@ FILES_${PN}-dbg += "${libexecdir}/lowpan-tools/.debug/"
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${libdir}/python*"
 
-PNBLACKLIST[lowpan-tools] = "WARNING these tools are deprecated! Use wpan-tools instead"
+PNBLACKLIST[lowpan-tools] ?= "WARNING these tools are deprecated! Use wpan-tools instead"
meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb +1 -1
index 21d110aee..2e3da7d4d 100644
@@ -27,4 +27,4 @@ RDEPENDS_${PN} += "\
 
 BBCLASSEXTEND = "native nativesdk"
 
-PNBLACKLIST[nanopb] = "Needs forward porting to use python3"
+PNBLACKLIST[nanopb] ?= "Needs forward porting to use python3"
meta-oe/recipes-extended/socketcan/can-isotp_git.bb +1 -1
index e40e1cd26..eca8dfc7b 100644
@@ -11,4 +11,4 @@ inherit module
 
 EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"
 
-PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[can-isotp] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-oe/recipes-kernel/bpftool/bpftool.bb +1 -1
index 6683eccf2..1758430bc 100644
@@ -32,4 +32,4 @@ python do_package_prepend() {
 }
 
 B = "${WORKDIR}/${BPN}-${PV}"
-PNBLACKLIST[bpftool] = "Needs forward porting to kernel 5.2+"
+PNBLACKLIST[bpftool] ?= "Needs forward porting to kernel 5.2+"
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 4 lines · Robert P. J. Day

Make sure PNBLACKLIST assignments in recipe files use weak assignment, so they can be overridden in, for example, local.conf files.

I would like contributions here when someone fixes one of the blacklisted recipes. This patch will let downstream users host it in bbappends or other places
what is the intended use of this patch?

Quoted 75 lines

---

meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb +1 -1
index c39faef8d..eee96d865 100644
@@ -69,4 +69,4 @@ RDEPENDS_${PN}-server += "tcp-wrappers xinetd rpcbind"
 
 # http://errors.yoctoproject.org/Errors/Details/186962/
 COMPATIBLE_HOST_libc-musl = 'null'
-PNBLACKLIST[netkit-rusers] = "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
+PNBLACKLIST[netkit-rusers] ?= "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb +1 -1
index 23fe2021b..c296c3bc1 100644
@@ -22,4 +22,4 @@ do_install () {
     oe_runmake install DESTDIR="${D}"
 }
 
-PNBLACKLIST[drbd] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[drbd] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +1 -1
index 5917cfb3e..4a1bbe620 100644
@@ -36,4 +36,4 @@ FILES_${PN}-dbg += "${libexecdir}/lowpan-tools/.debug/"
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${libdir}/python*"
 
-PNBLACKLIST[lowpan-tools] = "WARNING these tools are deprecated! Use wpan-tools instead"
+PNBLACKLIST[lowpan-tools] ?= "WARNING these tools are deprecated! Use wpan-tools instead"
meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb +1 -1
index 21d110aee..2e3da7d4d 100644
@@ -27,4 +27,4 @@ RDEPENDS_${PN} += "\
 
 BBCLASSEXTEND = "native nativesdk"
 
-PNBLACKLIST[nanopb] = "Needs forward porting to use python3"
+PNBLACKLIST[nanopb] ?= "Needs forward porting to use python3"
meta-oe/recipes-extended/socketcan/can-isotp_git.bb +1 -1
index e40e1cd26..eca8dfc7b 100644
@@ -11,4 +11,4 @@ inherit module
 
 EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"
 
-PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[can-isotp] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-oe/recipes-kernel/bpftool/bpftool.bb +1 -2
index 6683eccf2..1758430bc 100644
@@ -32,4 +32,4 @@ python do_package_prepend() {
 }
 
 B = "${WORKDIR}/${BPN}-${PV}"
-PNBLACKLIST[bpftool] = "Needs forward porting to kernel 5.2+"
+PNBLACKLIST[bpftool] ?= "Needs forward porting to kernel 5.2+"
 
--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

#2 lore raw
Quoted 10 lines · Khem Raj
Quoted 5 lines · Robert P. J. Day

Make sure PNBLACKLIST assignments in recipe files use weak assignment, so they can be overridden in, for example, local.conf files.

I would like contributions here when someone fixes one of the blacklisted recipes. This patch will let downstream users host it in bbappends or other places what is the intended use of this patch?

i'm not sure what you're asking for here ... there is no claim that
any of these recipes have been fixed in any way, only that weak assignment seems to be the default for blacklisting to at least allow for the possibility of overriding.

Quoted 73 lines
Quoted 72 lines
meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb +1 -1
index c39faef8d..eee96d865 100644
@@ -69,4 +69,4 @@ RDEPENDS_${PN}-server += "tcp-wrappers xinetd rpcbind"
 
 # http://errors.yoctoproject.org/Errors/Details/186962/
 COMPATIBLE_HOST_libc-musl = 'null'
-PNBLACKLIST[netkit-rusers] = "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
+PNBLACKLIST[netkit-rusers] ?= "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory"
meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb +1 -1
index 23fe2021b..c296c3bc1 100644
@@ -22,4 +22,4 @@ do_install () {
     oe_runmake install DESTDIR="${D}"
 }
 
-PNBLACKLIST[drbd] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[drbd] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +1 -1
index 5917cfb3e..4a1bbe620 100644
@@ -36,4 +36,4 @@ FILES_${PN}-dbg += "${libexecdir}/lowpan-tools/.debug/"
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${libdir}/python*"
 
-PNBLACKLIST[lowpan-tools] = "WARNING these tools are deprecated! Use wpan-tools instead"
+PNBLACKLIST[lowpan-tools] ?= "WARNING these tools are deprecated! Use wpan-tools instead"
meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb +1 -1
index 21d110aee..2e3da7d4d 100644
@@ -27,4 +27,4 @@ RDEPENDS_${PN} += "\
 
 BBCLASSEXTEND = "native nativesdk"
 
-PNBLACKLIST[nanopb] = "Needs forward porting to use python3"
+PNBLACKLIST[nanopb] ?= "Needs forward porting to use python3"
meta-oe/recipes-extended/socketcan/can-isotp_git.bb +1 -1
index e40e1cd26..eca8dfc7b 100644
@@ -11,4 +11,4 @@ inherit module
 
 EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"
 
-PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"
+PNBLACKLIST[can-isotp] ?= "Kernel module Needs forward porting to kernel 5.2+"
meta-oe/recipes-kernel/bpftool/bpftool.bb +1 -2
index 6683eccf2..1758430bc 100644
@@ -32,4 +32,4 @@ python do_package_prepend() {
 }
 
 B = "${WORKDIR}/${BPN}-${PV}"
-PNBLACKLIST[bpftool] = "Needs forward porting to kernel 5.2+"
+PNBLACKLIST[bpftool] ?= "Needs forward porting to kernel 5.2+"
 
--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw
Quoted 10 lines · Robert P. J. Day
Quoted 1 line · Khem Raj

On Mon, May 25, 2020 at 12:21 PM Robert P. J. Day <[email protected]>

Quoted 6 lines · wrote:
Quoted 5 lines

Make sure PNBLACKLIST assignments in recipe files use weak assignment, so they can be overridden in, for example, local.conf files.

Quoted 9 lines
Quoted 3 lines

I would like contributions here when someone fixes one of the blacklisted recipes. This patch will let downstream users host it in bbappends or other places what is the intended use of this patch?

i'm not sure what you're asking for here ... there is no claim that
any of these recipes have been fixed in any way, only that weak assignment seems to be the default for blacklisting to at least allow for the possibility of overriding.

Ok I think that’s fine I wanted to understand the reason since weak assignment do have some unintended results but if it is to make it uniform I
Think that’s fair

Quoted 110 lines
Quoted 3 lines

Review

Quoted 3 lines
(quoted diff) +0 -0

netkit-rusers_0.17.bb b/meta-networking/recipes-netkit/netkit-rusers/ netkit-rusers_0.17.bb

Quoted 2 lines
Quoted 2 lines

index c39faef8d..eee96d865 100644
--- a/meta-networking/recipes-netkit/netkit-rusers/

netkit-rusers_0.17.bb

Quoted 1 line
Quoted 1 line

+++ b/meta-networking/recipes-netkit/netkit-rusers/

netkit-rusers_0.17.bb

Quoted 1 line

Review RDEPENDS_${PN}-server += "tcp-wrappers xinetd

Quoted 1 line
(quoted diff) +0 -0
@@ -69,4 +69,4 @@ RDEPENDS_${PN}-server += "tcp-wrappers xinetd

rpcbind"

Quoted 4 lines

meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb RDEPENDS_${PN}-server += "tcp-wrappers xinetd rpcbind"

Quoted 4 lines
meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb +0 -1
 # http://errors.yoctoproject.org/Errors/Details/186962/
 COMPATIBLE_HOST_libc-musl = 'null'
-PNBLACKLIST[netkit-rusers] = "Fails to build rup.c:51:10: fatal

error: rstat.h: No such file or directory"

Quoted 1 line

Review RDEPENDS_${PN}-server += "tcp-wrappers xinetd · line 71

Quoted 1 line
(quoted diff) +1 -0
+PNBLACKLIST[netkit-rusers] ?= "Fails to build rup.c:51:10: fatal

error: rstat.h: No such file or directory"

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb

Quoted 8 lines

meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb do_install () { · line 25

Quoted 8 lines

index 23fe2021b..c296c3bc1 100644

meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb +0 -1
@@ -22,4 +22,4 @@ do_install () {
     oe_runmake install DESTDIR="${D}"
 }
 
-PNBLACKLIST[drbd] = "Kernel module Needs forward porting to kernel

5.2+"

Quoted 1 line

meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb do_install () { · line 25

Quoted 1 line
meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb +1 -0
+PNBLACKLIST[drbd] ?= "Kernel module Needs forward porting to kernel

5.2+"

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

lowpan-tools_git.bb b/meta-networking/recipes-support/lowpan-tools/ lowpan-tools_git.bb

Quoted 4 lines

meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb FILES_${PN}-dbg +=

Quoted 4 lines

index 5917cfb3e..4a1bbe620 100644

meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +0 -0
@@ -36,4 +36,4 @@ FILES_${PN}-dbg +=

"${libexecdir}/lowpan-tools/.debug/"

Quoted 4 lines

meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb FILES_${PN}-dbg += "${libexecdir}/lowpan-tools/.debug/"

Quoted 4 lines
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +0 -1
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${libdir}/python*"
 
-PNBLACKLIST[lowpan-tools] = "WARNING these tools are deprecated! Use

wpan-tools instead"

Quoted 1 line

meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb FILES_${PN}-dbg += · line 39

Quoted 1 line
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +1 -0
+PNBLACKLIST[lowpan-tools] ?= "WARNING these tools are deprecated! Use

wpan-tools instead"

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb

Quoted 10 lines

Review

Quoted 10 lines

index 21d110aee..2e3da7d4d 100644

meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb +1 -1
@@ -27,4 +27,4 @@ RDEPENDS_${PN} += "\
 
 BBCLASSEXTEND = "native nativesdk"
 
-PNBLACKLIST[nanopb] = "Needs forward porting to use python3"
+PNBLACKLIST[nanopb] ?= "Needs forward porting to use python3"
(quoted diff) +0 -0

b/meta-oe/recipes-extended/socketcan/can-isotp_git.bb

Quoted 8 lines

meta-oe/recipes-extended/socketcan/can-isotp_git.bb inherit module · line 14

Quoted 8 lines

index e40e1cd26..eca8dfc7b 100644

meta-oe/recipes-extended/socketcan/can-isotp_git.bb +0 -1
@@ -11,4 +11,4 @@ inherit module
 
 EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"
 
-PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to

kernel 5.2+"

Quoted 1 line

meta-oe/recipes-extended/socketcan/can-isotp_git.bb inherit module · line 14

Quoted 1 line
meta-oe/recipes-extended/socketcan/can-isotp_git.bb +1 -0
+PNBLACKLIST[can-isotp] ?= "Kernel module Needs forward porting to

kernel 5.2+"

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta-oe/recipes-kernel/bpftool/bpftool.bb

Quoted 6 lines
Quoted 6 lines

index 6683eccf2..1758430bc 100644

meta-oe/recipes-kernel/bpftool/bpftool.bb +0 -0
@@ -32,4 +32,4 @@ python do_package_prepend() {
 }
 
Quoted 7 lines

meta-oe/recipes-kernel/bpftool/bpftool.bb python do_package_prepend() {

Quoted 7 lines
meta-oe/recipes-kernel/bpftool/bpftool.bb +1 -2
 B = "${WORKDIR}/${BPN}-${PV}"
-PNBLACKLIST[bpftool] = "Needs forward porting to kernel 5.2+"
+PNBLACKLIST[bpftool] ?= "Needs forward porting to kernel 5.2+"
 
--

========================================================================

Quoted 1 line
Quoted 1 line

Robert P. J. Day Ottawa, Ontario,

CANADA

Quoted 3 lines
Quoted 3 lines

http://crashcourse.ca

Twitter:

http://twitter.com/rpjday

Quoted 1 line
Quoted 1 line

LinkedIn:

http://ca.linkedin.com/in/rpjday

Quoted 1 line
Quoted 1 line

========================================================================

Quoted 2 lines
Quoted 1 line

--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

#4 lore raw
Quoted 23 lines · Khem Raj

On Wed, May 27, 2020 at 3:14 AM Robert P. J. Day <[email protected]> wrote:
On Tue, 26 May 2020, Khem Raj wrote:

> On Mon, May 25, 2020 at 12:21 PM Robert P. J. Day <[email protected]> wrote:
> >
> > Make sure PNBLACKLIST assignments in recipe files use weak > > assignment, so they can be overridden in, for example, local.conf > > files.
> >
>
> I would like contributions here when someone fixes one of the > blacklisted recipes. This patch will let downstream users host it in > bbappends or other places what is the intended use of this patch?

  i'm not sure what you're asking for here ... there is no claim that any of these recipes have been fixed in any way, only that weak assignment seems to be the default for blacklisting to at least allow for the possibility of overriding.

Quoted 3 lines

Ok I think that’s fine I wanted to understand the reason since weak assignment do have some unintended results but if it is to make it uniform I Think that’s fair

discussion on YP list that inspired this:

https://lists.yoctoproject.org/g/yocto/topic/74460612#49479

rday