Skip to contentSkip to conversation

perf test: Avoid call to missing cleanup function

PATCH Applied Ian Rogers 4 participants 4 messages Sep 4 – Sep 8 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf test: Avoid call to missing cleanup function

Cleanup function was removed by writing to /dev/null rather than temporary files. The exit path still had a call.

Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
---
 tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
 1 file changed, 2 deletions(-)
tools/perf/tests/shell/test_event_open_fallback.sh +0 -2
index 9420a7557c13..27d440a5355d 100755
@@ -57,8 +57,6 @@ ret=0
 test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
 test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
 
-cleanup
-
 if [ ${err_cnt} -gt 0 ] ; then
 	exit 1
 fi
Signature · 1 line
2.55.0.979.g7e5102b832-goog
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines

Cleanup function was removed by writing to /dev/null rather than temporary files. The exit path still had a call.

Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Ian Rogers

LGTM. Thanks.

Quoted 22 lines · Ian Rogers

Cleanup function was removed by writing to /dev/null rather than temporary files. The exit path still had a call.

Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
---
 tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
 1 file changed, 2 deletions(-)
tools/perf/tests/shell/test_event_open_fallback.sh +0 -2
index 9420a7557c13..27d440a5355d 100755
@@ -57,8 +57,6 @@ ret=0
 test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
 test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
 
-cleanup
-
 if [ ${err_cnt} -gt 0 ] ; then
 	exit 1
 fi
maintainer Applied
#3 lore raw
Quoted 3 lines · Dapeng

LGTM. Thanks.

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo

Quoted 23 lines · Ian Rogers
Quoted 22 lines

Cleanup function was removed by writing to /dev/null rather than temporary files. The exit path still had a call.

Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
---
 tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
 1 file changed, 2 deletions(-)
tools/perf/tests/shell/test_event_open_fallback.sh +0 -2
index 9420a7557c13..27d440a5355d 100755
@@ -57,8 +57,6 @@ ret=0
 test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
 test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
 
-cleanup
-
 if [ ${err_cnt} -gt 0 ] ; then
 	exit 1
 fi