perf test: Avoid call to missing cleanup function
Ian Rogers
reviewerPATCH 1/1 perf test: Avoid call to missing cleanup function
Cleanup function was removed by writing to /dev/null rather than temporary files. The exit path still had a call.
Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
Signed-off-by Ian Rogers <[email protected]>
--- tools/perf/tests/shell/test_event_open_fallback.sh | 2 -- 1 file changed, 2 deletions(-)
tools/perf/tests/shell/test_event_open_fallback.sh +0 -2
@@ -57,8 +57,6 @@ ret=0 test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0 test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0 -cleanup - if [ ${err_cnt} -gt 0 ] ; then exit 1 fi
Signature · 1 line
2.55.0.979.g7e5102b832-goog
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines
Cleanup function was removed by writing to
/dev/nullrather than temporary files. The exit path still had a call.Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")Signed-off-by Ian Rogers <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
LGTM. Thanks.
Reviewed-by Dapeng Mi <[email protected]>
Quoted 22 lines · Ian Rogers
Cleanup function was removed by writing to
/dev/nullrather than temporary files. The exit path still had a call.Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/test_event_open_fallback.sh | 2 -- 1 file changed, 2 deletions(-)tools/perf/tests/shell/test_event_open_fallback.sh +0
-2@@ -57,8 +57,6 @@ ret=0 test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0 test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0 -cleanup - if [ ${err_cnt} -gt 0 ] ; then exit 1 fi
Quoted 3 lines · Dapeng
LGTM. Thanks.
Reviewed-by Dapeng Mi <[email protected]>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
Quoted 23 lines · Ian Rogers
Quoted 22 lines
Cleanup function was removed by writing to
/dev/nullrather than temporary files. The exit path still had a call.Fixes 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/test_event_open_fallback.sh | 2 -- 1 file changed, 2 deletions(-)tools/perf/tests/shell/test_event_open_fallback.sh +0
-2@@ -57,8 +57,6 @@ ret=0 test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0 test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0 -cleanup - if [ ${err_cnt} -gt 0 ] ; then exit 1 fi