Skip to contentSkip to conversation

tbs2910: migrate to DM_VIDEO

PATCH New Anatolij Gustschin 5 participants 15 messages May 22, 2020 – Jul 1, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

---
This is only build tested.

 configs/tbs2910_defconfig | 7 ++++++-
 include/configs/tbs2910.h | 2 --
 2 files changed, 6 insertions(+), 3 deletions(-)
configs/tbs2910_defconfig +6 -1
index 2ff0e160f7..b40641c17b 100644
@@ -1,6 +1,7 @@
 CONFIG_ARM=y
 CONFIG_ARCH_MX6=y
 CONFIG_SYS_TEXT_BASE=0x17800000
+CONFIG_SYS_MALLOC_F_LEN=0x4000
 CONFIG_ENV_SIZE=0x2000
 CONFIG_ENV_OFFSET=0x60000
 CONFIG_TARGET_TBS2910=y
@@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_I2C_EDID=y
+CONFIG_DM_VIDEO=y
+# CONFIG_VIDEO_BPP8 is not set
+# CONFIG_VIDEO_BPP32 is not set
+# CONFIG_VIDEO_ANSI is not set
 CONFIG_VIDEO_IPUV3=y
-CONFIG_VIDEO=y
+CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_OF_LIBFDT_ASSUME_MASK=0xff
 # CONFIG_EFI_LOADER is not set
include/configs/tbs2910.h +0 -2
index 7376b91f55..8ab3fcfe3e 100644
@@ -37,11 +37,9 @@
 #define CONFIG_MXC_UART_BASE		UART1_BASE /* select UART1/UART2 */
 
 /* Framebuffer */
-#ifdef CONFIG_VIDEO
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
-#endif
 
 /* PCI */
 #ifdef CONFIG_CMD_PCI
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Quoted 4 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

And this exactly is the problem.
There are some users of this board without serial console. They have no chance to set this after upgrading u-boot.

What is the reason behind this incompatible change? In other words, why vga cannot be an alias for vidconsole, if this is the preferred name nowadays?

Regards,
Soeren

Quoted 50 lines

---
This is only build tested.

 configs/tbs2910_defconfig | 7 ++++++-
 include/configs/tbs2910.h | 2 --
 2 files changed, 6 insertions(+), 3 deletions(-)
configs/tbs2910_defconfig +6 -1
index 2ff0e160f7..b40641c17b 100644
@@ -1,6 +1,7 @@
 CONFIG_ARM=y
 CONFIG_ARCH_MX6=y
 CONFIG_SYS_TEXT_BASE=0x17800000
+CONFIG_SYS_MALLOC_F_LEN=0x4000
 CONFIG_ENV_SIZE=0x2000
 CONFIG_ENV_OFFSET=0x60000
 CONFIG_TARGET_TBS2910=y
@@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_I2C_EDID=y
+CONFIG_DM_VIDEO=y
+# CONFIG_VIDEO_BPP8 is not set
+# CONFIG_VIDEO_BPP32 is not set
+# CONFIG_VIDEO_ANSI is not set
 CONFIG_VIDEO_IPUV3=y
-CONFIG_VIDEO=y
+CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_OF_LIBFDT_ASSUME_MASK=0xff
 # CONFIG_EFI_LOADER is not set
include/configs/tbs2910.h +0 -2
index 7376b91f55..8ab3fcfe3e 100644
@@ -37,11 +37,9 @@
 #define CONFIG_MXC_UART_BASE		UART1_BASE /* select UART1/UART2 */
 
 /* Framebuffer */
-#ifdef CONFIG_VIDEO
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
-#endif
 
 /* PCI */
 #ifdef CONFIG_CMD_PCI
#2 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

---
 arch/arm/mach-tegra/Kconfig |  1 -
 common/console.c            |  7 ++++---
 drivers/video/Kconfig       | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)
arch/arm/mach-tegra/Kconfig +0 -1
index 00facf492e..15e7684028 100644
@@ -58,7 +58,6 @@ config TEGRA_COMMON
 	select MISC
 	select OF_CONTROL
 	select SPI
-	select VIDCONSOLE_AS_LCD if DM_VIDEO
 	imply CMD_DM
 	imply CRC32_VERIFY
 
common/console.c +4 -3
index 1deca3cb78..f149624954 100644
@@ -713,7 +713,7 @@ struct stdio_dev *search_device(int flags, const char *name)
 
 	dev = stdio_get_by_name(name);
 #ifdef CONFIG_VIDCONSOLE_AS_LCD
-	if (!dev && !strcmp(name, "lcd"))
+	if (!dev && !strcmp(name, CONFIG_VIDCONSOLE_AS_LCD))
 		dev = stdio_get_by_name("vidconsole");
 #endif
 
@@ -897,8 +897,9 @@ done:
 	stdio_print_current_devices();
 #endif /* CONFIG_SYS_CONSOLE_INFO_QUIET */
 #ifdef CONFIG_VIDCONSOLE_AS_LCD
-	if (strstr(stdoutname, "lcd"))
-		printf("Warning: Please change 'lcd' to 'vidconsole' in stdout/stderr environment vars\n");
+	if (strstr(stdoutname, CONFIG_VIDCONSOLE_AS_LCD))
+		printf("Warning: Please change '%s' to 'vidconsole' in stdout/stderr environment vars\n",
+		       CONFIG_VIDCONSOLE_AS_LCD);
 #endif
 
 #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE
drivers/video/Kconfig +9 -7
index 38123543a5..28c22fe525 100644
@@ -146,14 +146,16 @@ config NO_FB_CLEAR
 source "drivers/video/fonts/Kconfig"
 
 config VIDCONSOLE_AS_LCD
-	bool "Use 'vidconsole' when 'lcd' is seen in stdout"
+	string "Use 'vidconsole' when string defined here is seen in stdout"
 	depends on DM_VIDEO
-	help
-	  This is a work-around for boards which have 'lcd' in their stdout
-	  environment variable, but have moved to use driver model for video.
-	  In this case the console will no-longer work. While it is possible
-	  to update the environment, the breakage may be confusing for users.
-	  This option will be removed around the end of 2016.
+	default "lcd" if LCD || TEGRA_COMMON
+	default "vga" if !LCD
+	help
+	  This is a work-around for boards which have 'lcd' or 'vga' in their
+	  stdout environment variable, but have moved to use driver model for
+	  video. In this case the console will no-longer work. While it is
+	  possible to update the environment, the breakage may be confusing for
+	  users. This option will be removed around the end of 2020.
 
 config VIDEO_COREBOOT
 	bool "Enable coreboot framebuffer driver support"
Signature · 1 line
2.17.1
#3 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

Quoted 5 lines · Anatolij Gustschin

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

Tested on tbs2910, works as intended.

Thanks,
Soeren

Quoted 71 lines
---
 arch/arm/mach-tegra/Kconfig |  1 -
 common/console.c            |  7 ++++---
 drivers/video/Kconfig       | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)
arch/arm/mach-tegra/Kconfig +0 -1
index 00facf492e..15e7684028 100644
@@ -58,7 +58,6 @@ config TEGRA_COMMON
 	select MISC
 	select OF_CONTROL
 	select SPI
-	select VIDCONSOLE_AS_LCD if DM_VIDEO
 	imply CMD_DM
 	imply CRC32_VERIFY
 
common/console.c +4 -3
index 1deca3cb78..f149624954 100644
@@ -713,7 +713,7 @@ struct stdio_dev *search_device(int flags, const char *name)
 
 	dev = stdio_get_by_name(name);
 #ifdef CONFIG_VIDCONSOLE_AS_LCD
-	if (!dev && !strcmp(name, "lcd"))
+	if (!dev && !strcmp(name, CONFIG_VIDCONSOLE_AS_LCD))
 		dev = stdio_get_by_name("vidconsole");
 #endif
 
@@ -897,8 +897,9 @@ done:
 	stdio_print_current_devices();
 #endif /* CONFIG_SYS_CONSOLE_INFO_QUIET */
 #ifdef CONFIG_VIDCONSOLE_AS_LCD
-	if (strstr(stdoutname, "lcd"))
-		printf("Warning: Please change 'lcd' to 'vidconsole' in stdout/stderr environment vars\n");
+	if (strstr(stdoutname, CONFIG_VIDCONSOLE_AS_LCD))
+		printf("Warning: Please change '%s' to 'vidconsole' in stdout/stderr environment vars\n",
+		       CONFIG_VIDCONSOLE_AS_LCD);
 #endif
 
 #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE
drivers/video/Kconfig +9 -7
index 38123543a5..28c22fe525 100644
@@ -146,14 +146,16 @@ config NO_FB_CLEAR
 source "drivers/video/fonts/Kconfig"
 
 config VIDCONSOLE_AS_LCD
-	bool "Use 'vidconsole' when 'lcd' is seen in stdout"
+	string "Use 'vidconsole' when string defined here is seen in stdout"
 	depends on DM_VIDEO
-	help
-	  This is a work-around for boards which have 'lcd' in their stdout
-	  environment variable, but have moved to use driver model for video.
-	  In this case the console will no-longer work. While it is possible
-	  to update the environment, the breakage may be confusing for users.
-	  This option will be removed around the end of 2016.
+	default "lcd" if LCD || TEGRA_COMMON
+	default "vga" if !LCD
+	help
+	  This is a work-around for boards which have 'lcd' or 'vga' in their
+	  stdout environment variable, but have moved to use driver model for
+	  video. In this case the console will no-longer work. While it is
+	  possible to update the environment, the breakage may be confusing for
+	  users. This option will be removed around the end of 2020.
 
 config VIDEO_COREBOOT
 	bool "Enable coreboot framebuffer driver support"
#4 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

In reply to Anatolij Gustschin
Quoted 11 lines · Anatolij Gustschin

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

---
 arch/arm/mach-tegra/Kconfig |  1 -
 common/console.c            |  7 ++++---
 drivers/video/Kconfig       | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)
#5 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

In reply to Anatolij Gustschin
Quoted 5 lines · Anatolij Gustschin

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200526/eab167b1/attachment.sig>
#6 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

In reply to Anatolij Gustschin
Quoted 10 lines · On Sat, 23 May 2020 17:11:20 +0200 Anatolij Gustschin agust at denx.de wrote:

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

---
 arch/arm/mach-tegra/Kconfig |  1 -
 common/console.c            |  7 ++++---
 drivers/video/Kconfig       | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)

Applied to u-boot-video/next, thanks!

--
Anatolij

#7 lore raw

PATCH 1/1 video: extend stdout video console work-around for 'vga'

Hi Anatolij

Quoted 10 lines

From: U-Boot <[email protected]> On Behalf Of Anatolij Gustschin
Sent: vendredi 19 juin 2020 15:56

Quoted 4 lines · On Sat, 23 May 2020 17:11:20 +0200 Anatolij Gustschin agust at denx.de wrote:

cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment.

Quoted 8 lines
Quoted 6 lines
---
 arch/arm/mach-tegra/Kconfig |  1 -
 common/console.c            |  7 ++++---
 drivers/video/Kconfig       | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)

Applied to u-boot-video/next, thanks!

This patch breaks the stm32mp15 boot in console_init_r.on the next branch.

The board have with DM_VIDEO activated.
In previous version the workaround was not activated for the board: CONFIG_VIDCONSOLE_AS_LCD=n (default)

PS: the config is activated in few board but still as bolean but defined as sting in Kconfig
configs/peach-pit_defconfig:76:CONFIG_VIDCONSOLE_AS_LCD=y configs/snow_defconfig:87:CONFIG_VIDCONSOLE_AS_LCD=y configs/peach-pi_defconfig:77:CONFIG_VIDCONSOLE_AS_LCD=y configs/spring_defconfig:88:CONFIG_VIDCONSOLE_AS_LCD=y

Now it is a string, the CONFIG is always defined = value is "lcd" or "vga" or ""

And the code in console.c under this compilation flags cause the crash.

I push a patch [1] to fix up it this update:

VIDCONSOLE_AS_LCD => Boolean used in defconfig as previously VIDCONSOLE_AS_NAME => name the the string to used.... NEW

[1] "video: restore CONFIG_VIDCONSOLE_AS_LCD as Boolean"

Regards

Patrick

#8 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

In reply to Soeren Moch
Quoted 4 lines · On Sat, 23 May 2020 09:55:48 +0200 Soeren Moch smoch at web.de wrote:
Quoted 3 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

Quoted 8 lines
Quoted 1 line

setenv stdout serial,vidconsole

And this exactly is the problem.
There are some users of this board without serial console. They have no chance to set this after upgrading u-boot.

What is the reason behind this incompatible change? In other words, why vga cannot be an alias for vidconsole, if this is the preferred name nowadays?

DM video console driver uses more generic name for the video console. As a work-around, an alias exists for 'lcd' name. I've sent a patch to also use 'vga' as an alias.

--
Anatolij

#9 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Quoted 12 lines · Anatolij Gustschin
Quoted 9 lines · On Sat, 23 May 2020 09:55:48 +0200 Soeren Moch smoch at web.de wrote:
Quoted 4 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

And this exactly is the problem.
There are some users of this board without serial console. They have no chance to set this after upgrading u-boot.

Quoted 7 lines
Quoted 3 lines

What is the reason behind this incompatible change? In other words, why vga cannot be an alias for vidconsole, if this is the preferred name nowadays?

DM video console driver uses more generic name for the video console. As a work-around, an alias exists for 'lcd' name. I've sent a patch to also use 'vga' as an alias.

Thanks.

I will test both patches for tbs2910.

Soeren

#10 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

In reply to Anatolij Gustschin
Quoted 8 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

---
This is only build tested.

I tested this on top of v2020.07-rc2 and your patch "video: extend stdout video console work-around for 'vga'"

Works great. However, some comments below.

Quoted 10 lines
 configs/tbs2910_defconfig | 7 ++++++-
 include/configs/tbs2910.h | 2 --
 2 files changed, 6 insertions(+), 3 deletions(-)
configs/tbs2910_defconfig +0 -0
index 2ff0e160f7..b40641c17b 100644

configs/tbs2910_defconfig line 4

Quoted 4 lines
configs/tbs2910_defconfig +1 -0
@@ -1,6 +1,7 @@
 CONFIG_ARM=y
 CONFIG_ARCH_MX6=y
 CONFIG_SYS_TEXT_BASE=0x17800000
+CONFIG_SYS_MALLOC_F_LEN=0x4000

This is not necessary. The default 0x2000 also works fine.

Quoted 22 lines
configs/tbs2910_defconfig +5 -1
 CONFIG_ENV_SIZE=0x2000
 CONFIG_ENV_OFFSET=0x60000
 CONFIG_TARGET_TBS2910=y
@@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_I2C_EDID=y
+CONFIG_DM_VIDEO=y
+# CONFIG_VIDEO_BPP8 is not set
+# CONFIG_VIDEO_BPP32 is not set
+# CONFIG_VIDEO_ANSI is not set
 CONFIG_VIDEO_IPUV3=y
-CONFIG_VIDEO=y
+CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_OF_LIBFDT_ASSUME_MASK=0xff
 # CONFIG_EFI_LOADER is not set
include/configs/tbs2910.h +0 -0
index 7376b91f55..8ab3fcfe3e 100644
@@ -37,11 +37,9 @@
 #define CONFIG_MXC_UART_BASE		UART1_BASE /* select UART1/UART2 */

include/configs/tbs2910.h line 45

Quoted 10 lines
include/configs/tbs2910.h +0 -2
 
 /* Framebuffer */
-#ifdef CONFIG_VIDEO
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
-#endif
 
 /* PCI */
 #ifdef CONFIG_CMD_PCI

Since DM_VIDEO requires vidconsole as output device, please also add

---8<---

include/configs/tbs2910.h +0 -0
index 8ab3fcfe3e..82165a9ffe 100644
@@ -92,11 +92,11 @@

??????? "fan=gpio set 92\0" \
??????? "set_con_serial=setenv stdout serial; " \
??????????????????????? "setenv stderr serial\0" \
-?????? "set_con_hdmi=setenv stdout serial,vga; " \
-?????????????????????? "setenv stderr serial,vga\0" \
-?????? "stderr=serial,vga\0" \
+?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \
+?????????????????????? "setenv stderr serial,vidconsole\0" \
+?????? "stderr=serial,vidconsole\0" \
??????? "stdin=serial,usbkbd\0" \
-?????? "stdout=serial,vga\0"
+?????? "stdout=serial,vidconsole\0"
?
?#define CONFIG_BOOTCOMMAND \
??????? "mmc rescan; " \
---8<---

to avoid warnings for users with default environment.(not sure if whitespace is still correct in this snippet)

With this DM_VIDEO conversion the board comes very close to the size limit. While it works with my toolchain, there might be problems with others. So maybe not a good idea to merge this as fix immediately.

Since this depends on your above mentioned patch, do you plan to merge this via u-boot-video, or should this go as usual through the imx tree?

Thank you very much for finishing this DM_VIDEO migration, Soeren

#11 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Quoted 6 lines · On Sun, 24 May 2020 17:46:22 +0200 Soeren Moch smoch at web.de wrote:
Quoted 5 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

Quoted 7 lines
Quoted 3 lines

---
This is only build tested.

I tested this on top of v2020.07-rc2 and your patch "video: extend stdout video console work-around for 'vga'"

Works great. However, some comments below.

Thanks for testing!

...

Quoted 2 lines
Quoted 1 line

+CONFIG_SYS_MALLOC_F_LEN=0x4000

This is not necessary. The default 0x2000 also works fine.

Dropped in v2.

...

Quoted 25 lines

Since DM_VIDEO requires vidconsole as output device, please also add

---8<---

include/configs/tbs2910.h +4 -4
index 8ab3fcfe3e..82165a9ffe 100644
@@ -92,11 +92,11 @@
 ??????? "fan=gpio set 92\0" \
 ??????? "set_con_serial=setenv stdout serial; " \
 ??????????????????????? "setenv stderr serial\0" \
-?????? "set_con_hdmi=setenv stdout serial,vga; " \
-?????????????????????? "setenv stderr serial,vga\0" \
-?????? "stderr=serial,vga\0" \
+?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \
+?????????????????????? "setenv stderr serial,vidconsole\0" \
+?????? "stderr=serial,vidconsole\0" \
 ??????? "stdin=serial,usbkbd\0" \
-?????? "stdout=serial,vga\0"
+?????? "stdout=serial,vidconsole\0"

?
?#define CONFIG_BOOTCOMMAND \
??????? "mmc rescan; " \
---8<---

Quoted 2 lines

to avoid warnings for users with default environment.(not sure if whitespace is still correct in this snippet)

Done in v2.

Quoted 3 lines

With this DM_VIDEO conversion the board comes very close to the size limit. While it works with my toolchain, there might be problems with others. So maybe not a good idea to merge this as fix immediately.

Yes, with GCC 9.2 it didn't work any more. I've submitted some DM_VIDEO patches to disable more unused code to fix this.

Quoted 2 lines

Since this depends on your above mentioned patch, do you plan to merge this via u-boot-video, or should this go as usual through the imx tree?

I'll merge this via u-boot-video tree. v2 patch depends on a few more video patches which are under review/built-test currently.

--
Anatolij

#12 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Quoted 56 lines · Anatolij Gustschin
Quoted 6 lines · On Sun, 24 May 2020 17:46:22 +0200 Soeren Moch smoch at web.de wrote:
Quoted 5 lines · Anatolij Gustschin

Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like:

setenv stdout serial,vidconsole

Quoted 7 lines
Quoted 3 lines

---
This is only build tested.

I tested this on top of v2020.07-rc2 and your patch "video: extend stdout video console work-around for 'vga'"

Works great. However, some comments below.

Thanks for testing!

...

Quoted 2 lines
Quoted 1 line

+CONFIG_SYS_MALLOC_F_LEN=0x4000

This is not necessary. The default 0x2000 also works fine.

Dropped in v2.

...

Quoted 25 lines

Since DM_VIDEO requires vidconsole as output device, please also add

---8<---

include/configs/tbs2910.h +4 -4
index 8ab3fcfe3e..82165a9ffe 100644
@@ -92,11 +92,11 @@
 ??????? "fan=gpio set 92\0" \
 ??????? "set_con_serial=setenv stdout serial; " \
 ??????????????????????? "setenv stderr serial\0" \
-?????? "set_con_hdmi=setenv stdout serial,vga; " \
-?????????????????????? "setenv stderr serial,vga\0" \
-?????? "stderr=serial,vga\0" \
+?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \
+?????????????????????? "setenv stderr serial,vidconsole\0" \
+?????? "stderr=serial,vidconsole\0" \
 ??????? "stdin=serial,usbkbd\0" \
-?????? "stdout=serial,vga\0"
+?????? "stdout=serial,vidconsole\0"

?
?#define CONFIG_BOOTCOMMAND \
??????? "mmc rescan; " \
---8<---

Quoted 2 lines

to avoid warnings for users with default environment.(not sure if whitespace is still correct in this snippet)

Done in v2.

Quoted 3 lines

With this DM_VIDEO conversion the board comes very close to the size limit. While it works with my toolchain, there might be problems with others. So maybe not a good idea to merge this as fix immediately.

Quoted 7 lines

Yes, with GCC 9.2 it didn't work any more. I've submitted some DM_VIDEO patches to disable more unused code to fix this.

Quoted 2 lines

Since this depends on your above mentioned patch, do you plan to merge this via u-boot-video, or should this go as usual through the imx tree?

I'll merge this via u-boot-video tree. v2 patch depends on a few more video patches which are under review/built-test currently.

OK, I will try to test this new version again on top of your other patches.

Do you plan to merge this for v2020.07, or for -next?

Soeren

#13 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

On Thu, 28 May 2020 09:54:42 +0200
Soeren Moch smoch at web.de wrote:
...

Quoted 3 lines
Quoted 2 lines

I'll merge this via u-boot-video tree. v2 patch depends on a few more video patches which are under review/built-test currently.

OK, I will try to test this new version again on top of your other patches.

OK, you could use 'dm_video-imx6' branch in my repo:
https://gitlab.denx.de/u-boot/custodians/u-boot-video/-/commits/dm_video-imx6

All required patches are already integrated there.

Quoted 1 line

Do you plan to merge this for v2020.07, or for -next?

For v2020.07 it is too late, Tom suggested to merge this for -next.

--
Anatolij

#14 lore raw

PATCH 1/1 tbs2910: migrate to DM_VIDEO

Quoted 10 lines · Anatolij Gustschin

On Thu, 28 May 2020 09:54:42 +0200
Soeren Moch smoch at web.de wrote:
...

Quoted 3 lines
Quoted 2 lines

I'll merge this via u-boot-video tree. v2 patch depends on a few more video patches which are under review/built-test currently.

OK, I will try to test this new version again on top of your other patches.

OK, you could use 'dm_video-imx6' branch in my repo:
https://gitlab.denx.de/u-boot/custodians/u-boot-video/-/commits/dm_video-imx6

All required patches are already integrated there.

Still works as expected.
The tbs2910-patch already has my tested-by, I could not find this series as a whole to send a tag for this.

Quoted 2 lines
Quoted 1 line

Do you plan to merge this for v2020.07, or for -next?

For v2020.07 it is too late, Tom suggested to merge this for -next.

OK, thanks,
Soeren