Skip to contentSkip to conversation

ARM: dts: aspeed: Adding Inventec Starscream BMC

PATCH Superseded Chen.PJ 陳柏任 TAO 2 participants 3 messages May 16, 2023 – May 17, 2023 1 message not in the archive

Subsystems (3)

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): d0cd49b86ba6446e8ed78cbeea0e8c1d

#1 lore raw

PATCH v2 1/1 ARM: dts: aspeed: Adding Inventec Starscream BMC

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

---
v2:
- Correct License description
- Remove not supported device
- Using openbmc-flash-layout.dtsi
- Correct device format
---

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 513 ++++++++++++++++++
 2 files changed, 514 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +1 -0
index eb681903d50b..0002290ae028 100644
@@ -1630,6 +1630,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
+	aspeed-bmc-inventec-starscream.dtb \
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
 	aspeed-bmc-vegman-n110.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +513 -0

513 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw
Quoted 1 line · Chen.PJ ??? TAO

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Quoted 21 lines

---
v2:
- Correct License description
- Remove not supported device
- Using openbmc-flash-layout.dtsi
- Correct device format
---

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 513 ++++++++++++++++++
 2 files changed, 514 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +0 -0
index eb681903d50b..0002290ae028 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_ASPEED) += \ · line 1633

Quoted 4 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -1630,6 +1630,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
+	aspeed-bmc-inventec-starscream.dtb \

Please keep alphabetical order.

Quoted 12 lines
arch/arm/boot/dts/Makefile +0 -0
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
 	aspeed-bmc-vegman-n110.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +3 -0
new file mode 100644
index 000000000000..a6c733b29d04
@@ -0,0 +1,513 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 Inventec Corp.
+

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 13

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include "aspeed-g6-pinctrl.dtsi"
+#include <dt-bindings/i2c/i2c.h>
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+	model = "STARSCREAM BMC";
+	compatible = "inventec,starscream-bmc", "aspeed,ast2600";

Still missing bindings.

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 21

Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +8 -0
+
+	aliases {
+		serial4 = &uart5;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+		bootargs = "console=tty0 console=ttyS4,115200n8 root=/dev/ram rw init=/linuxrc";

Drop bootargs. They are not part of hardware description.

Quoted 17 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +17 -0
+	};
+
+	memory at 80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		gfx_memory: framebuffer {
+			size = <0x01000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 48

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+		};
+
+		video_engine_memory: video {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		ssp_memory: ssp_memory {

No underscores in node names.

Quoted 19 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +19 -0
+			size = <0x00200000>;
+			alignment = <0x00100000>;
+			compatible = "shared-dma-pool";
+			no-map;
+		};
+	};
+
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels =
+		<&adc_u74 0>, // P0_VDD11
+		<&adc_u74 1>, // P1_VDD11
+		<&adc_u74 2>, // P0_3V3_S5
+		<&adc_u74 3>, // P1_3V3_S5
+		<&adc_u74 4>, // P3V3
+		<&adc_u74 5>, // VBAT
+		<&adc_u74 6>, // P3V3_STBY
+		<&adc_u74 7>, // P5V_STBY
+		<&adc_u74 8>, // P5V

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 77

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+		<&adc_u74 9>, // P12V
+		<&adc_u74 10>, // P1_VDD18_S5
+		<&adc_u74 11> // P0_VDD18_S5
+		;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		// UID led

Redundant/obvious comment drop.

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 78

Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +1 -0
+		uid {

It does not look like you tested the DTS against bindings. Please run make dtbs_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 84

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +6 -0
+			label = "UID_LED";
+			gpios = <&gpio0 ASPEED_GPIO(X, 2) GPIO_ACTIVE_LOW>;
+		};
+
+		// Heart beat led
+		heartbeat {

Ditto

Quoted 5 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +5 -0
+			label = "HB_LED";
+			gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+		};
+	};
+};

...

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts

Quoted 2 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +2 -0
+
+		usb_hub:i2c at 0 {

Missing space after label. Fix it everywhere.

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 248

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +6 -0
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+
+			// USB U114
+			usb2512b at 2c {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 27 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +27 -0
+				compatible = "microchip,usb2514b";
+				reg = <0x2c>;
+			};
+		};
+
+		riser1:i2c at 1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+		};
+
+		riser2:i2c at 2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+};
+
+&i2c6 {
+	status = "okay";

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 285

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+
+	// FRU Motherboard
+	eeprom at 51 {
+		compatible = "atmel,24c64";
+		reg = <0x51>;
+		pagesize = <32>;
+	};
+
+	// ADC_U74
+	adc_u74:max1139 at 35 {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +7 -0
+		compatible = "maxim,max1139";
+		reg = <0x35>;
+		#io-channel-cells = <1>;
+	};
+
+	psu at 58 {
+		compatible = "pmbus";

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 302

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+		reg = <0x58>;
+	};
+
+	psu at 5a {
+		compatible = "pmbus";
+		reg = <0x5a>;
+	};
+
+	// Motherboard Temp_U89
+	tmp421 at 4e {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 308

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +6 -0
+		compatible = "ti,tmp421";
+		reg = <0x4e>;
+	};
+
+	// RunBMC Temp_U6
+	tmp75 at 49 {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 314

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +6 -0
+		compatible = "ti,tmp75";
+		reg = <0x49>;
+	};
+
+	// Right ear board Temp_U1
+	emc1412 at 7c {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof

#3 lore raw

PATCH v3 1/1 ARM: dts: aspeed: Adding Inventec Starscream BMC

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

---
V2 -> V3:
- Rename the node name to generic.
V1 -> V2:
- Correct License description
- Remove not supported device
- Using openbmc-flash-layout.dtsi
- Correct device format

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 485 ++++++++++++++++++
 2 files changed, 486 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +1 -0
index eb681903d50b..6a897ff40ff0 100644
@@ -1629,6 +1629,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-q71l.dtb \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
+	aspeed-bmc-inventec-starscream.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +485 -0

485 lines not on this page · raw message

Signature · 1 line
2.25.1