KVM: s390: add counters for vsie performance
v2 cover KVM: s390: add counters for vsie performance
v2:
---
* also count shadowing of pages (Janosch)
* fix naming of counters (Janosch)
* mention shadowing of multiple levels is counted in each level (Claudio)
* fix inaccuate commit description regarding gmap notifier (Claudio)
When running a guest-3 via VSIE, guest-1 needs to shadow the page table structures of guest-2.
To reflect changes of the guest-2 in the _shadowed_ page table structures, the _shadowing_ sturctures sometimes need to be rebuilt. Since this is a costly operation, it should be avoided whenever possible.
This series adds kvm stat counters to count the number of shadow gmaps created and a tracepoint whenever something is unshadowed. This is a first step to try and improve VSIE performance.
Please note that "KVM: s390: add tracepoint in gmap notifier" has some checkpatch --strict findings. I did not fix these since the tracepoint definition would then look completely different from all the other tracepoints in arch/s390/kvm/trace-s390.h. If you want me to fix that, please let me know.
While developing this, a question regarding the stat counters came up:
there's usually no locking involved when the stat counters are incremented. On s390, GCC accidentally seems to do the right thing(TM) most of the time by generating a agsi instruction (which should be atomic given proper alignment). However, it's not guaranteed, so would we rather want to go with an atomic for the stat counters to avoid losing events? Or do we just accept the fact that we might loose events sometimes? Is there anything that speaks against having an atomic in kvm_stat?
Nico Boehr (2):
KVM: s390: add stat counter for shadow gmap events
KVM: s390: add tracepoint in gmap notifier
arch/s390/include/asm/kvm_host.h | 6 ++++++ arch/s390/kvm/gaccess.c | 7 +++++++ arch/s390/kvm/kvm-s390.c | 10 +++++++++- arch/s390/kvm/trace-s390.h | 23 +++++++++++++++++++++++ arch/s390/kvm/vsie.c | 1 + 5 files changed, 46 insertions(+), 1 deletion(-)
Signature · 1 line
2.39.1
PATCH v2 1/2 KVM: s390: add stat counter for shadow gmap events
The shadow gmap tracks memory of nested guests (guest-3). In certain scenarios, the shadow gmap needs to be rebuilt, which is a costly operation since it involves a SIE exit into guest-1 for every entry in the respective shadow level.
Add kvm stat counters when new shadow structures are created at various levels. Also add a counter gmap_shadow_acquire when a completely fresh shadow gmap is created.
Note that when several levels are shadowed at once, counters on all affected levels will be increased.
Also note that not all page table levels need to be present and a ASCE can directly point to e.g. a segment table. In this case, a new segment table will always be equivalent to a new shadow gmap and hence will be counted as gmap_shadow_acquire and not as gmap_shadow_segment.
--- arch/s390/include/asm/kvm_host.h | 6 ++++++ arch/s390/kvm/gaccess.c | 7 +++++++ arch/s390/kvm/kvm-s390.c | 8 +++++++- arch/s390/kvm/vsie.c | 1 + 4 files changed, 21 insertions(+), 1 deletion(-)
arch/s390/include/asm/kvm_host.h +6 -0
@@ -777,6 +777,12 @@ struct kvm_vm_stat {u64 inject_service_signal;u64 inject_virtio;u64 aen_forward; +u64 gmap_shadow_acquire; +u64 gmap_shadow_r1_te; +u64 gmap_shadow_r2_te; +u64 gmap_shadow_r3_te; +u64 gmap_shadow_sg_te; +u64 gmap_shadow_pg_te; };struct kvm_arch_memory_slot {
arch/s390/kvm/gaccess.c +7 -0
@@ -1382,6 +1382,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, unsigned long *pgt, int *dat_protection, int *fake) { + struct kvm *kvm;struct gmap *parent;union asce asce;union vaddress vaddr;
@@ -1390,6 +1391,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, *fake =0 ; *dat_protection =0 ; + kvm = sg->private; parent = sg->parent; vaddr.addr = saddr; asce.val = sg->orig_asce;
@@ -1450,6 +1452,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_r2t (sg, saddr, rfte.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r1_te++; } fallthrough;case ASCE_TYPE_REGION2 : {
@@ -1478,6 +1481,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_r3t (sg, saddr, rste.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r2_te++; } fallthrough;case ASCE_TYPE_REGION3 : {
@@ -1515,6 +1519,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_sgt (sg, saddr, rtte.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r3_te++; } fallthrough;case ASCE_TYPE_SEGMENT : {
@@ -1548,6 +1553,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_pgt (sg, saddr, ste.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_sg_te++; } }/* Return the parent address of the page table */
@@ -1618,6 +1624,7 @@ int kvm_s390_shadow_fault(struct kvm_vcpu *vcpu, struct gmap *sg, pte.p |= dat_protection;if (!rc) rc =gmap_shadow_page (sg, saddr,__pte (pte.val)); + vcpu->kvm->stat.gmap_shadow_pg_te++;ipte_unlock (vcpu->kvm);mmap_read_unlock (sg->mm);return rc;
arch/s390/kvm/kvm-s390.c +7 -1
@@ -66,7 +66,13 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = {STATS_DESC_COUNTER (VM , inject_pfault_done),STATS_DESC_COUNTER (VM , inject_service_signal),STATS_DESC_COUNTER (VM , inject_virtio), -STATS_DESC_COUNTER (VM , aen_forward) +STATS_DESC_COUNTER (VM , aen_forward), +STATS_DESC_COUNTER (VM , gmap_shadow_acquire), +STATS_DESC_COUNTER (VM , gmap_shadow_r1_te), +STATS_DESC_COUNTER (VM , gmap_shadow_r2_te), +STATS_DESC_COUNTER (VM , gmap_shadow_r3_te), +STATS_DESC_COUNTER (VM , gmap_shadow_sg_te), + STATS_DESC_COUNTER(VM, gmap_shadow_pg_te), }; const struct kvm_stats_header kvm_vm_stats_header = {
arch/s390/kvm/vsie.c +1 -0
@@ -1221,6 +1221,7 @@ static int acquire_gmap_shadow(struct kvm_vcpu *vcpu,if (IS_ERR (gmap))return PTR_ERR (gmap); gmap->private = vcpu->kvm; + vcpu->kvm->stat.gmap_shadow_acquire++;WRITE_ONCE (vsie_page->gmap, gmap);return 0 ; }
Signature · 1 line
2.39.1
Re: [PATCH v2 1/2] KVM: s390: add stat counter for shadow gmap events
Quoted 30 lines · Nico Boehr
The shadow gmap tracks memory of nested guests (guest-3). In certain scenarios, the shadow gmap needs to be rebuilt, which is a costly operation since it involves a SIE exit into guest-1 for every entry in the respective shadow level.
Add kvm stat counters when new shadow structures are created at various levels. Also add a counter
gmap_shadow_acquirewhen a completely fresh shadow gmap is created.Note that when several levels are shadowed at once, counters on all affected levels will be increased.
Also note that not all page table levels need to be present and a ASCE can directly point to e.g. a segment table. In this case, a new segment table will always be equivalent to a new shadow gmap and hence will be counted as
gmap_shadow_acquireand not asgmap_shadow_segment.Signed-off-by Nico Boehr <[email protected]>--- arch/s390/include/asm/kvm_host.h | 6 ++++++ arch/s390/kvm/gaccess.c | 7 +++++++ arch/s390/kvm/kvm-s390.c | 8 +++++++- arch/s390/kvm/vsie.c | 1 + 4 files changed, 21 insertions(+), 1 deletion(-)arch/s390/include/asm/kvm_host.h +0
-0
arch/s390/include/asm/kvm_host.h struct kvm_vm_stat { · line 785
Quoted 9 lines
arch/s390/include/asm/kvm_host.h +6
-0@@ -777,6 +777,12 @@ struct kvm_vm_stat {u64 inject_service_signal;u64 inject_virtio;u64 aen_forward; +u64 gmap_shadow_acquire; +u64 gmap_shadow_r1_te; +u64 gmap_shadow_r2_te; +u64 gmap_shadow_r3_te; +u64 gmap_shadow_sg_te; +u64 gmap_shadow_pg_te;
Is "te" supposed to stand for "table entry" ?
If so, I'd suggest to just call this gmap_shadow_pg_entry etc.
Quoted 87 lines
arch/s390/include/asm/kvm_host.h +0
-0};struct kvm_arch_memory_slot {arch/s390/kvm/gaccess.c +7
-0@@ -1382,6 +1382,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, unsigned long *pgt, int *dat_protection, int *fake) { + struct kvm *kvm;struct gmap *parent;union asce asce;union vaddress vaddr;@@ -1390,6 +1391,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, *fake =0 ; *dat_protection =0 ; + kvm = sg->private; parent = sg->parent; vaddr.addr = saddr; asce.val = sg->orig_asce;@@ -1450,6 +1452,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_r2t (sg, saddr, rfte.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r1_te++; } fallthrough;case ASCE_TYPE_REGION2 : {@@ -1478,6 +1481,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_r3t (sg, saddr, rste.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r2_te++; } fallthrough;case ASCE_TYPE_REGION3 : {@@ -1515,6 +1519,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_sgt (sg, saddr, rtte.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_r3_te++; } fallthrough;case ASCE_TYPE_SEGMENT : {@@ -1548,6 +1553,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr, rc =gmap_shadow_pgt (sg, saddr, ste.val, *fake);if (rc)return rc; + kvm->stat.gmap_shadow_sg_te++; } }/* Return the parent address of the page table */ @@ -1618,6 +1624,7 @@ int kvm_s390_shadow_fault(struct kvm_vcpu *vcpu, struct gmap *sg, pte.p |= dat_protection;if (!rc) rc =gmap_shadow_page (sg, saddr,__pte (pte.val)); + vcpu->kvm->stat.gmap_shadow_pg_te++;ipte_unlock (vcpu->kvm);mmap_read_unlock (sg->mm);return rc;arch/s390/kvm/kvm-s390.c +7
-1@@ -66,7 +66,13 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = {STATS_DESC_COUNTER (VM , inject_pfault_done),STATS_DESC_COUNTER (VM , inject_service_signal),STATS_DESC_COUNTER (VM , inject_virtio), -STATS_DESC_COUNTER (VM , aen_forward) +STATS_DESC_COUNTER (VM , aen_forward), +STATS_DESC_COUNTER (VM , gmap_shadow_acquire), +STATS_DESC_COUNTER (VM , gmap_shadow_r1_te), +STATS_DESC_COUNTER (VM , gmap_shadow_r2_te), +STATS_DESC_COUNTER (VM , gmap_shadow_r3_te), +STATS_DESC_COUNTER (VM , gmap_shadow_sg_te), + STATS_DESC_COUNTER(VM, gmap_shadow_pg_te), }; const struct kvm_stats_header kvm_vm_stats_header = {arch/s390/kvm/vsie.c +0
-0
arch/s390/kvm/vsie.c static int acquire_gmap_shadow(struct kvm_vcpu *vcpu, · line 1224
Quoted 4 lines
arch/s390/kvm/vsie.c +1
-0@@ -1221,6 +1221,7 @@ static int acquire_gmap_shadow(struct kvm_vcpu *vcpu,if (IS_ERR (gmap))return PTR_ERR (gmap); gmap->private = vcpu->kvm; + vcpu->kvm->stat.gmap_shadow_acquire++;
Do you rather want to have events for
gmap_shadow_reuse (if gmap_shadow_valid() succeeded in that function) gmap_shadow_create (if we have to create a new one via gmap_shadow)
?
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 1/2] KVM: s390: add stat counter for shadow gmap events
Quoting David Hildenbrand (2023-07-27 09:37:21)
[...]
Quoted 8 lines
Quoted 8 lines
arch/s390/include/asm/kvm_host.h +0
-0@@ -777,6 +777,12 @@ struct kvm_vm_stat {u64 inject_service_signal;u64 inject_virtio;u64 aen_forward;
Quoted 8 lines
arch/s390/include/asm/kvm_host.h struct kvm_vm_stat { · line 785
Quoted 6 lines
arch/s390/include/asm/kvm_host.h +6
-0+u64 gmap_shadow_acquire; +u64 gmap_shadow_r1_te; +u64 gmap_shadow_r2_te; +u64 gmap_shadow_r3_te; +u64 gmap_shadow_sg_te; +u64 gmap_shadow_pg_te;Is "te" supposed to stand for "table entry" ?
Yes.
Quoted 1 line
If so, I'd suggest to just call this
gmap_shadow_pg_entryetc.
Janosch, since you suggested the current naming, are you OK with _entry?
[...]
Quoted 13 lines
arch/s390/kvm/vsie.c static int acquire_gmap_shadow(struct kvm_vcpu *vcpu, · line 1224
Quoted 9 lines
arch/s390/kvm/vsie.c +1
-0@@ -1221,6 +1221,7 @@ static int acquire_gmap_shadow(struct kvm_vcpu *vcpu,if (IS_ERR (gmap))return PTR_ERR (gmap); gmap->private = vcpu->kvm; + vcpu->kvm->stat.gmap_shadow_acquire++;Do you rather want to have events for
Quoted 4 lines
gmap_shadow_reuse(ifgmap_shadow_valid()succeeded in that function)gmap_shadow_create(if we have to create a new one viagmap_shadow)?
Yeah, good suggestion. I'll add that.
Janosch Frank
maintainerRe: [PATCH v2 1/2] KVM: s390: add stat counter for shadow gmap events
Quoted 19 lines · Nico Boehr
Quoting David Hildenbrand (2023-07-27 09:37:21)
[...]Quoted 8 lines
Quoted 8 lines
arch/s390/include/asm/kvm_host.h +0
-0@@ -777,6 +777,12 @@ struct kvm_vm_stat {u64 inject_service_signal;u64 inject_virtio;u64 aen_forward;Quoted 8 lines
arch/s390/include/asm/kvm_host.h struct kvm_vm_stat { · line 785
Quoted 6 lines
arch/s390/include/asm/kvm_host.h +6
-0+u64 gmap_shadow_acquire; +u64 gmap_shadow_r1_te; +u64 gmap_shadow_r2_te; +u64 gmap_shadow_r3_te; +u64 gmap_shadow_sg_te; +u64 gmap_shadow_pg_te;Is "te" supposed to stand for "table entry" ?
Quoted 5 lines
Yes.
Quoted 1 line
If so, I'd suggest to just call this
gmap_shadow_pg_entryetc.Janosch, since you suggested the current naming, are you OK with
_entry?
Sure
Quoted 21 lines
[...]
Quoted 13 lines
arch/s390/kvm/vsie.c static int acquire_gmap_shadow(struct kvm_vcpu *vcpu, · line 1224
Quoted 9 lines
arch/s390/kvm/vsie.c +1
-0@@ -1221,6 +1221,7 @@ static int acquire_gmap_shadow(struct kvm_vcpu *vcpu,if (IS_ERR (gmap))return PTR_ERR (gmap); gmap->private = vcpu->kvm; + vcpu->kvm->stat.gmap_shadow_acquire++;Do you rather want to have events for
Quoted 4 lines
gmap_shadow_reuse(ifgmap_shadow_valid()succeeded in that function)gmap_shadow_create(if we have to create a new one viagmap_shadow)?
Yeah, good suggestion. I'll add that.
PATCH v2 2/2 KVM: s390: add tracepoint in gmap notifier
In reply to Nico BoehrThe gmap notifier is called for changes in table entries with the notifier bit set. To diagnose performance issues, it can be useful to see what causes certain changes in the gmap.
Hence, add a tracepoint in the gmap notifier.
--- arch/s390/kvm/kvm-s390.c | 2 ++ arch/s390/kvm/trace-s390.h | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+)
arch/s390/kvm/kvm-s390.c +2 -0
@@ -3982,6 +3982,8 @@ static void kvm_gmap_notifier(struct gmap *gmap, unsigned long start,unsigned long prefix;unsigned long i; +trace_kvm_s390_gmap_notifier (start, end,gmap_is_shadow (gmap)); +if (gmap_is_shadow (gmap))return ;if (start >=1UL <<31 )
arch/s390/kvm/trace-s390.h +23 -0
@@ -333,6 +333,29 @@ TRACE_EVENT(kvm_s390_airq_suppressed, __entry->id, __entry->isc) ); +/* +* Trace point for gmap notifier calls. +*/ +TRACE_EVENT (kvm_s390_gmap_notifier, + TP_PROTO(unsigned long start, unsigned long end, unsigned int shadow), +TP_ARGS (start, end, shadow), + +TP_STRUCT__entry ( + __field(unsigned long, start) + __field(unsigned long, end) + __field(unsigned int, shadow) + ), + +TP_fast_assign ( + __entry->start = start; + __entry->end = end; + __entry->shadow = shadow; + ), + +TP_printk ("gmap notified (start:0x%lx end:0x%lx shadow:%d)" , + __entry->start, __entry->end, __entry->shadow) + ); +#endif /* _TRACE_KVMS390_H */
Signature · 1 line
2.39.1
Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
Quoted 49 lines · Nico Boehr
The gmap notifier is called for changes in table entries with the notifier bit set. To diagnose performance issues, it can be useful to see what causes certain changes in the gmap.
Hence, add a tracepoint in the gmap notifier.
Signed-off-by Nico Boehr <[email protected]>--- arch/s390/kvm/kvm-s390.c | 2 ++ arch/s390/kvm/trace-s390.h | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+)arch/s390/kvm/kvm-s390.c +2
-0@@ -3982,6 +3982,8 @@ static void kvm_gmap_notifier(struct gmap *gmap, unsigned long start,unsigned long prefix;unsigned long i; +trace_kvm_s390_gmap_notifier (start, end,gmap_is_shadow (gmap)); +if (gmap_is_shadow (gmap))return ;if (start >=1UL <<31 )arch/s390/kvm/trace-s390.h +16
-0@@ -333,6 +333,29 @@ TRACE_EVENT(kvm_s390_airq_suppressed, __entry->id, __entry->isc) ); +/* +* Trace point for gmap notifier calls. +*/ +TRACE_EVENT(kvm_s390_gmap_notifier, + TP_PROTO(unsigned long start, unsigned long end, unsigned int shadow), + TP_ARGS(start, end, shadow), + + TP_STRUCT__entry( + __field(unsigned long, start) + __field(unsigned long, end) + __field(unsigned int, shadow) + ), + + TP_fast_assign( + __entry->start = start; + __entry->end = end;
arch/s390/kvm/trace-s390.h TRACE_EVENT(kvm_s390_airq_suppressed, · line 361
Quoted 10 lines
arch/s390/kvm/trace-s390.h +7
-0+ __entry->shadow = shadow; + ), + +TP_printk ("gmap notified (start:0x%lx end:0x%lx shadow:%d)" , + __entry->start, __entry->end, __entry->shadow) + ); +#endif /* _TRACE_KVMS390_H */
In the context of vsie, I'd have thought you'd be tracing kvm_s390_vsie_gmap_notifier() instead.
This should work as well, as all notifier are called.
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
Quoting David Hildenbrand (2023-07-27 09:41:51)
Quoted 58 lines · Nico Boehr
Quoted 57 lines
The gmap notifier is called for changes in table entries with the notifier bit set. To diagnose performance issues, it can be useful to see what causes certain changes in the gmap.
Hence, add a tracepoint in the gmap notifier.
Signed-off-by Nico Boehr <[email protected]>--- arch/s390/kvm/kvm-s390.c | 2 ++ arch/s390/kvm/trace-s390.h | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+)arch/s390/kvm/kvm-s390.c +2
-0@@ -3982,6 +3982,8 @@ static void kvm_gmap_notifier(struct gmap *gmap, unsigned long start,unsigned long prefix;unsigned long i; +trace_kvm_s390_gmap_notifier (start, end,gmap_is_shadow (gmap)); +if (gmap_is_shadow (gmap))return ;if (start >=1UL <<31 )arch/s390/kvm/trace-s390.h +23
-0@@ -333,6 +333,29 @@ TRACE_EVENT(kvm_s390_airq_suppressed, __entry->id, __entry->isc) ); +/* +* Trace point for gmap notifier calls. +*/ +TRACE_EVENT (kvm_s390_gmap_notifier, + TP_PROTO(unsigned long start, unsigned long end, unsigned int shadow), +TP_ARGS (start, end, shadow), + +TP_STRUCT__entry ( + __field(unsigned long, start) + __field(unsigned long, end) + __field(unsigned int, shadow) + ), + +TP_fast_assign ( + __entry->start = start; + __entry->end = end; + __entry->shadow = shadow; + ), + +TP_printk ("gmap notified (start:0x%lx end:0x%lx shadow:%d)" , + __entry->start, __entry->end, __entry->shadow) + ); +
Quoted 5 lines
arch/s390/kvm/trace-s390.h TRACE_EVENT(kvm_s390_airq_suppressed, · line 361
Quoted 2 lines
arch/s390/kvm/trace-s390.h +0
-0#endif /* _TRACE_KVMS390_H */ In the context of vsie, I'd have thought you'd be tracing
kvm_s390_vsie_gmap_notifier()instead.
Right, I can change that if you / others have a preference for that.
Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
#endif /* _TRACE_KVMS390_H */In the context of vsie, I'd have thought you'd be tracing
kvm_s390_vsie_gmap_notifier()instead.Right, I can change that if you / others have a preference for that.
No strong opinion, just a thought.
Signature · 3 lines
Cheers, David / dhildenb
Polite ping.
Quoting Nico Boehr (2023-05-10 14:18:20)
Quoted 47 lines
v2:
---
* also count shadowing of pages (Janosch)
* fix naming of counters (Janosch)
* mention shadowing of multiple levels is counted in each level (Claudio)
* fix inaccuate commit description regarding gmap notifier (Claudio)When running a guest-3 via VSIE, guest-1 needs to shadow the page table structures of guest-2.
To reflect changes of the guest-2 in the _shadowed_ page table structures, the _shadowing_ sturctures sometimes need to be rebuilt. Since this is a costly operation, it should be avoided whenever possible.
This series adds kvm stat counters to count the number of shadow gmaps created and a tracepoint whenever something is unshadowed. This is a first step to try and improve VSIE performance.
Please note that "KVM: s390: add tracepoint in gmap notifier" has some checkpatch --strict findings. I did not fix these since the tracepoint definition would then look completely different from all the other tracepoints in
arch/s390/kvm/trace-s390.h. If you want me to fix that, please let me know.While developing this, a question regarding the stat counters came up:
there's usually no locking involved when the stat counters are incremented. On s390, GCC accidentally seems to do the right thing(TM) most of the time by generating a agsi instruction (which should be atomic given proper alignment). However, it's not guaranteed, so would we rather want to go with an atomic for the stat counters to avoid losing events? Or do we just accept the fact that we might loose events sometimes? Is there anything that speaks against having an atomic inkvm_stat?Nico Boehr (2):
KVM: s390: add stat counter for shadow gmap events
KVM: s390: add tracepoint in gmap notifierarch/s390/include/asm/kvm_host.h | 6 ++++++ arch/s390/kvm/gaccess.c | 7 +++++++ arch/s390/kvm/kvm-s390.c | 10 +++++++++- arch/s390/kvm/trace-s390.h | 23 +++++++++++++++++++++++ arch/s390/kvm/vsie.c | 1 + 5 files changed, 46 insertions(+), 1 deletion(-)Signature · 1 line
2.39.1