Skip to contentSkip to conversation

drm/msm/disp/dpu1: add safe lut config in dpu driver

PATCH Superseded Kalyan Thota 3 participants 4 messages Aug 3, 2021 – Aug 4, 2021

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/msm/disp/dpu1: add safe lut config in dpu driver

Add safe lut configuration for all the targets in dpu driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalidaiton process thus impacting the performance on NRT clients such as eMMC and NVMe.

Validated this change on SC7280, With this change eMMC performance has improved significantly.

Changes in v1:
- Add fixes tag (Sai)
- CC stable kernel (Dimtry)

Fixes cfacf946a464d4(drm/msm/disp/dpu1: add support for display for SC7280 target)
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +5 -0
index d01c4c9..2e482cd 100644
@@ -974,6 +974,7 @@ static const struct dpu_perf_cfg sdm845_perf_data = {
 	.amortizable_threshold = 25,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xf000, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sdm845_qos_linear),
 		.entries = sdm845_qos_linear
@@ -1001,6 +1002,7 @@ static const struct dpu_perf_cfg sc7180_perf_data = {
 	.min_dram_ib = 1600000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xff, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_linear),
 		.entries = sc7180_qos_linear
@@ -1028,6 +1030,7 @@ static const struct dpu_perf_cfg sm8150_perf_data = {
 	.min_dram_ib = 800000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff8, 0xf000, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sm8150_qos_linear),
 		.entries = sm8150_qos_linear
@@ -1056,6 +1059,7 @@ static const struct dpu_perf_cfg sm8250_perf_data = {
 	.min_dram_ib = 800000,
 	.min_prefill_lines = 35,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_linear),
 		.entries = sc7180_qos_linear
@@ -1084,6 +1088,7 @@ static const struct dpu_perf_cfg sc7280_perf_data = {
 	.min_dram_ib = 1600000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xffff, 0xffff, 0x0},
+	.safe_lut_tbl = {0xff00, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_macrotile),
 		.entries = sc7180_qos_macrotile
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1
#1 lore raw
Quoted 15 lines · Kalyan Thota

Add safe lut configuration for all the targets in dpu driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalidaiton process thus impacting the performance on NRT clients such as eMMC and NVMe.

Validated this change on SC7280, With this change eMMC performance has improved significantly.

Quoted 7 lines

Changes in v1:
- Add fixes tag (Sai)
- CC stable kernel (Dimtry)

Fixes cfacf946a464d4(drm/msm/disp/dpu1: add support for display for SC7280 target)
Quoted 51 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +5 -1
index d01c4c9..2e482cd 100644
@@ -974,6 +974,7 @@ static const struct dpu_perf_cfg sdm845_perf_data = {
        .amortizable_threshold = 25,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xf000, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sdm845_qos_linear),
                .entries = sdm845_qos_linear
@@ -1001,6 +1002,7 @@ static const struct dpu_perf_cfg sc7180_perf_data = {
        .min_dram_ib = 1600000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xff, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_linear),
                .entries = sc7180_qos_linear
@@ -1028,6 +1030,7 @@ static const struct dpu_perf_cfg sm8150_perf_data = {
        .min_dram_ib = 800000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff8, 0xf000, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sm8150_qos_linear),
                .entries = sm8150_qos_linear
@@ -1056,6 +1059,7 @@ static const struct dpu_perf_cfg sm8250_perf_data = {
        .min_dram_ib = 800000,
        .min_prefill_lines = 35,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_linear),
                .entries = sc7180_qos_linear
@@ -1084,6 +1088,7 @@ static const struct dpu_perf_cfg sc7280_perf_data = {
        .min_dram_ib = 1600000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xffff, 0xffff, 0x0},
+       .safe_lut_tbl = {0xff00, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_macrotile),
                .entries = sc7180_qos_macrotile
--

2.7.4

Signature · 2 lines
With best wishes
Dmitry
#2 lore raw
In reply to Kalyan Thota

Quoting Kalyan Thota (2021-08-03 03:41:47)

Quoted 11 lines

Add safe lut configuration for all the targets in dpu driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalidaiton process thus impacting the performance on NRT clients such as eMMC and NVMe.

Quoted 8 lines

Validated this change on SC7280, With this change eMMC performance has improved significantly.

Changes in v1:
- Add fixes tag (Sai)
- CC stable kernel (Dimtry)

Fixes cfacf946a464d4(drm/msm/disp/dpu1: add support for display for SC7280 target)

This is wrong format and commit hash

Fixes 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for

SC7280 target")

Quoted 2 lines
#3 lore raw
Quoted 15 lines · Stephen Boyd

Quoting Kalyan Thota (2021-08-03 03:41:47)

Quoted 14 lines

Add safe lut configuration for all the targets in dpu driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalidaiton process thus impacting the performance on NRT clients such as eMMC and NVMe.

Validated this change on SC7280, With this change eMMC performance has improved significantly.

Quoted 8 lines
Quoted 5 lines

Changes in v1:
- Add fixes tag (Sai)
- CC stable kernel (Dimtry)

Fixes cfacf946a464d4(drm/msm/disp/dpu1: add support for display for SC7280 target)

This is wrong format and commit hash

My bad, i'll fix it right away
- KT

Quoted 5 lines
Fixes 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for

SC7280 target")

Quoted 2 lines