Skip to contentSkip to conversation

staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

PATCH Superseded Aliya Rahmani 2 participants 2 messages Apr 13, 2022 Staging

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('

Code style warnings reported by checkpatch.
Improve the layout of a function header:
*Put the first parameter immediately after the '(' and align the other parameters underneath it.

---
v1->v2 changes: Put static and void on a single line.

v2->v3 changes: Rework commit description.

---
 drivers/staging/vt6655/rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rxtx.c +1 -1
index 01dc83b2f4bc..2853cb9efd30 100644
@@ -568,7 +568,7 @@ s_uFillDataHead(
 }
 
 static void
-s_vFillRTSHead(struct vnt_private *pDevice,
+s_vFillRTSHead( struct vnt_private *pDevice,
 		unsigned char byPktType,
 		void *pvRTS,
 		unsigned int cbFrameLength,
Signature · 1 line
2.25.1
#1 lore raw

Hi Aliya,

Quoted 19 lines · Aliya Rahmani

Code style warnings reported by checkpatch.
Improve the layout of a function header:
*Put the first parameter immediately after the '(' and align the other parameters underneath it.

---
v1->v2 changes: Put static and void on a single line.

v2->v3 changes: Rework commit description.

---
  drivers/staging/vt6655/rxtx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rxtx.c +0 -0
index 01dc83b2f4bc..2853cb9efd30 100644

drivers/staging/vt6655/rxtx.c s_uFillDataHead( · line 571

Quoted 5 lines
drivers/staging/vt6655/rxtx.c +1 -1
@@ -568,7 +568,7 @@ s_uFillDataHead(
  }
 
  static void
-s_vFillRTSHead(struct vnt_private *pDevice,
+s_vFillRTSHead( struct vnt_private *pDevice,

You have only added extra space. Why?

With regards,
Pavel Skripkin