drm: Restore helper usability
Subsystems (29)
Geert Uytterhoeven
maintainercover drm: Restore helper usability
Hi all,
As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.
Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.
Thanks for applying!
[1] https://lore.kernel.org/r/[email protected]/
Geert Uytterhoeven (11):
Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2" Revert "drm/display: Select DRM_KMS_HELPER for DP helpers" Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable" Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies" Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on" Revert "drm: Switch DRM_DISPLAY_HELPER to depends on" Revert "drm: Make drivers depends on DRM_DW_HDMI"
Revert "drm/display: Make all helpers visible and switch to depends
on"
drivers/gpu/drm/Kconfig | 8 +++---- drivers/gpu/drm/amd/amdgpu/Kconfig | 12 ++++------ drivers/gpu/drm/bridge/Kconfig | 28 +++++++++++----------- drivers/gpu/drm/bridge/analogix/Kconfig | 18 +++++++------- drivers/gpu/drm/bridge/cadence/Kconfig | 8 +++---- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 ++--- drivers/gpu/drm/display/Kconfig | 32 ++++++++++--------------- drivers/gpu/drm/exynos/Kconfig | 4 ++-- drivers/gpu/drm/i915/Kconfig | 8 +++---- drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++-- drivers/gpu/drm/ingenic/Kconfig | 2 +- drivers/gpu/drm/mediatek/Kconfig | 6 ++--- drivers/gpu/drm/meson/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 8 +++---- drivers/gpu/drm/nouveau/Kconfig | 10 ++++---- drivers/gpu/drm/panel/Kconfig | 32 ++++++++++++------------- drivers/gpu/drm/radeon/Kconfig | 8 +++---- drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 10 ++++---- drivers/gpu/drm/sun4i/Kconfig | 2 +- drivers/gpu/drm/tegra/Kconfig | 8 +++---- drivers/gpu/drm/vc4/Kconfig | 10 ++++---- drivers/gpu/drm/xe/Kconfig | 13 ++++------ drivers/gpu/drm/xlnx/Kconfig | 8 +++---- 25 files changed, 116 insertions(+), 138 deletions(-)
Signature · 12 lines
2.34.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH 1/11 Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2"
This reverts commit a57e191ebbaa0363dbf352cc37447c2230573e29, as the commits it fixes will be reverted, too.
--- drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/analogix/Kconfig +1 -1
@@ -28,7 +28,7 @@ config DRM_ANALOGIX_ANX78XX config DRM_ANALOGIX_DP tristate - depends on DRM_DISPLAY_HELPER + depends on DRM config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support"
drivers/gpu/drm/rockchip/Kconfig +1 -1
@@ -36,7 +36,7 @@ config ROCKCHIP_VOP2 config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HELPER=y || (DRM_DISPLAY_HELPER=m && DRM_ROCKCHIP=m) + depends on DRM_DISPLAY_HELPER depends on ROCKCHIP_VOP help This selects support for Rockchip SoC specific extensions
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 2/11 Revert "drm/display: Select DRM_KMS_HELPER for DP helpers"
In reply to Geert UytterhoevenThis reverts commit 7fa678cc0a5648b5ea28629a2d21b9d4b6ac8f56, as the commit it fixes will be reverted, too.
--- drivers/gpu/drm/display/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/display/Kconfig +0 -1
@@ -39,7 +39,6 @@ config DRM_DISPLAY_DP_AUX_CHARDEV config DRM_DISPLAY_DP_HELPER bool "DRM DisplayPort Helpers" depends on DRM_DISPLAY_HELPER - select DRM_KMS_HELPER default y help DRM display helpers for DisplayPort.
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 3/11 Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable"
In reply to Geert UytterhoevenThis reverts commit 0209df3b4731516fe77638bfc52ba2e9629c67cd, as the commit it fixes (which is BTW not the commit in the Fixes: tag!) will be reverted, too.
--- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/synopsys/Kconfig +1 -1
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_DW_HDMI - tristate "Synopsys Designware HDMI TX Controller" + tristate depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER select DRM_KMS_HELPER
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 4/11 Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies"
In reply to Geert UytterhoevenThis reverts commit d1ef8fc18be6adbbffdee06fbb5b33699e2852be, as the commit it fixes will be reverted, too.
--- drivers/gpu/drm/exynos/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/exynos/Kconfig +1 -1
@@ -68,7 +68,7 @@ config DRM_EXYNOS_DP bool "Exynos specific extensions for Analogix DP driver" depends on DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HELPER=y || (DRM_DISPLAY_HELPER=m && DRM_EXYNOS=m) + depends on DRM_DISPLAY_HELPER select DRM_ANALOGIX_DP default DRM_EXYNOS select DRM_PANEL
drivers/gpu/drm/rockchip/Kconfig +1 -1
@@ -46,7 +46,7 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP bool "Rockchip cdn DP" depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HELPER=y || (DRM_DISPLAY_HELPER=m && DRM_ROCKCHIP=m) + depends on DRM_DISPLAY_HELPER depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) help This selects support for Rockchip SoC specific extensions
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 5/11 Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on"
In reply to Geert UytterhoevenThis reverts commit f6d2dc03fa8546b284dd8c1af027d9fac5725921, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- drivers/gpu/drm/display/Kconfig | 1 - drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/nouveau/Kconfig | 2 +- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/drm/vc4/Kconfig | 2 +- drivers/gpu/drm/xe/Kconfig | 2 +- 8 files changed, 7 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/amdgpu/Kconfig +1 -1
@@ -5,12 +5,12 @@ config DRM_AMDGPU depends on DRM depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HDCP_HELPER - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI depends on !UML select FW_LOADER + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_SCHED select DRM_TTM
drivers/gpu/drm/bridge/synopsys/Kconfig +1 -1
@@ -1,8 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_DW_HDMI tristate - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select REGMAP_MMIO select CEC_CORE if CEC_NOTIFIER
drivers/gpu/drm/display/Kconfig +0 -1
@@ -74,6 +74,5 @@ config DRM_DISPLAY_HDCP_HELPER config DRM_DISPLAY_HDMI_HELPER bool "DRM HDMI Helpers" depends on DRM_DISPLAY_HELPER - default y help DRM display helpers for HDMI.
drivers/gpu/drm/i915/Kconfig +1 -1
@@ -4,7 +4,6 @@ config DRM_I915 depends on DRM depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HDCP_HELPER - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on X86 && PCI depends on !PREEMPT_RT
@@ -14,6 +13,7 @@ config DRM_I915 # the shmem_readpage() which depends upon tmpfs select SHMEM select TMPFS + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_PANEL select DRM_MIPI_DSI
drivers/gpu/drm/nouveau/Kconfig +1 -1
@@ -3,12 +3,12 @@ config DRM_NOUVEAU tristate "Nouveau (NVIDIA) cards" depends on DRM depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on PCI depends on MMU select IOMMU_API select FW_LOADER + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_TTM select DRM_TTM_HELPER
drivers/gpu/drm/tegra/Kconfig +1 -1
@@ -6,9 +6,9 @@ config DRM_TEGRA depends on DRM depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL
drivers/gpu/drm/vc4/Kconfig +1 -1
@@ -4,13 +4,13 @@ config DRM_VC4 depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST depends on COMMON_CLK depends on DRM - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on PM # Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only # happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE. depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) depends on SND && SND_SOC + select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER select DRM_PANEL_BRIDGE
drivers/gpu/drm/xe/Kconfig +1 -1
@@ -5,7 +5,6 @@ config DRM_XE depends on DRM depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HDCP_HELPER - depends on DRM_DISPLAY_HDMI_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI
@@ -20,6 +19,7 @@ config DRM_XE select DRM_KUNIT_TEST_HELPERS if DRM_XE_KUNIT_TEST != n select DRM_PANEL select DRM_SUBALLOC_HELPER + select DRM_DISPLAY_HDMI_HELPER select DRM_MIPI_DSI select RELAY select IRQ_WORK
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 6/11 Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on"
In reply to Geert UytterhoevenThis reverts commit 3166e7e6d935caaef07605a5c90773fbf9ffeaf4, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu/drm/bridge/Kconfig | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu/drm/bridge/cadence/Kconfig | 2 +- drivers/gpu/drm/display/Kconfig | 1 - drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/xe/Kconfig | 2 +- 7 files changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/Kconfig +1 -1
@@ -4,13 +4,13 @@ config DRM_AMDGPU tristate "AMD GPU" depends on DRM depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI depends on !UML select FW_LOADER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER select DRM_SCHED select DRM_TTM
drivers/gpu/drm/bridge/Kconfig +1 -1
@@ -94,9 +94,9 @@ config DRM_ITE_IT6505 tristate "ITE IT6505 DisplayPort bridge" depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER select EXTCON select CRYPTO
drivers/gpu/drm/bridge/analogix/Kconfig +1 -1
@@ -35,9 +35,9 @@ config DRM_ANALOGIX_ANX7625 depends on DRM depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_HDCP_HELPER select DRM_MIPI_DSI help ANX7625 is an ultra-low power 4K mobile HD transmitter
drivers/gpu/drm/bridge/cadence/Kconfig +1 -1
@@ -24,9 +24,9 @@ endif config DRM_CDNS_MHDP8546 tristate "Cadence DPI/DP bridge" depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER select DRM_PANEL_BRIDGE help
drivers/gpu/drm/display/Kconfig +0 -1
@@ -67,7 +67,6 @@ config DRM_DISPLAY_DP_TUNNEL_STATE_DEBUG config DRM_DISPLAY_HDCP_HELPER bool "DRM HDCD Helpers" depends on DRM_DISPLAY_HELPER - default y help DRM display helpers for HDCP.
drivers/gpu/drm/i915/Kconfig +1 -1
@@ -3,7 +3,6 @@ config DRM_I915 tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" depends on DRM depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on X86 && PCI depends on !PREEMPT_RT
@@ -13,6 +12,7 @@ config DRM_I915 # the shmem_readpage() which depends upon tmpfs select SHMEM select TMPFS + select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_PANEL
drivers/gpu/drm/xe/Kconfig +1 -1
@@ -4,7 +4,6 @@ config DRM_XE depends on (m || (y && KUNIT=y)) depends on DRM depends on DRM_DISPLAY_DP_HELPER - depends on DRM_DISPLAY_HDCP_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI
@@ -19,6 +18,7 @@ config DRM_XE select DRM_KUNIT_TEST_HELPERS if DRM_XE_KUNIT_TEST != n select DRM_PANEL select DRM_SUBALLOC_HELPER + select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_MIPI_DSI select RELAY
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 7/11 Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on"
In reply to Geert UytterhoevenThis reverts commit 0323287de87d7e6e9c22c57d7440aa353a2298d0, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu/drm/bridge/Kconfig | 10 +++++----- drivers/gpu/drm/bridge/analogix/Kconfig | 6 +++--- drivers/gpu/drm/bridge/cadence/Kconfig | 2 +- drivers/gpu/drm/display/Kconfig | 1 - drivers/gpu/drm/exynos/Kconfig | 2 +- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 2 +- drivers/gpu/drm/nouveau/Kconfig | 2 +- drivers/gpu/drm/panel/Kconfig | 8 ++++---- drivers/gpu/drm/radeon/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 4 ++-- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/drm/xe/Kconfig | 2 +- drivers/gpu/drm/xlnx/Kconfig | 2 +- 17 files changed, 26 insertions(+), 27 deletions(-)
drivers/gpu/drm/Kconfig +1 -1
@@ -75,11 +75,11 @@ config DRM_KUNIT_TEST_HELPERS config DRM_KUNIT_TEST tristate "KUnit tests for DRM" if !KUNIT_ALL_TESTS depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on KUNIT depends on MMU select DRM_BUDDY + select DRM_DISPLAY_DP_HELPER select DRM_EXEC select DRM_EXPORT_FOR_TESTS if m select DRM_GEM_SHMEM_HELPER
drivers/gpu/drm/amd/amdgpu/Kconfig +1 -1
@@ -3,12 +3,12 @@ config DRM_AMDGPU tristate "AMD GPU" depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI depends on !UML select FW_LOADER + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER
drivers/gpu/drm/bridge/Kconfig +5 -5
@@ -93,9 +93,9 @@ config DRM_FSL_LDB config DRM_ITE_IT6505 tristate "ITE IT6505 DisplayPort bridge" depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER select EXTCON
@@ -226,9 +226,9 @@ config DRM_PARADE_PS8622 config DRM_PARADE_PS8640 tristate "Parade PS8640 MIPI DSI to eDP Converter" depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL
@@ -312,9 +312,9 @@ config DRM_TOSHIBA_TC358764 config DRM_TOSHIBA_TC358767 tristate "Toshiba TC358767 eDP bridge" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_MIPI_DSI
@@ -335,9 +335,9 @@ config DRM_TOSHIBA_TC358768 config DRM_TOSHIBA_TC358775 tristate "Toshiba TC358775 DSI/LVDS bridge" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_PANEL
@@ -381,9 +381,9 @@ config DRM_TI_SN65DSI83 config DRM_TI_SN65DSI86 tristate "TI SN65DSI86 DSI to eDP bridge" depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_PANEL
drivers/gpu/drm/bridge/analogix/Kconfig +3 -3
@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_ANALOGIX_ANX6345 tristate "Analogix ANX6345 bridge" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF select DRM_ANALOGIX_DP + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select REGMAP_I2C help
@@ -15,9 +15,9 @@ config DRM_ANALOGIX_ANX6345 config DRM_ANALOGIX_ANX78XX tristate "Analogix ANX78XX bridge" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER select DRM_ANALOGIX_DP + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select REGMAP_I2C help
@@ -34,9 +34,9 @@ config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support" depends on DRM depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_MIPI_DSI help
drivers/gpu/drm/bridge/cadence/Kconfig +1 -1
@@ -23,9 +23,9 @@ endif config DRM_CDNS_MHDP8546 tristate "Cadence DPI/DP bridge" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_KMS_HELPER select DRM_PANEL_BRIDGE
drivers/gpu/drm/display/Kconfig +0 -1
@@ -39,7 +39,6 @@ config DRM_DISPLAY_DP_AUX_CHARDEV config DRM_DISPLAY_DP_HELPER bool "DRM DisplayPort Helpers" depends on DRM_DISPLAY_HELPER - default y help DRM display helpers for DisplayPort.
drivers/gpu/drm/exynos/Kconfig +1 -1
@@ -67,9 +67,9 @@ config DRM_EXYNOS_DSI config DRM_EXYNOS_DP bool "Exynos specific extensions for Analogix DP driver" depends on DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER select DRM_ANALOGIX_DP + select DRM_DISPLAY_DP_HELPER default DRM_EXYNOS select DRM_PANEL help
drivers/gpu/drm/i915/Kconfig +1 -1
@@ -2,7 +2,6 @@ config DRM_I915 tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on X86 && PCI depends on !PREEMPT_RT
@@ -12,6 +11,7 @@ config DRM_I915 # the shmem_readpage() which depends upon tmpfs select SHMEM select TMPFS + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER
drivers/gpu/drm/mediatek/Kconfig +1 -1
@@ -23,10 +23,10 @@ config DRM_MEDIATEK config DRM_MEDIATEK_DP tristate "DRM DPTX Support for MediaTek SoCs" depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on DRM_MEDIATEK select PHY_MTK_DP + select DRM_DISPLAY_DP_HELPER help DRM/KMS Display Port driver for MediaTek SoCs.
drivers/gpu/drm/msm/Kconfig +1 -1
@@ -6,7 +6,6 @@ config DRM_MSM depends on COMMON_CLK depends on DRM depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on IOMMU_SUPPORT depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
@@ -17,6 +16,7 @@ config DRM_MSM select IOMMU_IO_PGTABLE select QCOM_MDT_LOADER if ARCH_QCOM select REGULATOR + select DRM_DISPLAY_DP_HELPER select DRM_EXEC select DRM_KMS_HELPER select DRM_PANEL
drivers/gpu/drm/nouveau/Kconfig +1 -1
@@ -2,12 +2,12 @@ config DRM_NOUVEAU tristate "Nouveau (NVIDIA) cards" depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on PCI depends on MMU select IOMMU_API select FW_LOADER + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_TTM
drivers/gpu/drm/panel/Kconfig +4 -4
@@ -545,10 +545,10 @@ config DRM_PANEL_RAYDIUM_RM68200 config DRM_PANEL_RAYDIUM_RM692E5 tristate "Raydium RM692E5-based DSI panel" depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on DRM_MIPI_DSI depends on OF + select DRM_DISPLAY_DP_HELPER help Say Y here if you want to enable support for Raydium RM692E5-based display panels, such as the one found in the Fairphone 5 smartphone.
@@ -572,10 +572,10 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20 tristate "Samsung ATNA33XC20 eDP panel" depends on BACKLIGHT_CLASS_DEVICE depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF depends on PM + select DRM_DISPLAY_DP_HELPER help DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't be handled by the DRM_PANEL_SIMPLE driver because its power
@@ -812,11 +812,11 @@ config DRM_PANEL_EDP tristate "support for simple Embedded DisplayPort panels" depends on BACKLIGHT_CLASS_DEVICE depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF depends on PM select VIDEOMODE_HELPERS + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER help DRM panel driver for dumb eDP panels that need at most a regulator and
@@ -891,10 +891,10 @@ config DRM_PANEL_TRULY_NT35597_WQXGA config DRM_PANEL_VISIONOX_R66451 tristate "Visionox R66451" depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on DRM_MIPI_DSI depends on OF + select DRM_DISPLAY_DP_HELPER help Say Y here if you want to enable support for Visionox R66451 1080x2340 AMOLED DSI panel.
drivers/gpu/drm/radeon/Kconfig +1 -1
@@ -4,11 +4,11 @@ config DRM_RADEON tristate "ATI Radeon" depends on AGP || !AGP depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on PCI depends on MMU select FW_LOADER + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select DRM_SUBALLOC_HELPER select DRM_TTM
drivers/gpu/drm/rockchip/Kconfig +2 -2
@@ -35,9 +35,9 @@ config ROCKCHIP_VOP2 config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on ROCKCHIP_VOP + select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions for the Analogix Core DP driver. If you want to enable DP
@@ -45,9 +45,9 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP bool "Rockchip cdn DP" - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) + select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions for the cdn DP driver. If you want to enable Dp on
drivers/gpu/drm/tegra/Kconfig +1 -1
@@ -5,9 +5,9 @@ config DRM_TEGRA depends on COMMON_CLK depends on DRM depends on DRM_DISPLAY_DP_AUX_BUS - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI
drivers/gpu/drm/xe/Kconfig +1 -1
@@ -3,7 +3,6 @@ config DRM_XE tristate "Intel Xe Graphics" depends on (m || (y && KUNIT=y)) depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on MMU depends on PCI
@@ -18,6 +17,7 @@ config DRM_XE select DRM_KUNIT_TEST_HELPERS if DRM_XE_KUNIT_TEST != n select DRM_PANEL select DRM_SUBALLOC_HELPER + select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_MIPI_DSI
drivers/gpu/drm/xlnx/Kconfig +1 -1
@@ -4,12 +4,12 @@ config DRM_ZYNQMP_DPSUB depends on COMMON_CLK depends on DMADEVICES depends on DRM - depends on DRM_DISPLAY_DP_HELPER depends on DRM_DISPLAY_HELPER depends on OF depends on PHY_XILINX_ZYNQMP depends on XILINX_ZYNQMP_DPDMA select DMA_ENGINE + select DRM_DISPLAY_DP_HELPER select DRM_GEM_DMA_HELPER select DRM_KMS_HELPER select GENERIC_PHY
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 8/11 Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on"
In reply to Geert UytterhoevenThis reverts commit 4d15125d7fe637f401e64e33c99513adf6586fdd, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/bridge/Kconfig | 6 +++--- drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu/drm/display/Kconfig | 1 - drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 2 +- drivers/gpu/drm/panel/Kconfig | 4 ++-- drivers/gpu/drm/tegra/Kconfig | 2 +- 7 files changed, 9 insertions(+), 10 deletions(-)
drivers/gpu/drm/bridge/Kconfig +3 -3
@@ -92,11 +92,11 @@ config DRM_FSL_LDB config DRM_ITE_IT6505 tristate "ITE IT6505 DisplayPort bridge" - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select EXTCON select CRYPTO
@@ -225,10 +225,10 @@ config DRM_PARADE_PS8622 config DRM_PARADE_PS8640 tristate "Parade PS8640 MIPI DSI to eDP Converter" - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL
@@ -380,7 +380,6 @@ config DRM_TI_SN65DSI83 config DRM_TI_SN65DSI86 tristate "TI SN65DSI86 DSI to eDP bridge" - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER
@@ -389,6 +388,7 @@ config DRM_TI_SN65DSI86 select DRM_PANEL select DRM_MIPI_DSI select AUXILIARY_BUS + select DRM_DISPLAY_DP_AUX_BUS help Texas Instruments SN65DSI86 DSI to eDP Bridge driver
drivers/gpu/drm/bridge/analogix/Kconfig +1 -1
@@ -33,11 +33,11 @@ config DRM_ANALOGIX_DP config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support" depends on DRM - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_DP_AUX_BUS select DRM_MIPI_DSI help ANX7625 is an ultra-low power 4K mobile HD transmitter
drivers/gpu/drm/display/Kconfig +0 -1
@@ -11,7 +11,6 @@ config DRM_DISPLAY_DP_AUX_BUS tristate "DRM DisplayPort AUX bus support" depends on DRM depends on OF || COMPILE_TEST - default y config DRM_DISPLAY_DP_AUX_CEC bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
drivers/gpu/drm/mediatek/Kconfig +1 -1
@@ -22,11 +22,11 @@ config DRM_MEDIATEK config DRM_MEDIATEK_DP tristate "DRM DPTX Support for MediaTek SoCs" - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on DRM_MEDIATEK select PHY_MTK_DP select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_DP_AUX_BUS help DRM/KMS Display Port driver for MediaTek SoCs.
drivers/gpu/drm/msm/Kconfig +1 -1
@@ -5,7 +5,6 @@ config DRM_MSM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on COMMON_CLK depends on DRM - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on IOMMU_SUPPORT depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
@@ -16,6 +15,7 @@ config DRM_MSM select IOMMU_IO_PGTABLE select QCOM_MDT_LOADER if ARCH_QCOM select REGULATOR + select DRM_DISPLAY_DP_AUX_BUS select DRM_DISPLAY_DP_HELPER select DRM_EXEC select DRM_KMS_HELPER
drivers/gpu/drm/panel/Kconfig +2 -2
@@ -571,11 +571,11 @@ config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01 config DRM_PANEL_SAMSUNG_ATNA33XC20 tristate "Samsung ATNA33XC20 eDP panel" depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF depends on PM select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_DP_AUX_BUS help DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't be handled by the DRM_PANEL_SIMPLE driver because its power
@@ -811,12 +811,12 @@ config DRM_PANEL_STARTEK_KD070FHFID015 config DRM_PANEL_EDP tristate "support for simple Embedded DisplayPort panels" depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF depends on PM select VIDEOMODE_HELPERS select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER help DRM panel driver for dumb eDP panels that need at most a regulator and
drivers/gpu/drm/tegra/Kconfig +1 -1
@@ -4,11 +4,11 @@ config DRM_TEGRA depends on ARCH_TEGRA || COMPILE_TEST depends on COMMON_CLK depends on DRM - depends on DRM_DISPLAY_DP_AUX_BUS depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 9/11 Revert "drm: Switch DRM_DISPLAY_HELPER to depends on"
In reply to Geert UytterhoevenThis reverts commit e075e496f516bf92bc0cbaf94d64e8d4a6b58321, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/Kconfig | 6 ++---- drivers/gpu/drm/amd/amdgpu/Kconfig | 6 ++---- drivers/gpu/drm/bridge/Kconfig | 10 +++++----- drivers/gpu/drm/bridge/analogix/Kconfig | 6 +++--- drivers/gpu/drm/bridge/cadence/Kconfig | 4 ++-- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- drivers/gpu/drm/display/Kconfig | 1 - drivers/gpu/drm/exynos/Kconfig | 2 +- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 4 ++-- drivers/gpu/drm/nouveau/Kconfig | 6 ++---- drivers/gpu/drm/panel/Kconfig | 20 ++++++++++---------- drivers/gpu/drm/radeon/Kconfig | 6 ++---- drivers/gpu/drm/rockchip/Kconfig | 4 ++-- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/drm/vc4/Kconfig | 8 ++++---- drivers/gpu/drm/xe/Kconfig | 7 ++----- drivers/gpu/drm/xlnx/Kconfig | 6 ++---- 19 files changed, 45 insertions(+), 59 deletions(-)
drivers/gpu/drm/Kconfig +2 -4
@@ -74,12 +74,10 @@ config DRM_KUNIT_TEST_HELPERS config DRM_KUNIT_TEST tristate "KUnit tests for DRM" if !KUNIT_ALL_TESTS - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on KUNIT - depends on MMU + depends on DRM && KUNIT && MMU select DRM_BUDDY select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_EXEC select DRM_EXPORT_FOR_TESTS if m select DRM_GEM_SHMEM_HELPER
drivers/gpu/drm/amd/amdgpu/Kconfig +2 -4
@@ -2,15 +2,13 @@ config DRM_AMDGPU tristate "AMD GPU" - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on MMU - depends on PCI + depends on DRM && PCI && MMU depends on !UML select FW_LOADER select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_SCHED select DRM_TTM
drivers/gpu/drm/bridge/Kconfig +5 -5
@@ -92,10 +92,10 @@ config DRM_FSL_LDB config DRM_ITE_IT6505 tristate "ITE IT6505 DisplayPort bridge" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select EXTCON
@@ -225,9 +225,9 @@ config DRM_PARADE_PS8622 config DRM_PARADE_PS8640 tristate "Parade PS8640 MIPI DSI to eDP Converter" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select DRM_MIPI_DSI
@@ -312,9 +312,9 @@ config DRM_TOSHIBA_TC358764 config DRM_TOSHIBA_TC358767 tristate "Toshiba TC358767 eDP bridge" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_MIPI_DSI
@@ -335,9 +335,9 @@ config DRM_TOSHIBA_TC358768 config DRM_TOSHIBA_TC358775 tristate "Toshiba TC358775 DSI/LVDS bridge" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_PANEL
@@ -380,9 +380,9 @@ config DRM_TI_SN65DSI83 config DRM_TI_SN65DSI86 tristate "TI SN65DSI86 DSI to eDP bridge" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_I2C select DRM_PANEL
drivers/gpu/drm/bridge/analogix/Kconfig +3 -3
@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_ANALOGIX_ANX6345 tristate "Analogix ANX6345 bridge" - depends on DRM_DISPLAY_HELPER depends on OF select DRM_ANALOGIX_DP select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_I2C help
@@ -15,9 +15,9 @@ config DRM_ANALOGIX_ANX6345 config DRM_ANALOGIX_ANX78XX tristate "Analogix ANX78XX bridge" - depends on DRM_DISPLAY_HELPER select DRM_ANALOGIX_DP select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_I2C help
@@ -33,10 +33,10 @@ config DRM_ANALOGIX_DP config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support" depends on DRM - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS select DRM_MIPI_DSI help
drivers/gpu/drm/bridge/cadence/Kconfig +2 -2
@@ -23,12 +23,12 @@ endif config DRM_CDNS_MHDP8546 tristate "Cadence DPI/DP bridge" - depends on DRM_DISPLAY_HELPER - depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_PANEL_BRIDGE + depends on OF help Support Cadence DPI to DP bridge. This is an internal bridge and is meant to be directly embedded in a SoC.
drivers/gpu/drm/bridge/synopsys/Kconfig +1 -1
@@ -1,8 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_DW_HDMI tristate - depends on DRM_DISPLAY_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select REGMAP_MMIO select CEC_CORE if CEC_NOTIFIER
drivers/gpu/drm/display/Kconfig +0 -1
@@ -3,7 +3,6 @@ config DRM_DISPLAY_HELPER tristate "DRM Display Helpers" depends on DRM - default y help DRM helpers for display adapters.
drivers/gpu/drm/exynos/Kconfig +1 -1
@@ -4,6 +4,7 @@ config DRM_EXYNOS depends on OF && DRM && COMMON_CLK depends on ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST depends on MMU + select DRM_DISPLAY_HELPER if DRM_EXYNOS_DP select DRM_KMS_HELPER select VIDEOMODE_HELPERS select FB_DMAMEM_HELPERS if DRM_FBDEV_EMULATION
@@ -67,7 +68,6 @@ config DRM_EXYNOS_DSI config DRM_EXYNOS_DP bool "Exynos specific extensions for Analogix DP driver" depends on DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON - depends on DRM_DISPLAY_HELPER select DRM_ANALOGIX_DP select DRM_DISPLAY_DP_HELPER default DRM_EXYNOS
drivers/gpu/drm/i915/Kconfig +1 -1
@@ -2,7 +2,6 @@ config DRM_I915 tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" depends on DRM - depends on DRM_DISPLAY_HELPER depends on X86 && PCI depends on !PREEMPT_RT select INTEL_GTT if X86
@@ -14,6 +13,7 @@ config DRM_I915 select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_PANEL select DRM_MIPI_DSI
drivers/gpu/drm/mediatek/Kconfig +1 -1
@@ -22,9 +22,9 @@ config DRM_MEDIATEK config DRM_MEDIATEK_DP tristate "DRM DPTX Support for MediaTek SoCs" - depends on DRM_DISPLAY_HELPER depends on DRM_MEDIATEK select PHY_MTK_DP + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_DP_AUX_BUS help
drivers/gpu/drm/msm/Kconfig +2 -2
@@ -2,10 +2,9 @@ config DRM_MSM tristate "MSM DRM" + depends on DRM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on COMMON_CLK - depends on DRM - depends on DRM_DISPLAY_HELPER depends on IOMMU_SUPPORT depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n depends on QCOM_OCMEM || QCOM_OCMEM=n
@@ -17,6 +16,7 @@ config DRM_MSM select REGULATOR select DRM_DISPLAY_DP_AUX_BUS select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_EXEC select DRM_KMS_HELPER select DRM_PANEL
drivers/gpu/drm/nouveau/Kconfig +2 -4
@@ -1,14 +1,12 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_NOUVEAU tristate "Nouveau (NVIDIA) cards" - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on PCI - depends on MMU + depends on DRM && PCI && MMU select IOMMU_API select FW_LOADER select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_TTM select DRM_TTM_HELPER
drivers/gpu/drm/panel/Kconfig +10 -10
@@ -544,11 +544,11 @@ config DRM_PANEL_RAYDIUM_RM68200 config DRM_PANEL_RAYDIUM_RM692E5 tristate "Raydium RM692E5-based DSI panel" - depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_HELPER - depends on DRM_MIPI_DSI depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for Raydium RM692E5-based display panels, such as the one found in the Fairphone 5 smartphone.
@@ -570,11 +570,11 @@ config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01 config DRM_PANEL_SAMSUNG_ATNA33XC20 tristate "Samsung ATNA33XC20 eDP panel" - depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_HELPER depends on OF + depends on BACKLIGHT_CLASS_DEVICE depends on PM select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS help DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
@@ -810,12 +810,12 @@ config DRM_PANEL_STARTEK_KD070FHFID015 config DRM_PANEL_EDP tristate "support for simple Embedded DisplayPort panels" - depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_HELPER depends on OF + depends on BACKLIGHT_CLASS_DEVICE depends on PM select VIDEOMODE_HELPERS select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER help
@@ -890,11 +890,11 @@ config DRM_PANEL_TRULY_NT35597_WQXGA config DRM_PANEL_VISIONOX_R66451 tristate "Visionox R66451" - depends on BACKLIGHT_CLASS_DEVICE - depends on DRM_DISPLAY_HELPER - depends on DRM_MIPI_DSI depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for Visionox R66451 1080x2340 AMOLED DSI panel.
drivers/gpu/drm/radeon/Kconfig +2 -4
@@ -2,13 +2,11 @@ config DRM_RADEON tristate "ATI Radeon" + depends on DRM && PCI && MMU depends on AGP || !AGP - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on PCI - depends on MMU select FW_LOADER select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_SUBALLOC_HELPER select DRM_TTM
drivers/gpu/drm/rockchip/Kconfig +2 -2
@@ -35,8 +35,8 @@ config ROCKCHIP_VOP2 config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" - depends on DRM_DISPLAY_HELPER depends on ROCKCHIP_VOP + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions
@@ -45,8 +45,8 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP bool "Rockchip cdn DP" - depends on DRM_DISPLAY_HELPER depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions
drivers/gpu/drm/tegra/Kconfig +1 -1
@@ -4,10 +4,10 @@ config DRM_TEGRA depends on ARCH_TEGRA || COMPILE_TEST depends on COMMON_CLK depends on DRM - depends on DRM_DISPLAY_HELPER depends on OF select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_AUX_BUS select DRM_KMS_HELPER select DRM_MIPI_DSI
drivers/gpu/drm/vc4/Kconfig +4 -4
@@ -2,15 +2,15 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST - depends on COMMON_CLK - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on PM # Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only # happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE. depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) + depends on DRM depends on SND && SND_SOC + depends on COMMON_CLK + depends on PM select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER select DRM_PANEL_BRIDGE
drivers/gpu/drm/xe/Kconfig +2 -5
@@ -1,11 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_XE tristate "Intel Xe Graphics" - depends on (m || (y && KUNIT=y)) - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on MMU - depends on PCI + depends on DRM && PCI && MMU && (m || (y && KUNIT=y)) select INTERVAL_TREE # we need shmfs for the swappable backing store, and in particular # the shmem_readpage() which depends upon tmpfs
@@ -20,6 +16,7 @@ config DRM_XE select DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_HDCP_HELPER select DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HELPER select DRM_MIPI_DSI select RELAY select IRQ_WORK
drivers/gpu/drm/xlnx/Kconfig +2 -4
@@ -1,15 +1,13 @@ config DRM_ZYNQMP_DPSUB tristate "ZynqMP DisplayPort Controller Driver" depends on ARCH_ZYNQMP || COMPILE_TEST - depends on COMMON_CLK + depends on COMMON_CLK && DRM && OF depends on DMADEVICES - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on OF depends on PHY_XILINX_ZYNQMP depends on XILINX_ZYNQMP_DPDMA select DMA_ENGINE select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_GEM_DMA_HELPER select DRM_KMS_HELPER select GENERIC_PHY
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 10/11 Revert "drm: Make drivers depends on DRM_DW_HDMI"
In reply to Geert UytterhoevenThis reverts commit c0e0f139354c01e0213204e4a96e7076e5a3e396, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++--- drivers/gpu/drm/ingenic/Kconfig | 2 +- drivers/gpu/drm/meson/Kconfig | 2 +- drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 2 +- drivers/gpu/drm/sun4i/Kconfig | 2 +- 7 files changed, 9 insertions(+), 10 deletions(-)
drivers/gpu/drm/bridge/imx/Kconfig +2 -2
@@ -5,9 +5,9 @@ config DRM_IMX_LDB_HELPER config DRM_IMX8MP_DW_HDMI_BRIDGE tristate "Freescale i.MX8MP HDMI-TX bridge support" - depends on COMMON_CLK - depends on DRM_DW_HDMI depends on OF + depends on COMMON_CLK + select DRM_DW_HDMI select DRM_IMX8MP_HDMI_PVI select PHY_FSL_SAMSUNG_HDMI_PHY help
drivers/gpu/drm/imx/ipuv3/Kconfig +2 -3
@@ -35,8 +35,7 @@ config DRM_IMX_LDB config DRM_IMX_HDMI tristate "Freescale i.MX DRM HDMI" - depends on DRM_DW_HDMI - depends on DRM_IMX - depends on OF + select DRM_DW_HDMI + depends on DRM_IMX && OF help Choose this if you want to use HDMI on i.MX6.
drivers/gpu/drm/ingenic/Kconfig +1 -1
@@ -27,8 +27,8 @@ config DRM_INGENIC_IPU config DRM_INGENIC_DW_HDMI tristate "Ingenic specific support for Synopsys DW HDMI" - depends on DRM_DW_HDMI depends on MACH_JZ4780 + select DRM_DW_HDMI help Choose this option to enable Synopsys DesignWare HDMI based driver. If you want to enable HDMI on Ingenic JZ4780 based SoC, you should
drivers/gpu/drm/meson/Kconfig +1 -1
@@ -13,9 +13,9 @@ config DRM_MESON config DRM_MESON_DW_HDMI tristate "HDMI Synopsys Controller support for Amlogic Meson Display" - depends on DRM_DW_HDMI depends on DRM_MESON default y if DRM_MESON + select DRM_DW_HDMI imply DRM_DW_HDMI_I2S_AUDIO config DRM_MESON_DW_MIPI_DSI
drivers/gpu/drm/renesas/rcar-du/Kconfig +1 -1
@@ -25,8 +25,8 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF - depends on DRM_DW_HDMI depends on DRM_RCAR_DU || COMPILE_TEST + select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
drivers/gpu/drm/rockchip/Kconfig +1 -1
@@ -7,6 +7,7 @@ config DRM_ROCKCHIP select DRM_PANEL select VIDEOMODE_HELPERS select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP + select DRM_DW_HDMI if ROCKCHIP_DW_HDMI select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI select GENERIC_PHY if ROCKCHIP_DW_MIPI_DSI select GENERIC_PHY_MIPI_DPHY if ROCKCHIP_DW_MIPI_DSI
@@ -56,7 +57,6 @@ config ROCKCHIP_CDN_DP config ROCKCHIP_DW_HDMI bool "Rockchip specific extensions for Synopsys DW HDMI" - depends on DRM_DW_HDMI help This selects support for Rockchip SoC specific extensions for the Synopsys DesignWare HDMI driver. If you want to
drivers/gpu/drm/sun4i/Kconfig +1 -1
@@ -57,8 +57,8 @@ config DRM_SUN6I_DSI config DRM_SUN8I_DW_HDMI tristate "Support for Allwinner version of DesignWare HDMI" depends on DRM_SUN4I - depends on DRM_DW_HDMI default DRM_SUN4I + select DRM_DW_HDMI help Choose this option if you have an Allwinner SoC with the DesignWare HDMI controller. SoCs that support HDMI and
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 11/11 Revert "drm/display: Make all helpers visible and switch to depends on"
In reply to Geert UytterhoevenThis reverts commit d674858ff979550a0e97b4ac766f2640f0d9d7e7, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel.
The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly.
--- drivers/gpu/drm/display/Kconfig | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-)
drivers/gpu/drm/display/Kconfig +12 -14
@@ -1,21 +1,20 @@ # SPDX-License-Identifier: MIT config DRM_DISPLAY_HELPER - tristate "DRM Display Helpers" + tristate depends on DRM help DRM helpers for display adapters. config DRM_DISPLAY_DP_AUX_BUS - tristate "DRM DisplayPort AUX bus support" + tristate depends on DRM depends on OF || COMPILE_TEST config DRM_DISPLAY_DP_AUX_CEC bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on DRM_DISPLAY_DP_HELPER + depends on DRM && DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER select CEC_CORE help Choose this option if you want to enable HDMI CEC support for
@@ -25,24 +24,23 @@ config DRM_DISPLAY_DP_AUX_CEC that do support this they often do not hook up the CEC pin. config DRM_DISPLAY_DP_AUX_CHARDEV - bool "DRM DisplayPort AUX Interface" - depends on DRM - depends on DRM_DISPLAY_HELPER - depends on DRM_DISPLAY_DP_HELPER + bool "DRM DP AUX Interface" + depends on DRM && DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER help Choose this option to enable a /dev/drm_dp_auxN node that allows to read and write values to arbitrary DPCD registers on the DP aux channel. config DRM_DISPLAY_DP_HELPER - bool "DRM DisplayPort Helpers" + bool depends on DRM_DISPLAY_HELPER help DRM display helpers for DisplayPort. config DRM_DISPLAY_DP_TUNNEL - bool "DRM DisplayPort tunnels support" - depends on DRM_DISPLAY_DP_HELPER + bool + select DRM_DISPLAY_DP_HELPER help Enable support for DisplayPort tunnels. This allows drivers to use DP tunnel features like the Bandwidth Allocation mode to maximize the
@@ -62,13 +60,13 @@ config DRM_DISPLAY_DP_TUNNEL_STATE_DEBUG If in doubt, say "N". config DRM_DISPLAY_HDCP_HELPER - bool "DRM HDCD Helpers" + bool depends on DRM_DISPLAY_HELPER help DRM display helpers for HDCP. config DRM_DISPLAY_HDMI_HELPER - bool "DRM HDMI Helpers" + bool depends on DRM_DISPLAY_HELPER help DRM display helpers for HDMI.
Signature · 1 line
2.34.1
Jani Nikula
maintainerQuoted 12 lines · Geert Uytterhoeven
Hi all,
As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers
Kconfigsymbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.
Quoted 5 lines
Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
That said, I'm not going to keep arguing against this. Whatever.
BR,
Jani.
Quoted 45 lines
Thanks for applying!
[1] https://lore.kernel.org/r/[email protected]/
Geert Uytterhoeven (11):
Revert "drm: fixDRM_DISPLAY_DP_HELPERdependencies, part 2" Revert "drm/display: SelectDRM_KMS_HELPERfor DP helpers" Revert "drm/bridge: dw-hdmi: MakeDRM_DW_HDMIselectable" Revert "drm: fixDRM_DISPLAY_DP_HELPERdependencies" Revert "drm: SwitchDRM_DISPLAY_HDMI_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_HDCP_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_DP_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_DP_AUX_BUSto depends on" Revert "drm: SwitchDRM_DISPLAY_HELPERto depends on" Revert "drm: Make drivers depends onDRM_DW_HDMI"
Revert "drm/display: Make all helpers visible and switch to dependson"drivers/gpu/drm/Kconfig | 8 +++---- drivers/gpu/drm/amd/amdgpu/Kconfig | 12 ++++------ drivers/gpu/drm/bridge/Kconfig | 28 +++++++++++----------- drivers/gpu/drm/bridge/analogix/Kconfig | 18 +++++++------- drivers/gpu/drm/bridge/cadence/Kconfig | 8 +++---- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 ++--- drivers/gpu/drm/display/Kconfig | 32 ++++++++++--------------- drivers/gpu/drm/exynos/Kconfig | 4 ++-- drivers/gpu/drm/i915/Kconfig | 8 +++---- drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++-- drivers/gpu/drm/ingenic/Kconfig | 2 +- drivers/gpu/drm/mediatek/Kconfig | 6 ++--- drivers/gpu/drm/meson/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 8 +++---- drivers/gpu/drm/nouveau/Kconfig | 10 ++++---- drivers/gpu/drm/panel/Kconfig | 32 ++++++++++++------------- drivers/gpu/drm/radeon/Kconfig | 8 +++---- drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 10 ++++---- drivers/gpu/drm/sun4i/Kconfig | 2 +- drivers/gpu/drm/tegra/Kconfig | 8 +++---- drivers/gpu/drm/vc4/Kconfig | 10 ++++---- drivers/gpu/drm/xe/Kconfig | 13 ++++------ drivers/gpu/drm/xlnx/Kconfig | 8 +++---- 25 files changed, 116 insertions(+), 138 deletions(-)
Signature · 1 line
Jani Nikula, Intel
Quoted 19 lines · Jani Nikula
Quoted 12 lines · Geert Uytterhoeven
Hi all,
As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers
Kconfigsymbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.Quoted 5 lines
Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.
Quoted 3 lines
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
I'd agree with you, but if the driver depends on helpers it becomes ridiculous. So, it seems, we need a different solution for the original problem.
Quoted 55 lines
That said, I'm not going to keep arguing against this. Whatever.
BR,
Jani.Quoted 45 lines
Thanks for applying!
[1] https://lore.kernel.org/r/[email protected]/
Geert Uytterhoeven (11):
Revert "drm: fixDRM_DISPLAY_DP_HELPERdependencies, part 2" Revert "drm/display: SelectDRM_KMS_HELPERfor DP helpers" Revert "drm/bridge: dw-hdmi: MakeDRM_DW_HDMIselectable" Revert "drm: fixDRM_DISPLAY_DP_HELPERdependencies" Revert "drm: SwitchDRM_DISPLAY_HDMI_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_HDCP_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_DP_HELPERto depends on" Revert "drm: SwitchDRM_DISPLAY_DP_AUX_BUSto depends on" Revert "drm: SwitchDRM_DISPLAY_HELPERto depends on" Revert "drm: Make drivers depends onDRM_DW_HDMI"
Revert "drm/display: Make all helpers visible and switch to dependson"drivers/gpu/drm/Kconfig | 8 +++---- drivers/gpu/drm/amd/amdgpu/Kconfig | 12 ++++------ drivers/gpu/drm/bridge/Kconfig | 28 +++++++++++----------- drivers/gpu/drm/bridge/analogix/Kconfig | 18 +++++++------- drivers/gpu/drm/bridge/cadence/Kconfig | 8 +++---- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 ++--- drivers/gpu/drm/display/Kconfig | 32 ++++++++++--------------- drivers/gpu/drm/exynos/Kconfig | 4 ++-- drivers/gpu/drm/i915/Kconfig | 8 +++---- drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++-- drivers/gpu/drm/ingenic/Kconfig | 2 +- drivers/gpu/drm/mediatek/Kconfig | 6 ++--- drivers/gpu/drm/meson/Kconfig | 2 +- drivers/gpu/drm/msm/Kconfig | 8 +++---- drivers/gpu/drm/nouveau/Kconfig | 10 ++++---- drivers/gpu/drm/panel/Kconfig | 32 ++++++++++++------------- drivers/gpu/drm/radeon/Kconfig | 8 +++---- drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 10 ++++---- drivers/gpu/drm/sun4i/Kconfig | 2 +- drivers/gpu/drm/tegra/Kconfig | 8 +++---- drivers/gpu/drm/vc4/Kconfig | 10 ++++---- drivers/gpu/drm/xe/Kconfig | 13 ++++------ drivers/gpu/drm/xlnx/Kconfig | 8 +++---- 25 files changed, 116 insertions(+), 138 deletions(-)Signature · 1 line
Jani Nikula, Intel
Signature · 2 lines
With best wishes Dmitry
Arnd Bergmann
Acked-byQuoted 13 lines · Jani Nikula
Quoted 12 lines · Geert Uytterhoeven
Hi all,
As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers
Kconfigsymbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.
Quoted 5 lines
Quoted 5 lines
Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.
Thanks for doing this.
Quoted 3 lines
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
Sorry you missed the IRC discussion on #armlinux, we should have included you as well since you applied the original patch.
I think the reason for this revert is a bit more nuanced than just the usability problem. Sorry if I'm dragging this out too much, but I want to be sure that two points come across:
1. There is a semantic problem that is mostly subjective, but with the naming as "helper", I generally expect it as a hidden symbol that gets selected by its users, while calling same module "feature" would be something that is user-enabled and that other modules depend on. Both ways are commonly used in the kernel and are not mistakes on their own.
2. Using "select" on user visible symbols that have dependencies is a common source for bugs, and this is is a problem in drivers/gpu/drm more than elsewhere in the kernel, as these drivers traditionally select entire subsystems or drivers (I2C, VIRTIO, INPUT, ACPI_WMI, BACKLIGHT_CLASS_DEVICE, POWER_SUPPLY, SND_PCM, INTERCONNECT, ...). This regularly leads to circular dependencies and we should fix all of them. The display helpers however don't have this problem because they do not have any dependencies outside of drivers/gpu/
Arnd
Jani Nikula
maintainerQuoted 35 lines · Arnd Bergmann
Quoted 13 lines · Jani Nikula
Quoted 12 lines · Geert Uytterhoeven
Hi all,
As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers
Kconfigsymbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.Quoted 5 lines
Quoted 5 lines
Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.
Thanks for doing this.
Acked-by Arnd Bergmann <[email protected]>Quoted 3 lines
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
Sorry you missed the IRC discussion on #armlinux, we should have included you as well since you applied the original patch.
I think the reason for this revert is a bit more nuanced than just the usability problem. Sorry if I'm dragging this out too much, but I want to be sure that two points come across:
Quoted 6 lines
1. There is a semantic problem that is mostly subjective, but with the naming as "helper", I generally expect it as a hidden symbol that gets selected by its users, while calling same module "feature" would be something that is user-enabled and that other modules depend on. Both ways are commonly used in the kernel and are not mistakes on their own.
Fair enough. I believe for (optional) "feature" the common pattern would then be depends on FEATURE || FEATURE=n.
Quoted 7 lines
2. Using "select" on user visible symbols that have dependencies is a common source for bugs, and this is is a problem in
drivers/gpu/drmmore than elsewhere in the kernel, as these drivers traditionally select entire subsystems or drivers (I2C, VIRTIO, INPUT,ACPI_WMI,BACKLIGHT_CLASS_DEVICE,POWER_SUPPLY,SND_PCM, INTERCONNECT, ...). This regularly leads to circular dependencies and we should fix all of them.
What annoys me is that the fixes tend to fall in two categories:
- Play catch with selecting the dependencies of the selected symbols. "depends on" handles this recursively, while select does not. There is no end to this, it just goes on and on, as the dependencies of the selected symbols change over time. Often the selects require unintuitive if patterns that are about the implementation details of the symbol being selected.
- Brush the invalid configs under the rug by using IS_REACHABLE(), switching from a loud link time failure to a silent runtime failure. (I regularly reject patches adding IS_REACHABLE() to i915, because from my pov e.g. i915=y backlight=m is an invalid configuration that the user shouldn't have to debug at runtime. But I can't express that in kconfig while everyone selects backlight.)
If you have other ideas how these should be fixed, I'm all ears.
Quoted 2 lines
The display helpers however don't have this problem because they do not have any dependencies outside of
drivers/gpu/
Fair enough, though I think they still suffer from some of them having dependencies. (Wasn't this how the original patches and the debate all got started?)
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel
Quoted 32 lines · Jani Nikula
Quoted 13 lines · Arnd Bergmann
Quoted 3 lines · Jani Nikula
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
Sorry you missed the IRC discussion on #armlinux, we should have included you as well since you applied the original patch.
I think the reason for this revert is a bit more nuanced than just the usability problem. Sorry if I'm dragging this out too much, but I want to be sure that two points come across:
Quoted 6 lines
1. There is a semantic problem that is mostly subjective, but with the naming as "helper", I generally expect it as a hidden symbol that gets selected by its users, while calling same module "feature" would be something that is user-enabled and that other modules depend on. Both ways are commonly used in the kernel and are not mistakes on their own.
Fair enough. I believe for (optional) "feature" the common pattern would then be depends on FEATURE || FEATURE=n.
Quoted 7 lines
2. Using "select" on user visible symbols that have dependencies is a common source for bugs, and this is is a problem in
drivers/gpu/drmmore than elsewhere in the kernel, as these drivers traditionally select entire subsystems or drivers (I2C, VIRTIO, INPUT,ACPI_WMI,BACKLIGHT_CLASS_DEVICE,POWER_SUPPLY,SND_PCM, INTERCONNECT, ...). This regularly leads to circular dependencies and we should fix all of them.
Quoted 5 lines
What annoys me is that the fixes tend to fall in two categories:
- Play catch with selecting the dependencies of the selected symbols. "depends on" handles this recursively, while select does not.
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config HELPER_A
tristate
config HELPER_B
tristate
select HELPER_A
config DRIVER
tristate "Turn on the driver and the helpers it uses" select HELPER_B # this recursively selects HELPER_A
Whereas this one is broken:
config FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2C
config HELPER_B
tristate # hidden
select FEATURE_A
config DRIVER
tristate "This driver is broken if I2C is disabled" select HELPER_B
Quoted 4 lines
There is no end to this, it just goes on and on, as the dependencies of the selected symbols change over time. Often the selects require unintuitive if patterns that are about the implementation details of the symbol being selected.
Agreed, that is the problem I frequently face with drivers/gpu/drm, and most of the time it can only be solved by rewriting the whole system to not select user-visible symbol at all.
Using 'depends on' by itself is unfortunately not enough to avoid /all/ the problems. See e.g. today's failure
config DRM_DISPLAY_HELPER
tristate "DRM Display Helpers"
default y
config DRM_DISPLAY_DP_HELPER
bool "DRM DisplayPort Helpers"
depends on DRM_DISPLAY_HELPER
config DRM_PANEL_LG_SW43408
tristate "LG SW43408 panel"
depends on DRM_DISPLAY_DP_HELPER
This version is still broken for DRM_DISPLAY_HELPER=m, DRM_DISPLAY_DP_HELPER=m, DRM_PANEL_LG_SW43408=y because the dependency on the bool symbol is not enough to ensure that DRM_DISPLAY_HELPER is also built-in, so you still need explicit dependencies on both DRM_DISPLAY_HELPER and DRM_DISPLAY_DP_HELPER in the users.
This can be solved by making DRM_DISPLAY_DP_HELPER a tristate symbol and adjusting the #ifdef checks and Makefile logic accordingly, which is exactly what you'd need to do to make it work with 'select' as well.
Quoted 6 lines
- Brush the invalid configs under the rug by using
IS_REACHABLE(), switching from a loud link time failure to a silent runtime failure. (I regularly reject patches addingIS_REACHABLE()to i915, because from my pov e.g. i915=y backlight=m is an invalid configuration that the user shouldn't have to debug at runtime. But I can't express that in kconfig while everyone selects backlight.)
Thanks a lot for rejecting the IS_REACHABLE() patches, it is indeed the worst way to handle those (I know, as I introduced IS_REACHABLE() only to replace open-coded versions of the same, not to have it as a feature or to use it in new code).
Quoted 8 lines
If you have other ideas how these should be fixed, I'm all ears.
Quoted 2 lines
The display helpers however don't have this problem because they do not have any dependencies outside of
drivers/gpu/Fair enough, though I think they still suffer from some of them having dependencies. (Wasn't this how the original patches and the debate all got started?)
I believe that Maxime said on IRC that he only did the patches originally because he expected problems with them based on his understanding on how Kconfig works. I'm not aware of any particular problem here.
Let me know if you see a problem with any of the symbols that Geert has proposed for reverting, and I'll try to find a solution. In my randconfig test environment, I have several patches that I sent in the past to clean up the ACPI_VIDEO, I2C, BACKLIGHT and LED dependencies to stop using 'select' as I could not otherwise get nouveau, i915 and xe to build reliably, but that means I may be missing some of the other problems.
Arnd
Hi Arnd,
CC kbuild
Quoted 38 lines · Arnd Bergmann
Quoted 9 lines · Jani Nikula
Quoted 7 lines · Arnd Bergmann
2. Using "select" on user visible symbols that have dependencies is a common source for bugs, and this is is a problem in
drivers/gpu/drmmore than elsewhere in the kernel, as these drivers traditionally select entire subsystems or drivers (I2C, VIRTIO, INPUT,ACPI_WMI,BACKLIGHT_CLASS_DEVICE,POWER_SUPPLY,SND_PCM, INTERCONNECT, ...). This regularly leads to circular dependencies and we should fix all of them.Quoted 5 lines
What annoys me is that the fixes tend to fall in two categories:
- Play catch with selecting the dependencies of the selected symbols. "depends on" handles this recursively, while select does not.
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config
HELPER_A
tristateconfig
HELPER_B
tristate
selectHELPER_Aconfig DRIVER
tristate "Turn on the driver and the helpers it uses" selectHELPER_B# this recursively selectsHELPER_AWhereas this one is broken:
config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2C
Quoted 7 lines
config
HELPER_B
tristate # hidden
selectFEATURE_Aconfig DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_B
So the DRIVER section should gain a "depends on I2C" statement.
Yamada-san: would it be difficult to modify Kconfig to ignore symbols like DRIVER that select other symbols with unmet dependencies? Currently it already warns about that.
Handling this implicitly (instead of the current explict "depends on") would have the disadvantage though: a user who is not aware of the implicit dependency may wonder why DRIVER is invisible in his config interface.
Quoted 9 lines
Quoted 5 lines
There is no end to this, it just goes on and on, as the dependencies of the selected symbols change over time. Often the selects require unintuitive if patterns that are about the implementation details of the symbol being selected.
Agreed, that is the problem I frequently face with
drivers/gpu/drm, and most of the time it can only be solved by rewriting the whole system to not select user-visible symbol at all.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Jani Nikula
maintainerQuoted 31 lines · Geert Uytterhoeven
Hi Arnd,
CC kbuild
Quoted 26 lines · Arnd Bergmann
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config
HELPER_A
tristateconfig
HELPER_B
tristate
selectHELPER_Aconfig DRIVER
tristate "Turn on the driver and the helpers it uses" selectHELPER_B# this recursively selectsHELPER_AWhereas this one is broken:
config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2Cconfig
HELPER_B
tristate # hidden
selectFEATURE_A
Quoted 5 lines
Quoted 3 lines
config DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_BSo the DRIVER section should gain a "depends on I2C" statement.
Why should DRIVER have to care that HELPER_B needs either FEATURE_A or I2C? It should only have to care about HELPER_B. And if the dependencies of FEATURE_A or HELPER_B later change, that's their business, not DRIVER's.
BR,
Jani.
Quoted 9 lines
Yamada-san: would it be difficult to modify
Kconfigto ignore symbols like DRIVER that select other symbols with unmet dependencies? Currently it already warns about that.Handling this implicitly (instead of the current explict "depends on") would have the disadvantage though: a user who is not aware of the implicit dependency may wonder why DRIVER is invisible in his config interface.
Signature · 1 line
Jani Nikula, Intel
Hi Jani,
Quoted 32 lines · Jani Nikula
Quoted 31 lines · Geert Uytterhoeven
Quoted 29 lines · Arnd Bergmann
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config
HELPER_A
tristateconfig
HELPER_B
tristate
selectHELPER_Aconfig DRIVER
tristate "Turn on the driver and the helpers it uses" selectHELPER_B# this recursively selectsHELPER_AWhereas this one is broken:
config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2Cconfig
HELPER_B
tristate # hidden
selectFEATURE_Aconfig DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_B
Quoted 6 lines
Quoted 1 line
So the DRIVER section should gain a "depends on I2C" statement.
Why should DRIVER have to care that
HELPER_Bneeds eitherFEATURE_Aor I2C? It should only have to care aboutHELPER_B. And if the dependencies ofFEATURE_AorHELPER_Blater change, that's their business, not DRIVER's.
That's correct. But currently the dependency on I2C is not handled automatically.
Quoted 8 lines
Quoted 8 lines
Yamada-san: would it be difficult to modify
Kconfigto ignore symbols like DRIVER that select other symbols with unmet dependencies? Currently it already warns about that.Handling this implicitly (instead of the current explict "depends on") would have the disadvantage though: a user who is not aware of the implicit dependency may wonder why DRIVER is invisible in his config interface.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 12 lines · Geert Uytterhoeven
Quoted 11 lines · Arnd Bergmann
On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote:
Whereas this one is broken:config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2Cconfig
HELPER_B
tristate # hidden
selectFEATURE_A
Quoted 5 lines
Quoted 3 lines
config DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_BSo the DRIVER section should gain a "depends on I2C" statement.
That is of course the common workaround, but my point was that nothing should ever 'select I2C' or any of the other subsystems that are user visible.
Quoted 8 lines
Yamada-san: would it be difficult to modify
Kconfigto ignore symbols like DRIVER that select other symbols with unmet dependencies? Currently it already warns about that.Handling this implicitly (instead of the current explict "depends on") would have the disadvantage though: a user who is not aware of the implicit dependency may wonder why DRIVER is invisible in his config interface.
I think hiding this would make it much harder to get anything right. The symbols in question are almost all ones that should be enabled in normal configs, and the 'make menuconfig' help doesn't make it too hard to figure things out normally, we just have to find a way to avoid regressions when converting things to 'depends on' that used an incorrect 'select'.
Arnd
Quoted 33 lines · Arnd Bergmann
Quoted 12 lines · Geert Uytterhoeven
Quoted 11 lines · Arnd Bergmann
On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote:
Whereas this one is broken:config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2Cconfig
HELPER_B
tristate # hidden
selectFEATURE_AQuoted 5 lines
Quoted 3 lines
config DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_BSo the DRIVER section should gain a "depends on I2C" statement.
That is of course the common workaround, but my point was that nothing should ever 'select I2C' or any of the other subsystems that are user visible.
Quoted 8 lines
Yamada-san: would it be difficult to modify
Kconfigto ignore symbols like DRIVER that select other symbols with unmet dependencies? Currently it already warns about that.Handling this implicitly (instead of the current explict "depends on") would have the disadvantage though: a user who is not aware of the implicit dependency may wonder why DRIVER is invisible in his config interface.
Quoted 8 lines
I think hiding this would make it much harder to get anything right. The symbols in question are almost all ones that should be enabled in normal configs, and the 'make menuconfig' help doesn't make it too hard to figure things out normally, we just have to find a way to avoid regressions when converting things to 'depends on' that used an incorrect 'select'.
Arnd
I am confused because you repeatedly discussed the missing I2C dependency.
Are you talking about DRM drivers,
or is it just "an example" in general?
DRM selects I2C.
https://github.com/torvalds/linux/blob/v6.9-rc4/drivers/gpu/drm/Kconfig#L16
If you make sure individual DRM drivers depend on DRM, none of them can be enabled without I2C.
Currently, this is not guaranteed just because DRM folks do not know how to use the "menuconfig" syntax.
The "menuconfig" makes sense only when it is followed by "if".
drivers/gpu/drm/Kconfig +4 -0
@@ -29,6 +29,8 @@ menuconfig DRM details. You should also select and configure AGP (/dev/agpgart) support if it is available for your platform. +if DRM + config DRM_MIPI_DBI tristate depends on DRM
@@ -414,3 +416,5 @@ config DRM_LIB_RANDOM config DRM_PRIVACY_SCREEN bool default n + +endif
--
Best Regards
Masahiro Yamada
Quoted 16 lines · Masahiro Yamada
Quoted 10 lines · Arnd Bergmann
Quoted 2 lines · Geert Uytterhoeven
Quoted 1 line · Arnd Bergmann
On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote:
I think hiding this would make it much harder to get anything right. The symbols in question are almost all ones that should be enabled in normal configs, and the 'make menuconfig' help doesn't make it too hard to figure things out normally, we just have to find a way to avoid regressions when converting things to 'depends on' that used an incorrect 'select'.
I am confused because you repeatedly discussed
the missing I2C dependency.
Quoted 6 lines
Are you talking about DRM drivers,
or is it just "an example" in general?DRM selects I2C.
It's a prominent example because I2C ends up showing up in most circular dependencies. I forgot that CONFIG_DRM itself selects this one, but this is clearly part of the overall problem:
$ git grep -w 'select I2C' | wc -l 35 $ git grep -w 'depends on I2C' | wc -l 1068
Attempting to clean up some of the incorrect 'select' statements, such as changing DRM_NOUVEAU to 'depends on ACPI_VIDEO' instead of 'select' tends to run into another 'select I2C' such as this one:
drivers/i2c/Kconfig:8: symbol I2C is selected by DRM_NOUVEAUdrivers/gpu/drm/nouveau/Kconfig:2: symbol DRM_NOUVEAU depends on ACPI_VIDEOdrivers/acpi/Kconfig:214: symbol ACPI_VIDEO depends on BACKLIGHT_CLASS_DEVICEdrivers/video/backlight/Kconfig:136: symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHTdrivers/video/fbdev/core/Kconfig:184: symbol FB_BACKLIGHT is selected by HT16K33drivers/auxdisplay/Kconfig:490: symbol HT16K33 depends on I2C
Again, I2C was probably not the best example for an urgent problem as it ends up being selected unconditionally anyway, but I think ACPI_VIDEO and BACKLIGHT_CLASS_DEVICE are the ones that we should stop selecting.
Quoted 14 lines
drivers/gpu/drm/Kconfig +2
-0@@ -29,6 +29,8 @@ menuconfig DRM details. You should also select and configure AGP (/dev/agpgart) support if it is available for your platform. +if DRM + config DRM_MIPI_DBI tristate depends on DRM
drivers/gpu/drm/Kconfig config DRM_LIB_RANDOM · line 420
Quoted 5 lines
drivers/gpu/drm/Kconfig +2
-0@@ -414,3 +416,5 @@ config DRM_LIB_RANDOM config DRM_PRIVACY_SCREEN bool default n + +endif
This is a probably good idea (aside from DRM_PANEL_ORIENTATION_QUIRKS, which needs to be moved out of the section), but seems completely unrelated to the issue of selecting too many symbols.
Arnd
Jani Nikula
maintainerQuoted 61 lines · Arnd Bergmann
Quoted 32 lines · Jani Nikula
Quoted 13 lines · Arnd Bergmann
Quoted 3 lines · Jani Nikula
I still disagree with this, because fundamentally the source symbol really should not have to care about the dependencies of the target symbol.
Sorry you missed the IRC discussion on #armlinux, we should have included you as well since you applied the original patch.
I think the reason for this revert is a bit more nuanced than just the usability problem. Sorry if I'm dragging this out too much, but I want to be sure that two points come across:
Quoted 6 lines
1. There is a semantic problem that is mostly subjective, but with the naming as "helper", I generally expect it as a hidden symbol that gets selected by its users, while calling same module "feature" would be something that is user-enabled and that other modules depend on. Both ways are commonly used in the kernel and are not mistakes on their own.
Fair enough. I believe for (optional) "feature" the common pattern would then be depends on FEATURE || FEATURE=n.
Quoted 7 lines
2. Using "select" on user visible symbols that have dependencies is a common source for bugs, and this is is a problem in
drivers/gpu/drmmore than elsewhere in the kernel, as these drivers traditionally select entire subsystems or drivers (I2C, VIRTIO, INPUT,ACPI_WMI,BACKLIGHT_CLASS_DEVICE,POWER_SUPPLY,SND_PCM, INTERCONNECT, ...). This regularly leads to circular dependencies and we should fix all of them.Quoted 5 lines
What annoys me is that the fixes tend to fall in two categories:
- Play catch with selecting the dependencies of the selected symbols. "depends on" handles this recursively, while select does not.
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config
HELPER_A
tristateconfig
HELPER_B
tristate
selectHELPER_Aconfig DRIVER
tristate "Turn on the driver and the helpers it uses" selectHELPER_B# this recursively selectsHELPER_AWhereas this one is broken:
config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2C
Quoted 7 lines
config
HELPER_B
tristate # hidden
selectFEATURE_Aconfig DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_B
This case is really what I was referring to, although I was sloppy with words there. I understand that select does work recursively for selects.
Quoted 31 lines
Quoted 4 lines
There is no end to this, it just goes on and on, as the dependencies of the selected symbols change over time. Often the selects require unintuitive if patterns that are about the implementation details of the symbol being selected.
Agreed, that is the problem I frequently face with
drivers/gpu/drm, and most of the time it can only be solved by rewriting the whole system to not select user-visible symbol at all.Using 'depends on' by itself is unfortunately not enough to avoid /all/ the problems. See e.g. today's failure
config
DRM_DISPLAY_HELPER
tristate "DRM Display Helpers"
default yconfig
DRM_DISPLAY_DP_HELPER
bool "DRM DisplayPort Helpers"
depends onDRM_DISPLAY_HELPERconfig
DRM_PANEL_LG_SW43408
tristate "LG SW43408 panel"
depends onDRM_DISPLAY_DP_HELPERThis version is still broken for DRM_DISPLAY_HELPER=m, DRM_DISPLAY_DP_HELPER=m, DRM_PANEL_LG_SW43408=y because the dependency on the bool symbol is not enough to ensure that
DRM_DISPLAY_HELPERis also built-in, so you still need explicit dependencies on bothDRM_DISPLAY_HELPERandDRM_DISPLAY_DP_HELPERin the users.
Quoted 4 lines
This can be solved by making
DRM_DISPLAY_DP_HELPERa tristate symbol and adjusting the #ifdef checks andMakefilelogic accordingly, which is exactly what you'd need to do to make it work with 'select' as well.
So bool is kind of problematic for depends on and select even when it's not really used for describing builtin vs. no, but rather yes vs. no?
Quoted 21 lines
Quoted 6 lines
- Brush the invalid configs under the rug by using
IS_REACHABLE(), switching from a loud link time failure to a silent runtime failure. (I regularly reject patches addingIS_REACHABLE()to i915, because from my pov e.g. i915=y backlight=m is an invalid configuration that the user shouldn't have to debug at runtime. But I can't express that in kconfig while everyone selects backlight.)Thanks a lot for rejecting the
IS_REACHABLE()patches, it is indeed the worst way to handle those (I know, as I introducedIS_REACHABLE()only to replace open-coded versions of the same, not to have it as a feature or to use it in new code).Quoted 8 lines
If you have other ideas how these should be fixed, I'm all ears.
Quoted 2 lines
The display helpers however don't have this problem because they do not have any dependencies outside of
drivers/gpu/Fair enough, though I think they still suffer from some of them having dependencies. (Wasn't this how the original patches and the debate all got started?)
Quoted 7 lines
I believe that Maxime said on IRC that he only did the patches originally because he expected problems with them based on his understanding on how
Kconfigworks. I'm not aware of any particular problem here.Let me know if you see a problem with any of the symbols that Geert has proposed for reverting, and I'll try to find a solution.
I think there will still be some things that select and some other things that depends on DRM_DISPLAY_HELPER, for example. Usually that's a recipe for kconfig failures down the line. (Is it ever a good idea?)
For example, after this series, we'll (again) have:
config DRM_DISPLAY_DP_AUX_CEC
bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" depends on DRM && DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER select CEC_CORE
Should we now also drop the help from DRM_DISPLAY_HELPER, and select it everywhere, including here, and in DRM_DISPLAY_HDCP_HELPER and DRM_DISPLAY_HDMI_HELPER?
Quoted 5 lines
In my randconfig test environment, I have several patches that I sent in the past to clean up the
ACPI_VIDEO, I2C, BACKLIGHT and LED dependencies to stop using 'select' as I could not otherwise get nouveau, i915 and xe to build reliably, but that means I may be missing some of the other problems.
Yeah, these seem to be the really problematic ones. I admit I may have been misguided in insisting the same approach to the helpers that should be used here; at least the helpers should be easier to fix without selecting the target symbol dependencies in the source symbols.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel
Hi Jani,
CC kbuild
Quoted 65 lines · Jani Nikula
Quoted 22 lines · Arnd Bergmann
I'm not sure where this misunderstanding comes from, as you seem to be repeating the same incorrect assumption about how select works that Maxime wrote in his changelog. To clarify, this works exactly as one would expect:
config
HELPER_A
tristateconfig
HELPER_B
tristate
selectHELPER_Aconfig DRIVER
tristate "Turn on the driver and the helpers it uses" selectHELPER_B# this recursively selectsHELPER_AWhereas this one is broken:
config
FEATURE_A
tristate "user visible if I2C is enabled"
depends on I2CQuoted 7 lines
config
HELPER_B
tristate # hidden
selectFEATURE_Aconfig DRIVER
tristate "This driver is broken if I2C is disabled" selectHELPER_BThis case is really what I was referring to, although I was sloppy with words there. I understand that select does work recursively for selects.
Quoted 31 lines
Quoted 4 lines
There is no end to this, it just goes on and on, as the dependencies of the selected symbols change over time. Often the selects require unintuitive if patterns that are about the implementation details of the symbol being selected.
Agreed, that is the problem I frequently face with
drivers/gpu/drm, and most of the time it can only be solved by rewriting the whole system to not select user-visible symbol at all.Using 'depends on' by itself is unfortunately not enough to avoid /all/ the problems. See e.g. today's failure
config
DRM_DISPLAY_HELPER
tristate "DRM Display Helpers"
default yconfig
DRM_DISPLAY_DP_HELPER
bool "DRM DisplayPort Helpers"
depends onDRM_DISPLAY_HELPERconfig
DRM_PANEL_LG_SW43408
tristate "LG SW43408 panel"
depends onDRM_DISPLAY_DP_HELPERThis version is still broken for DRM_DISPLAY_HELPER=m, DRM_DISPLAY_DP_HELPER=m, DRM_PANEL_LG_SW43408=y because the dependency on the bool symbol is not enough to ensure that
DRM_DISPLAY_HELPERis also built-in, so you still need explicit dependencies on bothDRM_DISPLAY_HELPERandDRM_DISPLAY_DP_HELPERin the users.
Quoted 7 lines
Quoted 4 lines
This can be solved by making
DRM_DISPLAY_DP_HELPERa tristate symbol and adjusting the #ifdef checks andMakefilelogic accordingly, which is exactly what you'd need to do to make it work with 'select' as well.So bool is kind of problematic for depends on and select even when it's not really used for describing builtin vs. no, but rather yes vs. no?
Yes, the underlying issue is that bool is used for two different things:
A. To enable a driver module that can be only built-in,
B. To enable an option or feature of a driver or subsystem.
Without this distinction, dependencies cannot be auto-propagated 100% correctly. Fixing that would require introducing a third type (and possibly renaming the existing ones to end up with 3 good names).
Actually two types could work:
1. driver,
2. option,
as case A is just a driver that can only be built-in (i.e. "depends on y", which is similar to the behavior with CONFIG_MODULES=n).
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds