riscv: add all available CSRs to 'info registers'
cover riscv: add all available CSRs to 'info registers'
Hi,
The output of HMP 'info registers', implemented by the cpu_dump_state callback, returns way less CSRs than what we have available in the default rv64 CPU with default options.
This series changes the callback to add all available non-vector CSRs when issuing 'info registers'. The vector CSRs are being handled by another patch [1].
Patches based on alistair/riscv-to-apply.next.
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Daniel Henrique Barboza (3):
target/riscv/cpu: add riscv_dump_csr() helper target/riscv/cpu: print all FPU CSRs in riscv_cpu_dump_state() target/riscv: print all available CSRs in riscv_cpu_dump_state()
target/riscv/cpu.c | 107 +++++++++++++++++---------------------------- target/riscv/cpu.h | 2 + target/riscv/csr.c | 18 ++++++++ 3 files changed, 61 insertions(+), 66 deletions(-)
Signature · 1 line
2.49.0
PATCH 1/3 target/riscv/cpu: add riscv_dump_csr() helper
riscv_cpu_dump_state() is using the same pattern to print a CSR given its number. Add a helper to avoid code repetition.
While we're at it fix the identation of the 'flags & CPU_DUMP_VPU' block.
--- target/riscv/cpu.c | 54 +++++++++++++++++++--------------------------- 1 file changed, 22 insertions(+), 32 deletions(-)
target/riscv/cpu.c +22 -32
@@ -515,6 +515,21 @@ char *riscv_cpu_get_name(RISCVCPU *cpu)return cpu_model_from_type (typename); } +static void riscv_dump_csr (CPURISCVState *env,int csrno,FILE *f) +{ +target_ulong val =0 ; +RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); + +/* +* Rely on the smode, hmode, etc, predicates within csr.c +* to do the filtering of the registers that are present. +*/ +if (res ==RISCV_EXCP_NONE ) { +qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , + csr_ops[csrno].name, val); + } +} +static void riscv_cpu_dump_state (CPUState *cs,FILE *f,int flags) {RISCVCPU *cpu =RISCV_CPU (cs);
@@ -565,18 +580,7 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) };for (i =0 ; i <ARRAY_SIZE (dump_csrs); ++i) { -int csrno = dump_csrs[i]; -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); - -/* -* Rely on the smode, hmode, etc, predicates within csr.c -* to do the filtering of the registers that are present. -*/ -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[csrno].name, val); - } +riscv_dump_csr (env, dump_csrs[i], f); } }#endif
@@ -589,12 +593,8 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) } }if (flags &CPU_DUMP_FPU ) { -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env,CSR_FCSR , &val,0 ,0 ); -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[CSR_FCSR ].name, val); - } +riscv_dump_csr (env,CSR_FCSR , f); +for (i =0 ; i <32 ; i++) {qemu_fprintf (f," %-8s %016" PRIx64, riscv_fpr_regnames[i], env->fpr[i]);
@@ -612,22 +612,12 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags)CSR_VL ,CSR_VTYPE , CSR_VLENB, - }; -for (i =0 ; i <ARRAY_SIZE (dump_rvv_csrs); ++i) { -int csrno = dump_rvv_csrs[i]; -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); + }; +uint16_t vlenb = cpu->cfg.vlenb; -/* -* Rely on the smode, hmode, etc, predicates within csr.c -* to do the filtering of the registers that are present. -*/ -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[csrno].name, val); - } +for (i =0 ; i <ARRAY_SIZE (dump_rvv_csrs); ++i) { +riscv_dump_csr (env, dump_rvv_csrs[i], f); } -uint16_t vlenb = cpu->cfg.vlenb;for (i =0 ; i <32 ; i++) {qemu_fprintf (f," %-8s " , riscv_rvv_regnames[i]);
Signature · 1 line
2.49.0
Re: [PATCH 1/3] target/riscv/cpu: add riscv_dump_csr() helper
Quoted 8 lines · Daniel Henrique Barboza
riscv_cpu_dump_state()is using the same pattern to print a CSR given its number. Add a helper to avoid code repetition.While we're at it fix the identation of the 'flags &
CPU_DUMP_VPU' block.Signed-off-by Daniel Henrique Barboza <[email protected]>
Alistair
Quoted 96 lines
--- target/riscv/cpu.c | 54 +++++++++++++++++++--------------------------- 1 file changed, 22 insertions(+), 32 deletions(-)target/riscv/cpu.c +22
-33@@ -515,6 +515,21 @@ char *riscv_cpu_get_name(RISCVCPU *cpu)return cpu_model_from_type (typename); } +static void riscv_dump_csr (CPURISCVState *env,int csrno,FILE *f) +{ +target_ulong val =0 ; +RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); + +/* +* Rely on the smode, hmode, etc, predicates within csr.c +* to do the filtering of the registers that are present. +*/ +if (res ==RISCV_EXCP_NONE ) { +qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , + csr_ops[csrno].name, val); + } +} +static void riscv_cpu_dump_state (CPUState *cs,FILE *f,int flags) {RISCVCPU *cpu =RISCV_CPU (cs);@@ -565,18 +580,7 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) };for (i =0 ; i <ARRAY_SIZE (dump_csrs); ++i) { -int csrno = dump_csrs[i]; -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); - -/* -* Rely on the smode, hmode, etc, predicates within csr.c -* to do the filtering of the registers that are present. -*/ -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[csrno].name, val); - } +riscv_dump_csr (env, dump_csrs[i], f); } }#endif @@ -589,12 +593,8 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) } }if (flags &CPU_DUMP_FPU ) { -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env,CSR_FCSR , &val,0 ,0 ); -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[CSR_FCSR ].name, val); - } +riscv_dump_csr (env,CSR_FCSR , f); +for (i =0 ; i <32 ; i++) {qemu_fprintf (f," %-8s %016" PRIx64, riscv_fpr_regnames[i], env->fpr[i]);@@ -612,22 +612,12 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags)CSR_VL ,CSR_VTYPE , CSR_VLENB, - }; -for (i =0 ; i <ARRAY_SIZE (dump_rvv_csrs); ++i) { -int csrno = dump_rvv_csrs[i]; -target_ulong val =0 ; -RISCVException res =riscv_csrrw_debug (env, csrno, &val,0 ,0 ); + }; +uint16_t vlenb = cpu->cfg.vlenb; -/* -* Rely on the smode, hmode, etc, predicates within csr.c -* to do the filtering of the registers that are present. -*/ -if (res ==RISCV_EXCP_NONE ) { -qemu_fprintf (f," %-8s " TARGET_FMT_lx"\n" , - csr_ops[csrno].name, val); - } +for (i =0 ; i <ARRAY_SIZE (dump_rvv_csrs); ++i) { +riscv_dump_csr (env, dump_rvv_csrs[i], f); } -uint16_t vlenb = cpu->cfg.vlenb;for (i =0 ; i <32 ; i++) {qemu_fprintf (f," %-8s " , riscv_rvv_regnames[i]); --2.49.0
PATCH 2/3 target/riscv/cpu: print all FPU CSRs in riscv_cpu_dump_state()
In reply to Daniel Henrique BarbozaWe're missing fflags and frm.
--- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+)
target/riscv/cpu.c +2 -0
@@ -593,6 +593,8 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) } }if (flags &CPU_DUMP_FPU ) { +riscv_dump_csr (env,CSR_FFLAGS , f); +riscv_dump_csr (env,CSR_FRM , f);riscv_dump_csr (env,CSR_FCSR , f);for (i =0 ; i <32 ; i++) {
Signature · 1 line
2.49.0
Re: [PATCH 2/3] target/riscv/cpu: print all FPU CSRs in riscv_cpu_dump_state()
Quoted 4 lines · Daniel Henrique Barboza
We're missing fflags and frm.
Signed-off-by Daniel Henrique Barboza <[email protected]>
Alistair
Quoted 21 lines
--- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+)target/riscv/cpu.c +2
-1@@ -593,6 +593,8 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags) } }if (flags &CPU_DUMP_FPU ) { +riscv_dump_csr (env,CSR_FFLAGS , f); +riscv_dump_csr (env,CSR_FRM , f);riscv_dump_csr (env,CSR_FCSR , f);for (i =0 ; i <32 ; i++) { --2.49.0
PATCH 3/3 target/riscv: print all available CSRs in riscv_cpu_dump_state()
In reply to Daniel Henrique BarbozaAt this moment we're printing a small selection of CSRs. There's no particular reason to not print all of them.
We're ignoring the note about CSR_SSTATUS being ommited because it can be read via CSR_MSTATUS. There's a huge list of CSRs that would fall in this category and it would be an extra burden to manage them, not mentioning having to document "we're not listing X because it's the same value as Y" to users.
Remove 'dump_csrs' and use the existing 'csr_ops' array to print all available CSRs. Create two helpers in csr.c to identify FPU and VPU CSRs and skip them - they'll be printed in the FPU/VPU blocks later.
--- target/riscv/cpu.c | 55 ++++++++++++++++------------------------------ target/riscv/cpu.h | 2 ++ target/riscv/csr.c | 18 +++++++++++++++ 3 files changed, 39 insertions(+), 36 deletions(-)
target/riscv/cpu.c +19 -36
@@ -544,44 +544,27 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags)#endif qemu_fprintf (f," %s " TARGET_FMT_lx"\n" ,"pc " , env->pc);#ifndef CONFIG_USER_ONLY - { -static const int dump_csrs[] = { -CSR_MHARTID , -CSR_MSTATUS , -CSR_MSTATUSH , -/* -* CSR_SSTATUS is intentionally omitted here as its value -* can be figured out by looking at CSR_MSTATUS -*/ -CSR_HSTATUS , -CSR_VSSTATUS , -CSR_MIP , -CSR_MIE , -CSR_MIDELEG , -CSR_HIDELEG , -CSR_MEDELEG , -CSR_HEDELEG , -CSR_MTVEC , -CSR_STVEC , -CSR_VSTVEC , -CSR_MEPC , -CSR_SEPC , -CSR_VSEPC , -CSR_MCAUSE , -CSR_SCAUSE , -CSR_VSCAUSE , -CSR_MTVAL , -CSR_STVAL , -CSR_HTVAL , -CSR_MTVAL2 , -CSR_MSCRATCH , -CSR_SSCRATCH , -CSR_SATP , - }; +for (i =0 ; i <ARRAY_SIZE (csr_ops); i++) { +int csrno = i; -for (i =0 ; i <ARRAY_SIZE (dump_csrs); ++i) { -riscv_dump_csr (env, dump_csrs[i], f); +/* +* Early skip when possible since we're going +* through a lot of NULL entries. +*/ +if (csr_ops[csrno].predicate ==NULL ) { +continue ; } + +/* +* FPU and VPU CSRs will be printed in the +* CPU_DUMP_FPU/CPU_DUMP_VPU blocks later. +*/ +if (riscv_csr_is_fpu (csrno) || +riscv_csr_is_vpu (csrno)) { +continue ; + } + +riscv_dump_csr (env, csrno, f); }#endif
target/riscv/cpu.h +2 -0
@@ -967,6 +967,8 @@ bool riscv_cpu_accelerator_compatible(RISCVCPU *cpu);/* CSR function table */ extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE ]; +bool riscv_csr_is_fpu (int csrno); +bool riscv_csr_is_vpu (int csrno);extern const bool valid_vm_1_10_32[], valid_vm_1_10_64[];
target/riscv/csr.c +18 -0
@@ -5799,6 +5799,24 @@ static RISCVException write_jvt(CPURISCVState *env, int csrno,return RISCV_EXCP_NONE ; } +bool riscv_csr_is_fpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == fs; +} + +bool riscv_csr_is_vpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == vs; +} +/* * Control and Status Register function table * riscv_csr_operations::predicate() must be provided for an implemented CSR
Signature · 1 line
2.49.0
Re: [PATCH 3/3] target/riscv: print all available CSRs in riscv_cpu_dump_state()
Quoted 3 lines · Daniel Henrique Barboza
At this moment we're printing a small selection of CSRs. There's no particular reason to not print all of them.
The reason was that there are just so many and printing everything makes it hard for people to read. So we just print the "main" ones and people can then probe the more obscure ones they are interested in.
Do we actually want to print all of them?
Quoted 7 lines
We're ignoring the note about
CSR_SSTATUSbeing ommited because it can be read viaCSR_MSTATUS. There's a huge list of CSRs that would fall in this category and it would be an extra burden to manage them, not mentioning having to document "we're not listing X because it's the same value as Y" to users.
Quoted 5 lines
Remove '
dump_csrs' and use the existing 'csr_ops' array to print all available CSRs. Create two helpers incsr.cto identify FPU and VPU CSRs and skip them - they'll be printed in the FPU/VPU blocks later.Signed-off-by Daniel Henrique Barboza <[email protected]>
The actual code looks fine though
Alistair
Quoted 120 lines
--- target/riscv/cpu.c | 55 ++++++++++++++++------------------------------ target/riscv/cpu.h | 2 ++ target/riscv/csr.c | 18 +++++++++++++++ 3 files changed, 39 insertions(+), 36 deletions(-)target/riscv/cpu.c +19
-36@@ -544,44 +544,27 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags)#endif qemu_fprintf (f," %s " TARGET_FMT_lx"\n" ,"pc " , env->pc);#ifndef CONFIG_USER_ONLY - { -static const int dump_csrs[] = { -CSR_MHARTID , -CSR_MSTATUS , -CSR_MSTATUSH , -/* -* CSR_SSTATUS is intentionally omitted here as its value -* can be figured out by looking at CSR_MSTATUS -*/ -CSR_HSTATUS , -CSR_VSSTATUS , -CSR_MIP , -CSR_MIE , -CSR_MIDELEG , -CSR_HIDELEG , -CSR_MEDELEG , -CSR_HEDELEG , -CSR_MTVEC , -CSR_STVEC , -CSR_VSTVEC , -CSR_MEPC , -CSR_SEPC , -CSR_VSEPC , -CSR_MCAUSE , -CSR_SCAUSE , -CSR_VSCAUSE , -CSR_MTVAL , -CSR_STVAL , -CSR_HTVAL , -CSR_MTVAL2 , -CSR_MSCRATCH , -CSR_SSCRATCH , -CSR_SATP , - }; +for (i =0 ; i <ARRAY_SIZE (csr_ops); i++) { +int csrno = i; -for (i =0 ; i <ARRAY_SIZE (dump_csrs); ++i) { -riscv_dump_csr (env, dump_csrs[i], f); +/* +* Early skip when possible since we're going +* through a lot of NULL entries. +*/ +if (csr_ops[csrno].predicate ==NULL ) { +continue ; } + +/* +* FPU and VPU CSRs will be printed in the +* CPU_DUMP_FPU/CPU_DUMP_VPU blocks later. +*/ +if (riscv_csr_is_fpu (csrno) || +riscv_csr_is_vpu (csrno)) { +continue ; + } + +riscv_dump_csr (env, csrno, f); }#endif target/riscv/cpu.h +2
-0@@ -967,6 +967,8 @@ bool riscv_cpu_accelerator_compatible(RISCVCPU *cpu);/* CSR function table */ extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE ]; +bool riscv_csr_is_fpu (int csrno); +bool riscv_csr_is_vpu (int csrno);extern const bool valid_vm_1_10_32[], valid_vm_1_10_64[];target/riscv/csr.c +18
-1@@ -5799,6 +5799,24 @@ static RISCVException write_jvt(CPURISCVState *env, int csrno,return RISCV_EXCP_NONE ; } +bool riscv_csr_is_fpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == fs; +} + +bool riscv_csr_is_vpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == vs; +} +/* * Control and Status Register function table * riscv_csr_operations::predicate() must be provided for an implemented CSR -- 2.49.0
Re: [PATCH 3/3] target/riscv: print all available CSRs in riscv_cpu_dump_state()
Quoted 11 lines · Alistair Francis
Quoted 3 lines · Daniel Henrique Barboza
At this moment we're printing a small selection of CSRs. There's no particular reason to not print all of them.
The reason was that there are just so many and printing everything makes it hard for people to read. So we just print the "main" ones and people can then probe the more obscure ones they are interested in.
Do we actually want to print all of them?
In case we have no idea what is going on with the CPU, e.g. there is something wrong and you can't quite put your finger on it, outputting all CSRs can help identify errors in unusual places you wouldn't expect.
After identifying the problematic CSRs we can then use the MonitorDef API to fetch just the CSRs we want with "p $<reg>".
At this is the sort of use case I was imagining with these patches. They'll be more effective when used together.
Thanks,
Daniel
Quoted 140 lines
Quoted 8 lines
We're ignoring the note about
CSR_SSTATUSbeing ommited because it can be read viaCSR_MSTATUS. There's a huge list of CSRs that would fall in this category and it would be an extra burden to manage them, not mentioning having to document "we're not listing X because it's the same value as Y" to users.Quoted 5 lines
Remove '
dump_csrs' and use the existing 'csr_ops' array to print all available CSRs. Create two helpers incsr.cto identify FPU and VPU CSRs and skip them - they'll be printed in the FPU/VPU blocks later.Signed-off-by Daniel Henrique Barboza <[email protected]>The actual code looks fine though
Reviewed-by Alistair Francis <[email protected]>Alistair
Quoted 120 lines
--- target/riscv/cpu.c | 55 ++++++++++++++++------------------------------ target/riscv/cpu.h | 2 ++ target/riscv/csr.c | 18 +++++++++++++++ 3 files changed, 39 insertions(+), 36 deletions(-)target/riscv/cpu.c +19
-36@@ -544,44 +544,27 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f, int flags)#endif qemu_fprintf (f," %s " TARGET_FMT_lx"\n" ,"pc " , env->pc);#ifndef CONFIG_USER_ONLY - { -static const int dump_csrs[] = { -CSR_MHARTID , -CSR_MSTATUS , -CSR_MSTATUSH , -/* -* CSR_SSTATUS is intentionally omitted here as its value -* can be figured out by looking at CSR_MSTATUS -*/ -CSR_HSTATUS , -CSR_VSSTATUS , -CSR_MIP , -CSR_MIE , -CSR_MIDELEG , -CSR_HIDELEG , -CSR_MEDELEG , -CSR_HEDELEG , -CSR_MTVEC , -CSR_STVEC , -CSR_VSTVEC , -CSR_MEPC , -CSR_SEPC , -CSR_VSEPC , -CSR_MCAUSE , -CSR_SCAUSE , -CSR_VSCAUSE , -CSR_MTVAL , -CSR_STVAL , -CSR_HTVAL , -CSR_MTVAL2 , -CSR_MSCRATCH , -CSR_SSCRATCH , -CSR_SATP , - }; +for (i =0 ; i <ARRAY_SIZE (csr_ops); i++) { +int csrno = i; -for (i =0 ; i <ARRAY_SIZE (dump_csrs); ++i) { -riscv_dump_csr (env, dump_csrs[i], f); +/* +* Early skip when possible since we're going +* through a lot of NULL entries. +*/ +if (csr_ops[csrno].predicate ==NULL ) { +continue ; } + +/* +* FPU and VPU CSRs will be printed in the +* CPU_DUMP_FPU/CPU_DUMP_VPU blocks later. +*/ +if (riscv_csr_is_fpu (csrno) || +riscv_csr_is_vpu (csrno)) { +continue ; + } + +riscv_dump_csr (env, csrno, f); }#endif target/riscv/cpu.h +2
-0@@ -967,6 +967,8 @@ bool riscv_cpu_accelerator_compatible(RISCVCPU *cpu);/* CSR function table */ extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE ]; +bool riscv_csr_is_fpu (int csrno); +bool riscv_csr_is_vpu (int csrno);extern const bool valid_vm_1_10_32[], valid_vm_1_10_64[];target/riscv/csr.c +18
-1@@ -5799,6 +5799,24 @@ static RISCVException write_jvt(CPURISCVState *env, int csrno,return RISCV_EXCP_NONE ; } +bool riscv_csr_is_fpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == fs; +} + +bool riscv_csr_is_vpu (int csrno) +{ +if (!csr_ops[csrno].predicate) { +return false; + } + +return csr_ops[csrno].predicate == vs; +} +/* * Control and Status Register function table * riscv_csr_operations::predicate() must be provided for an implemented CSR -- 2.49.0
Ping
It would be nice to have all CSRs for 'info registers' for the next release. We have one week before the freeze :D
Thanks,
Daniel
Quoted 25 lines · Daniel Henrique Barboza
Hi,
The output of HMP 'info registers', implemented by the
cpu_dump_statecallback, returns way less CSRs than what we have available in the default rv64 CPU with default options.This series changes the callback to add all available non-vector CSRs when issuing 'info registers'. The vector CSRs are being handled by another patch [1].
Patches based on alistair/riscv-to-apply.next.
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Daniel Henrique Barboza (3):
target/riscv/cpu: addriscv_dump_csr()helper target/riscv/cpu: print all FPU CSRs inriscv_cpu_dump_state()target/riscv: print all available CSRs inriscv_cpu_dump_state()target/riscv/cpu.c | 107 +++++++++++++++++---------------------------- target/riscv/cpu.h | 2 + target/riscv/csr.c | 18 ++++++++ 3 files changed, 61 insertions(+), 66 deletions(-)
Ping
Quoted 25 lines · Daniel Henrique Barboza
Hi,
The output of HMP 'info registers', implemented by the
cpu_dump_statecallback, returns way less CSRs than what we have available in the default rv64 CPU with default options.This series changes the callback to add all available non-vector CSRs when issuing 'info registers'. The vector CSRs are being handled by another patch [1].
Patches based on alistair/riscv-to-apply.next.
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Daniel Henrique Barboza (3):
target/riscv/cpu: addriscv_dump_csr()helper target/riscv/cpu: print all FPU CSRs inriscv_cpu_dump_state()target/riscv: print all available CSRs inriscv_cpu_dump_state()target/riscv/cpu.c | 107 +++++++++++++++++---------------------------- target/riscv/cpu.h | 2 + target/riscv/csr.c | 18 ++++++++ 3 files changed, 61 insertions(+), 66 deletions(-)
Quoted 20 lines · Daniel Henrique Barboza
Hi,
The output of HMP 'info registers', implemented by the
cpu_dump_statecallback, returns way less CSRs than what we have available in the default rv64 CPU with default options.This series changes the callback to add all available non-vector CSRs when issuing 'info registers'. The vector CSRs are being handled by another patch [1].
Patches based on alistair/riscv-to-apply.next.
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Daniel Henrique Barboza (3):
target/riscv/cpu: addriscv_dump_csr()helper target/riscv/cpu: print all FPU CSRs inriscv_cpu_dump_state()target/riscv: print all available CSRs inriscv_cpu_dump_state()
Quoted 9 lines
target/riscv/cpu.c | 107 +++++++++++++++++---------------------------- target/riscv/cpu.h | 2 + target/riscv/csr.c | 18 ++++++++ 3 files changed, 61 insertions(+), 66 deletions(-)Signature · 1 line
2.49.0
I think this makes sense, less manual maintainence is always a plus!:)
Series: reviewed-by: Anton Johansson <[email protected]>
Alistair Francis
AppliedQuoted 13 lines · Daniel Henrique Barboza
Hi,
The output of HMP 'info registers', implemented by the
cpu_dump_statecallback, returns way less CSRs than what we have available in the default rv64 CPU with default options.This series changes the callback to add all available non-vector CSRs when issuing 'info registers'. The vector CSRs are being handled by another patch [1].
Patches based on alistair/riscv-to-apply.next.
Quoted 7 lines
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Daniel Henrique Barboza (3):
target/riscv/cpu: addriscv_dump_csr()helper target/riscv/cpu: print all FPU CSRs inriscv_cpu_dump_state()target/riscv: print all available CSRs inriscv_cpu_dump_state()
Thanks!
Applied to riscv-to-apply.next
Alistair
Quoted 10 lines
target/riscv/cpu.c | 107 +++++++++++++++++---------------------------- target/riscv/cpu.h | 2 + target/riscv/csr.c | 18 ++++++++ 3 files changed, 61 insertions(+), 66 deletions(-)--
2.49.0