Skip to contentSkip to conversation

enable DM_SERIAL on imx8mn-evk and imx8mn-ddr4-evk

PATCH Superseded Heiko Thiery 3 participants 6 messages Feb 25, 2022 – Mar 21, 2022 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover enable DM_SERIAL on imx8mn-evk and imx8mn-ddr4-evk

I was only able to test it on a 8MNANOD3L-EVK board. Please help testing this change on the other 2 eval boards (8MNANOLPD4-EVK, 8MNANOD4-EVK).

Heiko Thiery (2):
ARM: imx: imx8mn-evk: enable DM_SERIAL
ARM: imx: imx8mn-ddr4-evk: enable DM_SERIAL

 configs/imx8mn_ddr4_evk_defconfig | 2 ++
 configs/imx8mn_evk_defconfig      | 2 ++
 2 files changed, 4 insertions(+)
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/2 ARM: imx: imx8mn-evk: enable DM_SERIAL

---
 configs/imx8mn_evk_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/imx8mn_evk_defconfig +2 -0
index 95ac6f85fa..15909d545c 100644
@@ -84,6 +84,8 @@ CONFIG_DM_REGULATOR=y
 CONFIG_SPL_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+# CONFIG_SPL_DM_SERIAL is not set
 CONFIG_MXC_UART=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
Signature · 1 line
2.30.2
reviewer
#2 lore raw

Re: [PATCH 1/2] ARM: imx: imx8mn-evk: enable DM_SERIAL

Hi Heiko,

Quoted 2 lines · Heiko Thiery

Please provide a commit log explaining why you are doing this change.

Thanks

#3 lore raw

PATCH 2/2 ARM: imx: imx8mn-ddr4-evk: enable DM_SERIAL

In reply to Heiko Thiery
---
 configs/imx8mn_ddr4_evk_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/imx8mn_ddr4_evk_defconfig +2 -0
index c13885ab5e..05aa4fb259 100644
@@ -77,6 +77,8 @@ CONFIG_PINCTRL_IMX8M=y
 CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+# CONFIG_SPL_DM_SERIAL is not set
 CONFIG_MXC_UART=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
Signature · 1 line
2.30.2
#4 lore raw
In reply to Heiko Thiery
Quoted 2 lines · Heiko Thiery

I was only able to test it on a 8MNANOD3L-EVK board. Please help testing this change on the other 2 eval boards (8MNANOLPD4-EVK, 8MNANOD4-EVK).

SPL not use DM_SERIAL, only U-Boot proper use DM_SERIAL, right?

Not related to your patch, I think we need add some low level debug uart setup to have uart work as early as possible, especially for bring up new SoC/board.

Thanks,
Peng.

Quoted 9 lines

Heiko Thiery (2):
ARM: imx: imx8mn-evk: enable DM_SERIAL
ARM: imx: imx8mn-ddr4-evk: enable DM_SERIAL

  configs/imx8mn_ddr4_evk_defconfig | 2 ++
  configs/imx8mn_evk_defconfig      | 2 ++
  2 files changed, 4 insertions(+)
#5 lore raw

Hi Peng,

Am Mo., 21. März 2022 um 04:07 Uhr schrieb Peng Fan (OSS) <[email protected]>:

Quoted 8 lines · Heiko Thiery
Quoted 2 lines

I was only able to test it on a 8MNANOD3L-EVK board. Please help testing this change on the other 2 eval boards (8MNANOLPD4-EVK, 8MNANOD4-EVK).

SPL not use DM_SERIAL, only U-Boot proper use DM_SERIAL, right?

Yes only U-Boot uses DM_SERIAL.

Quoted 16 lines

Not related to your patch, I think we need add some low level debug uart setup to have uart work as early as possible, especially for bring up new SoC/board.

Thanks,
Peng.

Quoted 9 lines

Heiko Thiery (2):
ARM: imx: imx8mn-evk: enable DM_SERIAL
ARM: imx: imx8mn-ddr4-evk: enable DM_SERIAL

  configs/imx8mn_ddr4_evk_defconfig | 2 ++
  configs/imx8mn_evk_defconfig      | 2 ++
  2 files changed, 4 insertions(+)
Signature · 1 line
Heiko